Re: [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal

On 27-05-2013 22:41, Zhang Rui wrote: > On Wed, 2013-05-15 at 11:45 -0400, Eduardo Valentin wrote: >> Hello Greg and Rui, >> >> I am proposing to move the ti-soc-thermal driver from drivers/stating/ >> to drivers/thermal. It has been some time that we have been fixin

Re: [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal

Hello Greg, On 21-05-2013 13:03, Greg KH wrote: > On Wed, May 15, 2013 at 11:45:59AM -0400, Eduardo Valentin wrote: >> >> Hello Greg and Rui, >> >> I am proposing to move the ti-soc-thermal driver from drivers/stating/ >> to drivers/thermal. It has been some

[PATCH 2/2] MAINTAINERS: update TI SoC thermal driver entry

Update driver path and status for TI SoC thermal drivers on MAINTAINERS file. Signed-off-by: Eduardo Valentin --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index bc3d340..2b8a7c5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH 1/2] thermal: introduce TI SoC thermal driver

This patch moves the ti-soc-thermal driver out of the staging tree to the thermal tree. Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc: Greg Kroah-Hartman Cc: Zhang Rui Cc: Eduardo Valentin Cc: J Keerthy Cc: Radhesh Fadnis Cc: Cyril Roelandt Cc: devicetree-disc...@lists.ozlabs.org

[PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal

far has not caused any issues, and I believe that most of the interesting data is protected by the thermal framework. I am sending this patch for your appreciation and also to get wider review. All best, Eduardo Valentin (2): thermal: introduce TI SoC thermal driver MAINTAINERS: update TI SoC

Re: [PATCH 1/1] staging: ti-soc-thermal: Fix incorrect usage of IS_ERR_OR_NULL

On 03-05-2013 01:52, Sachin Kamat wrote: > Use IS_ERR instead of IS_ERR_OR_NULL on clk_get results. > > Signed-off-by: Sachin Kamat > Cc: Eduardo Valentin > --- Sachin, I have a patch that covers this already: https://patchwork.kernel.org/patch/2488331/ Actually it does a wi

Re: [PATCH 1/1] staging: ti-soc-thermal: remove usage of IS_ERR_OR_NULL

Russell, Thanks for your time reviewing this patch. On 25-04-2013 13:44, Russell King wrote: On Thu, Apr 25, 2013 at 09:46:16AM -0400, Eduardo Valentin wrote: diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b/drivers/staging/ti-soc-thermal/ti-bandgap.c index f20c1cf..5027833 100644

[PATCH 1/1] staging: ti-soc-thermal: remove usage of IS_ERR_OR_NULL

-Hartman Cc: Russell King Cc: J Keerthy Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org Cc: linux...@vger.kernel.org Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.c| 8 drivers/staging/ti-soc-thermal/ti-thermal-common.c | 15

[PATCH 2/2] staging: ti-soc-thermal: remove external heat while extrapolating hotspot

For boards that provide a PCB sensor close to SoC junction temperature, it is possible to remove the cumulative heat reported by the SoC temperature sensor. This patch changes the extrapolation computation to consider an external sensor in the extrapolation equations. Signed-off-by: Eduardo

[PATCH 1/2] staging: ti-soc-thermal: update DT reference for OMAP5430

Add missing irq line for TALERT on DT entry for OMAP5430. Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti_soc_thermal.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ti-soc-thermal/ti_soc_thermal.txt b/drivers/staging/ti-soc-thermal

[PATCH 0/2] staging: ti-soc-thermal: couple of fixes

/rzhang/linux.git/commit/?h=next&id=63c4d919cf66b1b3ffa7861bddb50a697914af5b [2] - http://git.kernel.org/cgit/linux/kernel/git/rzhang/linux.git/commit/?h=next&id=837b26bb2e4a83d224e725f07a1d9ca824bf905c Eduardo Valentin (2): staging: ti-soc-thermal: update DT reference for OMAP5430 sta

Re: [PATCH] Staging: omap-thermal: remove trailing whitespace from omap-bandgap.c

On 08-04-2013 15:12, Dan Carpenter wrote: On Mon, Apr 08, 2013 at 02:27:13PM -0400, Eduardo Valentin wrote: Thanks, please keep sending your patches and copy my email address so I will give you a quick response. Please, send a patch adding yourself to the MAINTAINERS file so the

Re: [PATCH] Staging: omap-thermal: remove trailing whitespace from omap-bandgap.c

Tyrel, On 08-04-2013 14:24, edubez...@gmail.com wrote: Fixing to right email address. On Mon, Apr 8, 2013 at 1:22 PM, Greg KH wrote: On Sun, Apr 07, 2013 at 06:47:20PM -0700, Tyrel Datwyler wrote: This patch removes trailing whitespace from a blank line in omap-bandgap.c as detected by the

[PATCH 8/8] staging: ti-soc-thermal: fix device removal

While removing, the device needs to unregister the sensor from thermal framework. Before calling the call back the driver needs to check if the call back is registered. This patch fix the check by checking the right callback. Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti

[PATCH 7/8] staging: ti-soc-thermal: defer probe if cpufreq is not ready

registered, the probe will return -EPROBE_DEFER. Tested-by: J Keerthy Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.c| 27 --- drivers/staging/ti-soc-thermal/ti-thermal-common.c |5 +++ 2 files changed, 27 insertions(+), 5 deletions

[PATCH 6/8] staging: ti-soc-thermal: remove extrapolation rules from TODO

Extrapolation rules have been revisited. Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/TODO |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ti-soc-thermal/TODO b/drivers/staging/ti-soc-thermal/TODO index b320388..7da787d 100644

[PATCH 5/8] staging: ti-soc-thermal: update OMAP5 extrapolation rules

Update the constants to the correct hotspot extrapolation equation constants. OMAP4 constants are revisited and correct. Signed-off-by: Eduardo Valentin --- .../staging/ti-soc-thermal/omap5-thermal-data.c|1 - drivers/staging/ti-soc-thermal/ti-thermal.h| 16 2

[PATCH 4/8] staging: ti-soc-thermal: introduce OMAP4430 extrapolation constants

This patch defines and utilizes the extrapolation constants for OMAP4430. Signed-off-by: Eduardo Valentin --- .../staging/ti-soc-thermal/omap4-thermal-data.c|8 drivers/staging/ti-soc-thermal/ti-thermal.h|4 2 files changed, 8 insertions(+), 4 deletions

[PATCH 3/8] staging: ti-soc-thermal: Remove TC1/TC2 TODO (already done)

TC1/TC2 are not needed anymore, API has been upgraded. This is a TODO left-over. Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-thermal-common.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ti-soc-thermal/ti-thermal-common.c b

[PATCH 2/8] staging: ti-soc-thermal: fix min/max TODO (already done)

Min/Max cooling state are defined by registration helper function, if no specific limits are passed. No need to change this code. Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-thermal-common.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a

[PATCH 1/8] staging: ti-soc-thermal: update TODO list

issue. -- update documentation: DONE, kernel-doc for ti-bandgap is now available. Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/TODO | 11 --- 1 files changed, 0 insertions(+), 11 deletions(-) diff --git a/drivers/staging/ti-soc-thermal/TODO b/drivers/staging/ti

[PATCH 0/8] staging: ti-soc-thermal: fixes and TODO update

thermal_work/omap/ti-soc-thermal-fixes https://git.gitorious.org/thermal-framework/thermal-framework.git thermal_work/omap/ti-soc-fixes All best, Eduardo Valentin (8): staging: ti-soc-thermal: update TODO list staging: ti-soc-thermal: fix min/max TODO (already done) staging: ti-soc-thermal: Remove

[PATCH 13/14] staging: ti-soc-thermal:Introduce ti_bandgap_get_trend function for OMAP5

read valid temperature. P: Update Interval. Signed-off-by: J Keerthy Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.c | 67 +++ drivers/staging/ti-soc-thermal/ti-bandgap.h |1 + 2 files changed, 68 insertions(+), 0

[PATCH 14/14] staging: ti-soc-thermal: Add get_trend support

From: J Keerthy Patch adds get_trend functionality for OMAP Bandgap thermal devices. Signed-off-by: J Keerthy Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-thermal-common.c | 27 +++- 1 files changed, 26 insertions(+), 1 deletions(-) diff --git a

[PATCH 12/14] staging: ti-soc-thermal: Enable HISTORY_BUFFER Feature for OMAP5

From: J Keerthy This patch enables the HISTORY_BUFFER eature for OMAP5. Signed-off-by: J Keerthy Signed-off-by: Eduardo Valentin --- .../staging/ti-soc-thermal/omap5-thermal-data.c|3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ti-soc-thermal

[PATCH 11/14] staging: ti-soc-thermal: Introduce HAS_HISTORY_BUFFER feature for bandgap

From: J Keerthy The patch introduces HISTORY_BUFFER feature. This is present in OMAP5 bandgap and it is a hardware history buffer of previously read temperatures. Signed-off-by: J Keerthy Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.h |4 1 files

[PATCH 10/14] staging: ti-soc-thermal: Modify update_interval r/w functions to incorporate the OMAP5 feature of COUNTER_DELAY.

the changes required to program the delay for OMAP5. Signed-off-by: J Keerthy Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.c | 165 +++--- 1 files changed, 146 insertions(+), 19 deletions(-) diff --git a/drivers/staging/ti-soc-thermal/ti

[PATCH 09/14] staging: ti-soc-thermal: Enable COUNTER_DELAY feature for OMAP5

From: J Keerthy Enable COUNTER_DELAY feature for OMAP5. Signed-off-by: J Keerthy Signed-off-by: Eduardo Valentin --- .../staging/ti-soc-thermal/omap5-thermal-data.c|3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ti-soc-thermal/omap5-thermal

[PATCH 08/14] staging: ti-soc-thermal: Introduce HAS_COUNTER_DELAY feature for bandgap

From: J Keerthy Introduce HAS_COUNTER_DELAY feature for bandgap. Signed-off-by: J Keerthy Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.h b

[PATCH 07/14] staging: ti-soc-thermal: Initialise counter_delay field for OMAP5 sensors

From: J Keerthy Initialize all 3 temperature sensors of OMAP5 bandgap with the counter delay mask. Signed-off-by: J Keerthy Signed-off-by: Eduardo Valentin --- .../staging/ti-soc-thermal/omap5-thermal-data.c|3 +++ drivers/staging/ti-soc-thermal/omap5xxx-bandgap.h |1 + 2 files

[PATCH 06/14] staging: ti-soc-thermal: Add counter_delay_mask field to temp_sensor_registers struct

From: J Keerthy Add counter_delay_mask field to temp_sensor_registers structure. Signed-off-by: J Keerthy Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/ti-soc-thermal

[PATCH 05/14] staging: ti-soc-thermal: report alert events on OMAP5 devices

T_ALERT events. Signed-off-by: Eduardo Valentin --- .../staging/ti-soc-thermal/omap5-thermal-data.c|1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/ti-soc-thermal/omap5-thermal-data.c b/drivers/staging/ti-soc-thermal/omap5-thermal-data.c index 0afe9c8

[PATCH 04/14] staging: ti-soc-thermal: report alert events on OMAP4 devices

thermal framework about T_ALERT events. Signed-off-by: Eduardo Valentin --- .../staging/ti-soc-thermal/omap4-thermal-data.c|2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/ti-soc-thermal/omap4-thermal-data.c b/drivers/staging/ti-soc-thermal/omap4

[PATCH 03/14] staging: ti-soc-thermal: expose ti_thermal_report_temperature

Whenever a sensor has an alert to be reported to the thermal framework, it can use the report ti_thermal_report_temperature helper. This patch expose this function so that bandgap data config declarations could use it. Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti

[PATCH 02/14] staging: ti-soc-thermal: remove kernel-doc warnings reported with -v

From: Nishanth Menon Fix all kernel-doc warnings by add documentation about returns. Signed-off-by: Nishanth Menon Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.c | 58 +- 1 files changed, 47 insertions(+), 11 deletions(-) diff --git

[PATCH 01/14] staging: ti-soc-thermal: return error in case power switch is not supported

Improve ti_bandgap_power by returning an error code in case the device does not support controlling its power state. Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ti

[PATCH 00/14] staging: ti-soc-thermal: fixes and trending support

-soc-thermal-history-buffer https://git.gitorious.org/thermal-framework/thermal-framework.git thermal_work/omap/ti-soc-thermal-history-buffer Eduardo Valentin (4): staging: ti-soc-thermal: return error in case power switch is not supported staging: ti-soc-thermal: expose

Re: [PATCHv2 09/12] staging: ti-soc-thermal: fix several kernel-doc warnings and error

On 25-03-2013 14:22, Greg KH wrote: On Tue, Mar 19, 2013 at 10:54:25AM -0400, Eduardo Valentin wrote: This patch updates the documentation to remove all warnings and errors reported by scripts/kernel-doc. Most are missing arguments due to wrong format. Cc: Nishanth Menon Signed-off-by

Re: [PATCHv2 09/12] staging: ti-soc-thermal: fix several kernel-doc warnings and error

Hello Nishanth, On 19-03-2013 15:22, Nishanth Menon wrote: On 10:54-20130319, Eduardo Valentin wrote: * @adc_start_val: ADC conversion table starting value You may still want to fix warnings generated by: ./scripts/kernel-doc -v drivers/staging/ti-soc-thermal/ti-bandgap.c>/dev/n

[PATCHv2 12/12] staging: ti-soc-thermal: propagate error code

While writing talert thresholds, propagate the error code from ti_bandgap_update_alert_threshold to the caller of _ti_bandgap_write_threshold. Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCHv2 11/12] staging: ti-soc-thermal: fix bitfield writing while updating thresholds

Wrong threshold cold values may be written with current implementation. This patch fixes the threshold update function by simplifying the bitfield manipulation sequence. Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.c |8 1 files changed, 4

[PATCHv2 10/12] staging: ti-soc-thermal: fix condition to apply hyst

While updating talert thresholds, threshold cold must always be lower than threshold hot. This patch fixes the function ti_bandgap_update_alert_threshold to only change the thresholds by applying a hysteresis when they violate this condition. Signed-off-by: Eduardo Valentin --- drivers/staging

[PATCHv2 09/12] staging: ti-soc-thermal: fix several kernel-doc warnings and error

This patch updates the documentation to remove all warnings and errors reported by scripts/kernel-doc. Most are missing arguments due to wrong format. Cc: Nishanth Menon Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.c | 56 +- drivers

[PATCHv2 08/12] stating: ti-soc-thermal: use sizeof(*pointer) while allocating

Follow Documentation/CodingStyle and use sizeof(*pointer) instead of sizeof(struct type). Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b

[PATCHv2 07/12] staging: ti-soc-thermal: split writable data from readonly data

. Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.c| 20 -- drivers/staging/ti-soc-thermal/ti-bandgap.h| 65 +++- drivers/staging/ti-soc-thermal/ti-thermal-common.c |2 +- 3 files changed, 51 insertions(+), 36 deletions

[PATCHv2 06/12] staging: ti-soc-thermal: make unexported functions local

Move _ti_bandgap_write_threshold and _ti_bandgap_read_threshold to static area, as they are local functions. Signed-off-by: Eduardo Valentin --- drivers/staging/ti-soc-thermal/ti-bandgap.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ti-soc

[PATCHv2 04/12] staging: ti-soc-thermal: rename Kconfig options

This patch renames the Kconfig options to cope with the new naming convention. Cc: Santosh Shilimkar Cc: Benoit Cc: Nishanth Menon Cc: Dan Carpenter Signed-off-by: Eduardo Valentin --- drivers/staging/Makefile|2 +- drivers/staging/ti-soc-thermal/Kconfig | 14

[PATCHv2 03/12] staging: rename omap-thermal driver to ti-soc-thermal

Carpenter Signed-off-by: Eduardo Valentin --- drivers/staging/Kconfig|2 +- drivers/staging/Makefile |2 +- drivers/staging/omap-thermal/Makefile |5 - .../{omap-thermal => ti-soc-thermal}/Kconfig |

[PATCHv2 02/12] staging: omap-thermal: rename bg_ptr to bgp

Use a shorter name to bandgap pointer. Cc: Benoit Cc: Dan Carpenter Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c| 562 ++-- drivers/staging/omap-thermal/omap-bandgap.h| 28 +- drivers/staging/omap-thermal/omap-thermal

[PATCHv2 01/12] staging: omap-thermal: fix return value

Return the proper error value in _omap_bandgap_read_threshold. Acked-by: Dan Carpenter Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b

[PATCHv2 00/12] staging: [omap,ti-soc]-thermal: fixes and renaming

driver, these patches are also available, as usual, here: g...@gitorious.org:thermal-framework/thermal-framework.git thermal_work/omap/ti-thermal-rename https://git.gitorious.org/thermal-framework/thermal-framework.git thermal_work/omap/ti-thermal-rename All best, Eduardo Valentin (12): staging

Re: [PATCH 0/8] staging: [omap,ti-soc]-thermal: fixes and renaming

Hello Greg, On 18-03-2013 10:59, Eduardo Valentin wrote: Hi Greg, I am sending extra patches on omap-thermal driver, under staging. There are couple of fixes based on Dan Carpenter's review on the last patch set I sent. On top of these, there are some changes on the naming conventio

Re: [PATCH 2/8] staging: omap-thermal: use spin_lock_irqsave inside IRQ handler

On 18-03-2013 15:16, Dan Carpenter wrote: On Mon, Mar 18, 2013 at 10:59:10AM -0400, Eduardo Valentin wrote: Even if the IRQ is not firing because it is ONE_SHOT and disable at INTC level, the IRQ handler must use spin_lock_irqsave. It is necessary to disable IRQs from the current CPU while it

Re: [PATCH 1/8] staging: omap-thermal: fix return value

Dan, On 18-03-2013 12:39, Dan Carpenter wrote: Thanks. Acked-by: Dan Carpenter regards, dan carpenter Thanks for taking the time to check this code. Eduardo ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject

[PATCH 8/8] staging: ti-soc-thermal: fix several kernel-doc warnings and error

This patch updates the documentation to remove all warnings and errors reported by scripts/kernel-doc. Most are missing arguments due to wrong format. Cc: Nishanth Menon Signed-off-by: Eduardo Valentin diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b/drivers/staging/ti-soc-thermal

[PATCH 7/8] stating: ti-soc-thermal: use sizeof(*pointer) while allocating

Follow Documentation/CodingStyle and use sizeof(*pointer) instead of sizeof(struct type). Signed-off-by: Eduardo Valentin diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b/drivers/staging/ti-soc-thermal/ti-bandgap.c index b74e847..4382c0c 100644 --- a/drivers/staging/ti-soc-thermal/ti

[PATCH 6/8] staging: ti-soc-thermal: split writable data from readonly data

. Signed-off-by: Eduardo Valentin diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b/drivers/staging/ti-soc-thermal/ti-bandgap.c index c850e13..b74e847 100644 --- a/drivers/staging/ti-soc-thermal/ti-bandgap.c +++ b/drivers/staging/ti-soc-thermal/ti-bandgap.c @@ -249,7 +249,7 @@ static

[PATCH 5/8] staging: ti-soc-thermal: make unexported functions local

Move _ti_bandgap_write_threshold and _ti_bandgap_read_threshold to static area, as they are local functions. Signed-off-by: Eduardo Valentin diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b/drivers/staging/ti-soc-thermal/ti-bandgap.c index 6a0b1ac..c850e13 100644 --- a/drivers

[PATCH 3/8] staging: omap-thermal: rename bg_ptr to bgp

Use a shorter name to bandgap pointer. Cc: Benoit Signed-off-by: Eduardo Valentin diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap-bandgap.c index a4ac06c..89361fe 100644 --- a/drivers/staging/omap-thermal/omap-bandgap.c +++ b/drivers/staging/omap

[PATCH 2/8] staging: omap-thermal: use spin_lock_irqsave inside IRQ handler

Even if the IRQ is not firing because it is ONE_SHOT and disable at INTC level, the IRQ handler must use spin_lock_irqsave. It is necessary to disable IRQs from the current CPU while it is holding a spin_lock which is need. Cc: Dan Carpenter Signed-off-by: Eduardo Valentin diff --git a

[PATCH 1/8] staging: omap-thermal: fix return value

Return the proper error value in _omap_bandgap_read_threshold. Cc: Dan Carpenter Signed-off-by: Eduardo Valentin diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap-bandgap.c index 33bfe3b..cb7aa35 100644 --- a/drivers/staging/omap-thermal/omap

[PATCH 0/8] staging: [omap,ti-soc]-thermal: fixes and renaming

trying the driver, these patches are also available, as usual, here: g...@gitorious.org:thermal-framework/thermal-framework.git thermal_work/omap/ti-thermal-rename https://git.gitorious.org/thermal-framework/thermal-framework.git thermal_work/omap/ti-thermal-rename BR, Eduardo Valentin (8): sta

Re: [PATCH 00/50] staging: omap-thermal: several code refactoring

Greg, Dan, On 16-03-2013 12:16, Greg KH wrote: On Sat, Mar 16, 2013 at 08:46:03AM -0400, Eduardo Valentin wrote: Hello Dan, On 16-03-2013 05:05, Dan Carpenter wrote: I've reviewed this set. I hate to make people redo whole patchset sets, and I hate re-reviewing code. Obviously, I

Re: [PATCH 33/50] staging: omap-thermal: refactor APIs handling threshold values

On 16-03-2013 04:39, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote: if (ret) { dev_err(bg_ptr->dev, "failed to read thot\n"); - return -EIO; + ret = -EIO; +

Re: [PATCH 00/50] staging: omap-thermal: several code refactoring

Hello Dan, On 16-03-2013 05:05, Dan Carpenter wrote: I've reviewed this set. I hate to make people redo whole patchset sets, and I hate re-reviewing code. Obviously, I don't really like the bunny hop patches and I'm trying to discourage that going forward. ;P But I wouldn't say it's a "Redo

Re: [PATCH 47/50] staging: omap-thermal: switch mutex to spinlock inside omap-bandgap

On 16-03-2013 04:59, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 09:00:35AM -0400, Eduardo Valentin wrote: Because there is a need to lock inside IRQ handler, this patch changes the locking mechanism inside the omap-bandgap.[c,h] to spinlocks. Now this lock is used to protect omap_bandgap

Re: [PATCH 09/50] staging: omap-thermal: make a omap_bandgap_power with only one exit point

Hey Dan, On 15-03-2013 17:22, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 08:59:57AM -0400, Eduardo Valentin wrote: Change the way the omap_bandgap_power is written so that it has only one exit entry (Documentation/CodingStyle). It's only if there is an unlock or something that you s

Re: [PATCH 07/50] staging: omap-thermal: introduce RMW_BITS macro

Hello Dan, On 15-03-2013 17:09, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 08:59:55AM -0400, Eduardo Valentin wrote: This patch introduce a macro to read, update, write bitfields. It will be specific to bandgap data structures. Signed-off-by: Eduardo Valentin --- drivers/staging/omap

[PATCH 50/50] staging: omap-thermal: add documentation for omap_bandgap_validate

Document the helper to validate a struct omap_bandgap and a sensor id. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging

[PATCH 49/50] staging: omap-thermal: remove TODO entry for exposed APIs

Not all APIs exposed today are used. However all unused APIs will be required once the thermal layer allows IRQ based policies. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/TODO |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging/omap

[PATCH 48/50] staging: omap-thermal: remove TODO entry suggesting regmap usage

It is hard to use regmap because benefit of using regmap cache may not be applicable as there is a specific sequence to restore the bandgap context. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/TODO |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a

[PATCH 47/50] staging: omap-thermal: switch mutex to spinlock inside omap-bandgap

there are registers shared among the sensors, this lock is global, not per sensor. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/TODO |1 - drivers/staging/omap-thermal/omap-bandgap.c | 18 ++ drivers/staging/omap-thermal/omap-bandgap.h |4

[PATCH 46/50] staging: Add a MAINTAINERS entry for TI bandgap and thermal driver

Add myself as maintainer of the TI bandgap and thermal driver. CC: Santosh Shilimkar CC: Zhang Rui Signed-off-by: Eduardo Valentin --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6672165..199bb4b 100644 --- a

[PATCH 45/50] staging: omap-thermal: change Kconfig dependency method

is required to device the data structures that maps the registers and their bitfields. The DT compatible list must also be updated. CC: Santosh Shilimkar CC: Vaibhav Bedia Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/Kconfig |2 +- drivers/staging/omap-thermal/TODO

[PATCH 44/50] staging: omap-thermal: document omap_bandgap_build function

Document function to build omap_bandgap structure Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap

[PATCH 43/50] staging: omap-thermal: document omap_bandgap_alert_init function

Document function that sets talert handling up. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap

[PATCH 42/50] staging: omap-thermal: document omap_bandgap_tshut_init function

Add documentation for the function to setup TSHUT handling Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap

[PATCH 41/50] staging: omap-thermal: document _omap_bandgap_read_threshold function

Add documentation of the function for reading alert thresholds Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap

[PATCH 40/50] staging: omap-thermal: document _omap_bandgap_write_threshold function

Document function to update alert thresholds. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap

[PATCH 39/50] staging: omap-thermal: document omap_bandgap_update_alert_threshold function

Document function to program alert thresholds Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap

[PATCH 38/50] staging: omap-thermal: document omap_bandgap_force_single_read

Document function to initialize the conversion state machine. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap

[PATCH 37/50] staging: omap-thermal: update omap_bandgap_set_continous_mode documentation

Simple update on function documentation. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap-bandgap.c

[PATCH 36/50] staging: omap-thermal: rename enable_continuous_mode

This patch names 'enable_continuous_mode' accordingly to the file standard naming. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c

[PATCH 35/50] staging: omap-thermal: section of device driver callbacks

Section with platform device callbacks Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap-bandgap.c index

[PATCH 34/50] staging: omap-thermal: device initialization section

Section of helper functions to initilize the bandgap device Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap

[PATCH 33/50] staging: omap-thermal: refactor APIs handling threshold values

ed to update any threshold. This patch also removes macros that are used only inside the _validate helper function. In this patch there is also an addition of an extra function section for Exposed APIs, used outside the omap-bandgap.c, but inside the omap-thermal driver. Signed-off-by: Eduardo Val

[PATCH 32/50] staging: omap-thermal: update omap_bandgap_unmask_interrupts documentation

Proper document the function to configure the IRQ event masks. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap

[PATCH 31/50] staging: omap-thermal: refactor temp_sensor_unmask_interrupts

This change improves temp_sensor_unmask_interrupts by: . renaming it to omap_bandgap_unmask_interrupts . making it a void function, as there is nothing really to report an error. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 14 -- 1 files

[PATCH 30/50] staging: omap-thermal: threshold manipulation section

Section of functions manipulating thresholds for Alert and Shutdown. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap

[PATCH 29/50] staging: omap-thermal: document omap_bandgap_add_hyst function

Document function to handle hysteresis. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap-bandgap.c

[PATCH 28/50] staging: omap-thermal: rename add_hyst to omap_bandgap_add_hyst

This patch improves the add_hyst function by: . Renaming it to omap_bandgap_add_hyst . Moving it to the ADC conversion functions section . Changing its signature to follow the driver standard Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 42

[PATCH 27/50] staging: omap-thermal: add documentation for omap_bandgap_mcelsius_to_adc

Document the conversion function. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap-bandgap.c index

[PATCH 26/50] staging: omap-thermal: move conv table limits out of sensor data

As we have one conv table per bandgap device and not per sensor, this patch changes the data structures so that the conv table min and max values are now part of bandgap_data and not sensor_data. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 39

[PATCH 25/50] staging: omap-thermal: rewrite omap_bandgap_mcelsius_to_adc on kernel coding style

Follow Documentation/CodingStyle while doing omap_bandgap_mcelsius_to_adc Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers

[PATCH 24/50] staging: omap-thermal: name temp_to_adc_conversion in a better way

Rename temp_to_adc_conversion to omap_bandgap_mcelsius_to_adc. This name, though longer, describes better the function. This patch also changes this function signature so the function follows the style of this file. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap

[PATCH 23/50] staging: omap-thermal: add documentation for omap_bandgap_adc_to_mcelsius

Document the conversion function. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap-bandgap.c index

[PATCH 22/50] staging: omap-thermal: rewrite omap_bandgap_adc_to_mcelsius on kernel coding style

Follow Documentation/CodingStyle while doing omap_bandgap_adc_to_mcelsius. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers

[PATCH 21/50] staging: omap-thermal: name adc_to_temp_conversion in a better way

Rename adc_to_temp_conversion to omap_bandgap_adc_to_mcelsius. This name, though longer, describes better the function. Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 20/50] staging: omap-thermal: ADC section

Section of ADC helpers functions Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap-bandgap.c index ded2c8c

[PATCH 19/50] staging: omap-thermal: IRQ handler section

Section of IRQ handlers Signed-off-by: Eduardo Valentin --- drivers/staging/omap-thermal/omap-bandgap.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap-bandgap.c index 7927c59..ded2c8c

  1   2   >