[PATCH next] zram: __zram_reset_device() can be static

2013-02-07 Thread Fengguang Wu
Signed-off-by: Fengguang Wu --- drivers/staging/zram/zram_drv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next.orig/drivers/staging/zram/zram_drv.c 2013-02-08 10:10:21.924807710 +0800 +++ linux-next/drivers/staging/zram/zram_drv.c 2013-02-08 10:10:43.928808233

Re: [staging:staging-next 494/499] drivers/staging/fwserial/fwserial.c:581:3: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t'

2013-01-30 Thread Fengguang Wu
On Wed, Jan 30, 2013 at 11:20:26PM +0300, Dan Carpenter wrote: > It should be using %zu instead of %ld. These warnings are new. I > don't get them on my system. Is it a new version of GCC or > something? Yeah you guessed right: I'm running gcc version 4.7.1 (Debian 4.7.1-6). Thanks, Fengguang

Re: [driver-core:driver-core-next 65/93] WARNING: drivers/built-in.o(.text+0xe2399): Section mismatch in reference from the function stmpe_i2c_probe() to the function .devinit.text:stmpe_probe()

2012-11-28 Thread Fengguang Wu
On Wed, Nov 28, 2012 at 02:16:49PM -0800, Greg KH wrote: > On Thu, Nov 29, 2012 at 05:38:31AM +0800, kbuild test robot wrote: > > tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > > driver-core-next > > head: da095fd3d5063f2dd03468d71f7df39a0430d86f > > commit:

Re: drivers/staging/zram/zram_drv.c:352:8-14: ERROR: reference preceded by free on line 343

2012-10-28 Thread Fengguang Wu
Hi, On Sun, Oct 28, 2012 at 01:09:12AM +0800, Fengguang Wu wrote: > Hi Nitin, > > FYI, there are coccinelle warnings in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master > head: e657e078d3dfa9f96976db7a2b5fd7d

drivers/staging/ramster/zcache-main.c:1394:13: warning: 'cli' may be used uninitialized in this function

2012-10-28 Thread Fengguang Wu
+ + cli = &zcache_clients[cli_id]; [...] out: if (cli != NULL) ==> atomic_dec(&cli->refcount); --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu

drivers/staging/zram/zram_drv.c:352:8-14: ERROR: reference preceded by free on line 343

2012-10-27 Thread Fengguang Wu
ers/staging/zram/zram_drv.c Nitin Gupta 2012-10-10 354} a1dd52af drivers/staging/ramzswap/ramzswap_drv.c Nitin Gupta 2010-06-01 355 --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu

[PATCH] ced1401: remove useless value cast on kmalloc()

2012-10-26 Thread Fengguang Wu
Casting value returned by k[cmz]alloc to (struct page * *) is useless. Generated by: scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci Reported-by: Fengguang Wu --- drivers/staging/ced1401/ced_ioc.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- linux-next.orig/drivers

drivers/staging/comedi/drivers/cb_pcidda.c:660 cb_pcidda_attach_pci() warn: variable dereferenced before check 'pcidev' (see line 659)

2012-10-23 Thread Fengguang Wu
Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[staging:staging-next 151/155] drivers/staging/et131x/et131x.c:2383:11: warning: passing argument 2 of 'et131x_align_allocated_memory' from incompatible pointer type

2012-10-22 Thread Fengguang Wu
&rx_ring->fbr[0]->ring_physaddr, e592a9b0 Mark Einon 2011-10-20 @2383 &rx_ring->fbr[0]->offset, 0x0FFF); --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu

[staging:staging-next 15/18] drivers/staging/ipack/carriers/tpci200.c:190:2: error: implicit declaration of function 'kfree'

2012-10-20 Thread Fengguang Wu
ge 2012-09-12 193 } The code at line 190 was first introduced by commit: 40733ed Staging: ipack/bridges/tpci200: move tpci200_free_irq() and tpci200_request_irq() --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu

Re: [driver-core:driver-core-next 4/11] include/linux/device.h:925:12: error: 'dev_vprintk_emit' defined but not used

2012-10-02 Thread Fengguang Wu
On Tue, Oct 02, 2012 at 06:46:33AM -0700, Greg KH wrote: > On Tue, Oct 02, 2012 at 06:41:27PM +0800, Fengguang Wu wrote: > > Hi Joe, > > > > FYI, kernel build failed on > > > > tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-

[driver-core:driver-core-next 4/11] include/linux/device.h:925:12: error: 'dev_vprintk_emit' defined but not used

2012-10-02 Thread Fengguang Wu
09-12 928) static inline __printf(3, 4) --- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu, Yuanhan Liu Intel Corporation ___ devel mailing list devel@linuxdriverprojec

Re: [staging:staging-next 253/267] drivers/staging/comedi/drivers/s626.c:2516 s626_attach_pci() warn: 'pcidev->irq' was not released on error

2012-09-27 Thread Fengguang Wu
On Thu, Sep 27, 2012 at 10:27:13AM +0300, Dan Carpenter wrote: > On Thu, Sep 27, 2012 at 01:18:00PM +0800, Fengguang Wu wrote: > > On Thu, Sep 27, 2012 at 12:00:09AM -0500, H Hartley Sweeten wrote: > > > On Wednesday, September 26, 2012 6:11 PM, Fengguang Wu wrote: > > &g

Re: [staging:staging-next 253/267] drivers/staging/comedi/drivers/s626.c:2516 s626_attach_pci() warn: 'pcidev->irq' was not released on error

2012-09-26 Thread Fengguang Wu
On Thu, Sep 27, 2012 at 12:00:09AM -0500, H Hartley Sweeten wrote: > On Wednesday, September 26, 2012 6:11 PM, Fengguang Wu wrote: > > > > FYI, there are new smatch warnings show up in > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

[staging:staging-next 253/267] drivers/staging/comedi/drivers/s626.c:2516 s626_attach_pci() warn: 'pcidev->irq' was not released on error

2012-09-26 Thread Fengguang Wu
524 s->n_chan = S626_ADC_CHANNELS; --- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu, Yuanhan Liu Intel Corporation ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[staging:staging-next 245/267] drivers/staging/comedi/drivers/s626.c:2492 s626_attach_pci() warn: '(dev->private)->base_addr' was not released on error

2012-09-26 Thread Fengguang Wu
} 2494 2495 devpriv->ANABuf.PhysicalBase = appdma; 2496 2497 devpriv->allocatedBuf++; 2498 2499 devpriv->RPSBuf.LogicalBase = 2500 pci_alloc_consistent(devpriv->pdev, DMABUF_SIZE, &app

drivers/staging/comedi/drivers/ni_pcimio.c:1694 pcimio_attach_pci() warn: 'dev->irq' was not released on error

2012-09-26 Thread Fengguang Wu
1698 dev->subdevices[NI_GPCT_SUBDEV(0)].buf_change = &pcimio_gpct0_change; 1699 dev->subdevices[NI_GPCT_SUBDEV(1)].buf_change = &pcimio_gpct1_change; 1700 dev->subdevices[NI_DIO_SUBDEV].buf_change = &pcimio_dio_change; 1701 1702

Re: [staging:staging-next 86/151] drivers/staging/iio/iio_hwmon.c:96:21-27: ERROR: application of sizeof to pointer

2012-09-19 Thread Fengguang Wu
On Wed, Sep 19, 2012 at 07:06:39PM +0200, Lars-Peter Clausen wrote: > On 09/19/2012 06:31 PM, Fengguang Wu wrote: > > Hi Lars-Peter, > > > > FYI, there are new coccinelle warnings show up in > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gre

[staging:staging-next 86/151] drivers/staging/iio/iio_hwmon.c:96:21-27: ERROR: application of sizeof to pointer

2012-09-19 Thread Fengguang Wu
olding the attached diff :-) --- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu, Yuanhan Liu Intel Corporation [PATCH] iio_hwmon: fix coccinelle warnings /c/kernel-tests/src/linux/drivers/staging/iio/iio_hwmon.c:96:21-27: ERROR:

[staging:staging-next 67/134] drivers/staging/rts_pstor/rtsx.c:397:16-19: ERROR: dev is NULL but dereferenced.

2012-09-19 Thread Fengguang Wu
e pointers */ 404 mutex_lock(&(dev->dev_mutex)); 405 406 pci_set_power_state(pci, PCI_D0); 407 pci_restore_state(pci); --- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu, Yuanhan Liu

[PATCH] staging: ozwpan: compare pointer to NULL rather than 0

2012-09-18 Thread Fengguang Wu
Generated by: scripts/coccinelle/null/badzero.cocci Signed-off-by: Fengguang Wu --- drivers/staging/ozwpan/ozcdev.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) --- linux.orig/drivers/staging/ozwpan/ozcdev.c 2012-09-19 09:33:20.887977986 +0800 +++ linux/drivers

[PATCH] Staging: panel: fix spinlock trylock failure on UP

2012-09-09 Thread Fengguang Wu
b/0xd0 [8.296795] [] ? __sync_filesystem+0xa0/0xa0 [8.298199] [] ? sysenter_do_call+0x12/0x37 [8.306899] Restarting system. [8.307747] machine restart Signed-off-by: Fengguang Wu --- drivers/staging/panel/panel.c | 44 1 file c

Re: show_uevent() and general protection fault

2012-08-16 Thread Fengguang Wu
On Fri, Aug 17, 2012 at 10:44:37AM +0800, Ming Lei wrote: > On Fri, Aug 17, 2012 at 10:29 AM, Fengguang Wu wrote: > > > > > Something obviously wrong here: > > > > env->buflen == 12 > > env->envp_idx == 1627389952 > > e

Re: show_uevent() and general protection fault

2012-08-16 Thread Fengguang Wu
> > --- tip.orig/drivers/base/core.c2012-08-17 08:48:07.101972082 +0800 > > +++ tip/drivers/base/core.c 2012-08-17 09:49:43.665912992 +0800 > > @@ -343,8 +343,11 @@ static ssize_t show_uevent(struct device > > goto out; > > > > /* copy keys to file */ > > -

Re: show_uevent() and general protection fault

2012-08-16 Thread Fengguang Wu
On Thu, Aug 16, 2012 at 10:27:11AM -0700, Greg KH wrote: > On Wed, Jul 18, 2012 at 01:15:52PM +0800, Fengguang Wu wrote: > > On Mon, Jul 16, 2012 at 06:33:42PM -0700, Greg Kroah-Hartman wrote: > > > On Fri, Jul 13, 2012 at 04:46:16PM +0800, Fengguang Wu wrote: > > >

Re: [staging:staging-next 70/73] drivers/staging/comedi/drivers/amplc_dio200.c:1444:2: error: implicit declaration of function 'IS_ISA_BOARD'

2012-08-15 Thread Fengguang Wu
On Wed, Aug 15, 2012 at 07:10:01AM -0700, Greg KH wrote: > On Wed, Aug 15, 2012 at 10:07:36PM +0800, Fengguang Wu wrote: > > > > Well it looks like my patches got applied in the wrong order (1, 3, > > > > 2) on Greg's staging-next branch, but as long as all 3 patc

Re: [staging:staging-next 70/73] drivers/staging/comedi/drivers/amplc_dio200.c:1444:2: error: implicit declaration of function 'IS_ISA_BOARD'

2012-08-15 Thread Fengguang Wu
On Wed, Aug 15, 2012 at 07:47:01AM -0700, Greg KH wrote: > On Wed, Aug 15, 2012 at 10:35:05PM +0800, Fengguang Wu wrote: > > > Wait, what do you mean by "non-rebaseable"? I think you mean > > > "non-bisectable" right? > > > > I mean, the bra

Re: [staging:staging-next 70/73] drivers/staging/comedi/drivers/amplc_dio200.c:1444:2: error: implicit declaration of function 'IS_ISA_BOARD'

2012-08-15 Thread Fengguang Wu
> > Well it looks like my patches got applied in the wrong order (1, 3, > > 2) on Greg's staging-next branch, but as long as all 3 patches are > > applied it ought to compile okay. > > Argh, I did? Sorry about that. Nothing I can do about it now :( No problem. That reminds me to mark the stagin

[PATCH v3] isdnloop: fix and simplify isdnloop_init()

2012-08-03 Thread Fengguang Wu
] [] __stack_chk_fail+0x2b/0x30 [ 23.185748] [] isdnloop_init+0xaf/0xb1 Signed-off-by: Fengguang Wu --- drivers/isdn/isdnloop/isdnloop.c | 12 1 file changed, 12 deletions(-) --- linux.orig/drivers/isdn/isdnloop/isdnloop.c 2012-08-03 16:39:08.543650310 +0800 +++ linux/drivers/isdn/isdnloop

[PATCH v2] isdnloop: fix and simplify isdnloop_init()

2012-08-03 Thread Fengguang Wu
On Thu, Aug 02, 2012 at 04:21:56PM -0700, David Miller wrote: > From: Fengguang Wu > Date: Thu, 2 Aug 2012 19:05:43 +0800 > > > Fix a buffer overflow bug by removing the revision transform code. > > > > [ 22.016214] isdnloop-ISDN-driver Rev 1.11.6.7 > >

[PATCH] isdnloop: fix and simplify isdnloop_init()

2012-08-02 Thread Fengguang Wu
] [] __stack_chk_fail+0x2b/0x30 [ 23.185748] [] isdnloop_init+0xaf/0xb1 Signed-off-by: Fengguang Wu --- drivers/isdn/isdnloop/isdnloop.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) --- linux.orig/drivers/isdn/isdnloop/isdnloop.c 2012-05-24 19:03:06.748430938 +0800 +++ linux

Re: [PATCH] isdnloop: fix and simplify isdnloop_init()

2012-08-02 Thread Fengguang Wu
On Thu, Aug 02, 2012 at 01:57:36PM +0300, Dan Carpenter wrote: > On Thu, Aug 02, 2012 at 06:44:56PM +0800, Fengguang Wu wrote: > > [Add more CC] > > > > That's not helpful... Resend the patch to netdev in a way that > applies. OK, sorry...

Re: [PATCH] isdnloop: fix and simplify isdnloop_init()

2012-08-02 Thread Fengguang Wu
[Add more CC] On Thu, Aug 02, 2012 at 12:01:58PM +0800, Fengguang Wu wrote: > Remove the non-sense isdnloop revision transform code, so as to fix: > > [ 22.016214] isdnloop-ISDN-driver Rev 1.11.6.7 > [ 22.097508] isdnloop: (loop0) virtual card added > [ 22.174400] Ker

[PATCH] isdnloop: fix and simplify isdnloop_init()

2012-08-01 Thread Fengguang Wu
] [] __stack_chk_fail+0x2b/0x30 [ 23.185748] [] isdnloop_init+0xaf/0xb1 Signed-off-by: Fengguang Wu --- drivers/isdn/isdnloop/isdnloop.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) --- linux.orig/drivers/isdn/isdnloop/isdnloop.c 2012-05-24 19:03:06.748430938 +0800 +++ linux

Re: show_uevent() and general protection fault

2012-07-17 Thread Fengguang Wu
On Mon, Jul 16, 2012 at 06:33:42PM -0700, Greg Kroah-Hartman wrote: > On Fri, Jul 13, 2012 at 04:46:16PM +0800, Fengguang Wu wrote: > > This is another kconfig, produced a bit different call trace, however > > also related to sysfs_read_file(). > > Any hint as to which file

Re: [staging:staging-next 86/99] drivers/staging/iio/adc/ad7298_ring.c:97:37: warning: 'time_ns' may be used uninitialized in this function

2012-07-13 Thread Fengguang Wu
On Fri, Jul 13, 2012 at 08:49:24AM +0200, Lars-Peter Clausen wrote: > On 07/13/2012 07:10 AM, Fengguang Wu wrote: > > Hi Lars-Peter, > > > > There are compile warnings in > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/stagi

[staging:staging-next 98/99] drivers/iio/light/adjd_s311.c:188:12: warning: cast from pointer to integer of different size

2012-07-12 Thread Fengguang Wu
= time_ns; 190 iio_push_to_buffer(buffer, (u8 *)data->buffer, time_ns); 191 --- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu Intel Corporation ___ devel mailing list devel@li

[staging:staging-next 86/99] drivers/staging/iio/adc/ad7298_ring.c:97:37: warning: 'time_ns' may be used uninitialized in this function

2012-07-12 Thread Fengguang Wu
ngth); i++) 95 buf[i] = be16_to_cpu(st->rx_buf[i]); 96 > 97 indio_dev->buffer->access->store_to(ring, (u8 *)buf, time_ns); 98 99 done: 100 iio_trigger_notify_done(indio_dev->trig); --- 0-DAY kernel build testing backend Open S

[staging:staging-next 93/99] drivers/staging/sm7xxfb/sm7xxfb.c:1061:1: warning: data definition has no type or storage class

2012-07-11 Thread Fengguang Wu
uot;Framebuffer driver for SMI Graphic Cards"); --- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu Intel Corporation ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [driver-core:driver-core-linus 6/6] drivers/firmware/iscsi_ibft_find.o: In function `kmsg_dump_rewind': (.text+0x18): multiple definition of `kmsg_dump_rewind'

2012-06-15 Thread Fengguang Wu
Hi Stephen, On Sat, Jun 16, 2012 at 11:15:50AM +1000, Stephen Rothwell wrote: > Hi, > > On Sat, 16 Jun 2012 08:02:55 +0800 w...@linux.intel.com wrote: > > > > Kernel build failed on > > > > tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > > driver-core-linus >

Re: comedi: kernel build error

2012-06-04 Thread Fengguang Wu
On Mon, Jun 04, 2012 at 06:15:52AM -0700, Greg KH wrote: > On Mon, Jun 04, 2012 at 08:47:24PM +0800, Fengguang Wu wrote: > > FYI, I got this error in some randconfig (where CONFIG_USB is not enabled): > > > > ERROR: "usb_deregister" [drivers/staging/comedi/

comedi: kernel build error

2012-06-04 Thread Fengguang Wu
FYI, I got this error in some randconfig (where CONFIG_USB is not enabled): ERROR: "usb_deregister" [drivers/staging/comedi/comedi.ko] undefined! ERROR: "usb_register_driver" [drivers/staging/comedi/comedi.ko] undefined! .config attached. Thanks, Fengguang # # Automatically generated file; DO NO