On 08/27/2012 03:34 PM, Baodong Chen wrote:
Sorry, I do not get this change. You should not touch tty_driver.kref at
all.
And what is the patch good for?
> Signed-off-by: Baodong Chen
> ---
> drivers/staging/net/pc300_tty.c | 55
> ++-
> 1 files changed,
On 07/29/2012 10:40 AM, Baodong Chen wrote:
> Fixed code to fix tty_driver's kref field
> checkpatch.pl clean up
> Signed-off-by: Baodong Chen
NACK. Please read Documentation/SubmittingPatches first.
This is an unreviewable patch. You do too many diverse changes in one
patch. Make your changes s
On 05/30/2011 11:23 PM, Peter Hüwe wrote:
> Hi Janitors, staging-list
>
> what is your opinion on using set_bit instead of using |= to set a bit?
> Is it worth the effort to convert existing |= to set_bit?
>
> __set_bit
> pro:
> - often implemented in optimized assembly (e.g. for x86)
> - intent
On 05/19/2011 06:03 PM, Dhoti Walla wrote:
> Hi Jiri,
>
> thanks for all you help. Two quick questions:
>
> 1) when I reply to these posts they go to jirisl...@gmail.com and
> devel@linuxdriverproject.org. The latter replies with something like
> 'message rejected based on filter rule'
Dunno, yo
On 05/19/2011 04:36 AM, Dhoti Walla wrote:
> BTW, if I use pci_iomap() do I still have to first invoke
> request_mem_region()?
Yes. And in fact, you should use pci_request_region.
regards,
--
js
___
devel mailing list
devel@linuxdriverproject.org
http:
On 05/18/2011 06:38 PM, Dhoti Walla wrote:
> I'm now using pci_iomap() and ioread*/iowrite* and I still face the same
> problems. After every write, I read back the register value and check it.
Are the registers RW or only W? Is the device intended to return
meaningful values from the registers at
On 05/18/2011 08:04 AM, Dhoti Walla wrote:
> Hello,
>
> I'm writing a driver for a PCI card and having some trouble accessing
> the memory mapped registers on the board.
>
> I use:
>
> pci_resource_start(..) and pci_resource_len(..) to get the starting
> address and size of the memory mapped re
On 04/27/2011 12:27 PM, Oren Weil wrote:
> + dev->mem_addr = pci_iomap(pdev, 0, 0);
...
> + iounmap(dev->mem_addr);
...
> + if (dev->mem_addr)
> + iounmap(dev->mem_addr);
Just what I noticed after a quick look: you shall use pci_iounmap for
pci_iomap'ped space.
regards,
--
On 04/22/2011 08:19 PM, Michelle Konzack wrote:
> Hello Greg KH,
>
> Am 2011-04-21 14:29:01, hacktest Du folgendes herunter:
>> Why do you need to write a new driver? We already have such a driver in
>> the kernel today, have you tried it?
>
> Because this keyboard has much more functions (incl
On 04/05/2011 09:11 PM, Roland Vossen wrote:
> Code cleanup. ASSERTs that check static (compile time) conditions
> have been removed.
I'm missing why? Is it obvious that it can never happen or is it an
optimization?
If the latter you should switch to BUILD_BUG_ON.
> Signed-off-by: Roland Vossen
On 03/31/2011 04:14 PM, Russell King wrote:
> On Thu, Mar 31, 2011 at 04:09:32PM +0200, Jiri Slaby wrote:
>> On 03/31/2011 03:51 PM, Russell King wrote:
>>> On Thu, Mar 31, 2011 at 03:48:20PM +0200, Jiri Slaby wrote:
>>>> How it can? Packed only tells the compi
On 03/31/2011 03:51 PM, Russell King wrote:
> On Thu, Mar 31, 2011 at 03:48:20PM +0200, Jiri Slaby wrote:
>> How it can? Packed only tells the compiler to have one byte alignment
>> steps. And it should not matter here as all the members are 32-bit long.
>
> It also tells the
On 03/30/2011 02:53 PM, Arnd Bergmann wrote:
> On Tuesday 29 March 2011, Jiri Slaby wrote:
>> On 03/29/2011 11:40 AM, Arend van Spriel wrote:
>>> --- /dev/null
>>> +++ b/drivers/brcmaxi/axi.c
>>> @@ -0,0 +1,786 @@
>> ...
>>> +/* res
On 03/29/2011 11:40 AM, Arend van Spriel wrote:
> --- /dev/null
> +++ b/drivers/brcmaxi/axi.c
> @@ -0,0 +1,786 @@
...
> +/* resetctrl */
> +#define AIRC_RESET 1
> +
> +/* definition for specifying padding fields */
> +#define _PADLINE(line) pad ## line
> +#define _XSTR(
On 03/23/2011 08:08 AM, Marek Belisko wrote:
> From: pixo
>
> Firmware file needs to be read by 4bytes also on 64 bit architectures.
> Change long type to u32 and also extend checking. Tested on 32 and also
> 64 bit architectures.
>
> Signed-off-by: Stano Lanci
> Signed-off-by: Marek Belisko
>
On 03/18/2011 10:37 AM, Xiaochen Wang wrote:
> Description:
> 1. use filp_open/vfs_read/filp_close instead of system calls
> 2. fix double calling of sys_close when first sys_lseek fails
> 3. reset segment fs when reading file into kernel space buffer
Hmm, this is still ugly and no driver shoul
On 03/01/2011 11:45 AM, Jiri Slaby wrote:
> On 02/25/2011 04:39 PM, Arend van Spriel wrote:
>> --- a/drivers/staging/brcm80211/util/hnddma.c
>> +++ b/drivers/staging/brcm80211/util/hnddma.c
>> @@ -32,6 +32,10 @@
>> #include
>> #endif
>>
>> +#ifde
On 02/25/2011 04:39 PM, Arend van Spriel wrote:
> --- a/drivers/staging/brcm80211/util/hnddma.c
> +++ b/drivers/staging/brcm80211/util/hnddma.c
> @@ -32,6 +32,10 @@
> #include
> #endif
>
> +#ifdef BRCM_FULLMAC
> +#error "hnddma.c shouldn't be needed for FULLMAC"
> +#endif
> +
> /* debug/trace
On 02/11/2011 06:59 PM, K. Y. Srinivasan wrote:
> In preperation for getting rid of the osd layer; change
> the code to use native wait interfaces. As part of this,
> fixed the buggy implementation in the osd_wait_primitive
> where the condition was cleared potentially after the
> condition was si
On 02/15/2011 02:38 AM, wei_w...@realsil.com.cn wrote:
> From: wwang
>
> Fix some sparse warning for realtek_cr patch
>
> Signed-off-by: wwang
> ---
> drivers/usb/storage/realtek_cr.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/storage/realtek_
On 01/19/2011 09:54 AM, Uwe Kleine-König wrote:
> On Tue, Jan 18, 2011 at 09:37:15PM -0800, Greg KH wrote:
>> On Tue, Jan 18, 2011 at 04:39:11PM +0100, Uwe Kleine-König wrote:
>>> Signed-off-by: Uwe Kleine-König
>>> ---
>>> drivers/staging/hv/osd.h |5 ++---
>>> 1 files changed, 2 insertions(
On 12/13/2010 02:16 PM, Namhyung Kim wrote:
> The gcc complains about the cast pointer to int on 64-bit as follows.
> Use unsigned long instead and wrap it up in new macro.
>
> CC [M] drivers/staging/vme/bridges/vme_ca91cx42.o
> drivers/staging/vme/bridges/vme_ca91cx42.c: In function
> ‘ca91cx
On 11/29/2010 11:01 PM, Randy Dunlap wrote:
> On Mon, 29 Nov 2010 22:59:11 +0100 Peter Hüwe wrote:
>
>>> Are you sure? I'm used to these being gcc warnings, not sparse.
>> You're right - these are generated by gcc ;) sorry for the confusion.
>>
>>> Also, this fixes the warnings on x86_64 but not
On 11/23/2010 03:00 PM, Belisko Marek wrote:
> On Tue, Nov 23, 2010 at 2:53 PM, Jiri Slaby wrote:
>> On 11/23/2010 01:29 PM, Marek Belisko wrote:
>>> Use simple misc device for ioctl driver funtionality testing.
>>>
>>> Signed-off-by: Marek Belisko
>>&g
On 11/23/2010 01:29 PM, Marek Belisko wrote:
> Use simple misc device for ioctl driver funtionality testing.
>
> Signed-off-by: Marek Belisko
> ---
> drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c | 90 ++---
> 1 files changed, 77 insertions(+), 13 deletions(-)
>
> diff --gi
On 11/10/2010 02:20 PM, Damian Varayud wrote:
> @@ -291,21 +296,22 @@ static void __exit ni_tio_cleanup_module(void)
>
> module_exit(ni_tio_cleanup_module);
>
> struct ni_gpct_device *ni_gpct_device_construct(struct comedi_device *dev,
> - void (*writ
On 11/10/2010 12:51 PM, Carmine IASCONE wrote:
> Hi Greg, Hi JS,
> Matteo and I have started to develop linux device drivers for our
> STMicroelectronics sensors about one year ago. Our main target is the Android
> platform (mobile phone or tablet pc), and for this reason the drivers are
> thoug
On 11/09/2010 06:25 PM, mems applications wrote:
> Add STMicroelectronics LIS331DLH digital accelerometer device driver
I'm no IIC guy, but why this goes to staging?
> From: Carmine Iascone
> ---
> drivers/staging/Kconfig |2 +
> drivers/staging/Makefile |1 +
On 10/12/2010 10:33 PM, nohee ko wrote:
> --- a/drivers/staging/brcm80211/include/linuxver.h
> +++ b/drivers/staging/brcm80211/include/linuxver.h
> @@ -35,14 +35,11 @@
> #undef IP_TOS
> #include
>
> -#define KILL_PROC(nr, sig) \
> +#define KILL_PROC(pid, sig) \
> do { \
> s
On 10/08/2010 11:44 PM, Jason Cooper wrote:
> Replaced kernel_thread() with kthread_run(). Used kthread_should_stop()
> in place of watchdog_exited completion. Replaced watchdog_pid with
> struct task_struct.
>
> watchdog_tsk is NULL when not in use, -ENOMEM for error, otherwise, in use.
>
> Si
On 10/07/2010 09:26 PM, Brett Rudley wrote:
> Sure, we'll try to get these tested ASAP.
You don't need to. They are buggy, as I wrote earlier:
http://www.spinics.net/lists/linux-driver-devel/msg08213.html
and
http://www.spinics.net/lists/linux-driver-devel/msg08214.html
regards,
--
js
__
On 10/07/2010 04:52 PM, Savoy, Pavan wrote:
> Per-system? I don't understand this.
> There can be ldisc for each individual TTY, so doesn't that make it per
> device?
No, you can have only up to NR_LDISCS ldiscs in the system and you have
to choose one of them to "handle" a particular tty.
IOW,
On 10/07/2010 11:42 AM, Jiri Slaby wrote:
> On 10/06/2010 11:40 PM, Jason Cooper wrote:
>> --- a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c
>> +++ b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c
...
>> +if (IS_ERR(tsk)) {
>> +
On 10/06/2010 11:40 PM, Jason Cooper wrote:
> --- a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c
> +++ b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c
...
> @@ -2020,7 +2022,14 @@ dhd_pub_t *dhd_attach(osl_t *osh, struct dhd_bus *bus,
> uint bus_hdrlen)
> /* Initialize watchdog th
On 10/07/2010 12:36 AM, Savoy, Pavan wrote:
> +int st_core_init(struct st_data_s **core_data)
> +{
> + struct st_data_s *st_gdata;
> + long err;
> + static struct tty_ldisc_ops *st_ldisc_ops;
> +
> + /* populate and register to TTY line discipline */
> + st_ldisc_ops
On 10/06/2010 10:08 PM, Savoy, Pavan wrote:
>> On 10/06/2010 06:18 PM, pavan_sa...@ti.com wrote:
>>> --- /dev/null
>>> +++ b/drivers/misc/ti-st/st_core.c
>>> @@ -0,0 +1,1031 @@
>> ...
>>> +#define PROTO_ENTRY(type, name)name
>>> +const unsigned char *protocol_strngs[] = {
>>> + PROTO_ENTRY(ST
Hi,
I have few comments below.
On 10/06/2010 06:18 PM, pavan_sa...@ti.com wrote:
> --- /dev/null
> +++ b/drivers/misc/ti-st/st_core.c
> @@ -0,0 +1,1031 @@
...
> +#define PROTO_ENTRY(type, name) name
> +const unsigned char *protocol_strngs[] = {
> + PROTO_ENTRY(ST_BT, "Bluetooth"),
> +
On 09/24/2010 12:40 PM, Mike McCormack wrote:
> --- a/drivers/staging/rtl8192e/dot11d.h
> +++ b/drivers/staging/rtl8192e/dot11d.h
> @@ -41,9 +41,11 @@ typedef struct _RT_DOT11D_INFO {
> DOT11D_STATE State;
> } RT_DOT11D_INFO, *PRT_DOT11D_INFO;
>
> -#define eqMacAddr(a, b) (((a)[0] == (b)[0
On 09/08/2010 02:38 AM, Greg KH wrote:
> On Tue, Sep 07, 2010 at 10:46:27AM +0200, Jiri Slaby wrote:
>> On 09/07/2010 07:34 AM, Javier Martinez Canillas wrote:
>>> Current patch solves compilation warnings in staging/xgifb for using
>>> possibly uninitialized varia
On 09/07/2010 07:34 AM, Javier Martinez Canillas wrote:
> Current patch solves compilation warnings in staging/xgifb for using possibly
> uninitialized variables.
>
> Signed-off-by: Javier Martinez Canillas
> ---
> drivers/staging/xgifb/vb_setmode.c |4 ++--
> 1 files changed, 2 insertions(
In wmi_bssInfo_event_rx, there is unneeded check for bss, because it
is in the branch where the bss is checked to be non-null already.
Remove the superfluous check.
Signed-off-by: Jiri Slaby
Cc: Vipin Mehta
Cc: Greg Kroah-Hartman
---
drivers/staging/ath6kl/wmi/wmi.c |2 +-
1 files
When 'context' allocation fails in imon_probe, we jump to unlock
context->ctx_lock. This is wrong as context is NULL and the lock is
not locked.
Fix the labels.
Signed-off-by: Jiri Slaby
Cc: Jarod Wilson
Cc: Mauro Carvalho Chehab
---
drivers/staging/lirc/lirc_imon.c |5 +
there are many
leaks. But that's a different story.
2) There is an omitted unlock in one fail path in vfd_write, jump to
the right place to unlock the lock.
3) In the probe function, there is one more error where the lock is
not unlocked. Fix that by jumping to the proper place.
Signed-off-by:
There is an omitted unlock in one fail path in vfd_write, jump to the
right place to unlock the lock.
Signed-off-by: Jiri Slaby
Cc: Jarod Wilson
Cc: Mauro Carvalho Chehab
---
drivers/staging/lirc/lirc_sasem.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a
story.
Signed-off-by: Jiri Slaby
Cc: Jarod Wilson
Cc: Mauro Carvalho Chehab
---
drivers/staging/lirc/lirc_sasem.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lirc/lirc_sasem.c
b/drivers/staging/lirc/lirc_sasem.c
index 73166c3..b496ff1 100644
On 08/18/2010 10:39 PM, Bernie Thompson wrote:
> +static ssize_t dlfb_ops_write(struct fb_info *info, const char __user *buf,
> + size_t count, loff_t *ppos)
> +{
> + ssize_t result = -ENOSYS;
> + struct dlfb_data *dev = info->par;
> + u32 offset = (u32) *ppos;
> +
On 08/18/2010 10:39 PM, Bernie Thompson wrote:
> static int dlfb_ops_blank(int blank_mode, struct fb_info *info)
> {
> struct dlfb_data *dev = info->par;
> +
> + if (blank_mode != FB_BLANK_UNBLANK) {
> char *bufptr;
> struct urb *urb;
>
> urb = dlfb_get_urb(dev);
>
On 07/30/2010 02:31 PM, walter harms wrote:
>
>
> Kulikov Vasiliy schrieb:
>> kmalloc() may fail, if so return error from zfwUsbSubmitControl().
>>
>> Signed-off-by: Kulikov Vasiliy
>> ---
>> drivers/staging/otus/wrap_usb.c |5 +
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>>
On 07/30/2010 01:07 PM, Kulikov Vasiliy wrote:
> put_user() may fail, if so return -EFAULT.
> Also compare count with copied data size, not size of struct with these
> fields.
Please do whitespace cleanup separately. We cannot review this.
--
js
___
de
On 07/29/2010 07:12 AM, Chris McIntosh wrote:
> + /*
> + * @todo Do we need to verify destination pointer
> + * "argp" is non-zero? Is that already done by
> + * copy_to_user()?
> + */
FWIW you need not. (Unless you want
On 07/29/2010 02:55 AM, H Hartley Sweeten wrote:
> On Wednesday, July 28, 2010 1:59 PM, Jiri Slaby wrote:
>> On 07/28/2010 06:48 PM, H Hartley Sweeten wrote:
>>> --- a/drivers/staging/dt3155/dt3155_drv.c
>>> +++ b/drivers/staging/dt3155/dt3155_drv.c
>>>
On 07/28/2010 06:48 PM, H Hartley Sweeten wrote:
> Make the module parameter dt3155_major static and add the proper
> wrappers to export it.
>
> Signed-off-by: H Hartley Sweeten
> Cc: Greg Kroah-Hartman
> Cc: Scott Smedley
> ---
>
> diff --git a/drivers/staging/dt3155/dt3155_drv.c
> b/drivers
On 07/25/2010 05:14 PM, Michael Jensen wrote:
> Removed macro definition that wasn't used.
>
> Signed-off-by: Michael Jensen
> ---
> drivers/staging/comedi/comedidev.h |5 -
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h
> b/drive
On 07/23/2010 11:17 AM, Michael Jensen wrote:
> On Fri, Jul 23, 2010 at 6:53 PM, Jiri Slaby wrote:
>>
>
>> Hmm, does this compile?
>>
> I did build the comedi directory (as per Greg's "Write and submit your
> first kernel patch" video), a
On 07/23/2010 08:11 AM, Michael Jensen wrote:
> Fixed a code style issue.
>
> Signed-off-by: Michael Jensen
> ---
> drivers/staging/comedi/comedidev.h |7 ---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h
> b/drivers/staging/come
On 07/21/2010 02:57 AM, H Hartley Sweeten wrote:
> The ioctl's DT3155_STOP and DT3155_START are defined with the macro
> _IO indicating that they have no parameters. They should not be using
> copy_to_user to return data to user space.
This is not a reason for removing them. You should check what
On 07/15/2010 08:42 AM, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_
On 07/06/2010 04:45 PM, Charles Clément wrote:
> Change variables to int type.
Why not to use in-kernel bool, true and false if it ought to be boolean?
regards,
--
js
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproje
On 07/06/2010 12:02 AM, Joe Eloff wrote:
> --- a/drivers/staging/dt3155/dt3155_drv.c
> +++ b/drivers/staging/dt3155/dt3155_drv.c
> @@ -78,7 +78,7 @@ extern void printques(int);
> MODULE_LICENSE("GPL");
>
> /* Error variable. Zero means no error. */
> -int dt3155_errno = 0;
> +int dt3155_errno
On 06/24/2010 08:02 PM, Charles Clément wrote:
> Replace all occurrences with unsigned long type, except for pointer fields
> that
> should be u32 in packed structures and 8-byte-aligned 8 byte long structure
> QWORD.
>
> Thanks to Jiri Slaby for pointing out that simply rep
On 06/24/2010 01:15 AM, Charles Clément wrote:
> Yes, no problem, although won't just changing these to u32 for the first
> case take the problem elsewhere in the driver?
No, it can't. As Greg wrote, apparently it has never ever been tested on
64-bit (it wouldn't work) and long on 32-bit is 32-bit
On 06/23/2010 01:56 AM, Charles Clément wrote:
> Replace all occurrences with unsigned long type.
At least this:
> --- a/drivers/staging/vt6655/desc.h
> +++ b/drivers/staging/vt6655/desc.h
...
> @@ -391,13 +391,13 @@ typedef const STxDesc *PCSTxDesc;
> typedef struct tagSTxSyncDesc {
> vola
On 05/31/2010 05:04 PM, Spyros Papageorgiou wrote:
> From:Spyros Papageorgiou
>
> Removed an unneeded struct specifier in function call.
>
> Signed-off-by: Spyros Papageorgiou
> ---
> drivers/staging/memrar/memrar_allocator.c |6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
On 05/26/2010 11:25 PM, Haiyang Zhang wrote:
>> From: Greg KH [mailto:gre...@suse.de]
>>> + VmbusChannelOpen(newChannel, 2 * PAGE_SIZE,
>>> +2 * PAGE_SIZE, NULL, 0,
>>> +hv_cb_utils[cnt].callback,
64 matches
Mail list logo
