Re: [PATCH 05/34] staging: bcm: for loop neatening

2012-01-12 Thread Julie Sullivan
> Presumably it was larger once and the person > making the change decided to be lazy. > Oh, OK, that makes sense. I was really scratching my head there :-) Thanks for the reply. Cheers Julie ___ devel mailing list devel@linuxdriverproject.org http://dr

Re: [PATCH 05/34] staging: bcm: for loop neatening

2012-01-11 Thread Julie Sullivan
OK, so it's probably obvious to everyone else, but please indulge a newbie. Why do we need a for() here? I've looked at the source file and I'm missing whatever it is. (I guess it must be deliberate, it's in more than one place in the source file.) - for (uiLoopIndex=0; uiLoopIndex <

Re: How should I update linux-next tree ?

2011-12-05 Thread Julie Sullivan
On Fri, Dec 2, 2011 at 8:57 PM, Dan Carpenter wrote: > On Fri, Dec 02, 2011 at 07:36:54AM -0300, Joilnen Leite wrote: >> Should I to do git pull ? >> or like said >> http://linux.f-seidel.de/linux-next/pmwiki/pmwiki.php?n=Linux-next.FAQ >> >> $ git remote add linux-next >> git://git.kernel.org/pu

Re: Need Info about Adding new Kernel Module source code to Linux Kernel Tree

2011-09-22 Thread Julie Sullivan
On Thu, Sep 22, 2011 at 6:28 AM, Sahana B Adiga - ERS, HCL Tech wrote: > Thanks a lot Julie. > This info is helping me a lot. > > > Regards, > Sahana Btw in case you have just come back from a two-week holiday on a desert island, the host for the kernel devs' collection of git kernel trees - kern

Re: Need Info about Adding new Kernel Module source code to Linux Kernel Tree

2011-09-21 Thread Julie Sullivan
Hi Sahana > 2.      I read somewhere that GIT is the revision control system used by > Linux Driver Developers. How to add our driver source code to GIT repository? >  I assume there is some strict validation involved as non-working or > improperly validated source code should not be added to t

Re: [PATCH 00/21] staging: brcm80211: code cleanup and fullmac bugfix

2011-06-12 Thread julie Sullivan
> > Yeah.  The driver only works under 32 bit.  This is listed in the > TODO file as something to fix before it leaves staging. > > regards, > dan carpenter > > Oh, OK. Thanks for the response. Cheers Julie ___ devel mailing list devel@linuxdriverprojec

Re: [PATCH 00/21] staging: brcm80211: code cleanup and fullmac bugfix

2011-06-12 Thread julie Sullivan
> I am using GregKH's staging-next repo: > git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6.git > > The patch applies on top of 5ad7b85b90e30eb5af4fbf6ce21907a2bd8934df. > > Bye, Roland. > OK, this compiles fine on x86-64/SMP. It's probably not interesting but there are just a few warni

Re: [PATCH 00/21] staging: brcm80211: code cleanup and fullmac bugfix

2011-06-09 Thread julie Sullivan
Roland, I'm happy to compile test this change (I don't have the hardware on a working machine) but I can't get this series to apply again, what tree are you using? If it's -next a tag reference would be helpful, it could be that my version is too recent. :-) Cheers Julie __

Re: [PATCH 44/83] staging: brcm80211: replaced typedef si_t with struct si_pub

2011-06-05 Thread julie Sullivan
> > #include > > #include > #include > -typedef const struct si_pub si_t; > + > +struct si_pub; > > #include > #include Is there any reason why dngl_stats.h and dhd.h are included twice in wl_iw.c? (if not, maybe you corrected this in another patch, I couldn't get the series to apply cleanly

Re: [PATCH 2/4] staging: Remove direct includes of printk.h

2011-05-29 Thread julie Sullivan
> --- a/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c > +++ b/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c > @@ -16,7 +16,6 @@ > >  #include >  #include > -#include > --- a/drivers/staging/usbip/usbip_common.h > +++ b/drivers/staging/usbip/usbip_common.h > @@ -24,7 +24,7 @@ >  #include >  #i