Re: Possibility for an external staging tree - bring up quality code

2013-03-28 Thread Luis R. Rodriguez
On Thu, Mar 28, 2013 at 3:53 PM, Greg Kroah-Hartman wrote: > On Thu, Mar 28, 2013 at 01:13:23PM -0700, Luis R. Rodriguez wrote: > > > >> This has me thinking if it makes sense to have an external driver tree >> for staging drivers but lead by engineers who already know

Possibility for an external staging tree - bring up quality code

2013-03-28 Thread Luis R. Rodriguez
Greg, folks, So the staging area of the Linux kernel has proven quite successful for a few drivers for 802.11 already. Otus [0] for example was rewritten completely first as ar9170 [1] and then carl9170 [2] even with open firmware, carl9170.fw [3] and then Otus got nuked. ath6kl [4] is another exa

Re: [PATCH 1/2] uapi: update includes for drm content when no kernel API exists

2012-10-16 Thread Luis R. Rodriguez
On Tue, Oct 16, 2012 at 5:34 AM, Laurent Pinchart wrote: > Hi Luis, > > On Saturday 13 October 2012 10:00:42 Luis R. Rodriguez wrote: >> On Sat, Oct 13, 2012 at 3:33 AM, Laurent Pinchart wrote: >> > On Friday 12 October 2012 16:49:31 Luis R. Rodriguez wrote: >&g

Re: [PATCH 1/2] uapi: update includes for drm content when no kernel API exists

2012-10-13 Thread Luis R. Rodriguez
On Sat, Oct 13, 2012 at 3:33 AM, Laurent Pinchart wrote: > Hi Luis, > > On Friday 12 October 2012 16:49:31 Luis R. Rodriguez wrote: >> From: "Luis R. Rodriguez" >> >> The UAPI changes split kernel API and userspace API >> content onto two separate hea

[PATCH 1/2] uapi: update includes for drm content when no kernel API exists

2012-10-12 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The UAPI changes split kernel API and userspace API content onto two separate header files. The userspace API drm content was moved to include/uapi/drm/ with the same file name while kernel specific API content was kept under include/drm/ with the same file

[PATCH 2/2] uapi: remove trailing spaces

2012-10-12 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" No functional changes. Cc: dri-de...@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Cc: de...@driverdev.osuosl.org Cc: backpo...@vger.kernel.org Cc: Rob Clark Cc: Arnd Bergmann Cc: Dave Jones Cc: David Airlie Cc: Ben Skeggs Cc: Alan Cox Cc: Dav

[PATCH 0/2] uapi: two minor changes

2012-10-12 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Here are a few minor updates to the UAPI changes [0]. The first one is to help with the backport effort [1], the second one is simply space cosmetic change to address my eyes bleeding while reviewing the changes on next-20121012 with git. If the changes on

Re: [PATCH v2] Move brcm80211 to mainline

2011-09-30 Thread Luis R. Rodriguez
On Fri, Sep 30, 2011 at 2:54 PM, Arend Van Spriel wrote: >> From: Johannes Berg [mailto:johan...@sipsolutions.net] >> Sent: donderdag 25 augustus 2011 7:03 >> >> > +#define LOCK(wl)   spin_lock_bh(&(wl)->lock) >> >> No way ... >> > > Hi Johannes, > > Your comment is a bit open for interpretation (

Re: [PATCH 00/20] staging: brcm80211: 7th reaction for mainline patch #2

2011-09-21 Thread Luis R. Rodriguez
2011/9/20 Alex Deucher : > 2011/9/20 Rafał Miłecki : >> 2011/9/20 Johannes Berg : >>> On Tue, 2011-09-20 at 06:03 -0700, Greg KH wrote: >>> And while code is great and nice, I still haven't seen any real answers to all of the questions that were asked of the Broadcom driver team duri

Re: [PATCH v2] Move brcm80211 to mainline

2011-08-31 Thread Luis R. Rodriguez
On Wed, Aug 31, 2011 at 11:33 AM, Greg KH wrote: > On Wed, Aug 31, 2011 at 10:55:45AM -0700, Luis R. Rodriguez wrote: >> On Tue, Aug 30, 2011 at 11:14 AM, Greg KH wrote: >> > On Mon, Aug 29, 2011 at 06:42:57PM -0700, Henry Ptasinski wrote: >> >> The brcmsmac driv

Re: [PATCH v2] Move brcm80211 to mainline

2011-08-31 Thread Luis R. Rodriguez
On Tue, Aug 30, 2011 at 11:14 AM, Greg KH wrote: > On Mon, Aug 29, 2011 at 06:42:57PM -0700, Henry Ptasinski wrote: >> The brcmsmac driver has architectural alignment with our drivers for other >> operating systems, and we intend to to enhance and maintain this driver in >> parallel with drivers f

Re: [PATCH v2] Move brcm80211 to mainline

2011-08-31 Thread Luis R. Rodriguez
On Wed, Aug 31, 2011 at 10:46 AM, Luis R. Rodriguez wrote: > At Atheros not only have we provided documentation to help > support ath5k but we even released firmware for our legacy Otus driver > -- and documentation. To be clear, open GPLv2 firmware

Re: [PATCH v2] Move brcm80211 to mainline

2011-08-31 Thread Luis R. Rodriguez
On Wed, Aug 31, 2011 at 7:18 AM, John W. Linville wrote: > On Wed, Aug 31, 2011 at 01:55:58PM +0200, Hauke Mehrtens wrote: > >> If brcmsmac gets merged it should support all braodcom softmac wireless >> devices with ieee80211n support, this includes also the N-PHY devices >> with SB-bus, otherwise

[PATCH 1/2] linux-firmware: update Atheros firmware license

2011-04-22 Thread Luis R. Rodriguez
...@atheros.com Cc: Len Widra Cc: Brian Lee Cc: Adam Tachner Cc: Paul Lever Cc: Vipin Mehta Signed-off-by: Luis R. Rodriguez --- LICENCE.atheros_firmware |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/LICENCE.atheros_firmware b/LICENCE.atheros_firmware index d336492

[PATCH 0/2] linux-firmware: changes for ath6kl firmware

2011-04-22 Thread Luis R. Rodriguez
David, the first patch was sent September, 1, 2010 but I just noticed that it was never applied. I am resending that and now with the never-sent-before ath6kl firmware... Luis R. Rodriguez (2): linux-firmware: update Atheros firmware license linux-firmware: add ath6kl firmware

[PATCH v2 5/5] ath6kl: fix operations for power management

2011-04-21 Thread Luis R. Rodriguez
thing. Signed-off-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/os/linux/cfg80211.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ath6kl/os/linux/cfg80211.c b/drivers/staging/ath6kl/os/linux/cfg80211.c index d5e554e

[PATCH v2 4/5] ath6kl: fix scan operation while disconnect

2011-04-21 Thread Luis R. Rodriguez
return the scan done to the cfg80211 to enable futher scans to be issued. Signed-off-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/os/linux/cfg80211.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/staging/ath6kl/os/linux

[PATCH v2 3/5] ath6kl: add the device ID on the data command packet

2011-04-21 Thread Luis R. Rodriguez
From: Naveen Singh The firmware expects the device ID to be added on the data and command packets sent to firmware for AR6003 v2.1.1. Signed-off-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/include/common/wmi.h | 23 ++- drivers/staging

[PATCH v2 1/5] ath6kl: add support for AR6003 v2.1.1

2011-04-21 Thread Luis R. Rodriguez
files are different for AR6003 v2.1.1. The capability to read those file have been added in the driver. 3. Certain parameters like numdevice, firmware mode needs to be programmed for proper functionality of new driver. Signed-off-by: Naveen Singh Signed-off-by: Luis R. Rodriguez

[PATCH v2 2/5] ath6kl: Extend WMI API used by AR6003 v2.1.1

2011-04-21 Thread Luis R. Rodriguez
From: Naveen Singh These commands and event IDs are used by AR6003 v2.1.1. Some events are no longer needed so these are removed now. Signed-off-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/include/common/wmi.h | 95 +++ drivers

[PATCH v2 0/5] ath6kl: AR6003 v2.1.1 support

2011-04-21 Thread Luis R. Rodriguez
Greg, here's a respin of Naveen's patches cleaned up and sanitized, and also fixed to apply on top of your staging-next branch as of today. Will be sending the respective firmware files to David later once I get them from our team. You will see whitespace noise on the patches but these complaints

Re: [PATCH 0/5] staging:ath6kl:patches for supporting 2.1.1 and bug fixes

2011-04-21 Thread Luis R. Rodriguez
On Wed, Apr 06, 2011 at 08:52:16PM -0700, Naveen Singh wrote: > From: Naveen Singh > > Greg, > > These are set of 5 patches for ath6kl. These patches are related > to the correct functionality of driver as well as providing the > support of 2.1.1 silicon in the upstream driver. > > I have teste

Re: [PATCH 0/5] staging:ath6kl:patches for supporting 2.1.1 and bug fixes

2011-04-20 Thread Luis R. Rodriguez
On Tue, Apr 12, 2011 at 1:28 PM, Vipin Mehta wrote: > Greg, >  Did you get a chance to review these patches? Pls provide us your feedback. Greg, I saw you were starting to integrate some changes (I think), I was just wondering if these were in the batch of new updates you are integrating, or if

Re: [PATCH 34/34] ath6kl: remove the HTC raw interface

2011-03-31 Thread Luis R. Rodriguez
On Thu, Mar 31, 2011 at 9:50 AM, Vipin Mehta wrote: > The raw HTC support is required for the tools used on the manufacturing floor > For module calibration. Without this code, the driver and the hardware > cannot be shipped. I suggest we keep this code until we add the support for > nl80211 test

[PATCH 33/34] ath6kl: remove ar6000_prepare_target() crap

2011-03-29 Thread Luis R. Rodriguez
This was empty code, WTF^pi. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/include/common_drv.h |4 --- drivers/staging/ath6kl/miscdrv/common_drv.c | 34 -- drivers/staging/ath6kl/os/linux/ar6000_drv.c |8 -- 3 files

[PATCH 34/34] ath6kl: remove the HTC raw interface

2011-03-29 Thread Luis R. Rodriguez
This uses ioctl, if this is required it should be replaced with the nl80211 test command interface. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/Kconfig |6 - drivers/staging/ath6kl/Makefile|5 - drivers/staging

[PATCH 26/34] ath6kl: propagate errors on hifEnableFunc() failures

2011-03-29 Thread Luis R. Rodriguez
This will be passed along to the SDIO probe routine when it fails. This will generate better error code to the user when loading the module if it fails. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../staging/ath6kl/hif/sdio/linux_sdio/src/hif.c | 12 ++-- 1 files changed

[PATCH 32/34] ath6kl: remove chatty debug messages on ath6kl driver ops

2011-03-29 Thread Luis R. Rodriguez
These do not help in any way. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../staging/ath6kl/hif/sdio/linux_sdio/src/hif.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/staging/ath6kl/hif/sdio/linux_sdio/src/hif.c b/drivers/staging/ath6kl

[PATCH 31/34] ath6kl: rename the pm ops to something more sensible

2011-03-29 Thread Luis R. Rodriguez
This has no functional changes. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../staging/ath6kl/hif/sdio/linux_sdio/src/hif.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/ath6kl/hif/sdio/linux_sdio/src/hif.c b/drivers

[PATCH 22/34] ath6kl: use CONFIG_ATH6KL_ENABLE_COEXISTENCE

2011-03-29 Thread Luis R. Rodriguez
When CONFIG_ATH6KL_ENABLE_COEXISTENCE gets enabled we define another flag called ENABLE_COEXISTENCE, just use CONFIG_ATH6KL_ENABLE_COEXISTENCE since that is already defined by the generated autoconf header file from the kernel. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers

[PATCH 30/34] ath6kl: cleanup and move the ath6kl pm ops to be assigned statically

2011-03-29 Thread Luis R. Rodriguez
assigning the pm ops statically. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../staging/ath6kl/hif/sdio/linux_sdio/src/hif.c | 130 ++-- 1 files changed, 64 insertions(+), 66 deletions(-) diff --git a/drivers/staging/ath6kl/hif/sdio/linux_sdio/src/hif.c b/drivers

[PATCH 29/34] ath6kl: remove completely pointles platform driver

2011-03-29 Thread Luis R. Rodriguez
Perhaps there was some good intention on having some platform driver on ath6kl, but right now its pointless. Kill! Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/os/linux/ar6000_drv.c |6 -- drivers/staging/ath6kl/os/linux/ar6000_pm.c| 55

[PATCH 27/34] ath6kl: cleanup allocation and getting of the hif dev

2011-03-29 Thread Luis R. Rodriguez
Removes verbose debug messages and checks that are just not needed, and renames the functions to something more sensible. While we clean this up, just move the routines above and remove the forward declarations. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../staging/ath6kl/hif/sdio

[PATCH 28/34] ath6kl: style cleanup on struct sdio_driver components

2011-03-29 Thread Luis R. Rodriguez
No functional changes except renames of the routines and id data structure. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../staging/ath6kl/hif/sdio/linux_sdio/src/hif.c | 172 ++-- 1 files changed, 85 insertions(+), 87 deletions(-) diff --git a/drivers/staging

[PATCH 25/34] ath6kl: remove useless plat_setup_power() calls

2011-03-29 Thread Luis R. Rodriguez
These map to do nothing. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/os/linux/ar6000_drv.c |3 --- drivers/staging/ath6kl/os/linux/ar6000_pm.c|6 -- .../staging/ath6kl/os/linux/include/wlan_config.h |6 -- 3 files changed, 0

[PATCH 23/34] ath6kl: simplify btcoex parameter programming

2011-03-29 Thread Luis R. Rodriguez
Make the code more legible by parsing the config options on the header file. While a it ensure to propagate errors and bail out if we fail to set btcoex params. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/os/linux/ar6000_drv.c | 80

[PATCH 24/34] ath6kl: propagate errors on module setup

2011-03-29 Thread Luis R. Rodriguez
This propagates initial platform registration failures and also HIF initialization failures. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../staging/ath6kl/hif/sdio/linux_sdio/src/hif.c | 32 --- drivers/staging/ath6kl/os/linux/ar6000_drv.c | 12

[PATCH 19/34] ath6kl: use CONFIG_AR600x_WB31_XXX

2011-03-29 Thread Luis R. Rodriguez
When CONFIG_AR600x_WB31_XXX gets enabled we define another flag called AR600x_WB31_XXX, just use CONFIG_AR600x_WB31_XXX since that is already defined by the generated autoconf header file from the kernel. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/Makefile

[PATCH 21/34] ath6kl: remove AR600x_CUSTOM_XXX define

2011-03-29 Thread Luis R. Rodriguez
There already is a CONFIG_AR600x_CUSTOM_XXX if this is desired to be used. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/Makefile |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ath6kl/Makefile b/drivers/staging/ath6kl

[PATCH 20/34] ath6kl: use CONFIG_AR600x_SD32_XXX

2011-03-29 Thread Luis R. Rodriguez
When CONFIG_AR600x_SD32_XXX gets enabled we define another flag called AR600x_SD32_XXX, just use CONFIG_AR600x_SD32_XXX since that is already defined by the generated autoconf header file from the kernel. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/Makefile

[PATCH 12/34] ath6kl: remove SEND_EVENT_TO_APP define

2011-03-29 Thread Luis R. Rodriguez
This was enabled by default but its pretty useless for upstream given that its sendign some custom wireless event. These need to be reviewed instead and a respective cfg80211 event / call should be used later. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl

[PATCH 17/34] ath6kl: remove INIT_MODE_DRV_ENABLED define

2011-03-29 Thread Luis R. Rodriguez
Since this is defined statically we just leave the code. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/Makefile|1 - drivers/staging/ath6kl/os/linux/ar6000_drv.c | 14 -- .../staging/ath6kl/os/linux/include/ar6000_drv.h

[PATCH 11/34] ath6kl: remove dependency on LINUX and KERNEL_2_6 macros

2011-03-29 Thread Luis R. Rodriguez
Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/Makefile|1 - drivers/staging/ath6kl/htc2/AR6000/ar6k.h |3 - drivers/staging/ath6kl/include/a_config.h | 22 drivers/staging/ath6kl/include/a_debug.h

[PATCH 10/34] ath6kl: remove define ATH_AR6K_11N_SUPPORT

2011-03-29 Thread Luis R. Rodriguez
This is always enabled. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/Makefile |1 - drivers/staging/ath6kl/os/linux/ar6000_drv.c | 12 drivers/staging/ath6kl/reorder/rcv_aggr.c|4 drivers/staging/ath6kl/wmi/wmi.c

[PATCH 18/34] ath6kl: use CONFIG_AR600x_SD31_XXX

2011-03-29 Thread Luis R. Rodriguez
When CONFIG_AR600x_SD31_XXX gets enabled we define another flag called AR600x_SD31_XXX, just use CONFIG_AR600x_SD31_XXX since that is already defined by the generated autoconf header file from the kernel. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/Makefile

[PATCH 14/34] ath6kl: remove unused define NO_SYNC_FLUSH

2011-03-29 Thread Luis R. Rodriguez
Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/Makefile |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ath6kl/Makefile b/drivers/staging/ath6kl/Makefile index d7441e7..50f9be3 100644 --- a/drivers/staging/ath6kl/Makefile

[PATCH 16/34] ath6kl: remove unused define WLAN_HEADERS

2011-03-29 Thread Luis R. Rodriguez
All the code is used so just keep it and remove the static define. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/Makefile|1 - .../common/AR6002/hw4.0/hw/analog_intf_reg.h | 13 - .../include/common/AR6002/hw4.0/hw

[PATCH 15/34] ath6kl: remove define HTC_EP_STAT_PROFILING

2011-03-29 Thread Luis R. Rodriguez
This is always set so just keep the code it idefs around. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/Makefile|1 - drivers/staging/ath6kl/htc2/htc.c |6 -- drivers/staging/ath6kl/htc2/htc_internal.h |8 drivers

[PATCH 13/34] ath6kl: remove USER_KEYS define

2011-03-29 Thread Luis R. Rodriguez
This is always defined so just keep the code. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/Makefile|1 - drivers/staging/ath6kl/os/linux/ar6000_drv.c | 11 --- .../staging/ath6kl/os/linux/include/ar6000_drv.h |5

[PATCH 07/34] ath6kl: remove Bluetooth PAL code and WMI ACL TX/RX data support

2011-03-29 Thread Luis R. Rodriguez
processing of spurious ACL data frames from the target, previously they would not be dropped if they were generated by the target but EXPORT_HCI_PAL_INTERFACE was not compiled in. Cc: Naveen Singh Cc: Prerepa (Dham) Viswanadham Cc: Shanmugamkamatchi Balashanmugam Signed-off-by: Luis R. Rodriguez

[PATCH 06/34] ath6kl: move setting netdev for non-cf80211 case

2011-03-29 Thread Luis R. Rodriguez
Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/os/linux/ar6000_drv.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ath6kl/os/linux/ar6000_drv.c b/drivers/staging/ath6kl/os/linux/ar6000_drv.c index bb4dbb5..94b9132 100644 --- a/drivers

[PATCH 08/34] ath6kl: kill Android specific code

2011-03-29 Thread Luis R. Rodriguez
To get upstream we can't use out of tree defines, kill all the androidisms. ath6kl won't be usable on Android unless external patches are supported later or Android gets their shit together and gets all their crap upstream. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drive

[PATCH 05/34] ath6kl: remove SET_MODULE_OWNER usage

2011-03-29 Thread Luis R. Rodriguez
This is not required. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/os/linux/ar6000_drv.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ath6kl/os/linux/ar6000_drv.c b/drivers/staging/ath6kl/os/linux/ar6000_drv.c

[PATCH 01/34] ath6kl: s|A_FREE|kfree|g

2011-03-29 Thread Luis R. Rodriguez
for i in $(find ./drivers/staging/ath6kl/ -name \*.[ch]) ; do \ sed -r -i -e "s/A_FREE/kfree/g" $i; done Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/bmi/src/bmi.c |8 +++--- .../ath6kl/hif/sdio/linux_sdio/src/hif

[PATCH 02/34] ath6kl: remove BMIENABLE_SET define

2011-03-29 Thread Luis R. Rodriguez
Leave the code in place as this is always defined statically. Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/Makefile|1 - drivers/staging/ath6kl/os/linux/ar6000_android.c |2 - drivers/staging/ath6kl/os/linux/ar6000_drv.c | 66

[PATCH 04/34] ath6kl: replace do while loop with function helpers on ar6000_avail_ev()

2011-03-29 Thread Luis R. Rodriguez
This unwraps the do while loops in favor for function helpers. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/os/linux/ar6000_drv.c | 68 ++ 1 files changed, 48 insertions(+), 20 deletions(-) diff --git a/drivers/staging/ath6kl/os/linux

[PATCH 03/34] ath6kl: propagate error values on ar6000_avail_ev()

2011-03-29 Thread Luis R. Rodriguez
When something fails we set up some generic error values, instead keep the values from the callers and make sure to pass them on. Cc: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/os/linux/ar6000_drv.c | 51 -- 1 files changed, 24 insertions

[PATCH 00/34] ath6kl: cleanup series III

2011-03-29 Thread Luis R. Rodriguez
know if you have any issues. Luis R. Rodriguez (34): ath6kl: s|A_FREE|kfree|g ath6kl: remove BMIENABLE_SET define ath6kl: propagate error values on ar6000_avail_ev() ath6kl: replace do while loop with function helpers on ar6000_avail_ev() ath6kl: remove SET_MODULE_OWNER usage ath6kl: mov

Unstable staging-next branch ?

2011-03-29 Thread Luis R. Rodriguez
Hey Greg, the staging-next branch seems pretty unstable right now, am I the only one experiencing this? Unfortunately I cannot debug what is making it unstable at the moment though. Just curious -- can suck in new 2.6.38 stuff and also tags. Also would it be too much trouble to ask for private bra

Update on Android PM enhancements - CONFIG_HAS_EARLYSUSPEND and friends

2011-03-23 Thread Luis R. Rodriguez
Arve, What ever happened with your series on the Android PM extensions you had submitted in 2009 [1] ? I'm working on ath6kl right now and I'm going to remove all that early suspend crap as its not upstream and I want to get ath6kl into upstream proper. Do you have plans for a replacement? Since t

Re: [RTF] iwmc3200wifi: fix device registration ordering for cfg80211

2011-03-18 Thread Luis R. Rodriguez
On Fri, Mar 18, 2011 at 11:03 AM, Johannes Berg wrote: > On Fri, 18 Mar 2011 10:41:53 -0700, Luis R. Rodriguez wrote: >>> >>> On Fri, Mar 18, 2011 at 6:50 AM, John W. Linville >>>> >>>> Does anyone even have this hardware? > > I don't t

Re: [RTF] iwmc3200wifi: fix device registration ordering for cfg80211

2011-03-18 Thread Luis R. Rodriguez
> On Fri, Mar 18, 2011 at 6:50 AM, John W. Linville >> Does anyone even have this hardware? So similarly here we can likely hit a case where we hit the double wiphy_unregister() twice and I think we'd oops. My preference is to make wiphy_unregister() re-entrant and let us detect when the device al

Re: [PATCH] ath6kl: fix device registration ordering

2011-03-18 Thread Luis R. Rodriguez
On Fri, Mar 18, 2011 at 10:35 AM, Luis R. Rodriguez wrote: > On Thu, Mar 17, 2011 at 7:45 PM, Luis R. Rodriguez > wrote: >> Defer device registration to cfg80211 until it is ready. >> This fixes a race against udev whereby device events >> (both udev and RTNL)

Re: [PATCH] ath6kl: fix device registration ordering

2011-03-18 Thread Luis R. Rodriguez
On Thu, Mar 17, 2011 at 7:45 PM, Luis R. Rodriguez wrote: > Defer device registration to cfg80211 until it is ready. > This fixes a race against udev whereby device events > (both udev and RTNL) might be emitted with an unregistered > device specification (wlan%d). > > This fixe

Re: [RTF] iwmc3200wifi: fix device registration ordering for cfg80211

2011-03-18 Thread Luis R. Rodriguez
On Fri, Mar 18, 2011 at 6:50 AM, John W. Linville wrote: > On Thu, Mar 17, 2011 at 08:11:17PM -0700, Luis R. Rodriguez wrote: >> On Thu, Mar 17, 2011 at 8:10 PM, Luis R. Rodriguez >> wrote: >> > Without this you can get a race against udev and userspace daemons >>

Re: [RTF] iwmc3200wifi: fix device registration ordering for cfg80211

2011-03-17 Thread Luis R. Rodriguez
On Thu, Mar 17, 2011 at 8:10 PM, Luis R. Rodriguez wrote: > Without this you can get a race against udev and userspace daemons > which will try to poke the device even before netdev ops and friends > are available. Device initialization will fail without this. > > Cc: sta...@

[RTF] iwmc3200wifi: fix device registration ordering for cfg80211

2011-03-17 Thread Luis R. Rodriguez
: Luis R. Rodriguez --- I'm pretty sure this is correct, I noticed ath6kl followed the same path as iwmc3200wifi and I spotted a bug on ath6kl with this path.. so I'm pretty damn sure this bug is also present on iwmc3200wifi. Please test. drivers/net/wireless/iwmc3200wifi/cfg8021

[PATCH] ath6kl: fix device registration ordering

2011-03-17 Thread Luis R. Rodriguez
Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/os/linux/ar6000_drv.c |8 drivers/staging/ath6kl/os/linux/cfg80211.c |9 - 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/ath6kl/os/linux/ar6000_drv.c b/drivers/staging/ath6kl/os

Re: [PATCH 00/38] ath6kl: remove typedefs part II

2011-03-14 Thread Luis R. Rodriguez
On Mon, Mar 14, 2011 at 10:58 AM, Luis R. Rodriguez wrote: > Greg, here is my second cleanup series for ath6kl. This series addresses > more typedef removals. Given that I have so many and they all do the > same, and are tested I'm submitting them all in one series. I can really

[PATCH 19/38] ath6kl: remove-typedef HTC_ENDPOINT_STATS

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HTC_ENDPOINT_STATS \ "struct htc_endpoint_stats" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/htc2/htc.c |6 +++--- drivers/staging/ath6kl/htc2/htc_internal.h |2 +- drivers/stag

[PATCH 18/38] ath6kl: remove-typedef HTC_ENDPOINT_CREDIT_DIST

2011-03-14 Thread Luis R. Rodriguez
This required two passes: remove-typedef -s HTC_ENDPOINT_CREDIT_DIST \ "struct htc_endpoint_credit_dist" drivers/staging/ath6kl/ remove-typedef -s _HTC_ENDPOINT_CREDIT_DIST \ "struct htc_endpoint_credit_dist" drivers/staging/ath6kl/ Tested-by: Naveen Singh S

[PATCH 13/38] ath6kl: remove-typedef HIF_SCATTER_ITEM

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HIF_SCATTER_ITEM \ "struct hif_scatter_item" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../ath6kl/hif/sdio/linux_sdio/src/hif_scatter.c |2 +- drivers/staging/ath6kl/htc2/AR6000/ar6k.c |2 +

[PATCH 06/38] ath6kl: remove-typedef HCI_TRANSPORT_PROPERTIES

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HCI_TRANSPORT_PROPERTIES \ "struct hci_transport_properties" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../ath6kl/htc2/AR6000/ar6k_gmbox_hciuart.c|2 +- drivers/staging/ath6kl/include/ar3kconfig.h

[PATCH 05/38] ath6kl: remove-typedef HCI_TRANSPORT_MISC_HANDLES

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HCI_TRANSPORT_MISC_HANDLES \ "struct hci_transport_misc_handles" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/include/common_drv.h |4 ++-- drivers/staging/ath6kl/os/linux/ar6000_dr

[PATCH 03/38] ath6kl: remove-typedef HCI_TRANSPORT_CALLBACKS

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HCI_TRANSPORT_CALLBACKS \ "struct hci_transport_callbacks" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/include/common_drv.h|4 ++-- drivers/staging/ath6kl/os/linux/ar6000_drv.c

[PATCH 02/38] ath6kl: remove-typedef GMBOX_PROTO_HCI_UART

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s GMBOX_PROTO_HCI_UART \ "struct gmbox_proto_hci_uart" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../ath6kl/htc2/AR6000/ar6k_gmbox_hciuart.c| 60 ++-- 1 files changed, 30 insertions(+), 30

[PATCH 38/38] ath6kl: remove-typedef HIF_DEVICE

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HIF_DEVICE \ "struct hif_device" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/bmi/include/bmi_internal.h |4 +- drivers/staging/ath6kl/bmi/src/bmi.c | 40 +- ..

[PATCH 35/38] ath6kl: remove-typedef ST_READ_STATUS

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s ST_READ_STATUS \ "struct st_read_status" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../staging/ath6kl/miscdrv/ar3kps/ar3kpsparser.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 34/38] ath6kl: remove-typedef ST_PS_DATA_FORMAT

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s ST_PS_DATA_FORMAT \ "struct st_ps_data_format" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../staging/ath6kl/miscdrv/ar3kps/ar3kpsparser.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) di

[PATCH 36/38] ath6kl: remove-typedef WINDOW_SNAPSHOT

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s WINDOW_SNAPSHOT \ "struct window_snapshot" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/reorder/aggr_rx_internal.h |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 33/38] ath6kl: remove-typedef RXTID_STATS

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s RXTID_STATS \ "struct rxtid_stats" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/reorder/aggr_rx_internal.h |6 +++--- drivers/staging/ath6kl/reorder/rcv_aggr.c | 16 ---

[PATCH 32/38] ath6kl: remove-typedef RXTID

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s RXTID \ "struct rxtid" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/reorder/aggr_rx_internal.h |6 ++-- drivers/staging/ath6kl/reorder/rcv_aggr.c | 22 ++-- 2 fil

[PATCH 31/38] ath6kl: remove-typedef PSCmdPacket

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s PSCmdPacket \ "struct ps_cmd_packet" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../staging/ath6kl/miscdrv/ar3kps/ar3kpsconfig.c |4 ++-- .../staging/ath6kl/miscdrv/ar3kps/ar3kpsparser.

[PATCH 29/38] ath6kl: remove-typedef HTC_TX_PACKET_INFO

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HTC_TX_PACKET_INFO \ "struct htc_tx_packet_info" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/include/htc_packet.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 30/38] ath6kl: remove-typedef OSBUF_HOLD_Q

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s OSBUF_HOLD_Q \ "struct osbuf_hold_q" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/reorder/aggr_rx_internal.h |8 drivers/staging/ath6kl/reorder/rcv_aggr.c |4 ++-- 2 fil

[PATCH 28/38] ath6kl: remove-typedef HTC_TARGET

2011-03-14 Thread Luis R. Rodriguez
This required two passes: remove-typedef -s _HTC_TARGET \ "struct htc_target" drivers/staging/ath6kl/ remove-typedef -s HTC_TARGET \ "struct htc_target" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/stagi

[PATCH 27/38] ath6kl: remove-typedef HTC_SERVICE_CONNECT_RESP

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HTC_SERVICE_CONNECT_RESP \ "struct htc_service_connect_resp" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/htc2/htc.c |2 +- drivers/staging/ath6kl/htc2/htc_services.c

[PATCH 26/38] ath6kl: remove-typedef HTC_SERVICE_CONNECT_REQ

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HTC_SERVICE_CONNECT_REQ \ "struct htc_service_connect_req" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/htc2/htc.c |2 +- drivers/staging/ath6kl/htc2/htc_services.c

[PATCH 24/38] ath6kl: remove-typedef HTC_PACKET_QUEUE

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HTC_PACKET_QUEUE \ "struct htc_packet_queue" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/htc2/AR6000/ar6k.h |2 +- .../ath6kl/htc2/AR6000/ar6k_gmbox_hciuart.c

[PATCH 25/38] ath6kl: remove-typedef HTC_RX_PACKET_INFO

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HTC_RX_PACKET_INFO \ "struct htc_rx_packet_info" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/include/htc_packet.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 21/38] ath6kl: remove-typedef HTC_FRAME_HDR

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HTC_FRAME_HDR \ "struct htc_frame_hdr" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/htc2/htc_internal.h | 12 drivers/staging/ath6kl/htc2/htc_recv.c

[PATCH 22/38] ath6kl: remove-typedef HTC_INIT_INFO

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HTC_INIT_INFO \ "struct htc_init_info" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/htc2/htc.c|4 ++-- drivers/staging/ath6kl/htc2/htc_internal.h |2 +- drivers/staging/ath6

[PATCH 20/38] ath6kl: remove-typedef HTC_EP_CALLBACKS

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HTC_EP_CALLBACKS \ "struct htc_ep_callbacks" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/htc2/htc_internal.h |2 +- drivers/staging/ath6kl/include/htc_api.h |6 +++--- 2 files

[PATCH 19/38] ath6kl: remove-typedef HTC_ENDPOINT_STATS

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HTC_ENDPOINT_STATS \ "struct htc_endpoint_stats" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/htc2/htc.c |6 +++--- drivers/staging/ath6kl/htc2/htc_internal.h |2 +- drivers/stag

[PATCH 18/38] ath6kl: remove-typedef HTC_ENDPOINT_CREDIT_DIST

2011-03-14 Thread Luis R. Rodriguez
This required two passes: remove-typedef -s HTC_ENDPOINT_CREDIT_DIST \ "struct htc_endpoint_credit_dist" drivers/staging/ath6kl/ remove-typedef -s _HTC_ENDPOINT_CREDIT_DIST \ "struct htc_endpoint_credit_dist" drivers/staging/ath6kl/ Tested-by: Naveen Singh S

[PATCH 17/38] ath6kl: remove-typedef HTC_ENDPOINT

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HTC_ENDPOINT \ "struct htc_endpoint" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/htc2/htc.c |2 +- drivers/staging/ath6kl/htc2/htc_internal.h |6 ++-- drivers/staging/a

[PATCH 16/38] ath6kl: remove-typedef HTC_CONTROL_BUFFER

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HTC_CONTROL_BUFFER \ "struct htc_control_buffer" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- drivers/staging/ath6kl/htc2/htc_internal.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 15/38] ath6kl: remove-typedef HIF_SCATTER_REQ

2011-03-14 Thread Luis R. Rodriguez
This requird two passes: remove-typedef -s HIF_SCATTER_REQ \ "struct hif_scatter_req" drivers/staging/ath6kl/ remove-typedef -s _HIF_SCATTER_REQ \ "struct hif_scatter_req" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodrigue

[PATCH 14/38] ath6kl: remove-typedef HIF_SCATTER_REQ_PRIV

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HIF_SCATTER_REQ_PRIV \ "struct hif_scatter_req_priv" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../hif/sdio/linux_sdio/include/hif_internal.h |8 +++- .../ath6kl/hif/sdio/linux_sdio/src/hif_scatter.

[PATCH 13/38] ath6kl: remove-typedef HIF_SCATTER_ITEM

2011-03-14 Thread Luis R. Rodriguez
remove-typedef -s HIF_SCATTER_ITEM \ "struct hif_scatter_item" drivers/staging/ath6kl/ Tested-by: Naveen Singh Signed-off-by: Luis R. Rodriguez --- .../ath6kl/hif/sdio/linux_sdio/src/hif_scatter.c |2 +- drivers/staging/ath6kl/htc2/AR6000/ar6k.c |2 +

  1   2   >