Re: [PATCH] staging:ft1000: replace c99 comments with c88

> + u32 version_id;/* Version ID of this image format. */ > + u32 package_id;/* Package ID of code release. */ > + u32 build_date;/* Date/time stamp when file was built. */ > + u32 commands_offset; /* Offset to attached commands in Pseudo Hdr >

Re: [PATCH V2 3/3] staging: zram: conventions, line splitting

> Problem is, other zram changes just went into my tree, so they probably > conflicted with your changes as well. Ok cool. I was assuming me and someone else simply clobbered each others work. I try and keep an eye on the mailing lists to avoid duplicating work and causing a merge conflict. Tha

Re: [PATCH V2 3/3] staging: zram: conventions, line splitting

>  drivers/staging/zram/zram_drv.c |    8 >  1 files changed, 4 insertions(+), 4 deletions(-) > > This patch no longer applies to the tree :( Hi Greg, I wrote the patch against Linus' tree . Is it more appropriate to write

[PATCH V2 2/3] staging: zram: conventions, __aligned() attribute

Using the __aligned() attribute in favor of __attribute__((aligned(size))) Signed-off-by: Sam Hansen --- drivers/staging/zram/zram_drv.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/zram/zram_drv.h b/drivers/staging/zram/zram_drv.h index fbe8ac9

[PATCH V2 3/3] staging: zram: conventions, line splitting

Opting to violate the 80-char limit in favor of not splitting strings onto multiple lines (via pr_info()). This mostly to help readability. Signed-off-by: Sam Hansen --- drivers/staging/zram/zram_drv.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH V2 1/3] staging: zram: conventions pr_warning -> pr_warn()

Porting zram to use the pr_warn() function instead of the deprecated pr_warning(). Signed-off-by: Sam Hansen --- drivers/staging/zram/zram_drv.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c

[PATCH V2 0/3] Styleguide conformity

From: Sam Hansen This patch set addresses basic checkpatch.pl issues. Sam Hansen (3): staging: zram: conventions pr_warning -> pr_warn() staging: zram: conventions, __aligned() attribute staging: zram: conventions, line splitting drivers/staging/zram/zram_drv.c |

Re: [PATCH 3/3] staging: zram: conventions, line splitting

> The general use has been to allow the format string to exceed > 80 columns, but not any additional arguments on the same line. Oh cool. Expect a follow up patch set later on. ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdr

[PATCH 3/3] staging: zram: conventions, line splitting

Opting to violate the 80-char limit in favor of not splitting strings onto multiple lines (via pr_info()). This mostly to help readability. Signed-off-by: Sam Hansen --- drivers/staging/zram/zram_drv.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 2/3] staging: zram: conventions, __aligned() attribute

Using the __aligned() attribute in favor of __attribute__((aligned(size))) Signed-off-by: Sam Hansen --- drivers/staging/zram/zram_drv.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/zram/zram_drv.h b/drivers/staging/zram/zram_drv.h index fbe8ac9

[PATCH 1/3] staging: zram: conventions pr_warning -> pr_warn()

Porting zram to use the pr_warn() function instead of the deprecated pr_warning(). Signed-off-by: Sam Hansen --- drivers/staging/zram/zram_drv.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c

[PATCH 0/3] Styleguide conformity

From: Sam Hansen This patch set addresses basic checkpatch.pl issues. Sam Hansen (3): staging: zram: conventions pr_warning -> pr_warn() staging: zram: conventions, __aligned() attribute staging: zram: conventions, line splitting drivers/staging/zram/zram_drv.c |

[PATCH V2 3/3] xgifb: checkpatch cleanup printk() -> pr_lvl()

Rewrote code to use pr_lvl() instead of printk(). There are still a few instances of printk(), mainly in the debug code which looks like it's going to be dropped/rewrote (most of it is blocked out). Signed-off-by: Sam Hansen --- drivers/staging/xgifb/XGI_main_26.c |

[PATCH V2 2/3] xgifb: checkpatch cleanup __func__

Replaced an instance of __FUNCTION__ with __func__ in XGI_main_26.c. Signed-off-by: Sam Hansen --- drivers/staging/xgifb/XGI_main_26.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index

[PATCH V2 1/3] xgifb: checkpatch cleanup braces

Cleaned up XGI_main_26.c and removed some unneeded braces to keep with code conventions. Signed-off-by: Sam Hansen --- drivers/staging/xgifb/XGI_main_26.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging

[PATCH V2 0/3] xgifb: patch set

CALLscripts/checksyscalls.sh CC [M] drivers/staging/xgifb/XGI_main_26.o LD [M] drivers/staging/xgifb/xgifb.o Building modules, stage 2. MODPOST 6 modules LD [M] drivers/staging/xgifb/xgifb.ko Sam Hansen (3): xgifb: checkpatch cleanup braces xgifb: checkpatch cleanup __func__

[PATCH] xgifb: pr_fmt kbuild macro

Added the kbuild macro pr_fmt() to XGI_main_26.c Signed-off-by: Sam Hansen --- drivers/staging/xgifb/XGI_main_26.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index 2502c49..edd7de7 100644

Re: [PATCH 3/3] xgifb: checkpatch cleanup, printk() KERN_*

> One other thing.  It would be better to add > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > before any #include and convert all the > printks(KERN_ to pr_( > stripping all the leading XGIfb: too. So, an administrative question. Sorry for my noob-ishness but... I will be 1) modifying the patch r

Re: [PATCH 3/3] xgifb: checkpatch cleanup, printk() KERN_*

> These last two should be KERN_CONT > though the block could be rewritten as > >        if (XGIInitNew(pdev)) >                printk(KERN_INFO "XGIfb: XGIInitNew() ... OK\n"); >        else >                printk(KERN_ERR "XGIfb: XGIInitNew() ... Fail\n"); > > Emitting any dmesg output like "XGI

Re: [PATCH 3/3] xgifb: checkpatch cleanup, printk() KERN_*

> It doesn't make sense to do this.  KERN_ERR puts a "<3>" in front of > the line so we know how important it is, but it's a blank line > because of the "\n" at the start. > > Also the should probably be using pr_err() or dev_err(). > > ... > > These put a "<3>" in the middle of the line which does

[PATCH 3/3] xgifb: checkpatch cleanup, printk() KERN_*

Added KERN_ facility levels in XGI_main_26.c and vb_init.c in a few different printk() statements. Signed-off-by: Sam Hansen --- drivers/staging/xgifb/XGI_main_26.c | 16 drivers/staging/xgifb/vb_init.c |2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff

[PATCH 1/3] xgifb: checkpatch cleanup, braces

Cleaned up XGI_main_26.c and removed some unneeded braces to keep with code conventions. Signed-off-by: Sam Hansen --- drivers/staging/xgifb/XGI_main_26.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging

[PATCH 2/3] xgifb: checkpatch cleanup __func__

Replaced an instance of __FUNCTION__ with __func__ in XGI_main_26.c. Signed-off-by: Sam Hansen --- drivers/staging/xgifb/XGI_main_26.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index

[PATCH 1/1] vme: code convention fix

Fixed a code convention violation in vme.h Signed-off-by: Sam Hansen --- drivers/staging/vme/vme.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/vme/vme.h b/drivers/staging/vme/vme.h index 9d38cee..c9d65bf 100644 --- a/drivers/staging/vme/vme.h +++ b