Re: kobject question

2013-05-30 Thread Greg Kroah-Hartman (gre...@linuxfoundation.org)
On Tue, May 28, 2013 at 09:13:15PM -0500, H Hartley Sweeten wrote: > > But let's take a step back, what are you trying to do by creating a new > > sysfs directory? You should never create a subdir in the device tree in > > sysfs, that is not a 'struct device'. That is because udev / userspace > >

Re: kobject question

2013-05-28 Thread Greg Kroah-Hartman (gre...@linuxfoundation.org)
On Tue, May 28, 2013 at 08:46:58PM -0500, H Hartley Sweeten wrote: > Greg, > > I'm trying to create a simple directory in the sysfs hierarchy following > Documentation/kobject.txt and samples/kobject-example.c. Hint, don't :) > I have been able to create the subdirectory and attributes but now >

Re: ioremap of PCI resources

2013-04-10 Thread Greg Kroah-Hartman (gre...@linuxfoundation.org)
On Wed, Apr 10, 2013 at 11:16:46AM -0500, H Hartley Sweeten wrote: > On Wednesday, March 06, 2013 4:34 PM, H Hartley Sweeten wrote: > > > > Question, when doing an ioremap() of a PCI resource which is more correct? > > > > iobase = pci_resource_start(pcidev, bar); > > len = pci_resource_len

Re: [PATCH 5/6] Drivers: hv: balloon: Implement hot-add functionality

2013-03-12 Thread gre...@linuxfoundation.org
On Tue, Mar 12, 2013 at 02:54:23AM +, KY Srinivasan wrote: > > > > -Original Message- > > From: K. Y. Srinivasan [mailto:k...@microsoft.com] > > Sent: Friday, March 08, 2013 5:16 PM > > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; >

Re: [PATCH 6/6] Drivers: hv: Execute shutdown in a thread context

2013-03-01 Thread gre...@linuxfoundation.org
On Fri, Mar 01, 2013 at 03:15:58PM +, KY Srinivasan wrote: > > > > > Execute the shutdown code in a thread context. With recent changes > > > > > made > > > > the > > > > > shutdown code, shutdown code cannot be invoked from an interrupt > > context. > > > > > > > > > > Signed-off-by: K. Y. Sr

Re: [PATCH 6/6] Drivers: hv: Execute shutdown in a thread context

2013-02-08 Thread gre...@linuxfoundation.org
On Sat, Feb 09, 2013 at 12:31:49AM +, KY Srinivasan wrote: > > > > -Original Message- > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Sent: Thursday, January 24, 2013 12:18 PM > > To: KY Srinivasan > > Cc: Jiri Kosina;

Re: [PATCH 6/6] Drivers: hv: Execute shutdown in a thread context

2013-01-24 Thread gre...@linuxfoundation.org
On Thu, Jan 24, 2013 at 05:06:27PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Jiri Kosina [mailto:jkos...@suse.cz] > > Sent: Thursday, January 24, 2013 5:10 AM > > To: KY Srinivasan > > Cc: gre...@linuxfoundation.org; lin

Re: [PATCH 1/3] tools/hv: Fix /var subdirectory

2012-11-26 Thread gre...@linuxfoundation.org
On Mon, Nov 26, 2012 at 08:42:40PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Tomas Hozza [mailto:tho...@redhat.com] > > Sent: Monday, November 12, 2012 3:55 AM > > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; >

Re: [PATCH 1/3] tools/hv: Fix /var subdirectory

2012-11-15 Thread gre...@linuxfoundation.org
On Fri, Nov 09, 2012 at 03:56:14PM +, KY Srinivasan wrote: > > -Original Message- > > From: Tomas Hozza [mailto:tho...@redhat.com] KY, there have been a few of these tools/hv patches floating by, and you haven't acked all of them from what I can tell. I've applied some of them, but

Re: [PATCH v7 0/3] Add modules to support realtek PCIE card reader

2012-11-08 Thread gre...@linuxfoundation.org
On Thu, Nov 08, 2012 at 01:30:11PM +0800, wwang wrote: > 于 2012年11月08日 12:01, Alex Dubov 写道: > >Hi, > >>Do you have any comment on the MEMSTICK part in this v7 patchset? Can > >>you help to merge the patch to the kernel tree? > > > >I'm afraid that presently I don't have much time to look at the me

Re: [PATCH 00/24] staging: comedi: addi-data: fix the do/di subdevices

2012-11-05 Thread gre...@linuxfoundation.org
On Mon, Nov 05, 2012 at 07:06:57PM -0600, H Hartley Sweeten wrote: > On Monday, November 05, 2012 5:50 PM, H Hartley Sweeten wrote: > > > > The addi-data drivers abuse the comedi API and try to make it conform to > > the API that addi-data uses for there own private drivers. > > > > Fix the digital

Re: [Q] comedi 8255 based PCI boards

2012-09-11 Thread Greg Kroah-Hartman (gre...@linuxfoundation.org)
On Tue, Sep 11, 2012 at 07:17:10PM -0500, H Hartley Sweeten wrote: > There are a couple comedi drivers for 8255 based I/O boards. They > are all virtually identical: > > adl_pci7296.c supports 3 ADLink board types > cb_pcidio.c supports 3 ComputerBoards (MeasurementComputing) board types > ni_pc

Re: realtek card reader core driver

2012-07-25 Thread gre...@linuxfoundation.org
On Thu, Jul 26, 2012 at 11:11:50AM +0800, wwang wrote: > Hi Dan: > > Sorry to bother you. > I can't find the maintainer of drivers/misc. So if I want to submit my > driver as misc device, who should I contact to send my patch? >From the MAINTAINERS file: CHAR and MISC DRIVERS M: Arnd Bergma

Re: [PATCH 15/90] staging: comedi: adv_pci1723: move comedi_pci_enable() into the attach

2012-07-20 Thread gre...@linuxfoundation.org
On Fri, Jul 20, 2012 at 11:33:27AM -0500, H Hartley Sweeten wrote: > I think there are a couple pci drivers that would still need the old "attach" > in order to load firmware using comedi_config. We can address those > later and possibly figure out a more "standard" way to load the firmware. That

Re: [PATCH 15/90] staging: comedi: adv_pci1723: move comedi_pci_enable() into the attach

2012-07-19 Thread gre...@linuxfoundation.org
On Thu, Jul 19, 2012 at 06:58:38PM -0500, H Hartley Sweeten wrote: > On Thursday, July 19, 2012 4:35 PM, gregkh wrote: > > On Thu, Jul 19, 2012 at 06:31:23PM -0500, H Hartley Sweeten wrote: > >> If the comedi pci drivers have the "attach_pci" callback defined, the > >> PCI api does correctly probe

Re: [PATCH 15/90] staging: comedi: adv_pci1723: move comedi_pci_enable() into the attach

2012-07-19 Thread gre...@linuxfoundation.org
On Thu, Jul 19, 2012 at 06:31:23PM -0500, H Hartley Sweeten wrote: > On Thursday, July 19, 2012 4:17 PM, gregkh wrote: > > On Thu, Jul 19, 2012 at 12:12:02PM -0500, H Hartley Sweeten wrote: > >> I was planning on making a comedi_find_pci_dev() function that the > >> drivers could call with a "match

Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)

2012-07-19 Thread Greg KH (gre...@linuxfoundation.org)
On Thu, Jul 19, 2012 at 10:30:38PM +, KY Srinivasan wrote: > > > As you know, this ID has been in use for a long time now. While the > > > hypervisor > > > does not interpret the guest ID that is registered, I am not sure what > > dependencies > > > there might be on this value. > > > > Could

Re: [PATCH 15/90] staging: comedi: adv_pci1723: move comedi_pci_enable() into the attach

2012-07-19 Thread gre...@linuxfoundation.org
On Thu, Jul 19, 2012 at 12:12:02PM -0500, H Hartley Sweeten wrote: > On Thursday, July 19, 2012 2:38 AM, Ian Abbott wrote: > > On 2012-07-19 02:30, H Hartley Sweeten wrote: > >> Use pci_is_enabled() in the "find pci device" function to determine if > >> the found pci device is not in use and move t

Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)

2012-07-19 Thread Greg KH (gre...@linuxfoundation.org)
On Thu, Jul 19, 2012 at 09:22:53PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Greg KH (gre...@linuxfoundation.org) > > [mailto:gre...@linuxfoundation.org] > > Sent: Thursday, July 19, 2012 5:07 PM > > To: KY Sri

Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)

2012-07-19 Thread Greg KH (gre...@linuxfoundation.org)
On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > > Bonzini > > Sent: Friday, July 13, 2012 6:23 AM > > To: KY Srinivasan > > Cc: Greg KH; devel@linuxdriverproject.org; li

Re: comedi exports

2012-07-03 Thread Greg Kroah-Hartman (gre...@linuxfoundation.org)
On Tue, Jul 03, 2012 at 01:02:11PM -0500, H Hartley Sweeten wrote: > On Tuesday, July 03, 2012 10:59 AM, Greg Kroah-Hartman wrote: > > On Tue, Jul 03, 2012 at 12:53:38PM -0500, H Hartley Sweeten wrote: > >> All the comedi files appear to be GPL. Shouldn't the exports all be > >> changed to EXPORT_S

Re: comedi exports

2012-07-03 Thread Greg Kroah-Hartman (gre...@linuxfoundation.org)
On Tue, Jul 03, 2012 at 12:53:38PM -0500, H Hartley Sweeten wrote: > All the comedi files appear to be GPL. Shouldn't the exports all be > changed to EXPORT_SYMBOL_GPL? As the original comedi symbols were exported in this manner, I kept these as-is, and I would probably recommend doing the same un

Re: [PATCH] bcb: Android bootloader control block driver

2012-06-29 Thread gre...@linuxfoundation.org
On Fri, Jun 29, 2012 at 09:56:36PM +, Boie, Andrew P wrote: > > From: NeilBrown [mailto:ne...@suse.de] > > Sent: Friday, June 29, 2012 2:25 PM > > > > On Fri, 29 Jun 2012 12:36:30 -0700 Andrew Boie > > wrote: > > > > > Android userspace tells the kernel that it wants to boot into recovery >

Re: [PATCH 00/36] staging: comedi: cb_pcidas: cleanup the driver

2012-06-27 Thread gre...@linuxfoundation.org
On Wed, Jun 27, 2012 at 06:02:34PM +0100, Ian Abbott wrote: > On 2012-06-27 17:45, H Hartley Sweeten wrote: > >On Wednesday, June 27, 2012 9:31 AM, Stephen Clark wrote: > >>I there some reason you can't post these as response to this message, > >>like GKH does, so if readers aren't > >>interested t

Re: [PATCH 19/33] staging: comedi: cb_das16_cs: cleanup dio subdevice initialization

2012-06-25 Thread gre...@linuxfoundation.org
On Mon, Jun 25, 2012 at 07:09:39PM -0500, H Hartley Sweeten wrote: > On Monday, June 25, 2012 5:00 PM, H Hartley Sweeten wrote: > > The digital i/o subdevice is always initialized due to the 'if (1)'. > > Simplify the attach by removing the test. > > > > Signed-off-by: H Hartley Sweeten > > Cc: Ia

Re: [PATCH] staging: comedi: remove private header comedi_pci.h

2012-06-04 Thread gre...@linuxfoundation.org
On Tue, May 22, 2012 at 11:06:24AM +0100, Ian Abbott wrote: > On 2012-05-22 01:12, H Hartley Sweeten wrote: > >Remove the private header, comedi_pci.h, by moving the two > >helper functions into divers.c and providing the prototypes > >in comedidev.h. > > > >This allows the comedi_pci_enable/disabl

Re: [PATCH] staging: comedi: ii_pci20kc: iobase and ioaddr are void __iomem *

2012-06-04 Thread gre...@linuxfoundation.org
On Tue, May 22, 2012 at 11:15:12AM +0100, Ian Abbott wrote: > On 2012-05-22 09:11, Dan Carpenter wrote: > >On Mon, May 21, 2012 at 06:10:07PM -0700, H Hartley Sweeten wrote: > >>@@ -210,7 +210,7 @@ static int pci20xxx_attach(struct comedi_device *dev, > >>if (ret< 0) > >>return ret

Re: [PATCH] staging: comedi: adl_pci7296: factor out the PCI device code

2012-05-23 Thread gre...@linuxfoundation.org
On Thu, May 24, 2012 at 01:07:02AM +0300, Dan Carpenter wrote: > On Wed, May 23, 2012 at 04:52:47PM -0500, H Hartley Sweeten wrote: > > On Wednesday, May 23, 2012 2:44 PM, Dan Carpenter wrote: > > > Hartley, you're doing a great job with all these patches, but it's > > > going to be weeks before th

Re: [PATCH 0000/0003] drivers: hv: util

2012-05-12 Thread gre...@linuxfoundation.org
On Sat, May 12, 2012 at 08:41:06PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: K. Y. Srinivasan [mailto:k...@microsoft.com] > > Sent: Saturday, May 12, 2012 4:44 PM > > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; &g

Re: [PATCH] staging: comedi: Add helper macro for comedi pci driver boilerplate

2012-05-11 Thread gre...@linuxfoundation.org
On Fri, May 11, 2012 at 01:26:37PM -0500, H Hartley Sweeten wrote: > On Friday, May 11, 2012 11:14 AM, Ian Abbott wrote: > > Okay, but I don't think it's worth doing three patches for each driver > > where one would do. Adding a one-line .name = "foo", to the single > > patch for each driver you

Re: [PATCH] staging: comedi: remove __user annotation inside of struct's

2012-05-09 Thread gre...@linuxfoundation.org
On Wed, May 09, 2012 at 11:41:26AM -0500, H Hartley Sweeten wrote: > On Wednesday, May 09, 2012 8:57 AM, gre...@linuxfoundation.org wrote: > > On Wed, May 09, 2012 at 10:52:34AM -0500, H Hartley Sweeten wrote: > >> Based on the discussion I assume this patch is ok then. Do y

Re: [PATCH] staging: comedi: remove __user annotation inside of struct's

2012-05-09 Thread gre...@linuxfoundation.org
On Wed, May 09, 2012 at 10:52:34AM -0500, H Hartley Sweeten wrote: > On Wednesday, May 09, 2012 7:25 AM, gre...@linuxfoundation.org wrote: > > On Wed, May 09, 2012 at 11:20:07AM +0100, Ian Abbott wrote: > >> On 2012-05-09 00:55, H Hartley Sweeten wrote: > >>> On Tu

Re: [PATCH] staging: comedi: remove __user annotation inside of struct's

2012-05-09 Thread gre...@linuxfoundation.org
On Wed, May 09, 2012 at 11:20:07AM +0100, Ian Abbott wrote: > On 2012-05-09 00:55, H Hartley Sweeten wrote: > >On Tuesday, May 08, 2012 4:41 PM, H Hartley Sweeten wrote: > >> > >>The structs' comedi_insn, coomedi_insnlist, comedi_cmd, > >>comedi_chaninfo, and comedi_rangeinfo are all passed to > >>