Re: [PATCH v2] mfd:rtsx: Support RTS5249

2013-04-18 Thread wwang
于 2013年04月19日 06:50, Samuel Ortiz 写道: Hi Wei, On Thu, Apr 11, 2013 at 10:43:40AM +0800, wei_w...@realsil.com.cn wrote: From: Wei WANG Support new model: RTS5249 Could you please provide me with a more detailled changelog (What's so different with this model that the current driver does not s

Re: [PATCH] mfd:rtsx: Support RTS5249

2013-03-24 Thread wwang
于 2013年03月25日 14:00, Dan Carpenter 写道: On Mon, Mar 25, 2013 at 10:13:56AM +0800, wei_w...@realsil.com.cn wrote: +static int rts5249_optimize_phy(struct rtsx_pcr *pcr) +{ + int err; + + err = rtsx_pci_write_phy_register(pcr, 0x19, 0xFE46); + if (err < 0) + return e

Re: [PATCH v4 0/8] rtsx patchset for MFD and MMC tree

2013-01-22 Thread wwang
于 2013年01月23日 09:23, pclinux 写道: > 于 2013年01月23日 06:42, Samuel Ortiz 写道: >> On Tue, Jan 22, 2013 at 11:39:09AM +0800, wwang wrote: >>>>>> Wei WANG (8): >>>>>> MFD:rtsx: Fix typo in comment >>>>>> MFD:rtsx: Remove redundant cod

Re: [PATCH v4 0/8] rtsx patchset for MFD and MMC tree

2013-01-21 Thread wwang
于 2013年01月22日 11:31, Samuel Ortiz 写道: Hi Wei, On Wed, Jan 16, 2013 at 05:02:37PM +0800, wwang wrote: 于 2013年01月08日 17:57, 王炜 写道: From: Wei WANG v2: 1. Add commit message for patch 2 2. Move pci_set_dma_mask before the pci_enable_device(pcidev) call v3: 1. Add commit message for patch 3 2

Re: [PATCH v4 0/8] rtsx patchset for MFD and MMC tree

2013-01-16 Thread wwang
于 2013年01月08日 17:57, 王炜 写道: > From: Wei WANG > > v2: > 1. Add commit message for patch 2 > 2. Move pci_set_dma_mask before the pci_enable_device(pcidev) call > > v3: > 1. Add commit message for patch 3 > 2. Add patch 8: Use macro defines to replace some variables > > v4: > 1. Describe why patch 3

Re: [PATCH v3 3/8] MFD:rtsx: Declare that the DMA address limitationis32bit explicitly

2013-01-03 Thread wwang
于 2013年01月03日 20:25, Dan Carpenter 写道: > On Fri, Dec 28, 2012 at 10:41:28AM +0800, wei_w...@realsil.com.cn wrote: >> From: Wei WANG >> >> Realtek PCIe card reader only supports 32bit DMA >> > Is this a bugfix? If so what does the bug look like? > > regards, > dan carpenter > Hi Dan: No, this is

Re: [PATCH v2 1/2] mmc/host/rtsx: Configure SD_CFG2 register in sd_rw_multi

2012-11-19 Thread wwang
于 2012年11月20日 10:21, Chris Ball 写道: Hi, Sorry to be pedantic, but: On Mon, Nov 19 2012, wei_w...@realsil.com.cn wrote: For Realtek card reader, internal regsiter SD_CFG2 should be configured before transferring data. In the prior version, the value of this register has been calculated, but for

Re: [PATCH v7 0/3] Add modules to support realtek PCIE card reader

2012-11-09 Thread wwang
于 11/08/2012 03:41 AM, Chris Ball 写道: Hi, On Mon, Oct 29 2012, wwang wrote: I'm happy with the MMC portion. I think we're mainly waiting for the MFD patch -- Samuel, do you have any remaining review comments that need to be fixed? Thanks, - Chris. Hi Chris: I have noticed tha

Re: [PATCH v7 0/3] Add modules to support realtek PCIE card reader

2012-11-07 Thread wwang
于 2012年11月08日 12:01, Alex Dubov 写道: Hi, Do you have any comment on the MEMSTICK part in this v7 patchset? Can you help to merge the patch to the kernel tree? I'm afraid that presently I don't have much time to look at the memstick related stuff any further. Hopefully, somebody else can step i

Re: [PATCH v7 0/3] Add modules to support realtek PCIE card reader

2012-11-07 Thread wwang
于 2012年11月08日 03:41, Chris Ball 写道: On Mon, Oct 29 2012, wwang wrote: Hi Chris, Samuel and Alex: Can you help to review this patchset, please? I have asked Greg to remove rts_pstor from the staging tree. So this driver have to be merged into 3.8 kernel, or else Realtek'sPCI-E card reade

Re: [PATCH v7 0/3] Add modules to support realtek PCIE card reader

2012-10-29 Thread wwang
Hi Chris, Samuel and Alex: Can you help to review this patchset, please? I have asked Greg to remove rts_pstor from the staging tree. So this driver have to be merged into 3.8 kernel, or else Realtek'sPCI-E card reader can not be accessed easily. BR, Wei WANG ___

Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

2012-10-25 Thread wwang
于 2012年10月26日 10:45, Greg KH 写道: On Fri, Oct 26, 2012 at 09:10:45AM +0800, wwang wrote: 于 2012年10月26日 02:50, Greg KH 写道: On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote: On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote: We are still maintaining the SCSI driver for Realtek

Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

2012-10-25 Thread wwang
于 2012年10月26日 02:50, Greg KH 写道: > On Sat, Oct 20, 2012 at 06:46:15AM +0300, Dan Carpenter wrote: >> On Sat, Oct 06, 2012 at 03:23:56PM +0800, wwang wrote: >>> We are still maintaining the SCSI driver for Realtek card reader, >>> and will release the latest source code

Re: [PATCH v6 1/3] drivers/mfd: Add realtek pcie card reader driver

2012-10-06 Thread wwang
于 2012年10月01日 06:49, Samuel Ortiz 写道: > Hi Wei, > > On Tue, Sep 11, 2012 at 12:54:22PM +0800, wei_w...@realsil.com.cn wrote: > Although pretty big, the patch looks mostly good to me. > I only have a few comments: > >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >> index d1facef..4c07a34

Re: [PATCH v6 0/3] Add modules to support realtek PCIE card reader

2012-10-06 Thread wwang
于 2012年09月29日 23:29, Borislav Petkov 写道: On Sat, Sep 29, 2012 at 09:41:17AM -0400, Chris Ball wrote: On Sat, Sep 29 2012, Borislav Petkov wrote: So, I think that this driver has seen a bunch of testing and reviewing and we might start considering upstreaming it. There are a bunch of laptops int

Re: [PATCH v5 0/3] Add modules to support realtek PCIE card reader

2012-09-10 Thread wwang
it;a=tag;h=refs/tags/v3.6-rc5 BR, wwang ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [PATCH v4 0/2] Add modules to support realtek PCIE card reader

2012-08-24 Thread wwang
于 2012年08月24日 17:36, 王炜 写道: > From: Wei WANG > > Support for Realtek PCI-Express driver-based card readers including rts5209 > and rts5229. > > Oh, bad mail thread. I will resend them all. Please ignore these mails. Sorry for that. ___ devel mailing li

Re: [PATCH 1/2] drivers/mfd: Add realtek pcie card reader driver

2012-08-14 Thread wwang
t; Arnd Hi Arnd: OK. I will resend both of the patches according to your suggestion. Thank you so much! BR, wwang ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [PATCH 1/2] drivers/mfd: Add realtek pcie card reader driver

2012-08-13 Thread wwang
于 2012年08月13日 14:40, Dan Carpenter 写道: > Looks like bitwise OR was intended here. Hi Dan: Thank you. I will resend the patches. BR, wwang ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-02 Thread wwang
/ \ \/ / \_ \ /___/ \rtsx-slot-bus/ And I plan to push sdmmc-pci and sdmmc-usb to drivers/mmc/host, push memstick-pci and memstick-usb to driv

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-31 Thread wwang
; +schedule_timeout(msecs_to_jiffies(msecs)); \ >> +} while (0) >> + >> +#define wait_timeout(msecs) wait_timeout_x(TASK_INTERRUPTIBLE, (msecs)) > This is the same as msleep_interruptible, right? Note that with interuptible > sleep, you should always check if you got interrupted and return -ERESTARTSYS > to user space. Thank you for your explanation. It seems that I should call msleep instead of msleep_interruptible. Best regards, wwang ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

realtek card reader core driver

2012-07-25 Thread wwang
Hi Dan: Sorry to bother you. I can't find the maintainer of drivers/misc. So if I want to submit my driver as misc device, who should I contact to send my patch? Thank you very much. I really appreciate this help. BR, wwang ___ devel mailing

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-25 Thread wwang
Hi Aaron: Thank you. I will modify our host per your suggestion. BR, wwang 于 2012年07月25日 18:16, Aaron Lu 写道: Hi Wei, We do not use MMC_CAP_MAX_CURRENT_* anymore, for your host, I would sugget you do something like this: static void realtek_init(struct realtek_sdmmc *host) { struct

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-24 Thread wwang
n and give me your kernel config? BR, wwang ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-23 Thread wwang
Hi Borislav: Realtek card reader supports not only SDMMC card, but also Memory stick. This part is the common code, so it is located in drivers/misc. There is also SDMMC-relevant code under CONFIG_MMC. And in the future, Memstick-relevant code will be added under CONFIG_MEMSTICK. BR, wwang

Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-22 Thread wwang
Hi Rusty: Thank you. I will fix it and resend all of the three patches BR, wwang 于 2012年07月20日 13:58, Rusty Russell 写道: > On Thu, 19 Jul 2012 17:55:10 +0800, wrote: >> From: Wei WANG >> >> Realtek PCI-E card reader driver adapts requests from upper-level >> sdmmc

Re: [PATCH 3/3] drivers/mmc/host: Add realtek sdmmc interface driver

2012-07-19 Thread wwang
Hi Oliver: I will fix it. Should I resend all three patches, or just this one? BR, Wei WANG 于 2012年07月19日 20:26, Oliver Neukum 写道: > On Thursday 19 July 2012 17:55:18 wei_w...@realsil.com.cn wrote: > >> +static void sd_normal_rw(struct realtek_sdmmc *host, struct mmc_request >> *mrq) >> +{ >> +

Re: work on rts5139

2012-05-13 Thread wwang
Hi Oleksij: We will modify the TODO file to manifest our next steps on Realtek card reader drivers. And as to your feature request, we will add it in our new driver stack. Many Thanks! wwang 于 2012年05月12日 21:58, Oleksij Rempel 写道: Hi wwang: I just noticed that your answer was not CCed to

Re: [PATCH] staging:rts_pstor:Fix SDIO issue

2011-10-09 Thread wwang
Dear Carpenter: I will resend the patch Best Regards, wwang 于 2011年10月09日 21:57, Dan Carpenter 写道: > What I'm saying is, it's confusing to add another variable which is > only subtly different from retval. Here is what it looks like after > we apply the patch. > >

Re: [PATCH] staging:rts_pstor:Fix SDIO issue

2011-10-09 Thread wwang
t_mmc(chip); 3172 if (retval == STATUS_SUCCESS) 3173 reset_pass = 1; 3174 } 3175 } else { 3176 reset_pass = 1; 3177 } Best regards, wwang ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [PATCH] staging:rts_pstor:modify thread synchronization flow

2011-08-03 Thread wwang
On 2011年08月03日 23:39, Greg KH wrote: > On Wed, Aug 03, 2011 at 04:00:25PM +0800, wei_w...@realsil.com.cn wrote: >> From: wwang >> >> Using different completion variables to synchronize different kernel threads >> >> Signed-off-by: wwang > Is this fixing a bug

Re: [PATCH] Fix a miswriting in ext_sd_send_cmd_get_rsp

2011-07-10 Thread wwang
On 2011年07月11日 10:13, 王炜 wrote: From: wwang cppcheck reported: [staging/rts_pstor/sd.c:3730] -> [staging/rts_pstor/sd.c:3726]: (style) Found duplicate if expressions. It's a miswriting, and the second if expression should be "(rsp_type == SD_RSP_TYPE_R0)" Signed-off-by: w

Re: [PATCH 2/2] staging: rts_pstor: set lun_mode in a differentplace

2011-03-15 Thread wwang
y now. So, I have to choose to set lun_mode detection code in a different place. Best regards, wwang ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [PATCH] staging: rts_pstor: MSXC card power class

2011-03-07 Thread wwang
于 2011年03月08日 02:50, Dan Carpenter 写道: > > This makes scripts/checkpatch.pl complain. > > regards, > dan carpenter > Yes, it would produce a braces warning. Should I send another patch to fix it, or just resend the patch? wwang ___

Re: [PATCH] staging: rts_pstor: fix sparse warning

2011-02-15 Thread wwang
Dear Greg: Do you mean that exactly one modification corresponds to one patch? Such as, if I add 2 static modifier and delete one function, I should send 3 patches? wwang 于 2011年02月16日 10:09, Greg KH 写道: > On Wed, Feb 16, 2011 at 09:43:38AM +0800, wei_w...@realsil.com.cn wrote: >> Fr