On 18/06/10 00:47, Joe Perches wrote:
> On Thu, 2010-06-17 at 16:28 -0700, Greg KH wrote:
>> On Thu, Jun 17, 2010 at 04:15:58PM -0700, Joe Perches wrote:
>>> On Thu, 2010-06-17 at 15:51 -0700, Greg KH wrote:
On Sat, Jun 12, 2010 at 10:30:50PM -0700, Joe Perches wrote:
> On Sat, 2010-06-12
On Thu, 2010-06-17 at 16:28 -0700, Greg KH wrote:
> On Thu, Jun 17, 2010 at 04:15:58PM -0700, Joe Perches wrote:
> > On Thu, 2010-06-17 at 15:51 -0700, Greg KH wrote:
> > > On Sat, Jun 12, 2010 at 10:30:50PM -0700, Joe Perches wrote:
> > > > On Sat, 2010-06-12 at 22:07 -0700, Joe Perches wrote:
> >
On Thu, Jun 17, 2010 at 04:15:58PM -0700, Joe Perches wrote:
> On Thu, 2010-06-17 at 15:51 -0700, Greg KH wrote:
> > On Sat, Jun 12, 2010 at 10:30:50PM -0700, Joe Perches wrote:
> > > On Sat, 2010-06-12 at 22:07 -0700, Joe Perches wrote:
> > > > 2: Create some comedi logging functions or macros lik
On Thu, 2010-06-17 at 15:51 -0700, Greg KH wrote:
> On Sat, Jun 12, 2010 at 10:30:50PM -0700, Joe Perches wrote:
> > On Sat, 2010-06-12 at 22:07 -0700, Joe Perches wrote:
> > > 2: Create some comedi logging functions or macros like:
> > > comedi_(fmt, arg...) (ie: comedi_info, comedi_err,
On Mon, Jun 14, 2010 at 09:34:15AM +0300, Henri Häkkinen wrote:
> Cleaned up and fixed coding convention issues as reporteed by
> checkpatch.pl tool on the file `drivers.c'. Added logging macros
> to `comedidev.h'. Replaced "BUG:" printk functions calls with
> BUG_ON macro.
>
> Signed-off-by: Hen
On Sat, Jun 12, 2010 at 10:30:50PM -0700, Joe Perches wrote:
> On Sat, 2010-06-12 at 22:07 -0700, Joe Perches wrote:
> > 2: Create some comedi logging functions or macros like:
> > comedi_(fmt, arg...) (ie: comedi_info, comedi_err, etc)
> >where "comedi:" is always prefixed and an
> >op
Cleaned up and fixed coding convention issues as reporteed by
checkpatch.pl tool on the file `drivers.c'. Added logging macros
to `comedidev.h'. Replaced "BUG:" printk functions calls with
BUG_ON macro.
Signed-off-by: Henri Häkkinen
---
drivers/staging/comedi/comedidev.h | 54 +++-
On Sun, 2010-06-13 at 14:27 +0300, Henri Häkkinen wrote:
> There are several printk statements without the "comedi:" prefix.
> Do you think it is better to leave these as they are, or should they
> be changed to use comedi_xxx macros (which will print the "comedi:"
> prefix)?
>
> printk(KERN_WARNI
Cleaned up and fixed coding convention issues as reporteed by
checkpatch.pl tool on the file `drivers.c'. Added logging macros
to `comedidev.h'.
Signed-off-by: Henri Häkkinen
---
drivers/staging/comedi/comedidev.h | 54 -
drivers/staging/comedi/drivers.c | 89 ++
Hello
There are several printk statements without the "comedi:" prefix. Such as:
printk(KERN_WARNING "BUG: dev->driver=NULL in comedi_device_detach()\n");
Do you think it is better to leave these as they are, or should they be changed
to use comedi_xxx macros (which will print the "comedi:" pre
On Sat, 2010-06-12 at 22:07 -0700, Joe Perches wrote:
> 2: Create some comedi logging functions or macros like:
> comedi_(fmt, arg...) (ie: comedi_info, comedi_err, etc)
>where "comedi:" is always prefixed and an
>optional #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>could be used
On Sun, 2010-06-13 at 10:14 +0800, Mark Rankilor wrote:
> 2010/6/12 Henri Häkkinen :
> > - printk
> > - (KERN_INFO "comedi: failed to increment module
> > count, skipping\n");
> > + printk(KERN_INFO "comedi: failed to increment
2010/6/12 Henri Häkkinen :
> - printk
> - (KERN_INFO "comedi: failed to increment module
> count, skipping\n");
> + printk(KERN_INFO "comedi: failed to increment module "
> + "count, skipping\n");
H
Cleaned up and fixed coding convention issues as reporteed by
checkpatch.pl tool on the file `drivers.c'.
Signed-off-by: Henri Häkkinen
---
drivers/staging/comedi/drivers.c | 85 +++--
1 files changed, 44 insertions(+), 41 deletions(-)
diff --git a/drivers/stag
14 matches
Mail list logo
