Re: [PATCH 3/8] Staging: bcm: Remove typedef for _stLocalSFAddIndication and call directly.

2012-09-24 Thread Dan Carpenter
On Sun, Sep 23, 2012 at 11:07:12PM -0400, Kevin McKinney wrote: - pstAddIndication = kmalloc(sizeof(*pstAddIndication), GFP_KERNEL); + pstAddIndication = kmalloc(sizeof(struct bcm_add_indication), GFP_KERNEL); Don't resend, but the style was still better in the original. regards, dan

Re: [PATCH 3/8] Staging: bcm: Remove typedef for _stLocalSFAddIndication and call directly.

2012-09-24 Thread Kevin McKinney
On Mon, Sep 24, 2012 at 6:57 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sun, Sep 23, 2012 at 11:07:12PM -0400, Kevin McKinney wrote: - pstAddIndication = kmalloc(sizeof(*pstAddIndication), GFP_KERNEL); + pstAddIndication = kmalloc(sizeof(struct bcm_add_indication),

Re: [PATCH 3/8] Staging: bcm: Remove typedef for _stLocalSFAddIndication and call directly.

2012-09-24 Thread Dan Carpenter
On Mon, Sep 24, 2012 at 09:46:05AM -0400, Kevin McKinney wrote: On Mon, Sep 24, 2012 at 6:57 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sun, Sep 23, 2012 at 11:07:12PM -0400, Kevin McKinney wrote: - pstAddIndication = kmalloc(sizeof(*pstAddIndication), GFP_KERNEL); +

Re: [PATCH 3/8] Staging: bcm: Remove typedef for _stLocalSFAddIndication and call directly.

2012-09-24 Thread Kevin McKinney
On Mon, Sep 24, 2012 at 10:16 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Mon, Sep 24, 2012 at 09:46:05AM -0400, Kevin McKinney wrote: On Mon, Sep 24, 2012 at 6:57 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sun, Sep 23, 2012 at 11:07:12PM -0400, Kevin McKinney wrote: -

[PATCH 3/8] Staging: bcm: Remove typedef for _stLocalSFAddIndication and call directly.

2012-09-23 Thread Kevin McKinney
This patch removes typedef for _stLocalSFAddIndication, and changes the name of the struct to bcm_add_indication. In addition, any calls to typedefs stLocalSFAddIndication, *pstLocalSFAddIndication, stLocalSFChangeRequest, *pstLocalSFChangeRequest, stLocalSFChangeIndication, or

Re: [PATCH 3/8] Staging: bcm: Remove typedef for _stLocalSFAddIndication and call directly.

2012-09-22 Thread Dan Carpenter
On Sat, Sep 22, 2012 at 01:24:34AM -0400, Kevin McKinney wrote: diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index fd2780d..83c525c 100644 --- a/drivers/staging/bcm/CmHost.c +++ b/drivers/staging/bcm/CmHost.c @@ -1334,7 +1334,7 @@ static ULONG StoreSFParam(struct

Re: [PATCH 3/8] Staging: bcm: Remove typedef for _stLocalSFAddIndication and call directly.

2012-09-22 Thread Kevin McKinney
On Sat, Sep 22, 2012 at 7:01 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, Sep 22, 2012 at 01:24:34AM -0400, Kevin McKinney wrote: diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c index fd2780d..83c525c 100644 --- a/drivers/staging/bcm/CmHost.c +++

[PATCH 3/8] Staging: bcm: Remove typedef for _stLocalSFAddIndication and call directly.

2012-09-21 Thread Kevin McKinney
This patch removes typedef for _stLocalSFAddIndication, and changes the name of the struct to bcm_add_indication. In addition, any calls to typedefs stLocalSFAddIndication, *pstLocalSFAddIndication, stLocalSFChangeRequest, *pstLocalSFChangeRequest, stLocalSFChangeIndication, or