[389-devel] Revised: please review replication code cleanup

2012-03-08 Thread Mark Reynolds
I still missed some tabs, revised patch attached On 03/08/2012 04:28 PM, Mark Reynolds wrote: While working on ticket 271, I found that the code was almost unreadable in repl5_inc_run(). The tabs and spacing were all over the place. So wanted to get this code cleanup checked in before I

[389-devel] please review additional change to ticket 302 - use thread local storage for modifiersname/creatorsname

2012-03-06 Thread Mark Reynolds
Config needs to ignore the new attributes... https://fedorahosted.org/389/ticket/302 https://fedorahosted.org/389/attachment/ticket/302/0001-Config-changes-fail-because-of-unknown-attribute-int.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] please review ticket #191 - Implement SO_KEEPALIVE on network calls

2012-03-05 Thread Mark Reynolds
https://fedorahosted.org/389/ticket/191 https://fedorahosted.org/389/attachment/ticket/191/0001-Ticket-191-Implement-SO_KEEPALIVE-in-network-calls.patch Thanks, Mark -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] please review ticket #305 - Certain CMP operations hang or cause ns-slapd to crash

2012-03-02 Thread Mark Reynolds
https://fedorahosted.org/389/ticket/305 https://fedorahosted.org/389/attachment/ticket/305/0001-Ticket-305-Certain-CMP-operations-hang-or-cause-ns-s.patch Thanks, Mark -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Revised: please review ticket #305 - Certain CMP operations hang or cause ns-slapd to crash

2012-03-02 Thread Mark Reynolds
https://fedorahosted.org/389/ticket/305 https://fedorahosted.org/389/attachment/ticket/305/0001-Ticket-305-Certain-CMP-operations-hang-or-cause-ns-s.patch Thanks, Mark -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel --

[389-devel] New Transformation Plugin proposal

2012-03-02 Thread Mark Reynolds
Hi Everyone, I figured I'd send this out since we are looking to possibly add proxy functionality to DS down the road. This came about because someone asked if there was a way to convert gmt timestamps to local time. Things like passwordexpiretime, modifierstimestamp, etc. A postop plugin

[389-devel] please review ticket #291 - cannot use in sasl search filter mappings

2012-02-29 Thread Mark Reynolds
https://fedorahosted.org/389/ticket/291 https://fedorahosted.org/389/attachment/ticket/291/0001-Ticket-291-cannot-use-in-a-sasl-map-search-filter.patch Thanks, Mark -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] please review ticket #74 - Create schema for DNA plugin - revised Makefile changes

2012-02-27 Thread Mark Reynolds
Revised the Makefile changes(didn't run autogen previously) Original Message Subject: [389-devel] please review ticket #74 - Create schema for DNA plugin Date: Sat, 25 Feb 2012 16:05:57 -0500 From: Mark Reynolds marey...@redhat.com Reply-To: 389 Directory server

[389-devel] please review ticket #74 - Create schema for DNA plugin

2012-02-25 Thread Mark Reynolds
https://fedorahosted.org/389/ticket/74 https://fedorahosted.org/389/attachment/ticket/74/0001-Ticket-74-Add-schema-for-DNA-plugin-RFE.patch Thanks, Mark -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Revised: please review ticket #211 - dnaNextValue gets incremented even if the user addition fails

2012-02-24 Thread Mark Reynolds
Revised: https://fedorahosted.org/389/attachment/ticket/211/0001-Ticket-211-dnaNextValue-gets-incremented-even-if-the.2.patch https://fedorahosted.org/389/attachment/ticket/211/ On 02/23/2012 02:35 PM, Mark Reynolds wrote: Original Message Subject: [389-devel] please

[389-devel] Revision #2: please review ticket #211 - dnaNextValue gets incremented even if the user addition fails

2012-02-24 Thread Mark Reynolds
Another revision https://fedorahosted.org/389/attachment/ticket/211/0001-Ticket-211-dnaNextValue-gets-incremented-even-if-the.patch https://fedorahosted.org/389/attachment/ticket/211/ On 02/24/2012 12:31 PM, Mark Reynolds wrote: Revised: https://fedorahosted.org/389/attachment/ticket/211

[389-devel] resent: please review ticket #211 - dnaNextValue gets incremented even if the user addition fails

2012-02-23 Thread Mark Reynolds
Original Message Subject: [389-devel] please review ticket #211 - dnaNextValue gets incremented even if the user addition fails Date: Wed, 22 Feb 2012 11:32:52 -0500 From: Mark Reynolds marey...@redhat.com Reply-To: 389 Directory server developer discussion. 389-de

[389-devel] please review ticket #211 - dnaNextValue gets incremented even if the user addition fails

2012-02-22 Thread Mark Reynolds
https://fedorahosted.org/389/attachment/ticket/211/ https://fedorahosted.org/389/attachment/ticket/211/0001-Ticket-211-dnaNextValue-gets-incremented-even-if-the.patch -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: coverity 12559 Uninitialized pointer read

2012-02-22 Thread Mark Reynolds
ack On 02/22/2012 11:21 AM, Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: coverity uninit var and resource leak

2012-02-16 Thread Mark Reynolds
ack On 02/16/2012 10:23 AM, Rich Megginson wrote: -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] please review ticket #111 - ability to control behavior of modifyTimestamp/modifiersNa

2012-02-15 Thread Mark Reynolds
Revised fix based on Rich's comments https://fedorahosted.org/389/ticket/111 https://fedorahosted.org/389/attachment/ticket/111/0001-Ticket-111-ability-to-control-behavior-of-modifyTime.patch Thanks, Mark -- 389-devel mailing list 389-de...@lists.fedoraproject.org

[389-devel] please review ticket #17 - Replication optimizations around adds and modifies

2012-02-07 Thread Mark Reynolds
https://fedorahosted.org/389/ticket/17 https://fedorahosted.org/389/attachment/ticket/17/0001-Ticket-17-Replication-optimizations.patch Thanks, Mark -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] New Support Tool: dseconv.pl (dse.ldif file parser)

2012-02-07 Thread Mark Reynolds
and if they are not found in the templates just failover to the hardcoded values? It will save some time on the script maintenance when the default values are changed and/or added in the templates. @+ 2012/2/6 Mark Reynolds marey...@redhat.com mailto:marey...@redhat.com Hi All

[389-devel] please review ticket#17 - additional optimizations for replicated ops

2012-02-07 Thread Mark Reynolds
https://fedorahosted.org/389/attachment/ticket/17 https://fedorahosted.org/389/attachment/ticket/17/0001-Ticket-17-replication-optimizations.patch Found a few more minor optimizations. Thanks, Mark -- 389-devel mailing list 389-de...@lists.fedoraproject.org

[389-devel] please review ticket#17 - additional optimizations for replicated ops - updated link

2012-02-07 Thread Mark Reynolds
Sorry had the wrong link to the patch https://fedorahosted.org/389/attachment/ticket/17/0001-Ticket-17-new-replication-optimizations.patch On 02/07/2012 03:05 PM, Mark Reynolds wrote: https://fedorahosted.org/389/attachment/ticket/17 https://fedorahosted.org/389/attachment/ticket/17/0001

[389-devel] please review ticket #129 - Should only update modifyTimestamp/modifiersName on MODIFY ops

2012-02-07 Thread Mark Reynolds
https://fedorahosted.org/389/attachment/ticket/129 https://fedorahosted.org/389/attachment/ticket/129/0001-Ticket-129-Should-only-update-modifyTimestamp-modifi.patch This issue was previously fixed, I just expanded the fix a little. Thanks, Mark -- 389-devel mailing list

Re: [389-devel] please review ticket #129 - Should only update modifyTimestamp/modifiersName on MODIFY ops

2012-02-07 Thread Mark Reynolds
if the the first two emails will actually go through. - Original Message - From: Mark Reynolds marey...@redhat.com To: 389 Directory server developer discussion. 389-de...@lists.fedoraproject.org Sent: Tuesday, February 7, 2012 4:23:52 PM Subject: [389-devel] please review ticket #129

Re: [389-devel] please review ticket #129 - Should only update modifyTimestamp/modifiersName on MODIFY ops

2012-02-07 Thread Mark Reynolds
I had a typo in part of the fix, but... After looking at ticket #111, I think maybe we should add this flag to memberOf, referint, and maybe some other plugins. Any thoughts on this? Thanks, Mark PS - having email issues again, so this is a duplicate On 02/07/2012 04:28 PM, Mark Reynolds

Re: [389-devel] please review ticket #129 - Should only update modifyTimestamp/modifiersName on MODIFY ops

2012-02-07 Thread Mark Reynolds
Actually after looking at ticket #111, I think maybe we should add this flag to memberOf, referint, and maybe some other plugins. Any thoughts on this? Thanks, Mark On 02/07/2012 04:23 PM, Mark Reynolds wrote: https://fedorahosted.org/389/attachment/ticket/129 https://fedorahosted.org/389

[389-devel] please review ticket #175 - logconv.pl improvements (2)

2012-02-06 Thread Mark Reynolds
https://fedorahosted.org/389/attachment/ticket/175 https://fedorahosted.org/389/attachment/ticket/175/0001-Ticket-175-logconv.pl-improvements.patch There might be another duplicate email coming through. Having mail server issues(again)... Thanks, Mark -- 389-devel mailing list

[389-devel] please review ticket #175 - logconv.pl improvements

2012-02-06 Thread Mark Reynolds
https://fedorahosted.org/389/attachment/ticket/175 https://fedorahosted.org/389/attachment/ticket/175/0001-Ticket-175-logconv.pl-improvements.patch Thanks, Mark -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] New Support Tool: dseconv.pl (dse.ldif file parser)

2012-02-06 Thread Mark Reynolds
Hi All, This was a side project of mine for some time, and I just ported it to DS 389. It basically parses the dse.ldif into a readable format. It groups all the backend info together. So each backend lists its own indexes, config, replication info, etc. It checks for non default config

[389-devel] please review ticket 55 - Limit of 1024 chars in nsMatchingRule

2012-02-01 Thread Mark Reynolds
https://fedorahosted.org/389/attachment/ticket/55 https://fedorahosted.org/389/attachment/ticket/55/0001-Ticket-55-Limit-of-1024-characters-for-nsMatchingRul.patch -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: fix a couple of minor coverity issues

2012-02-01 Thread Mark Reynolds
On 02/01/2012 01:56 PM, Rich Megginson wrote: -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel ack -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] PAM plugin vs post op processing. New return code proposal...

2012-02-01 Thread Mark Reynolds
On 02/01/2012 04:28 PM, Rich Megginson wrote: On 02/01/2012 02:16 PM, Mark Reynolds wrote: Hi Everyone, There is an issue with the PAM plugin, that when it performs a successful bind we actually return error 1 to plugins_call_func(), which essentially causes the abort of the all plugin

[389-devel] PAM plugin vs post op processing. New return code proposal...

2012-02-01 Thread Mark Reynolds
Hi Everyone, There is an issue with the PAM plugin, that when it performs a successful bind we actually return error 1 to plugins_call_func(), which essentially causes the abort of the all plugin processing: the rest of pre-op, the backend call, and all of post-op. PAM has completed the

[389-devel] please review ticket #39 - Account Policy doesn't work when authenticating through the PAM plugin

2012-02-01 Thread Mark Reynolds
https://fedorahosted.org/389/attachment/ticket/39 https://fedorahosted.org/389/attachment/ticket/39/0001-Ticket-39-Account-Policy-Plugin-does-not-work-for-si.patch Thanks, Mark -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] please review ticket #55 - limit of 1024 chars in nsMatchingRule

2012-01-31 Thread Mark Reynolds
This fix is now correctly tested. https://fedorahosted.org/389/attachment/ticket/55 https://fedorahosted.org/389/attachment/ticket/55/0001-Ticket-55-Limit-of-1024-characters-for-nsMatchingRul.patch Thanks, Mark -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] please review ticket 38 - nisDomain schema is incorrect

2012-01-31 Thread Mark Reynolds
https://fedorahosted.org/389/attachment/ticket/38 https://fedorahosted.org/389/attachment/ticket/38/0001-Ticket-38-nisDomain-schema-is-incorrect.patch Thanks, Mark -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] please review revision to ticket 6 - protocol error with proxied authentication

2012-01-31 Thread Mark Reynolds
https://fedorahosted.org/389/attachment/ticket/6 https://fedorahosted.org/389/attachment/ticket/6/0001-Ticket-6-protocol-error-when-doing-a-proxied-auth.patch Thanks, Mark -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review fix for ticket#71 - unable to delete managed entry config

2012-01-13 Thread Mark Reynolds
https://fedorahosted.org/389/ticket/71 https://fedorahosted.org/389/attachment/ticket/71/0001-Ticket-71-Unable-to-delete-managed-entry-config.patch Thanks in advance, Mark -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

<    5   6   7   8   9   10