Re: Packages still using %{?_smp_mflags} manually?

2020-05-28 Thread Richard Shaw
On Wed, May 27, 2020 at 10:01 AM Tom Stellard wrote: > On 05/27/2020 07:47 AM, Richard Shaw wrote: > > On Wed, May 27, 2020 at 9:44 AM Tom Stellard > wrote: > > > > > > Also, I used to use %make_build without the {}, but someone > suggested[1] I > > add the

Re: Packages still using %{?_smp_mflags} manually?

2020-05-27 Thread Tom Stellard
On 05/27/2020 07:47 AM, Richard Shaw wrote: > On Wed, May 27, 2020 at 9:44 AM Tom Stellard > wrote: > > > Also, I used to use %make_build without the {}, but someone suggested[1] I > add the {} in case the macro ever became a function. > > -Tom > >

Re: Packages still using %{?_smp_mflags} manually?

2020-05-27 Thread Richard Shaw
On Wed, May 27, 2020 at 9:44 AM Tom Stellard wrote: > > Also, I used to use %make_build without the {}, but someone suggested[1] I > add the {} in case the macro ever became a function. > > -Tom > > [1] > https://src.fedoraproject.org/rpms/perl-Digest-SHA/pull-request/1#comment-37158 Well the

Re: Packages still using %{?_smp_mflags} manually?

2020-05-27 Thread Tom Stellard
On 05/27/2020 05:19 AM, Richard Shaw wrote: > On Tue, May 26, 2020 at 10:12 PM Tom Stellard > wrote: > > On 05/21/2020 07:57 AM, Richard Shaw wrote: > > Not really a big deal but %build_make has been available for quite a > while. I noticed a few of my

Re: Packages still using %{?_smp_mflags} manually?

2020-05-27 Thread Richard Shaw
On Tue, May 26, 2020 at 10:12 PM Tom Stellard wrote: > On 05/21/2020 07:57 AM, Richard Shaw wrote: > > Not really a big deal but %build_make has been available for quite a > while. I noticed a few of my packages still supply _smp_mflags manually. > > > > Is this worth a script and automatic BZ?

Re: Packages still using %{?_smp_mflags} manually?

2020-05-27 Thread Björn 'besser82' Esser
Am Donnerstag, den 21.05.2020, 17:53 +0200 schrieb Igor Raits: > > In the spec file of another one that I've inherited, I see "make V=1 > > %{?_smp_mflags}". > > %make_build V=1 Not even neccessary since `V=1` already gets injected by the `%make_build` macro at least since F32: $ rpm -E

Re: Packages still using %{?_smp_mflags} manually?

2020-05-26 Thread Tom Stellard
On 05/21/2020 07:57 AM, Richard Shaw wrote: > Not really a big deal but %build_make has been available for quite a while. I > noticed a few of my packages still supply _smp_mflags manually. > > Is this worth a script and automatic BZ? Probably not, but I think there is > an intrinsic value to

Re: Packages still using %{?_smp_mflags} manually?

2020-05-21 Thread Alexander Ploumistos
Thanks Igor, I'll update both ASAP. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List

Re: Packages still using %{?_smp_mflags} manually?

2020-05-21 Thread Igor Raits
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Thu, 2020-05-21 at 17:41 +0200, Alexander Ploumistos wrote: > On Thu, May 21, 2020 at 5:01 PM Richard Shaw > wrote: > > Not really a big deal but %build_make has been available for quite > > a while. I noticed a few of my packages still supply

Re: Packages still using %{?_smp_mflags} manually?

2020-05-21 Thread Alexander Ploumistos
On Thu, May 21, 2020 at 5:01 PM Richard Shaw wrote: > > Not really a big deal but %build_make has been available for quite a while. I > noticed a few of my packages still supply _smp_mflags manually. Recently, one of my packages switched to meson and while searching through our documentation, I

Packages still using %{?_smp_mflags} manually?

2020-05-21 Thread Richard Shaw
Not really a big deal but %build_make has been available for quite a while. I noticed a few of my packages still supply _smp_mflags manually. Is this worth a script and automatic BZ? Probably not, but I think there is an intrinsic value to consistency. Thanks, Richard