Re: Packaging Guidelines - creating tarball from VCS with script

2012-05-23 Thread Tomas Radej
On Wed, 16 May 2012 10:10:17 -0600 Kevin Fenzi ke...@scrye.com wrote: On Tue, 15 May 2012 23:30:27 +0300 Otherwise this sounds like great stuff to talk to rpm upstream about. ;) Since the discussion is pretty much done here, I'll talk to RPM guys and see if they find this to be a good

Re: Packaging Guidelines - creating tarball from VCS with script

2012-05-16 Thread Kevin Fenzi
On Tue, 15 May 2012 23:30:27 +0300 Oron Peled o...@actcom.co.il wrote: ...snip... * A .spec file with the extra %vcs_prep and Vcs-URL can create SRPM directly from the vcs-repo. This SRPM can be uploaded to our build system and be used for building *without* any interaction with

Re: Packaging Guidelines - creating tarball from VCS with script

2012-05-15 Thread Tomas Radej
On Mon, 14 May 2012 16:31:08 +0200 Remi Collet fed...@famillecollet.com wrote: Le 14/05/2012 16:22, Toshio Kuratomi a écrit : What do you think? I personally prefer to have the checkout instructions in comments. +1 Except for some very complex scripts for which it make sense to

Re: Packaging Guidelines - creating tarball from VCS with script

2012-05-15 Thread Alec Leamas
On 05/15/2012 10:19 AM, Tomas Radej wrote: On Mon, 14 May 2012 16:31:08 +0200 Remi Colletfed...@famillecollet.com wrote: Le 14/05/2012 16:22, Toshio Kuratomi a écrit : What do you think? I personally prefer to have the checkout instructions in comments. +1 Except for some very complex

Re: Packaging Guidelines - creating tarball from VCS with script

2012-05-15 Thread Colin Walters
On Tue, 2012-05-15 at 10:19 +0200, Tomas Radej wrote: Discussion with pingou and sochotni on #fedora-java brought us this: What about using an RPM macro with this grammar: %create_tarball git|svn|cvs URL revision [additional commands] The build system has no network access. For the

Re: Packaging Guidelines - creating tarball from VCS with script

2012-05-15 Thread Oron Peled
On Tuesday, 15 בMay 2012 17:40:27 Colin Walters wrote: On Tue, 2012-05-15 at 10:19 +0200, Tomas Radej wrote: Discussion with pingou and sochotni on #fedora-java brought us this: What about using an RPM macro with this grammar: %create_tarball git|svn|cvs URL revision [additional

Packaging Guidelines - creating tarball from VCS with script

2012-05-14 Thread Tomas Radej
Hi, I was wondering if Packaging Guidelines could be amended so that even when creating tarball from VCS, using a standalone shell script would be mandatory (see http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control ). I believe this could allow easier reviews and package

Re: Packaging Guidelines - creating tarball from VCS with script

2012-05-14 Thread Emanuel Rietveld
On 05/14/2012 03:02 PM, Tomas Radej wrote: Hi, I was wondering if Packaging Guidelines could be amended so that even when creating tarball from VCS, using a standalone shell script would be mandatory (see http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control ). I believe

Re: Packaging Guidelines - creating tarball from VCS with script

2012-05-14 Thread Toshio Kuratomi
On Mon, May 14, 2012 at 03:02:23PM +0200, Tomas Radej wrote: Hi, I was wondering if Packaging Guidelines could be amended so that even when creating tarball from VCS, using a standalone shell script would be mandatory (see

Re: Packaging Guidelines - creating tarball from VCS with script

2012-05-14 Thread ニール・ゴンパ
I agree with Toshio on this. Depending on how the VCS behaves with checkout/cloning, it will be difficult to get predictable results in a usable way through a script. Commenting in the spec file is the best way to go in my opinion. On May 14, 2012 9:22 AM, Toshio Kuratomi a.bad...@gmail.com wrote:

Re: Packaging Guidelines - creating tarball from VCS with script

2012-05-14 Thread Remi Collet
Le 14/05/2012 16:22, Toshio Kuratomi a écrit : What do you think? I personally prefer to have the checkout instructions in comments. +1 Except for some very complex scripts for which it make sense to have a shell script. Remi. -- devel mailing list devel@lists.fedoraproject.org

Re: Packaging Guidelines - creating tarball from VCS with script

2012-05-14 Thread Ville Skyttä
On 2012-05-14 17:22, Toshio Kuratomi wrote: I personally prefer to have the checkout instructions in comments. The big drawback of that is that if they're just in comments, they're not a prerequisite for creating the shipped tarball, and they will bitrot sooner or later. Using macros in them

Re: Packaging Guidelines - creating tarball from VCS with script

2012-05-14 Thread Thomas Moschny
2012/5/14 Toshio Kuratomi a.bad...@gmail.com: Automating of the package's checksum won't work for many VCS's .  git, for instance, does not preserve timestamps.  So the tarball created from a git snapshot will have a different checksum for each checkout. While files' modification times in a

Re: Packaging Guidelines - creating tarball from VCS with script

2012-05-14 Thread Alec Leamas
On 05/14/2012 10:46 PM, Thomas Moschny wrote: 2012/5/14 Toshio Kuratomia.bad...@gmail.com: Automating of the package's checksum won't work for many VCS's . git, for instance, does not preserve timestamps. So the tarball created from a git snapshot will have a different checksum for each