Re: Please review use /$ in %files (Was: Re: Escaping macros in %changelog)

2018-02-12 Thread Michael Schwendt
On Thu, 8 Feb 2018 18:39:19 +0100, Petr Stodulka wrote: > > The following: > > %files > > /some/directory/ > > > > is equivalent to: > > %files > > %dir /some/directory > > /some/directory/* > > > > > > There's nothing wrong here. > > > > > > Exactly. IMHO, use of %dir macro for "top" pkg

Re: Please review use /$ in %files (Was: Re: Escaping macros in %changelog)

2018-02-12 Thread Michael Schwendt
On Thu, 8 Feb 2018 18:09:25 +, Tomasz Kłoczko wrote: > I'm sure that in the past it was difference here :| You are mistaken about that. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to

Re: Please review use /$ in %files (Was: Re: Escaping macros in %changelog)

2018-02-08 Thread Tomasz Kłoczko
On 8 February 2018 at 17:39, Petr Stodulka wrote: [..] > > There's nothing wrong here. > > > > > > Exactly. IMHO, use of %dir macro for "top" pkg directories is more clean > solution, but > doesn't matter in case the rpm is packaged correctly. > I'm sure that in the past it

Re: Please review use /$ in %files (Was: Re: Escaping macros in %changelog)

2018-02-08 Thread Igor Gnatenko
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Thu, 2018-02-08 at 16:56 +, Tomasz Kłoczko wrote: > BTW some massively occurring errors in really big number Fedora of specs. > > Looks like many people don't know that %files entry like: > > /some/directory/ > > does not include

Re: Please review use /$ in %files (Was: Re: Escaping macros in %changelog)

2018-02-08 Thread Petr Stodulka
On 8.2.2018 18:33, Neal Gompa wrote: > On Thu, Feb 8, 2018 at 11:56 AM, Tomasz Kłoczko > wrote: >> BTW some massively occurring errors in really big number Fedora of specs. >> >> Looks like many people don't know that %files entry like: >> >> /some/directory/ >> >>

Re: Please review use /$ in %files (Was: Re: Escaping macros in %changelog)

2018-02-08 Thread Neal Gompa
On Thu, Feb 8, 2018 at 11:56 AM, Tomasz Kłoczko wrote: > BTW some massively occurring errors in really big number Fedora of specs. > > Looks like many people don't know that %files entry like: > > /some/directory/ > > does not include /some/directory into package but all

Re: Please review use /$ in %files (Was: Re: Escaping macros in %changelog)

2018-02-08 Thread Jerry James
On Thu, Feb 8, 2018 at 9:56 AM, Tomasz Kłoczko wrote: > Looks like many people don't know that %files entry like: > > /some/directory/ > > does not include /some/directory into package but all files and > subdirectories which are in /some/directory. That is incorrect.

Please review use /$ in %files (Was: Re: Escaping macros in %changelog)

2018-02-08 Thread Tomasz Kłoczko
BTW some massively occurring errors in really big number Fedora of specs. Looks like many people don't know that %files entry like: /some/directory/ does not include /some/directory into package but all files and subdirectories which are in /some/directory. This is in how many specs such lines