On Mon, Apr 08, 2019 at 01:26:47PM +0200, Igor Gnatenko wrote:
> Ok, I have reverted change:
>
> * https://bodhi.fedoraproject.org/updates/FEDORA-2019-42ea21c6e4
> * https://bodhi.fedoraproject.org/updates/FEDORA-2019-660ccd306c
> *
On Tue, 9 Apr 2019 at 13:54, Igor Gnatenko
wrote:
> At this moment,
>
> * %meson doesn't pass -Db_ndebug at all, we use project-specific options
> * If project doesn't specify it, b_ndebug=false is default in meson
> * In case of mesa, it specifies b_ndebug=if-release which works correctly
> now
On Tue, Apr 9, 2019 at 7:54 AM, Kalev Lember
wrote:
Awesome, thanks Igor! All of this sounds good to me.
Yeah, sounds like everything is fine now after the if-release fix.
Thanks!
___
devel mailing list -- devel@lists.fedoraproject.org
To
Awesome, thanks Igor! All of this sounds good to me.
Kalev
On 4/9/19 14:47, Igor Gnatenko wrote:
At this moment,
* %meson doesn't pass -Db_ndebug at all, we use project-specific options
* If project doesn't specify it, b_ndebug=false is default in meson
* In case of mesa, it specifies
At this moment,
* %meson doesn't pass -Db_ndebug at all, we use project-specific options
* If project doesn't specify it, b_ndebug=false is default in meson
* In case of mesa, it specifies b_ndebug=if-release which works correctly
now with backported patch
On Mon, Apr 8, 2019 at 4:29 PM Kalev
On Mon, Apr 8, 2019 at 1:39 PM, Benjamin Tissoires
wrote:
That's not how I read it:
https://github.com/mesonbuild/meson/blob/master/docs/markdown/Builtin-options.md#base-options
-DB-ndebug defaults to false.
OK, then I was totally wrong, thanks.
Shame the docs are so hard to search
On Mon, Apr 8, 2019 at 3:17 PM wrote:
>
> On Mon, Apr 8, 2019 at 5:50 AM, Kalev Lember
> wrote:
> > I agree as well. Please don't override -Db_ndebug in distro-wide
> > %meson
> > macro and instead move the override to mesa packaging if it's needed
> > there.
>
> Well hold up. -Db_ndebug
On 4/8/19 15:16, mcatanz...@gnome.org wrote:
- Plain builds should match the behavior of release builds, and Fedora
plain builds should match the behavior of upstream plain builds. This is
what we briefly had but just reverted. (Option one)
I believe this is the case already in upstream
On Mon, Apr 8, 2019 at 5:50 AM, Kalev Lember
wrote:
I agree as well. Please don't override -Db_ndebug in distro-wide
%meson
macro and instead move the override to mesa packaging if it's needed
there.
Well hold up. -Db_ndebug defaults to if-release... right? We have only
changed the behavior
On Mon, Apr 08, 2019 at 12:50:06PM +0200, Kalev Lember wrote:
>
> On 4/8/19 11:13, Florian Weimer wrote:
> >* Peter Hutterer:
> >
> >>On Mon, Apr 08, 2019 at 09:20:35AM +0200, Igor Gnatenko wrote:
> >>>Hello,
> >>>
> >>>While fixing mesa build which was slow due to a lot off debug stuff
>
Ok, I have reverted change:
* https://bodhi.fedoraproject.org/updates/FEDORA-2019-42ea21c6e4
* https://bodhi.fedoraproject.org/updates/FEDORA-2019-660ccd306c
* https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2019-eb940f069c
*
On 4/8/19 11:13, Florian Weimer wrote:
* Peter Hutterer:
On Mon, Apr 08, 2019 at 09:20:35AM +0200, Igor Gnatenko wrote:
Hello,
While fixing mesa build which was slow due to a lot off debug stuff
(assert()), I've added -Db_ndebug=true into the %meson macro.
This seemed like good approach
* Peter Hutterer:
> On Mon, Apr 08, 2019 at 09:20:35AM +0200, Igor Gnatenko wrote:
>> Hello,
>>
>> While fixing mesa build which was slow due to a lot off debug stuff
>> (assert()), I've added -Db_ndebug=true into the %meson macro.
>>
>> This seemed like good approach because in Fedora we
On Mon, Apr 08, 2019 at 09:20:35AM +0200, Igor Gnatenko wrote:
> Hello,
>
> While fixing mesa build which was slow due to a lot off debug stuff
> (assert()), I've added -Db_ndebug=true into the %meson macro.
>
> This seemed like good approach because in Fedora we should not use debug
> bits in
14 matches
Mail list logo
