Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-06 Thread Dridi Boukelmoune
On Fri, Dec 4, 2020 at 7:23 AM Dridi Boukelmoune wrote: > > > > Maybe I need to reboot my system for vim to take over again? > > > > You will at least need to logout and log back in. > > You're right, if I force a login instead of plain sudo it becomes apparent: > > $ sudo env | grep EDITOR > $

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-04 Thread Kevin Kofler via devel
Ben Cotton wrote: > ...changes in default behavior, when 1. technically reasonable and 2. > not explicitly overridden by the user, should generally be made on > upgrade. I disagree. Upgrades should be as unsurprising as possible and keep user configuration as much as possible. Changes in

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-04 Thread Neal Gompa
On Fri, Dec 4, 2020 at 9:01 AM Simo Sorce wrote: > > On Thu, 2020-12-03 at 15:41 -0500, Ben Cotton wrote: > > On Thu, Dec 3, 2020 at 3:32 PM Tom Hughes via devel > > wrote: > > > What exactly does "change the default on upgrade" actually mean > > > here? Making nano-default-editor a dependency

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-04 Thread Simo Sorce
On Thu, 2020-12-03 at 15:41 -0500, Ben Cotton wrote: > On Thu, Dec 3, 2020 at 3:32 PM Tom Hughes via devel > wrote: > > What exactly does "change the default on upgrade" actually mean > > here? Making nano-default-editor a dependency of something else > > that people are likely to have installed?

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-04 Thread Vít Ondruch
Dne 04. 12. 20 v 12:36 Marius Schwarz napsal(a): Am 03.12.20 um 21:06 schrieb Ben Cotton: ...changes in default behavior, when 1. technically reasonable and 2. not explicitly overridden by the user, should generally be made on upgrade. Distributions are supposed to be opinionated, and in cases

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-04 Thread Marius Schwarz
Am 03.12.20 um 21:06 schrieb Ben Cotton: ...changes in default behavior, when 1. technically reasonable and 2. not explicitly overridden by the user, should generally be made on upgrade. Distributions are supposed to be opinionated, and in cases where the user has accepted our opinion, we should

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-04 Thread Miro Hrončok
On 12/4/20 9:40 AM, Till Maas wrote: Hi, On Thu, Dec 03, 2020 at 08:30:45PM +0100, Miro Hrončok wrote: Changing the default on upgrades is good because the Fedora 33+ experience is similar regardless whether the system is freshly installed or upgraded. in this specific case, the argument

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-04 Thread Miro Hrončok
On 12/3/20 8:30 PM, Miro Hrončok wrote: Hello, we have changed the default editor from vi to nano on Fedora 33+. The change proposal says: > Will not apply to upgrades. https://fedoraproject.org/wiki/Changes/UseNanoByDefault#Upgrade.2Fcompatibility_impact However, currently, it does

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-04 Thread pboy
> Am 04.12.2020 um 09:40 schrieb Till Maas : > > Hi, > > On Thu, Dec 03, 2020 at 08:30:45PM +0100, Miro Hrončok wrote: > >> Changing the default on upgrades is good because the Fedora 33+ experience >> is similar regardless whether the system is freshly installed or upgraded. > > … already

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-04 Thread Till Maas
Hi, On Thu, Dec 03, 2020 at 08:30:45PM +0100, Miro Hrončok wrote: > Changing the default on upgrades is good because the Fedora 33+ experience > is similar regardless whether the system is freshly installed or upgraded. in this specific case, the argument for making nano default was that it is

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-03 Thread Dridi Boukelmoune
> > Maybe I need to reboot my system for vim to take over again? > > You will at least need to logout and log back in. You're right, if I force a login instead of plain sudo it becomes apparent: $ sudo env | grep EDITOR $ sudo su -c env | grep EDITOR $ sudo su - -c env | grep EDITOR

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-03 Thread Samuel Sieb
On 12/3/20 10:52 PM, Dridi Boukelmoune wrote: puts setting EDITOR environment variable into a file (vim-default-editor.sh for bash, ksh, sh and zsh, vim-default-editor.csh for tcsh and vim-default-editor.fish for fish), which is installed under a specific directory (/etc/profile.d for bash,

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-03 Thread Dridi Boukelmoune
> actually Vim ships vim-default-editor subpackage now, which conflicts I did install it, but that didn't seem to have an immediate effect. > with nano-default-editor via virtual provide 'system-default-editor'. It I don't have that package on my system: $ sudo dnf remove nano-default-editor

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-03 Thread Zdenek Dohnal
On 12/3/20 9:46 PM, Tom Hughes via devel wrote: > >> Also from that bug: >> https://bugzilla.redhat.com/show_bug.cgi?id=1896707#c13 >>> "dnf remove nano-default-editor". Alternatively, you can set "export >>> EDITOR=vim" in your ~/.bash_profile > > Setting EDITOR doesn't really work. I mean I have

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-03 Thread Tom Hughes via devel
On 03/12/2020 20:41, Ben Cotton wrote: On Thu, Dec 3, 2020 at 3:32 PM Tom Hughes via devel wrote: What exactly does "change the default on upgrade" actually mean here? Making nano-default-editor a dependency of something else that people are likely to have installed? Or adding something to

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-03 Thread Ben Cotton
On Thu, Dec 3, 2020 at 3:32 PM Tom Hughes via devel wrote: > > What exactly does "change the default on upgrade" actually mean > here? Making nano-default-editor a dependency of something else > that people are likely to have installed? Or adding something to > some sort of post install script

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-03 Thread Tom Hughes via devel
On 03/12/2020 20:06, Ben Cotton wrote: On Thu, Dec 3, 2020 at 2:33 PM Miro Hrončok wrote: Should we try to "fix" this by ensuring the default does not change on upgrades? Or should we acknowledge that it does? I think we should acknowledge that it does because... Changing the default on

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-03 Thread Kevin Fenzi
On Thu, Dec 03, 2020 at 02:32:20PM -0500, Neal Gompa wrote: > On Thu, Dec 3, 2020 at 2:31 PM Miro Hrončok wrote: > > > > Hello, > > > > we have changed the default editor from vi to nano on Fedora 33+. > > > > The change proposal says: > > > > > Will not apply to upgrades. > > > >

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-03 Thread Ben Cotton
On Thu, Dec 3, 2020 at 2:33 PM Miro Hrončok wrote: > > Should we try to "fix" this by ensuring the default does not change on > upgrades? > Or should we acknowledge that it does? > I think we should acknowledge that it does because... > Changing the default on upgrades is good because the

Re: Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-03 Thread Neal Gompa
On Thu, Dec 3, 2020 at 2:31 PM Miro Hrončok wrote: > > Hello, > > we have changed the default editor from vi to nano on Fedora 33+. > > The change proposal says: > > > Will not apply to upgrades. > > https://fedoraproject.org/wiki/Changes/UseNanoByDefault#Upgrade.2Fcompatibility_impact > >

Should the default editor be changed from vi to nano on upgrades to Fedora 33+

2020-12-03 Thread Miro Hrončok
Hello, we have changed the default editor from vi to nano on Fedora 33+. The change proposal says: > Will not apply to upgrades. https://fedoraproject.org/wiki/Changes/UseNanoByDefault#Upgrade.2Fcompatibility_impact However, currently, it does apply to upgrades: