Re: Use immutable CRAN URLs

2019-11-06 Thread Iñaki Ucar
Hi, I had every intention of pushing this forward, but I never found the time. Sorry for that. It would still be great to have these. Iñaki On Wed, 6 Nov 2019 at 10:11, Elliott Sales de Andrade wrote: > > Hello, > > On Thu, 1 Nov 2018 at 20:45, Jason L Tibbitts III wrote: > > > > Since I actu

Re: Use immutable CRAN URLs

2019-11-06 Thread Elliott Sales de Andrade
Hello, On Thu, 1 Nov 2018 at 20:45, Jason L Tibbitts III wrote: > > Since I actually had an existing pagure repo for random RPM macro > experiments, I just dropped the R macro stuff there. > > https://pagure.io/misc-rpm-macros > https://pagure.io/misc-rpm-macros/blob/master/f/macros.R-extra > > I

Re: Use immutable CRAN URLs

2018-11-01 Thread Jason L Tibbitts III
Since I actually had an existing pagure repo for random RPM macro experiments, I just dropped the R macro stuff there. https://pagure.io/misc-rpm-macros https://pagure.io/misc-rpm-macros/blob/master/f/macros.R-extra I still have some ideas to implement but feel free to test what's there. To use t

Re: Use immutable CRAN URLs

2018-11-01 Thread Jason L Tibbitts III
> "IU" == Iñaki Ucar writes: IU> I see. Anyway, I suppose that it's healthy to preserve some manual IU> intervention in these sections. Well, it would be super great if we didn't have to do that and one day RPM might give us some reasonable way to generate more of the specfile based on the c

Re: Use immutable CRAN URLs

2018-11-01 Thread Iñaki Ucar
On Thu, 1 Nov 2018 at 15:45, Jason L Tibbitts III wrote: > > > "IU" == Iñaki Ucar writes: > > IU> - Version: As you already found out, there are many version formats > IU> allowed. > > But it's easy to work from Version: in the normal case and simply allow > the CRAN version to be specified s

Re: Use immutable CRAN URLs

2018-11-01 Thread Jason L Tibbitts III
> "IU" == Iñaki Ucar writes: IU> - Version: As you already found out, there are many version formats IU> allowed. But it's easy to work from Version: in the normal case and simply allow the CRAN version to be specified separately, as I showed in the R-uuid sample. If it's rather more common

Re: Use immutable CRAN URLs

2018-11-01 Thread Iñaki Ucar
On Thu, 1 Nov 2018 at 05:05, Elliott Sales de Andrade wrote: > > Basically anything under %{rlibdir}%{packname} is needed and nothing appears > elsewhere. If we didn't need to mark doc and license files, we could have > just specified that top-level directory. The hard part about that is the >

Re: Use immutable CRAN URLs

2018-11-01 Thread Nicolas Mailhot
Le jeudi 01 novembre 2018 à 13:36 +0100, Iñaki Ucar a écrit : Hi, > - Arch, Requires, BuildRequires, libdir/datadir: As Elliott pointed > out already, archful packages can be detected just by looking into the > DESCRIPTION file, by checking whether the NeedsCompilation flag > exists. If it does,

Re: Use immutable CRAN URLs

2018-11-01 Thread Iñaki Ucar
All this would be very useful. CRAN guidelines are pretty strict, and they are enforced by R packaging and checking tools, and additionally upon submission to CRAN, with many automatic checks. As a result, and as you say, most SPEC sections in most packages can be fully automated, and I think we sh

Re: Use immutable CRAN URLs

2018-11-01 Thread Nicolas Mailhot
Le mercredi 31 octobre 2018 à 21:31 +0100, Iñaki Ucar a écrit : > On Wed, 31 Oct 2018 at 21:22, Iñaki Ucar > wrote: > > while the R package name is TH.data, not TH-data. I see that the > > SPEC > > says "# Cannot use . in name", but this is clearly not true (maybe > > it > > was true long ago?). >

Re: Use immutable CRAN URLs

2018-10-31 Thread Elliott Sales de Andrade
On Wed, Oct 31, 2018, 5:01 PM Iñaki Ucar On Wed, 31 Oct 2018 at 21:48, Jason L Tibbitts III > wrote: > > > > > "IU" == Iñaki Ucar writes: > > > > > > IU> This is great. However, in theory, given the naming guidelines, by > > IU> stripping the leading "R-" you should get the package name. In

Re: Use immutable CRAN URLs

2018-10-31 Thread Jason L Tibbitts III
And with some tweaks to the macro file (current version at https://www.math.uh.edu/~tibbs/fedora/macros.test) and the R-uuid package is reduced to the following. Not quite as simple, but it shows how you can still split out the individual sections when you need to add something, and also cope with

Re: Use immutable CRAN URLs

2018-10-31 Thread Jason L Tibbitts III
> "JLT" == Jason L Tibbitts writes: JLT> It depends on how far you want to go, and how specific you can be JLT> before you're not actually simplifying a majority of the R packages JLT> we have. Just for fun I took the R-webp package and constructed a macro that generates most of the package.

Re: Use immutable CRAN URLs

2018-10-31 Thread Iñaki Ucar
On Wed, 31 Oct 2018 at 21:48, Jason L Tibbitts III wrote: > > > "IU" == Iñaki Ucar writes: > > > IU> This is great. However, in theory, given the naming guidelines, by > IU> stripping the leading "R-" you should get the package name. In > IU> practice, at least one package doesn't adhere to t

Re: Use immutable CRAN URLs

2018-10-31 Thread Jason L Tibbitts III
> "IU" == Iñaki Ucar writes: IU> This is great. However, in theory, given the naming guidelines, by IU> stripping the leading "R-" you should get the package name. In IU> practice, at least one package doesn't adhere to this: R-TH-data, IU> while the R package name is TH.data, not TH-data. I

Re: Use immutable CRAN URLs

2018-10-31 Thread Iñaki Ucar
On Wed, 31 Oct 2018 at 21:22, Iñaki Ucar wrote: > > while the R package name is TH.data, not TH-data. I see that the SPEC > says "# Cannot use . in name", but this is clearly not true (maybe it > was true long ago?). Well... the guidelines for Python state: 'Note that when a module that has a dot

Re: Use immutable CRAN URLs

2018-10-31 Thread Iñaki Ucar
On Wed, 31 Oct 2018 at 19:52, Jason L Tibbitts III wrote: > > > "IU" == Iñaki Ucar writes: > > IU> https://cran.r-project.org/package=simmer&version=3.0.0 > > IU> returns a redirection (303) to the complete URL, with file > IU> extension. > > 303 is actually "See Other". Which is odd as that

Re: Use immutable CRAN URLs

2018-10-31 Thread Jason L Tibbitts III
> "IU" == Iñaki Ucar writes: IU> https://cran.r-project.org/package=simmer&version=3.0.0 IU> returns a redirection (303) to the complete URL, with file IU> extension. 303 is actually "See Other". Which is odd as that's usually sent in response to a PUT or POST, not a GET. Maybe you can ge

Re: Use immutable CRAN URLs

2018-10-31 Thread Iñaki Ucar
I missed the example in my last email. Here it is: $ curl -I "https://cran.r-project.org/package=simmer&version=3.0.0"; HTTP/1.1 303 See Other Date: Wed, 31 Oct 2018 17:39:46 GMT Server: Apache/2.4.10 (Debian) Location: https://cran.r-project.org/src/contrib/Archive/simmer/simmer_3.0.0.tar.gz Con

Re: Use immutable CRAN URLs

2018-10-31 Thread Iñaki Ucar
On Wed, 31 Oct 2018 at 18:25, Jason L Tibbitts III wrote: > > Looking at this further, this URL scheme is just terrible and will be > "fun" to make use of. > > Basically you have to keep in mind that a tool like spectool can't trust > the filename that is sent by the remote web server and will ins

Re: Use immutable CRAN URLs

2018-10-31 Thread Jason L Tibbitts III
Looking at this further, this URL scheme is just terrible and will be "fun" to make use of. Basically you have to keep in mind that a tool like spectool can't trust the filename that is sent by the remote web server and will instead use only the filename extracted from the URL. That means if you

Re: Use immutable CRAN URLs

2018-10-31 Thread Jason L Tibbitts III
Spent a couple of seconds looking at this and have a couple of questions. Once I have answers it should take me only a couple of minutes to give you something to test. Does the source URL for CRAN not have any kind of file extension? Could you provide a couple of sample packages for me to look a

Re: Use immutable CRAN URLs

2018-10-31 Thread Jason L Tibbitts III
I've been trying to stay away from computers for a few days. Just catching back up with email. - J< ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https

Re: Use immutable CRAN URLs

2018-10-31 Thread Iñaki Ucar
Hi Dominik, On Wed, 31 Oct 2018 at 00:43, Dominik 'Rathann' Mierzejewski wrote: > > On Tuesday, 30 October 2018 at 16:36, Iñaki Ucar wrote: > > Kind reminder. Any update on this? > > Jason asked you to open a ticket in the Packaging Committee tracker > and open a pull request against the guidelin

Re: Use immutable CRAN URLs

2018-10-30 Thread Dominik 'Rathann' Mierzejewski
On Tuesday, 30 October 2018 at 16:36, Iñaki Ucar wrote: > Kind reminder. Any update on this? Jason asked you to open a ticket in the Packaging Committee tracker and open a pull request against the guidelines. Have you done that? Regards, Dominik -- Fedora https://getfedora.org | RPMFusion

Re: Use immutable CRAN URLs

2018-10-30 Thread Iñaki Ucar
Kind reminder. Any update on this? Iñaki On Wed, 24 Oct 2018 at 17:01, Iñaki Ucar wrote: > > On Wed, 24 Oct 2018 at 15:02, Jason L Tibbitts III wrote: > > > > > "IU" == Iñaki Ucar writes: > > > > IU> This URL format is not recommended by CRAN, but more importantly, > > IU> the Source0 form

Re: Use immutable CRAN URLs

2018-10-24 Thread Iñaki Ucar
On Wed, 24 Oct 2018 at 15:02, Jason L Tibbitts III wrote: > > > "IU" == Iñaki Ucar writes: > > IU> This URL format is not recommended by CRAN, but more importantly, > IU> the Source0 format does not work anymore, as [1] noted, when a new > IU> version is released. However, there is an immutab

Re: Use immutable CRAN URLs

2018-10-24 Thread Jason L Tibbitts III
> "IU" == Iñaki Ucar writes: IU> This URL format is not recommended by CRAN, but more importantly, IU> the Source0 format does not work anymore, as [1] noted, when a new IU> version is released. However, there is an immutable format IU> available, as [2] pointed out. So my proposal is to use

Use immutable CRAN URLs

2018-10-24 Thread Iñaki Ucar
Hi, Currently, most of the R packages included in Fedora use the following lines in the SPEC: URL: https://cran.r-project.org/web/packages/%{packname}/ Source0: https://cran.r-project.org/src/contrib/%{packname}_%{version}.tar.gz This URL format is not recommended by CRAN, but more importantly,