Re: What to do about FTBFS because auf cmake change?

2020-08-06 Thread Kevin Kofler
Neal Gompa wrote: > Not only is that terrible advice, it's actually *wrong*. If you're > going to do bad things like that, at least make sure to test it. I did: https://src.fedoraproject.org/rpms/blogilo/c/ee482f1b33b50d79190951180d209e749b545dcd?branch=master

Re: What to do about FTBFS because auf cmake change?

2020-08-06 Thread Neal Gompa
On Thu, Aug 6, 2020 at 5:45 AM Kevin Kofler wrote: > > FYI, the easiest and most portable fix is to add: > -B. > (followed by a space or some other whitespace) before the . or .. (source > directory) argument. (That basically undoes the effects of this pointless > incompatible macro change.) >

Re: What to do about FTBFS because auf cmake change?

2020-08-06 Thread Kevin Kofler
FYI, the easiest and most portable fix is to add: -B. (followed by a space or some other whitespace) before the . or .. (source directory) argument. (That basically undoes the effects of this pointless incompatible macro change.) Kevin Kofler

Re: What to do about FTBFS because auf cmake change?

2020-08-06 Thread Lukáš Hrázký
On Wed, 2020-08-05 at 07:59 -0400, Neal Gompa wrote: > On Wed, Aug 5, 2020 at 7:53 AM Lukáš Hrázký wrote: > > Hi Neal, all, > > > > On Tue, 2020-08-04 at 07:42 -0400, Neal Gompa wrote: > > > ... > > > > What if I build for multiple platforms at the same time? E.g. in dnf we > > have: > > > >

Re: What to do about FTBFS because auf cmake change?

2020-08-06 Thread Igor Raits
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Thu, 2020-08-06 at 07:48 +, Martin Gansser wrote: > what do I have to do if I want to keep the timestamp? > > %install > %make_install INSTALL="install -p" > > > %cmake_install INSTALL="install -p" did not work. Just use %cmake_install.

Re: What to do about FTBFS because auf cmake change?

2020-08-06 Thread Martin Gansser
what do I have to do if I want to keep the timestamp? %install %make_install INSTALL="install -p" %cmake_install INSTALL="install -p" did not work. Regards Martin ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to

Re: What to do about FTBFS because auf cmake change?

2020-08-05 Thread Neal Gompa
On Wed, Aug 5, 2020 at 7:53 AM Lukáš Hrázký wrote: > > Hi Neal, all, > > On Tue, 2020-08-04 at 07:42 -0400, Neal Gompa wrote: > > On Tue, Aug 4, 2020 at 7:32 AM Till Hofmann > > wrote: > > > Hi all, > > > > > > I have a number of packages that are FTBFS due to > > >

Re: What to do about FTBFS because auf cmake change?

2020-08-05 Thread Lukáš Hrázký
Hi Neal, all, On Tue, 2020-08-04 at 07:42 -0400, Neal Gompa wrote: > On Tue, Aug 4, 2020 at 7:32 AM Till Hofmann > wrote: > > Hi all, > > > > I have a number of packages that are FTBFS due to > > https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds. > > > > None of my

Re: What to do about FTBFS because auf cmake change?

2020-08-04 Thread Neal Gompa
On Tue, Aug 4, 2020 at 1:40 PM José Abílio Matos wrote: > > On Tuesday, 4 August 2020 12.42.30 WEST Neal Gompa wrote: > > Then you should do the following: > > > > %undefine __cmake_in_source_build > > > > %cmake > > %cmake_build > > %cmake_install > > Would not it be more clean to place the

Re: What to do about FTBFS because auf cmake change?

2020-08-04 Thread José Abílio Matos
On Tuesday, 4 August 2020 12.42.30 WEST Neal Gompa wrote: > Then you should do the following: > > %undefine __cmake_in_source_build > > %cmake > %cmake_build > %cmake_install Would not it be more clean to place the %undefine line inside guards? %if (0%{?rhel} || (0%{?fedora} && 0%{?fedora} <

Re: What to do about FTBFS because auf cmake change?

2020-08-04 Thread Neal Gompa
On Tue, Aug 4, 2020 at 9:55 AM Miro Hrončok wrote: > > On 04. 08. 20 14:54, Peter Robinson wrote: > > What's the proper way to deal with a "make test" in %check, I've seen > > a few get confused still by that even when the %cmake bits earlier in > > the process pass, it seems there's not a

Re: What to do about FTBFS because auf cmake change?

2020-08-04 Thread Miro Hrončok
On 04. 08. 20 14:54, Peter Robinson wrote: What's the proper way to deal with a "make test" in %check, I've seen a few get confused still by that even when the %cmake bits earlier in the process pass, it seems there's not a %cmake_test equiv. I've used: %cmake_build -- test There is

Re: What to do about FTBFS because auf cmake change?

2020-08-04 Thread Peter Robinson
> > I have a number of packages that are FTBFS due to > > https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds. > > > > None of my packages has seen any commits for that change. I've read on > > the list that packages that are considered "a complete mess" are not > > touched.

Re: What to do about FTBFS because auf cmake change?

2020-08-04 Thread Neal Gompa
On Tue, Aug 4, 2020 at 7:32 AM Till Hofmann wrote: > > Hi all, > > I have a number of packages that are FTBFS due to > https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds. > > None of my packages has seen any commits for that change. I've read on > the list that packages that

What to do about FTBFS because auf cmake change?

2020-08-04 Thread Till Hofmann
Hi all, I have a number of packages that are FTBFS due to https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds. None of my packages has seen any commits for that change. I've read on the list that packages that are considered "a complete mess" are not touched. Are all my