Re: review-stats bot spamming "failed to clear NEEDINFO" messages

2020-11-16 Thread Mattia Verga via devel
Il 16/11/20 09:29, Artur Frenszek-Iwicki ha scritto: >> a) failing to check if the NEEDINFO flag is set for the *submitter*, >>instead of a reviewer >> b) failing to clear the NEEDINFO flag for the submitter > Oops, I barely posted the message and I already spotted that I'm wrong. > > The NEEDI

Re: review-stats bot spamming "failed to clear NEEDINFO" messages

2020-11-16 Thread Artur Frenszek-Iwicki
>a) failing to check if the NEEDINFO flag is set for the *submitter*, > instead of a reviewer >b) failing to clear the NEEDINFO flag for the submitter Oops, I barely posted the message and I already spotted that I'm wrong. The NEEDINFO flag, in this case, is set to require action from "nob...@fe

review-stats bot spamming "failed to clear NEEDINFO" messages

2020-11-16 Thread Artur Frenszek-Iwicki
Recently we've had a new automation introduced, which seeks out stalled review requests and tries to prod them to move forward. One of the ways it does this is by looking at reviews which have the NEEDINFO flag set and, if the ticket reviewer failed to reply for a long time, it resets the ticket s