Re: the sad state of installability tests

2024-07-17 Thread Vít Ondruch
Dne 15. 07. 24 v 11:22 Michal Srb napsal(a): Hello, po 15. 7. 2024 o 10:57 Zbigniew Jędrzejewski-Szmek napísal(a): On Mon, Jul 15, 2024 at 10:39:37AM +0200, Cristian Le via devel wrote: > Hi Zbyszek, > > On 2024/07/14 20:04, Zbigniew Jędrzejewski-Szmek wrote: > > I'm

Re: the sad state of installability tests

2024-07-16 Thread Adam Williamson
On Tue, 2024-07-16 at 09:19 -0400, Stephen Gallagher wrote: > On Mon, Jul 15, 2024 at 4:06 PM Zbigniew Jędrzejewski-Szmek > wrote: > > > > On Mon, Jul 15, 2024 at 08:55:03AM -0400, Stephen Gallagher wrote: > > > This seems like overkill. Wouldn't the simplest valid installability > > > test just

Re: the sad state of installability tests

2024-07-16 Thread Stephen Gallagher
On Mon, Jul 15, 2024 at 4:06 PM Zbigniew Jędrzejewski-Szmek wrote: > > On Mon, Jul 15, 2024 at 08:55:03AM -0400, Stephen Gallagher wrote: > > This seems like overkill. Wouldn't the simplest valid installability > > test just be to test whether each subpackage *individually* could be > >

Re: the sad state of installability tests

2024-07-15 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jul 15, 2024 at 08:55:03AM -0400, Stephen Gallagher wrote: > This seems like overkill. Wouldn't the simplest valid installability > test just be to test whether each subpackage *individually* could be > installed? That's a really nice idea. > If we have 20 subpackages, just launch 20

Re: the sad state of installability tests

2024-07-15 Thread Adam Williamson
On Mon, 2024-07-15 at 08:45 +, Zbigniew Jędrzejewski-Szmek wrote: > > Yes, I've opened many issues regarding Fedora CI. I think the problem is > > that > > the CI maintainer is not a regular packager and thus does not observe CI > > reults in real life. On the other hand, package maintainers

Re: the sad state of installability tests

2024-07-15 Thread Cristian Le via devel
On 2024/07/15 13:52, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Jul 15, 2024 at 01:26:09PM +0200, Petr Pisar wrote: V Mon, Jul 15, 2024 at 08:45:53AM +, Zbigniew Jędrzejewski-Szmek napsal(a): Maybe I conflate installability tests with rpmdeplint tests. We need both: A test which checks

Re: the sad state of installability tests

2024-07-15 Thread Daniel P . Berrangé
On Mon, Jul 15, 2024 at 11:52:07AM +, Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Jul 15, 2024 at 01:26:09PM +0200, Petr Pisar wrote: > > V Mon, Jul 15, 2024 at 08:45:53AM +, Zbigniew Jędrzejewski-Szmek > > napsal(a): > > > On Mon, Jul 15, 2024 at 10:31:06AM +0200, Petr Pisar wrote: > >

Re: the sad state of installability tests

2024-07-15 Thread Stephen Gallagher
On Mon, Jul 15, 2024 at 8:03 AM Zbigniew Jędrzejewski-Szmek wrote: > > On Mon, Jul 15, 2024 at 01:26:09PM +0200, Petr Pisar wrote: > > V Mon, Jul 15, 2024 at 08:45:53AM +, Zbigniew Jędrzejewski-Szmek > > napsal(a): > > > On Mon, Jul 15, 2024 at 10:31:06AM +0200, Petr Pisar wrote: > > > > I

Re: the sad state of installability tests

2024-07-15 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jul 15, 2024 at 01:26:09PM +0200, Petr Pisar wrote: > V Mon, Jul 15, 2024 at 08:45:53AM +, Zbigniew Jędrzejewski-Szmek > napsal(a): > > On Mon, Jul 15, 2024 at 10:31:06AM +0200, Petr Pisar wrote: > > > I guess the test does not take RPM Conflicts into account. It's overly > > >

Re: the sad state of installability tests

2024-07-15 Thread Petr Pisar
V Mon, Jul 15, 2024 at 08:45:53AM +, Zbigniew Jędrzejewski-Szmek napsal(a): > On Mon, Jul 15, 2024 at 10:31:06AM +0200, Petr Pisar wrote: > > I guess the test does not take RPM Conflicts into account. It's overly > > optimistic when populating a system by installing all tested packages > >

Re: the sad state of installability tests

2024-07-15 Thread Michal Srb
Hello, po 15. 7. 2024 o 10:57 Zbigniew Jędrzejewski-Szmek napísal(a): > On Mon, Jul 15, 2024 at 10:39:37AM +0200, Cristian Le via devel wrote: > > Hi Zbyszek, > > > > On 2024/07/14 20:04, Zbigniew Jędrzejewski-Szmek wrote: > > > I'm looking for a solution which doesn't just skip the

Re: the sad state of installability tests

2024-07-15 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jul 15, 2024 at 10:39:37AM +0200, Cristian Le via devel wrote: > Hi Zbyszek, > > On 2024/07/14 20:04, Zbigniew Jędrzejewski-Szmek wrote: > > I'm looking for a solution which doesn't just skip the installability > > tests altogether. > > On PRs with zuul or FedoraCI automation, the same

Re: the sad state of installability tests

2024-07-15 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jul 15, 2024 at 10:31:06AM +0200, Petr Pisar wrote: > Yes. Installability is a very basic test and it should be reliable. My > feeling is that broken dependencies are the most common packaging bug. > > > Or if it's not possible to make them work, disable them? In the > > current state we

Re: the sad state of installability tests

2024-07-15 Thread Cristian Le via devel
Hi Zbyszek, On 2024/07/14 20:04, Zbigniew Jędrzejewski-Szmek wrote: I'm looking for a solution which doesn't just skip the installability tests altogether. On PRs with zuul or FedoraCI automation, the same instability tests that are done for Bodhi are performed. But what would help is to

Re: the sad state of installability tests

2024-07-15 Thread Petr Pisar
V Sun, Jul 14, 2024 at 06:04:25PM +, Zbigniew Jędrzejewski-Szmek napsal(a): > CI for Bodhi updates has a bunch of tests like > fedora-ci.koji-build.tier0.functional > fedora-ci.koji-build./plans/public.functional > that routinely fail. In fact, they are designed in a way where they >

the sad state of installability tests

2024-07-14 Thread Zbigniew Jędrzejewski-Szmek
CI for Bodhi updates has a bunch of tests like fedora-ci.koji-build.tier0.functional fedora-ci.koji-build./plans/public.functional that routinely fail. In fact, they are designed in a way where they _must_ fail for many important packages: systemd, fedora-release, coreutils, and anything else