Re: [Geany-Devel] Plugins Quality Check

2014-02-20 Thread Colomban Wendling
Le 20/02/2014 09:07, Lex Trotman a écrit : [...] geanygendoc - 2 warnings, extra switch case may be consequential, unused function [...] Unused functions and variables are probably inconsequential, unless they are the result of a typo in the code meant to use them, they need a quick check

Re: [Geany-Devel] modification of fullscreen behaviour

2014-02-20 Thread Matthew Brush
On 14-02-20 10:54 AM, Colomban Wendling wrote: Hi, Le 19/02/2014 06:23, Flynn Milligan a écrit : So far as I can tell, you're an acceptable person to contact about this matter; if not, I'll try to find a better place to submit it. It's acceptable, but you should rather ask development

Re: [Geany-Devel] Plugins Quality Check

2014-02-20 Thread Matthew Brush
On 14-02-20 12:07 AM, Lex Trotman wrote: Hi All, On the off chance that we might be converging on a release I did a compile of the plugins with the usual options (-Wall -Wextra -Wno-unused-paratemers). This was on GTK2 since many still don't work for GTK3. The results are not too bad really

Re: [Geany-Devel] Plugins Quality Check

2014-02-20 Thread Lex Trotman
On 21 February 2014 02:02, Colomban Wendling lists@herbesfolles.org wrote: Le 20/02/2014 09:07, Lex Trotman a écrit : [...] geanygendoc - 2 warnings, extra switch case may be consequential, unused function [...] Unused functions and variables are probably inconsequential, unless they

Re: [Geany-Devel] Plugins Quality Check

2014-02-20 Thread Lex Trotman
[...] Well, the same as for code written by humans, the C compiler warning is telling us something *might* be wrong with the code. The Vala compiler may have bugs, so such things need checking the same as manual code, to avoid possible UB. If, as in these cases, it seems to be ok, then its just