Re: [Geany-Devel] RFC: Keybindings rewrite

2014-06-06 Thread Lex Trotman
On 7 June 2014 10:32, Matthew Brush wrote: > On 14-06-06 07:17 AM, Thomas Martitz wrote: >> >> Hello, >> >> based up on Matthew's fine GtkActions branch [1] I think we could >> realistically rewrite keybindings.c use GtkAction/accelerators properly. >> >> Currently it re-implements lots of gtk stu

Re: [Geany-Devel] RFC: Keybindings rewrite

2014-06-06 Thread Matthew Brush
On 14-06-06 07:17 AM, Thomas Martitz wrote: Hello, based up on Matthew's fine GtkActions branch [1] I think we could realistically rewrite keybindings.c use GtkAction/accelerators properly. Currently it re-implements lots of gtk stuff, such as the actual looping through the known keybindings fo

Re: [Geany-Devel] RFC: Keybindings rewrite

2014-06-06 Thread Matthew Brush
On 14-06-06 01:35 PM, Thomas Martitz wrote: Am 06.06.2014 16:24, schrieb Yosef Or Boczko: I think it better to port to GAction instead of GtkAction (GtkAction has been deprecated since version 3.10 and will be removed in GTK+ 4), so it will be ease to port geany to GTK+ 4 in the future. We hav

Re: [Geany-Devel] RFC: Keybindings rewrite

2014-06-06 Thread Thomas Martitz
Am 06.06.2014 16:24, schrieb Yosef Or Boczko: I think it better to port to GAction instead of GtkAction (GtkAction has been deprecated since version 3.10 and will be removed in GTK+ 4), so it will be ease to port geany to GTK+ 4 in the future. We have elaborated GAction. The problem is that it

Re: [Geany-Devel] RFC: Keybindings rewrite

2014-06-06 Thread Yosef Or Boczko
I think it better to port to GAction instead of GtkAction (GtkAction has been deprecated since version 3.10 and will be removed in GTK+ 4), so it will be ease to port geany to GTK+ 4 in the future. Also, IIRC, there is a problem with GtkAction, wich cause to some accelactors to work only when t

[Geany-Devel] RFC: Keybindings rewrite

2014-06-06 Thread Thomas Martitz
Hello, based up on Matthew's fine GtkActions branch [1] I think we could realistically rewrite keybindings.c use GtkAction/accelerators properly. Currently it re-implements lots of gtk stuff, such as the actual looping through the known keybindings for the callback when a keybinding pressed.