[Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Thomas Martitz
Hello I have just noticed that current git, by default, doesn't prompt anymore when reloading documents, even when they are changed. I traced it back to the $SUBJECT commit. IMO it's fine to keep the undo history on reload and not prompt, but it's not fine if the file is currently modified (

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Colomban Wendling
Le 24/06/2015 17:04, Thomas Martitz a écrit : > Hello > > I have just noticed that current git, by default, doesn't prompt anymore > when reloading documents, even when they are changed. > > I traced it back to the $SUBJECT commit. IMO it's fine to keep the undo > history on reload and not prompt

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Thomas Martitz
Am 24.06.2015 um 18:30 schrieb Colomban Wendling: Le 24/06/2015 17:04, Thomas Martitz a écrit : Hello I have just noticed that current git, by default, doesn't prompt anymore when reloading documents, even when they are changed. I traced it back to the $SUBJECT commit. IMO it's fine to keep th

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Lex Trotman
On 25 June 2015 at 04:54, Thomas Martitz wrote: > Am 24.06.2015 um 18:30 schrieb Colomban Wendling: >> >> Le 24/06/2015 17:04, Thomas Martitz a écrit : >>> >>> Hello >>> >>> I have just noticed that current git, by default, doesn't prompt anymore >>> when reloading documents, even when they are ch

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Thomas Martitz
Am 24.06.2015 um 22:26 schrieb Lex Trotman: I'm struggling to understand why there is any confusion, reload is an editing action just like any other and can be undone like any other. Seems much safer to me and exactly what to expect. It used to have a side effect that was unexpected and nasty w

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Lex Trotman
On 25 June 2015 at 06:54, Thomas Martitz wrote: > Am 24.06.2015 um 22:26 schrieb Lex Trotman: >> >> I'm struggling to understand why there is any confusion, reload is an >> editing action just like any other and can be undone like any other. Seems >> much safer to me and exactly what to expect. It

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Matthew Brush
On 2015-06-24 09:30 AM, Colomban Wendling wrote: Le 24/06/2015 17:04, Thomas Martitz a écrit : Hello I have just noticed that current git, by default, doesn't prompt anymore when reloading documents, even when they are changed. I traced it back to the $SUBJECT commit. IMO it's fine to keep the

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Matthew Brush
On 2015-06-24 02:30 PM, Lex Trotman wrote: On 25 June 2015 at 06:54, Thomas Martitz wrote: Am 24.06.2015 um 22:26 schrieb Lex Trotman: I'm struggling to understand why there is any confusion, reload is an editing action just like any other and can be undone like any other. Seems much safer to

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Lex Trotman
[...] > I think the only weird behaviour besides the clearing the "dirty" state, is > that if you are editing a file, then edit it externally, then come back to > Geany, it rightly warns you using a nice document message, giving the choice > to reload, overwrite or do nothing. If you press the too

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Matthew Brush
On 2015-06-24 05:47 PM, Lex Trotman wrote: [...] I wonder if there's a more simple way to reduce confusion and increase visibility other than an annoying dialog or document message. Maybe as a separate action with a different name in the edit menu? Menu, what menu? I use the toolbar button.

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Lex Trotman
On 25 June 2015 at 10:51, Matthew Brush wrote: > On 2015-06-24 05:47 PM, Lex Trotman wrote: >> >> [...] >> >>> I wonder if there's a more simple way to reduce confusion and increase >>> visibility other than an annoying dialog or document message. Maybe as a >>> separate action with a different na

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Thomas Martitz
Am 25. Juni 2015 02:51:43 MESZ, schrieb Matthew Brush : >On 2015-06-24 05:47 PM, Lex Trotman wrote: >> [...] >> >>> I wonder if there's a more simple way to reduce confusion and >increase visibility other than an annoying dialog or document message. >Maybe as a separate action with a different name

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Lex Trotman
On 25 June 2015 at 15:19, Thomas Martitz wrote: > Am 25. Juni 2015 02:51:43 MESZ, schrieb Matthew Brush : >>On 2015-06-24 05:47 PM, Lex Trotman wrote: >>> [...] >>> I wonder if there's a more simple way to reduce confusion and >>increase visibility other than an annoying dialog or document me

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Thomas Martitz
Am 25.06.2015 um 07:54 schrieb Lex Trotman: The red indicates that the buffer is changed and unsaved, in other words the buffer is not the same as the file on disk. So clearing it on reload is the right thing. Well, thinking about it some more red doesn't really indicate anything about the bu

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Lex Trotman
[...] > > Right, makes some sense too. > > However, what to do in this case: the file is saved (clearing the red) and > immediately reloaded? Make it red again or keep it clear? Well reload syncs file and buffer, so its cleared again. Seems right. [...] > > There is a various pref for the "keep

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Thomas Martitz
Am 25.06.2015 um 08:17 schrieb Lex Trotman: [...] Right, makes some sense too. However, what to do in this case: the file is saved (clearing the red) and immediately reloaded? Make it red again or keep it clear? Well reload syncs file and buffer, so its cleared again. Seems right. Sorry, I