Re: [Geany-Devel] CodeAi Fixes a Null Pointer Dereference

2017-05-11 Thread Frank Lanitz
Am 2017-05-11 22:34, schrieb Benjamin Bales: ok, I'll submit a PR with some of the fixes that I think are good. Was the format of the bug report acceptable? Our tool integrates with static analyzers, and sometimes its tricky to include their reports in a way that is clear and concise. Of co

Re: [Geany-Devel] CodeAi Fixes a Null Pointer Dereference

2017-05-11 Thread Lex Trotman
On 12 May 2017 at 05:40, Benjamin Bales wrote: > Lex and Matthew, > > You seem to disagree on this issue. Is this a valid issue? And if so, do > you like the fix? I can batch a few of them (<= 10) as a single PR. No > problem. > ​Matthew is right, I misread the report as saying that `doc` wa

Re: [Geany-Devel] CodeAi Fixes a Null Pointer Dereference

2017-05-11 Thread Benjamin Bales
yep. That's one of the analyzers we integrate with. We're expanding out portfolio to include a suite of open source and (1 or 2) proprietary static analyzers. They help to identify defects and provide information about the defect to our AI (deep learning) component that suggests fixes. Obviously

Re: [Geany-Devel] CodeAi Fixes a Null Pointer Dereference

2017-05-11 Thread Matthew Brush
On 2017-05-11 01:34 PM, Benjamin Bales wrote: ok, I'll submit a PR with some of the fixes that I think are good. Was the format of the bug report acceptable? Our tool integrates with static analyzers, and sometimes its tricky to include their reports in a way that is clear and concise. Of cour

Re: [Geany-Devel] CodeAi Fixes a Null Pointer Dereference

2017-05-11 Thread Benjamin Bales
ok, I'll submit a PR with some of the fixes that I think are good. Was the format of the bug report acceptable? Our tool integrates with static analyzers, and sometimes its tricky to include their reports in a way that is clear and concise. Of course, I will provide my own summary of the issues,

Re: [Geany-Devel] CodeAi Fixes a Null Pointer Dereference

2017-05-11 Thread Matthew Brush
On 2017-05-11 12:40 PM, Benjamin Bales wrote: Lex and Matthew, You seem to disagree on this issue. Is this a valid issue? And if so, do you like the fix? I can batch a few of them (<= 10) as a single PR. No problem. If they're valid bugs (even minor), it certainly doesn't hurt to make a

Re: [Geany-Devel] CodeAi Fixes a Null Pointer Dereference

2017-05-11 Thread Benjamin Bales
Lex and Matthew, You seem to disagree on this issue. Is this a valid issue? And if so, do you like the fix? I can batch a few of them (<= 10) as a single PR. No problem. -Ben On Wed, May 10, 2017 at 8:22 PM, Matthew Brush wrote: > On 2017-05-10 04:09 PM, Lex Trotman wrote: > >> On 11 May 2