Re: [Geany-Devel] Plugins Quality Check

2014-02-22 Thread Frank Lanitz
On Sat, 22 Feb 2014 07:06:43 +1100 Lex Trotman ele...@gmail.com wrote: Sigh, this is one of the places where a system interface should be const char* but isn't. Quick and dirty patch attached. Thanks. Will apply it. Cheers, Frank pgpLliyGvLKD5.pgp Description: PGP signature

Re: [Geany-Devel] Plugins Quality Check

2014-02-21 Thread Frank Lanitz
On Thu, 20 Feb 2014 19:07:04 +1100 Lex Trotman ele...@gmail.com wrote: geanysendmail - 3 const discarded warnings I have these on my plate, but no idea whether this is really a problem (I don't think so) nor how I can fix it. Cheers, Frank pgpgklCxEhcqi.pgp Description: PGP signature

Re: [Geany-Devel] Plugins Quality Check

2014-02-21 Thread Colomban Wendling
Le 21/02/2014 03:16, Lex Trotman a écrit : [...] Well, the same as for code written by humans, the C compiler warning is telling us something *might* be wrong with the code. The Vala compiler may have bugs, so such things need checking the same as manual code, to avoid possible UB. If, as

Re: [Geany-Devel] Plugins Quality Check

2014-02-21 Thread Colomban Wendling
Le 21/02/2014 15:02, Frank Lanitz a écrit : On Thu, 20 Feb 2014 19:07:04 +1100 Lex Trotman ele...@gmail.com wrote: geanysendmail - 3 const discarded warnings I have these on my plate, but no idea whether this is really a problem (I don't think so) It's not a real problem, it's only a

Re: [Geany-Devel] Plugins Quality Check

2014-02-21 Thread Matthew Brush
On 14-02-21 06:30 AM, Colomban Wendling wrote: Le 21/02/2014 03:16, Lex Trotman a écrit : [...] Well, the same as for code written by humans, the C compiler warning is telling us something *might* be wrong with the code. The Vala compiler may have bugs, so such things need checking the same

Re: [Geany-Devel] Plugins Quality Check

2014-02-21 Thread Colomban Wendling
Le 21/02/2014 16:39, Matthew Brush a écrit : On 14-02-21 06:30 AM, Colomban Wendling wrote: Le 21/02/2014 03:16, Lex Trotman a écrit : [...] OK, I didn't think it was OK to assume GCC was the compiler, It isn't, indeed. Although well, to be fair we probably have no idea what happens if

Re: [Geany-Devel] Plugins Quality Check

2014-02-21 Thread Lex Trotman
On 22 February 2014 04:50, Dimitar Zhekov dimitar.zhe...@gmail.com wrote: On Fri, 21 Feb 2014 16:52:51 +0100 Colomban Wendling lists@herbesfolles.org wrote: [...] OK, I didn't think it was OK to assume GCC was the compiler, It isn't, indeed. Although well, to be fair we probably

Re: [Geany-Devel] Plugins Quality Check

2014-02-21 Thread Matthew Brush
On 14-02-21 11:54 AM, Lex Trotman wrote: On 22 February 2014 04:50, Dimitar Zhekov dimitar.zhe...@gmail.com wrote: On Fri, 21 Feb 2014 16:52:51 +0100 Colomban Wendling lists@herbesfolles.org wrote: [...] OK, I didn't think it was OK to assume GCC was the compiler, It isn't, indeed.

Re: [Geany-Devel] Plugins Quality Check

2014-02-20 Thread Colomban Wendling
Le 20/02/2014 09:07, Lex Trotman a écrit : [...] geanygendoc - 2 warnings, extra switch case may be consequential, unused function [...] Unused functions and variables are probably inconsequential, unless they are the result of a typo in the code meant to use them, they need a quick check

Re: [Geany-Devel] Plugins Quality Check

2014-02-20 Thread Matthew Brush
On 14-02-20 12:07 AM, Lex Trotman wrote: Hi All, On the off chance that we might be converging on a release I did a compile of the plugins with the usual options (-Wall -Wextra -Wno-unused-paratemers). This was on GTK2 since many still don't work for GTK3. The results are not too bad really

Re: [Geany-Devel] Plugins Quality Check

2014-02-20 Thread Lex Trotman
On 21 February 2014 02:02, Colomban Wendling lists@herbesfolles.org wrote: Le 20/02/2014 09:07, Lex Trotman a écrit : [...] geanygendoc - 2 warnings, extra switch case may be consequential, unused function [...] Unused functions and variables are probably inconsequential, unless they

Re: [Geany-Devel] Plugins Quality Check

2014-02-20 Thread Lex Trotman
[...] Well, the same as for code written by humans, the C compiler warning is telling us something *might* be wrong with the code. The Vala compiler may have bugs, so such things need checking the same as manual code, to avoid possible UB. If, as in these cases, it seems to be ok, then its just