Re: [Geany-Devel] Win32 color chooser dialog removal, concerning the Pull Request #215

2014-03-05 Thread Enrico Tröger
On 04/03/14 16:41, Matthew Brush wrote: On 14-03-04 06:57 AM, Steven VALSESIA wrote: Hi everybody ! I copy-paste a code that belong to Peter Scholtens that add an apply button to the color chooser. But to make that code useful to windows users, and make the code more maintainable, I

Re: [Geany-Devel] Win32 color chooser dialog removal, concerning the Pull Request #215

2014-03-05 Thread Matthew Brush
On 14-03-05 12:14 PM, Enrico Tröger wrote: On 04/03/14 16:41, Matthew Brush wrote: On 14-03-04 06:57 AM, Steven VALSESIA wrote: Hi everybody ! I copy-paste a code that belong to Peter Scholtens that add an apply button to the color chooser. But to make that code useful to windows users, and

Re: [Geany-Devel] Win32 color chooser dialog removal, concerning the Pull Request #215

2014-03-05 Thread Steven VALSESIA
IMO, it should follow the use_win32_native_dialogs (or whatever) preference at least, like the other native win32 dialogs. But, I see no point in completely removing it while leaving all the other win32 native dialogs in there, it seems kind of an arbitrary change. I follow that setting, but

[Geany-Devel] Win32 color chooser dialog removal, concerning the Pull Request #215

2014-03-04 Thread Steven VALSESIA
Hi everybody ! I copy-paste a code that belong to Peter Scholtens that add an apply button to the color chooser. But to make that code useful to windows users, and make the code more maintainable, I choose to remove the Win32 API window dialog and put the Gtk's one ! Does someone know why that

Re: [Geany-Devel] Win32 color chooser dialog removal, concerning the Pull Request #215

2014-03-04 Thread Matthew Brush
On 14-03-04 06:57 AM, Steven VALSESIA wrote: Hi everybody ! I copy-paste a code that belong to Peter Scholtens that add an apply button to the color chooser. But to make that code useful to windows users, and make the code more maintainable, I choose to remove the Win32 API window dialog and