Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-07-08 Thread Colomban Wendling
Le 29/06/2015 10:24, Thomas Martitz a écrit : […] That helps only existing users, and only that fraction that actually reads release notes (I would think the bulk of them doesn't). Perhaps it would be indeed best to not toggle the default for this release already? Makes sense to me, and

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-29 Thread Matthew Brush
On 2015-06-29 02:24 AM, Lex Trotman wrote: On 29 June 2015 at 18:24, Thomas Martitz ku...@rockbox.org wrote: Am 29.06.2015 um 00:32 schrieb Lex Trotman: On 29 June 2015 at 07:41, Colomban Wendling lists@herbesfolles.org wrote: Le 26/06/2015 07:22, Thomas Martitz a écrit : […]

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-29 Thread Lex Trotman
On 29 June 2015 at 18:24, Thomas Martitz ku...@rockbox.org wrote: Am 29.06.2015 um 00:32 schrieb Lex Trotman: On 29 June 2015 at 07:41, Colomban Wendling lists@herbesfolles.org wrote: Le 26/06/2015 07:22, Thomas Martitz a écrit : […] However, as we entered string freeze, I don't

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-29 Thread Thomas Martitz
Am 29.06.2015 um 00:32 schrieb Lex Trotman: On 29 June 2015 at 07:41, Colomban Wendling lists@herbesfolles.org wrote: Le 26/06/2015 07:22, Thomas Martitz a écrit : […] However, as we entered string freeze, I don't suppose a new dialog like this is acceptable at this point? It would be

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-28 Thread Thomas Martitz
Am 26.06.2015 um 07:22 schrieb Thomas Martitz: Hello, I hacked up a document message to inform the user about this new behavior, see attached screenshot. However, as we entered string freeze, I don't suppose a new dialog like this is acceptable at this point? What else can we do for *this*

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-28 Thread Colomban Wendling
Le 26/06/2015 07:22, Thomas Martitz a écrit : […] However, as we entered string freeze, I don't suppose a new dialog like this is acceptable at this point? It would be really better not to indeed? What else can we do for *this* release? Hum. If this is an important enough issue, I can

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-28 Thread Lex Trotman
On 29 June 2015 at 07:41, Colomban Wendling lists@herbesfolles.org wrote: Le 26/06/2015 07:22, Thomas Martitz a écrit : […] However, as we entered string freeze, I don't suppose a new dialog like this is acceptable at this point? It would be really better not to indeed? What else can

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-25 Thread Thomas Martitz
Hello, I hacked up a document message to inform the user about this new behavior, see attached screenshot. However, as we entered string freeze, I don't suppose a new dialog like this is acceptable at this point? What else can we do for *this* release? Best regards

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-25 Thread Lex Trotman
[...] Right, makes some sense too. However, what to do in this case: the file is saved (clearing the red) and immediately reloaded? Make it red again or keep it clear? Well reload syncs file and buffer, so its cleared again. Seems right. [...] There is a various pref for the keep edit

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Thomas Martitz
Am 24.06.2015 um 22:26 schrieb Lex Trotman: I'm struggling to understand why there is any confusion, reload is an editing action just like any other and can be undone like any other. Seems much safer to me and exactly what to expect. It used to have a side effect that was unexpected and nasty

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Lex Trotman
On 25 June 2015 at 10:51, Matthew Brush mbr...@codebrainz.ca wrote: On 2015-06-24 05:47 PM, Lex Trotman wrote: [...] I wonder if there's a more simple way to reduce confusion and increase visibility other than an annoying dialog or document message. Maybe as a separate action with a

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Matthew Brush
On 2015-06-24 09:30 AM, Colomban Wendling wrote: Le 24/06/2015 17:04, Thomas Martitz a écrit : Hello I have just noticed that current git, by default, doesn't prompt anymore when reloading documents, even when they are changed. I traced it back to the $SUBJECT commit. IMO it's fine to keep

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Matthew Brush
On 2015-06-24 05:47 PM, Lex Trotman wrote: [...] I wonder if there's a more simple way to reduce confusion and increase visibility other than an annoying dialog or document message. Maybe as a separate action with a different name in the edit menu? Menu, what menu? I use the toolbar

[Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Thomas Martitz
Hello I have just noticed that current git, by default, doesn't prompt anymore when reloading documents, even when they are changed. I traced it back to the $SUBJECT commit. IMO it's fine to keep the undo history on reload and not prompt, but it's not fine if the file is currently modified

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Lex Trotman
On 25 June 2015 at 15:19, Thomas Martitz ku...@rockbox.org wrote: Am 25. Juni 2015 02:51:43 MESZ, schrieb Matthew Brush mbr...@codebrainz.ca: On 2015-06-24 05:47 PM, Lex Trotman wrote: [...] I wonder if there's a more simple way to reduce confusion and increase visibility other than an

Re: [Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

2015-06-24 Thread Thomas Martitz
Am 24.06.2015 um 18:30 schrieb Colomban Wendling: Le 24/06/2015 17:04, Thomas Martitz a écrit : Hello I have just noticed that current git, by default, doesn't prompt anymore when reloading documents, even when they are changed. I traced it back to the $SUBJECT commit. IMO it's fine to keep