Re: [Sugar-devel] Rationale behind the JSON -> CJSON switch in Sugar codebase?

2009-11-13 Thread Tomeu Vizoso
On Fri, Nov 13, 2009 at 12:01, Daniel Drake wrote: > On Fri, 2009-11-13 at 11:50 +0100, Tomeu Vizoso wrote: >> For past stable releases, deployers are the ones who should know best. >> If you are talking about 0.82, then we should go back to use >> simplejson. If this is 0.84 on F11, then we can u

Re: [Sugar-devel] Rationale behind the JSON -> CJSON switch in Sugar codebase?

2009-11-13 Thread Daniel Drake
On Fri, 2009-11-13 at 11:50 +0100, Tomeu Vizoso wrote: > For past stable releases, deployers are the ones who should know best. > If you are talking about 0.82, then we should go back to use > simplejson. If this is 0.84 on F11, then we can use what python 2.6 > provides. 0.82 doesn't have this bu

Re: [Sugar-devel] Rationale behind the JSON -> CJSON switch in Sugar codebase?

2009-11-13 Thread Tomeu Vizoso
2009/11/12 Lucian Branescu : > The json module (simplejson) has only the parser written in C, so it's > still slower overall than cjson. Not by a lot, but measurable. Well, we don't really care about overall slowness, but only if it's fast enough for our actual use of it. In this case, we only car

Re: [Sugar-devel] Rationale behind the JSON -> CJSON switch in Sugar codebase?

2009-11-13 Thread Lucian Branescu
I did a quick and not-so-scientific benchmark. The test involves a round trip for a small json file 10 times. cjson7.56759595871 simplejson-c 9.09944200516 simplejson-pure 58.1605060101 2009/11/13 Daniel Drake : > On Fri, 2009-11-13 at 10:53 +0100, Martin Langhoff wrote:

Re: [Sugar-devel] Rationale behind the JSON -> CJSON switch in Sugar codebase?

2009-11-13 Thread Daniel Drake
On Fri, 2009-11-13 at 10:53 +0100, Martin Langhoff wrote: > After a few tries, I did find that the same problem was reported in > Debian, a patch proposed, and upstream rejected it: > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=534709 > > As Tomeu mentions, Python 2.6 reduces the cjson/json p

Re: [Sugar-devel] Rationale behind the JSON -> CJSON switch in Sugar codebase?

2009-11-13 Thread Martin Langhoff
On Fri, Nov 13, 2009 at 10:39 AM, Daniel Drake wrote: > It would be worth a quick look at fixing cjson yourself. I am cheeky but I am not a C hacker. Looking around yesterday, I have not found a way to report bugs against cjson. The "project homepage" is the page of the company where the author w

Re: [Sugar-devel] Rationale behind the JSON -> CJSON switch in Sugar codebase?

2009-11-13 Thread Daniel Drake
On Fri, 2009-11-13 at 10:14 +0100, Martin Langhoff wrote: > On Thu, Nov 12, 2009 at 4:40 PM, Tomeu Vizoso wrote: > > Right now just using the json module in python 2.6 may be best as the > > parser is a C module (AFAIR). > > > > Is because of a bug in cjson why those files aren't being parsed? >

Re: [Sugar-devel] Rationale behind the JSON -> CJSON switch in Sugar codebase?

2009-11-12 Thread Lucian Branescu
The json module (simplejson) has only the parser written in C, so it's still slower overall than cjson. Not by a lot, but measurable. 2009/11/12 Martin Langhoff : > On Thu, Nov 12, 2009 at 4:59 PM, Martin Langhoff > wrote: >> Then maybe yes, I am seeing a bug in cjson that parses 'foo\/bar' >> i