Re: os-builder: could we roll a 1.3.1?

2011-03-11 Thread Daniel Drake
On 10 March 2011 23:17, Martin Langhoff wrote: > That's completely understood, and I meant to stay the heck away from > any risky changes. We're on the same page -- your changes read very > sane to me. OK. Pushed all that and the v1.3 branch changes. it just needs testing then we can do a 1.3.1 r

Re: os-builder: could we roll a 1.3.1?

2011-03-10 Thread Martin Langhoff
On Thu, Mar 10, 2011 at 3:56 PM, Daniel Drake wrote: > Sorry for the delayed response, I haven't had much OLPC time this week :( np - we're all busy! > I agree that all your changes are safe. I was just worried about the > general idea of allowing further commits after a released build. But > th

Re: os-builder: could we roll a 1.3.1?

2011-03-10 Thread Daniel Drake
On 3 March 2011 22:21, Martin Langhoff wrote: >  - Very clearly, the changes I am proposing do _not_ affect the build > of 10.1.3 -- they don't change the .ks file prep, or anything after. I > am happy to run test to verify Sorry for the delayed response, I haven't had much OLPC time this week :

Re: os-builder: could we roll a 1.3.1?

2011-03-09 Thread Martin Langhoff
On Thu, Mar 3, 2011 at 5:21 PM, Martin Langhoff wrote: > Ho-hum. Not convinced. Here's why: Nag nag. Would you consider 1.3.1? I've re-reviewed the patches. Some more reasons that a potential 1.3.1 is safe to recommend: - Many changes are in oats_cfg and custom_scripts, which are not used for

Re: os-builder: could we roll a 1.3.1?

2011-03-03 Thread Martin Langhoff
On Thu, Mar 3, 2011 at 2:18 PM, Daniel Drake wrote: > I'd take the patches from the master branch, slightly different from > the ones you propose. Sure -- I didn'tthink there was divergence, but I agree. Any divergence is bad. > suggested_oob_version for 10.1.3 would still say 1.3.0, meaning tha

Re: os-builder: could we roll a 1.3.1?

2011-03-03 Thread Daniel Drake
On 2 March 2011 13:56, Martin Langhoff wrote: > I normally use v1.3 with a bunch of patches on top, and they are so > useful I find myself telling deployments to use the same ones, and > thinking "I should roll an rpm to avoid them having issues > cherry-picking patches and stuff". > > Should we j

os-builder: could we roll a 1.3.1?

2011-03-02 Thread Martin Langhoff
Hi Daniel, I normally use v1.3 with a bunch of patches on top, and they are so useful I find myself telling deployments to use the same ones, and thinking "I should roll an rpm to avoid them having issues cherry-picking patches and stuff". Should we just prep a 1.3.1? Together with my bios-crypto