These values are currently unsupported for ssh disks, and in fact aren't
even parsed for ssh disks. So while this didn't result in any test
errors, we can remove them from the test input files.
Signed-off-by: Jonathon Jongsma
---
tests/qemuxml2argvdata/disk-network-ssh-key.xml | 4
When trying to start nbdkit-backed disks in backing chains, we were
accidentally always checking the private data of the top of the chain
instead of using the loop variable.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_nbdkit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Changes in v2
- patch 1 now includes the same patch for both start and stop storage source
functions
Jonathon Jongsma (2):
qemu: Fix bug in nbdkit-backed backing chains
tests: Remove readahead and timeout from ssh tests
src/qemu/qemu_nbdkit.c | 4 ++--
On 1/23/24 2:47 PM, Peter Krempa wrote:
On Tue, Jan 23, 2024 at 13:00:35 -0600, Jonathon Jongsma wrote:
From subject: v4?
Jonathon Jongsma (2):
qemu: Fix bug in nbdkit-backed backing chains
tests: Remove readahead and timeout from ssh tests
Reviewed-by: Peter Krempa
Oops re v4. I
On Tue, Jan 23, 2024 at 13:00:35 -0600, Jonathon Jongsma wrote:
From subject: v4?
> Jonathon Jongsma (2):
> qemu: Fix bug in nbdkit-backed backing chains
> tests: Remove readahead and timeout from ssh tests
Reviewed-by: Peter Krempa
___
Devel
When trying to start nbdkit-backed disks in backing chains, we were
accidentally always checking the private data of the top of the chain
instead of using the loop variable.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_nbdkit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
These values are currently unsupported for ssh disks, and in fact aren't
even parsed for ssh disks. So while this didn't result in any test
errors, we can remove them from the test input files.
Signed-off-by: Jonathon Jongsma
---
tests/qemuxml2argvdata/disk-network-ssh-key.xml | 4
Jonathon Jongsma (2):
qemu: Fix bug in nbdkit-backed backing chains
tests: Remove readahead and timeout from ssh tests
src/qemu/qemu_nbdkit.c | 2 +-
tests/qemuxml2argvdata/disk-network-ssh-key.xml | 4
On Tue, Jan 23, 2024 at 04:47:44PM +0100, Michal Prívozník wrote:
> On 1/23/24 10:45, Andrea Bolognani wrote:
> > On Fri, Jan 19, 2024 at 04:25:11PM +0100, Michal Privoznik wrote:
> >> +++ b/src/conf/domain_validate.c
> >> @@ -2315,7 +2316,10 @@ virDomainMemoryDefCheckConflict(const
> >>
On 1/23/24 10:45, Andrea Bolognani wrote:
> On Fri, Jan 19, 2024 at 04:25:11PM +0100, Michal Privoznik wrote:
>> +++ b/src/conf/domain_validate.c
>> @@ -2315,7 +2316,10 @@ virDomainMemoryDefCheckConflict(const
>> virDomainMemoryDef *mem,
>> if (thisStart == 0 || otherStart == 0)
>>
On Tue, Jan 23, 2024 at 03:18:42PM +0100, Peter Krempa wrote:
> As I've promised this part unifies the output file directories and
> unifies naming.
>
> Pipeline: https://gitlab.com/pipo.sk/libvirt/-/pipelines/1148227164
>
> git fetch https://gitlab.com/pipo.sk/libvirt.git test-qemuxmlconf-dirs
>
On a Tuesday in 2024, Peter Krempa wrote:
As I've promised this part unifies the output file directories and
unifies naming.
Pipeline: https://gitlab.com/pipo.sk/libvirt/-/pipelines/1148227164
git fetch https://gitlab.com/pipo.sk/libvirt.git test-qemuxmlconf-dirs
Peter Krempa (6):
Remove leftover output files. The list of files was identified by
temporarily hacking testConfXMLEnumerate to also enumerate
'tests/qemuxml2xmloutdata' directory.
Signed-off-by: Peter Krempa
---
...arch64-virt-virtio-MMIO.aarch64.latest.xml | 63
Include also the output files in the validation of used files.
Signed-off-by: Peter Krempa
---
tests/qemuxmlconftest.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c
index c3acfb59d5..cb19e7b27d 100644
---
Populate the output filename strings only when the files are expected to
exist, so that other logic can be based on the presence of the strings
rather than having to re-check the test flags for expected state.
Signed-off-by: Peter Krempa
---
tests/qemuxmlconftest.c | 13 +
1 file
There's plenty symlinks in qemuxml2argvdata and qemuxml2xmlout
directories pointing to other files in the same directory. It makes no
sense to check those files twice, thus we can simply skip symlinks.
Signed-off-by: Peter Krempa
---
tests/virschematest.c | 4
1 file changed, 4
On Fri, Jan 19, 2024 at 04:25:11PM +0100, Michal Privoznik wrote:
> +++ b/src/conf/domain_validate.c
> @@ -2315,7 +2316,10 @@ virDomainMemoryDefCheckConflict(const
> virDomainMemoryDef *mem,
> if (thisStart == 0 || otherStart == 0)
> continue;
>
> -if (thisStart <=
Division between integers will also be integer.
Thus, to preserve fractional part explicitly
convert first operand to double.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 28d54aab05 ("examples: Introduce domtop")
Signed-off-by: Egor Makrushin
---
On 1/17/24 19:40, Thomas Huth wrote:
For consistency we should drop the names with a "+" in it in the
long run.
Signed-off-by: Thomas Huth
Reviewed-by: Harsh Prateek Bora
---
docs/about/deprecated.rst | 9 +
1 file changed, 9 insertions(+)
diff --git
On 1/17/24 19:40, Thomas Huth wrote:
The character "+" is now forbidden in QOM device names (see commit
b447378e1217 - "Limit type names to alphanumerical and some few special
characters"). For the "power5+" and "power7+" CPU names, there is
currently a hack in type_name_is_valid() to still
* Philippe Mathieu-Daudé (phi...@linaro.org) wrote:
> This command has been deprecated before the 8.1 release,
> in commit e9ccfdd91d ("hmp: Add 'one-insn-per-tb' command
> equivalent to 'singlestep'"). Time to drop it.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan
In commit 4af3cbafdd0e31c5c5b20d57c4aaeb19efcb98bc
(Laine Stump , Tue Jul 31 14:36:51 2012 -0400)
the return -1 was removed and since then
virNetDevVPortProfileFormat() always returns 0,
so it is possible to make this function void
and remove return value checks.
Found by Linux Verification
22 matches
Mail list logo
