On 06/03/2024 10.53, Zhao Liu wrote:
From: Zhao Liu
Currentlt, it was allowed for users to specify the unsupported
s/Currentlt/Currently/
topology parameter as "1". For example, x86 PC machine doesn't
support drawer/book/cluster topology levels, but user could specify
"-smp
Hi Martin,
On 3/6/24 04:41, Martin Kletzander wrote:
On Mon, Mar 04, 2024 at 03:54:23PM -0600, Michael Galaxy wrote:
Hi Martin,
Answers inline. Thanks for helping with the review and all the tips!
On 3/1/24 04:00, Martin Kletzander wrote:
On Mon, Jan 29, 2024 at 04:43:53PM -0500,
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
PCMachineClass::acpi_data_size was only used by the pc-i440fx-2.0
machine, which got removed. Since it is constant, replace the class
field by a definition.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 4
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
X86CPU::kvm_no_smi_migration was only used by the
pc-i440fx-2.3 machine, which got removed. Remove it
and simplify kvm_put_vcpu_events().
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.h | 3 ---
target/i386/cpu.c | 2 --
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
The pc-i440fx-2.2 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
AcpiBuildState::rsdp is always NULL, remove it,
simplifying acpi_build_update().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/acpi-build.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Thomas Huth
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
PCMachineClass::rsdp_in_ram was only used by the
pc-i440fx-2.2 machine, which got removed. It is
now always true. Remove it, simplifying acpi_setup().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 1 -
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
PCMachineClass::resizable_acpi_blob was only used by the
pc-i440fx-2.2 machine, which got removed. It is now always
true. Remove it, simplifying acpi_build().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 3 ---
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
The pc-i440fx-2.1 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
'legacy_align' is always NULL, remove it, simplifying
memory_device_pre_plug().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/mem/memory-device.h | 2 +-
hw/i386/pc.c | 3 +--
hw/mem/memory-device.c | 12
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
'legacy_align' is always NULL, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/mem/pc-dimm.h | 3 +--
hw/arm/virt.c| 2 +-
hw/i386/pc.c | 2 +-
hw/loongarch/virt.c | 2 +-
hw/mem/pc-dimm.c
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
PCMachineClass::enforce_aligned_dimm was only used by the
pc-i440fx-2.1 machine, which got removed. It is now always
true. Remove it, simplifying pc_get_device_memory_range().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h |
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
PCMachineClass::smbios_uuid_encoded was only used by the
pc-i440fx-2.1 machine, which got removed. It is now always
true, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 1 -
hw/i386/fw_cfg.c | 2 +-
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
x86_cpu_change_kvm_default() was only used out of kvm-cpu.c by
the pc-i440fx-2.1 machine, which got removed. Inline it, and
s/Inline/Make it static/ ?
(since it is not a real inlining here)
remove its declaration. "kvm-cpu.h" is now empty,
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
The pc-i440fx-2.0 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
PCMachineClass::legacy_acpi_table_size was only used by the
pc-i440fx-2.0 machine, which got removed. Remove it and simplify
acpi_build().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 1 -
hw/i386/acpi-build.c | 60
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
XHCI_FLAG_SS_FIRST was only used by the pc-i440fx-2.0 machine,
which got removed. Remove it and simplify various functions in
hcd-xhci.c.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/hcd-xhci.h | 1 -
hw/usb/hcd-xhci-nec.c | 2 --
On 2/29/24 16:23, Ján Tomko wrote:
> From: Zheng Yan
>
> The new virDomainGraphicsReload API is used to make the domain reload
> its certificates without restart, and avoid service interruption.
>
> Currently, only QEMU VNC TLS certificates are supported, but parameters and
> flags are also
On 2/29/24 16:23, Ján Tomko wrote:
> Signed-off-by: Ján Tomko
> ---
> src/remote/remote_driver.c | 1 +
> src/remote/remote_protocol.x | 13 -
> src/remote_protocol-structs | 6 ++
> 3 files changed, 19 insertions(+), 1 deletion(-)
Ah yes, perks of faster compilation with
On 2/29/24 16:23, Ján Tomko wrote:
> From: Zheng Yan
>
> The 'display-reload' QMP command had been introduced from QEMU 6.0.0:
>
> https://gitlab.com/qemu-project/qemu/-/commit/9cc07651655ee86eca41059f5ead8c4e5607c734
>
> Currently it only supports reloading TLS certificates for VNC.
>
>
On 2/29/24 16:23, Ján Tomko wrote:
> https://issues.redhat.com/browse/RHEL-16333
>
> Based on the patches Huawei sent back in 2021:
> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/LDTM3NIOBWCS2USQSHXEKASHJHDVPNDG/
> * rebased
> * renamed
> * simplified (removed
On 2/29/24 16:23, Ján Tomko wrote:
> From: Zheng Yan
>
> The 'display-reload' QMP command had been introduced from QEMU 6.0.0:
>
> https://gitlab.com/qemu-project/qemu/-/commit/9cc07651655ee86eca41059f5ead8c4e5607c734
>
> Currently it only supports reloading TLS certificates for VNC.
>
>
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
XHCI_FLAG_FORCE_PCIE_ENDCAP was only used by the
pc-i440fx-2.0 machine, which got removed. Remove it
and simplify usb_xhci_pci_realize().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/hcd-xhci.h | 1 -
hw/usb/hcd-xhci-nec.c | 2 --
Hi Zhao,
On 6/3/24 14:27, Zhao Liu wrote:
Hi Philippe,
On Tue, Mar 05, 2024 at 02:42:04PM +0100, Philippe Mathieu-Daudé wrote:
Date: Tue, 5 Mar 2024 14:42:04 +0100
From: Philippe Mathieu-Daudé
Subject: [PATCH-for-9.1 02/18] hw/usb/hcd-xhci: Enumerate xhci_flags
setting values
X-Mailer:
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
The pc-i440fx-2.3 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
On Tue, Feb 27, 2024 at 05:36:02PM +0100, Peter Krempa wrote:
> This patchset removes the use of '-usb' legacy controller specification.
>
> For the vast majority of platforms/machines (most of the irrelevant
> ones) which don't actually have a concept of implicit USB qemu ignores
> the '-usb'
The "acpi" feature is not part of the specification[1],
so it will just get ignored.
[1]
https://gitlab.com/qemu-project/qemu/-/blob/master/docs/interop/firmware.json
Signed-off-by: Andrea Bolognani
---
.../usr/share/qemu/firmware/50-edk2-loongarch64.json | 1 -
1 file changed, 1
On Mon, Mar 04, 2024 at 03:54:23PM -0600, Michael Galaxy wrote:
Hi Martin,
Answers inline. Thanks for helping with the review and all the tips!
On 3/1/24 04:00, Martin Kletzander wrote:
On Mon, Jan 29, 2024 at 04:43:53PM -0500, mgal...@akamai.com wrote:
From: Michael Galaxy
In our case,
From: Zhao Liu
Currentlt, it was allowed for users to specify the unsupported
topology parameter as "1". For example, x86 PC machine doesn't
support drawer/book/cluster topology levels, but user could specify
"-smp drawers=1,books=1,clusters=1".
This is meaningless and confusing, so that the
From: Zhao Liu
The "parameter=0" SMP configurations have been marked as deprecated
since v6.2.
For these cases, -smp currently returns the warning and adjusts the
zeroed parameters to 1 by default.
Remove the above compatibility logic in v9.0, and return error directly
if any -smp parameter is
On Wed, Mar 06, 2024 at 10:19:41AM +0530, Prasad Pandit wrote:
> Date: Wed, 6 Mar 2024 10:19:41 +0530
> From: Prasad Pandit
> Subject: Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0"
> SMP configurations
>
> Hello Zhao,
>
> On Wed, 6 Mar 2024 at 08:49, Zhao Liu wrote:
> >>
Hello Zhao,
On Wed, 6 Mar 2024 at 08:49, Zhao Liu wrote:
>> then checking 'config->has_maxcpus ?' above is probably not required I
>> think. It could just be
>>
>>maxcpus = config->maxcpus
>
> Yes.
>
> > If a user does not specify config->maxcpus with -smp option, then it
> > could default
Apparently, if you change the commit message, patchew doesn't pick up v2
and mark the v1 as old (O). Sorry for the inconvenience if there is a patch,
with a changed commit message [1], please ignore it and consider the
present one.
[1]
Hi Prasad,
> On Tue, 5 Mar 2024 at 12:59, Zhao Liu wrote:
> > After simple test, if user sets maxcpus as 0, the has_maxcpus will be
> > true as well...I think it's related with QAPI code generation logic.
>
> * Right.
>
> [Maybe we digressed a bit in the discussion, so I snipped much of the
>
34 matches
Mail list logo
