[PATCH 02/35] virshtest: Allow to test failure of commands

2024-03-22 Thread Peter Krempa
Modify the test code so that if virsh fails both 'stdout' and 'stderr' are captured and compared against the output and also the return value is checked by appending it to the output. Signed-off-by: Peter Krempa --- tests/virshtest.c | 23 --- 1 file changed, 12

[PATCH 01/35] virshtest: Prepare for testing against output files

2024-03-22 Thread Peter Krempa
Modify testCompareOutputLit to take a filename argument and compare it against and populate the arguments. For tests which don't use the 'data' from virTestRun, we'll expect to pass the output filename, thus we also propagate it. Signed-off-by: Peter Krempa --- build-aux/syntax-check.mk | 6

Re: [PATCH] qemuDomainChangeNet: Error when boot index changes in live XML

2024-03-22 Thread Ján Tomko
On a Friday in 2024, Adam Julis wrote: If the original code detected a missing or null boot index in the new XML, it automatically added the current value. This autocompletion was incorrect because it was impossible to distinguish between user intent and user error - changing the This is also

Re: [PATCH] virsysinfo: Try reading DMI table

2024-03-22 Thread Kristina Hanicova
Hello, On Mon, Mar 18, 2024 at 11:30 PM wrote: > From: Brett Holman > > The SMBIOS specification[1] includes RISC-V and mips, and some systems have > SMBIOS info. Attempt to read dmidecode and fall back to old behavior if > that > fails. > > [1] >

Re: [PATCH v3 01/12] cpu_map: update script to handle versioned CPUs

2024-03-22 Thread Jim Fehlig
On 3/22/24 04:54, Daniel P. Berrangé wrote: On Mon, Mar 04, 2024 at 10:35:25AM -0700, Jim Fehlig wrote: On 3/1/24 10:13, Daniel P. Berrangé wrote: On Fri, Mar 01, 2024 at 10:36:12AM -0600, Jonathon Jongsma wrote: On 3/1/24 10:13 AM, Daniel P. Berrangé wrote: On Tue, Feb 20, 2024 at

Re: [PATCH 3/3] nodedev: reset active config data on udev remove event

2024-03-22 Thread Boris Fiuczynski
On 3/21/24 16:28, Jonathon Jongsma wrote: +void +nodeDeviceDefResetMdevActiveConfig(virNodeDeviceDef *def) +{ +    size_t i = 0; +    virMediatedDeviceConfig *active_config; + +    if (def->caps->data.type != VIR_NODE_DEV_CAP_MDEV) +    return; + +    active_config =

Re: [PATCH v3 01/12] cpu_map: update script to handle versioned CPUs

2024-03-22 Thread Daniel P . Berrangé
On Mon, Mar 04, 2024 at 10:35:25AM -0700, Jim Fehlig wrote: > On 3/1/24 10:13, Daniel P. Berrangé wrote: > > On Fri, Mar 01, 2024 at 10:36:12AM -0600, Jonathon Jongsma wrote: > > > On 3/1/24 10:13 AM, Daniel P. Berrangé wrote: > > > > On Tue, Feb 20, 2024 at 05:08:02PM -0700, Jim Fehlig wrote: > >

Re: [PATCH] qemuDomainChangeNet: Error when boot index changes in live XML

2024-03-22 Thread Michal Prívozník
On 3/22/24 09:12, Adam Julis wrote: > If the original code detected a missing or null boot index in the > new XML, it automatically added the current value. This > autocompletion was incorrect because it was impossible to > distinguish between user intent and user error - changing the > boot order

[PATCH] qemuDomainChangeNet: Error when boot index changes in live XML

2024-03-22 Thread Adam Julis
If the original code detected a missing or null boot index in the new XML, it automatically added the current value. This autocompletion was incorrect because it was impossible to distinguish between user intent and user error - changing the boot order itself is forbidden and should always be an

Re: [PATCH 0/2] NEWS: Mention loongarch64 guest support

2024-03-22 Thread Michal Prívozník
On 3/21/24 15:41, Andrea Bolognani wrote: > Plus a random fix. > > Andrea Bolognani (2): > NEWS: Fix spacing > NEWS: Mention loongarch64 guest support > > NEWS.rst | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > Reviewed-by: Michal Privoznik Michal

Re: [PATCH 0/2] Add 'display' and 'ramfb' option for pci hostdevs

2024-03-22 Thread Michal Prívozník
On 3/19/24 23:25, Jonathon Jongsma wrote: > see https://issues.redhat.com/browse/RHEL-28808 > > Jonathon Jongsma (2): > conf: allow display and ramfb for vfio pci hostdevs > qemu: enable display/ramfb for vfio pci hostdevs > > docs/formatdomain.rst | 8 >