Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-04-10 Thread Peter Xu
On Wed, Apr 10, 2024 at 02:28:59AM +, Zhijian Li (Fujitsu) via wrote: > > > on 4/10/2024 3:46 AM, Peter Xu wrote: > > >> Is there document/link about the unittest/CI for migration tests, Why > >> are those tests missing? > >> Is it hard or very special to set up an environment for that?

Re: [PATCH] qemu: Add sysusers config file for qemu & kvm user/groups

2024-04-10 Thread tim
Good catch. I've tried to look at fixing this but this requires meson knowledge that I don't have so I haven't been able to focus on it yet. Pointers appreciated. ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to

Re: [RFC PATCH 1/2] node_device_conf: virNodeDeviceGetSCSITargetCaps: fix memory leak

2024-04-10 Thread Marc Hartmayer
On Wed, Apr 10, 2024 at 09:42 AM +0200, Ján Tomko wrote: > On a Tuesday in 2024, Marc Hartmayer wrote: >>On Thu, Mar 28, 2024 at 03:55 PM +0100, Ján Tomko wrote: >>> On a Wednesday in 2024, Marc Hartmayer wrote: Make sure the old value in `scsi_target->wwpn` is free'd before replacing

Re: [PATCH RFC 00/12] Support throttle block filters

2024-04-10 Thread Chun Feng Wu
Thanks Peter for your quick response! I will fix the issues you listed On 2024/4/10 16:08, Peter Krempa wrote: On Tue, Apr 09, 2024 at 20:13:08 -0700, w...@linux.ibm.com wrote: From: Chun Feng Wu Hi, I am thinking to leverage "throttle block filter" in QEMU to support more flexible I/O

Re: [PATCH RFC 00/12] Support throttle block filters

2024-04-10 Thread Peter Krempa
On Tue, Apr 09, 2024 at 20:13:08 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > Hi, > > I am thinking to leverage "throttle block filter" in QEMU to support more > flexible I/O limits(e.g. tiered I/O groups), one sample provided by QEMU doc > is: >

Re: [RFC PATCH 1/2] node_device_conf: virNodeDeviceGetSCSITargetCaps: fix memory leak

2024-04-10 Thread Ján Tomko
On a Tuesday in 2024, Marc Hartmayer wrote: On Thu, Mar 28, 2024 at 03:55 PM +0100, Ján Tomko wrote: On a Wednesday in 2024, Marc Hartmayer wrote: Make sure the old value in `scsi_target->wwpn` is free'd before replacing it. While at it, simplify the code. "While at it" usually means it