I addressed those comments in v2
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/5Z3J4SSEFWPZGN436HUGP2M6G4NPCWNW/
On 2024/4/10 16:08, Peter Krempa wrote:
On Tue, Apr 09, 2024 at 20:13:08 -0700, w...@linux.ibm.com wrote:
From: Chun Feng Wu
Hi,
I am thinking to
From: Hao Ning Xin
Both throttlegroup and iotune share the same fields, so they share the same
verification logic
Signed-off-by: Hao Ning Xin
---
src/conf/domain_validate.c | 98 +-
1 file changed, 64 insertions(+), 34 deletions(-)
diff --git
From: Chun Feng Wu
* Add new cmds: throttlegroupset, throttlegrouplist, throttlegroupinfo,
throttlegroupdel
* Update "attach_disk" to support new option: throttle-groups to
form filter chain in QEMU for specific disk
Signed-off-by: Chun Feng Wu
---
tools/virsh-completer-domain.c | 64
From: Yan Xiu Wu
No need to use both "iotune" and "throttlefilters" for specific disk
Signed-off-by: Yan Xiu Wu
---
src/conf/domain_validate.c | 8
src/qemu/qemu_driver.c | 6 ++
2 files changed, 14 insertions(+)
diff --git a/src/conf/domain_validate.c
From: Chun Feng Wu
* Test "Set": testDomainSetThrottleGroup
* Test "Get": testDomainGetThrottleGroup
* Test "Del": testDomainDelThrottleGroup
Signed-off-by: Chun Feng Wu
---
src/test/test_driver.c | 382 +
1 file changed, 382 insertions(+)
diff --git
From: Chun Feng Wu
Within "testQemuMonitorJSONqemuMonitorJSONUpdateThrottleGroup"
* Test qemuMonitorJSONGetThrottleGroup
* Test qemuMonitorJSONUpdateThrottleGroup, which updates limits through
"qom-set"
Signed-off-by: Chun Feng Wu
---
tests/qemumonitorjsontest.c | 88
From: Chun Feng Wu
* Add new elements '' and ''
* contains defintions
* can include multiple throttlegroup references to form
filter chain in qemu
* Chained throttle filters feature in qemu is described at
https://github.com/qemu/qemu/blob/master/docs/throttle.txt
Signed-off-by: Chun Feng
From: Chun Feng Wu
When attaching disk along with specified throttle groups, those groups will be
chained up by parent node name, this change includes service side codes:
* Each filter references one throttle group by group name
* Each filter has a nodename, and those filters are chained up in
From: Chun Feng Wu
* Add qemuBuildThrottleGroupCommandLine in qemuBuildCommandLine
* Add qemuBuildThrottleFiltersCommandLine in qemuBuildDiskCommandLine
* Make sure referenced throttle group exists
Signed-off-by: Chun Feng Wu
---
src/conf/domain_validate.c | 14 ++
src/qemu/qemu_command.c
From: Chun Feng Wu
Implement the following methods:
* virDomainSetThrottleGroup
* virDomainGetThrottleGroup
* virDomainDelThrottleGroup
Signed-off-by: Chun Feng Wu
---
src/qemu/qemu_domain.c | 14 ++
src/qemu/qemu_domain.h | 4 +
src/qemu/qemu_driver.c | 523
From: Chun Feng Wu
Support throttlegroup lifecycle management by the following implementation:
* New methods defined in "include/libvirt/libvirt-domain.h"
* And they're exported in "src/libvirt_public.syms"
* Corresponding internal API is defined in "src/driver-hypervisor.h"
* Public API calls
From: Chun Feng Wu
* ThrottleGroup is updated through "qemuMonitorJSONUpdateThrottleGroup"
* ThrottleGroup is retrieved through "qemuMonitorJSONGetThrottleGroup"
* ThrottleGroup is deleted by reusing "qemuMonitorDelObject"
* ThrottleGroup is added by reusing "qemuMonitorAddObject"
*
From: Chun Feng Wu
* Define new structs 'virDomainThrottleGroupDef' and
'virDomainThrottleFilterDef'
* Update _virDomainDef to include virDomainThrottleGroupDef
* Update _virDomainDiskDef to include virDomainThrottleFilterDef
* Support new resource operations for DOM XML and structs,
From: Chun Feng Wu
Hi,
I am thinking to leverage "throttle block filter" in QEMU to support more
flexible I/O limits(e.g. tiered I/O groups), one sample provided by QEMU doc is:
https://github.com/qemu/qemu/blob/master/docs/throttle.txt
"For example, let's say that we have three different
Allow generation of command line for virtio-sound-pci and virtio-sound-device
devices along with additional virtio options.
A new testcase is added to test virtio-sound-pci. The
arm-vexpressa9-virtio testcase is also extended to test virtio-sound-device.
Signed-off-by: Rayhan Faizel
---
This patch adds parsing of the virtio sound model, along with parsing
of virtio options and PCI/virtio-mmio address assignment.
A new 'streams' attribute is added for configuring number of PCM streams
(default is 2) in virtio sound devices. QEMU additionally has jacks and chmaps
parameters but
Signed-off-by: Rayhan Faizel
---
src/qemu/qemu_capabilities.c | 3 +++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml | 1 +
virtio-sound-pci and virtio-sound-device were recently introduced
in QEMU 8.2.0.
The full documentation of the virtio sound implementation in QEMU
can be found here:
https://www.qemu.org/docs/master/system/devices/virtio-snd.html
Example:
[Changes in v2]
- Added missing break statement that
Makes sens and also adding the prefix to the other three attributes you
mentioned in you follow up email.
To all four...
Reviewed-by: Boris Fiuczynski
On 4/3/24 16:03, Marc Hartmayer wrote:
The new thread name makes it easier to understand the purpose of the thread.
Signed-off-by: Marc
Reviewed-by: Boris Fiuczynski
On 4/3/24 16:03, Marc Hartmayer wrote:
Since @driver->privateData is modified take the lock.
Question: In theory we could take the udevEventData->mdevctlLock?
Isn't that protecting the access to the mdevctlMonitor?
On the first sight scheduleMdevctlUpdate does
Reviewed-by: Boris Fiuczynski
On 4/3/24 16:03, Marc Hartmayer wrote:
Commit a99d876a0f58 ("node_device: Use automatic mutex management") replaced the
locking mechanism and accidentally removed the comment with the reason why the
lock is taken. Restore this comment and add a new comment about
Reviewed-by: Boris Fiuczynski
On 4/3/24 16:03, Marc Hartmayer wrote:
It is done a little differently everywhere in libvirt, but most common is to
test for != -1.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 7 ---
1 file changed, 4 insertions(+), 3
Reviewed-by: Boris Fiuczynski
On 4/3/24 16:03, Marc Hartmayer wrote:
Remove the timeout when the udevEventData is disposed, analogous to priv->watch.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
Allow generation of command line for virtio-sound-pci and virtio-sound-device
devices along with additional virtio options.
A new testcase is added to test virtio-sound-pci. The
arm-vexpressa9-virtio testcase is also extended to test virtio-sound-device.
Signed-off-by: Rayhan Faizel
---
This patch adds parsing of the virtio sound model, along with parsing
of virtio options and PCI/virtio-mmio address assignment.
A new 'streams' attribute is added for configuring number of PCM streams
(default is 2) in virtio sound devices. QEMU additionally has jacks and chmaps
parameters but
virtio-sound-pci and virtio-sound-device were recently introduced
in QEMU 8.2.0.
The full documentation of the virtio sound implementation in QEMU
can be found here:
https://www.qemu.org/docs/master/system/devices/virtio-snd.html
Example:
Rayhan Faizel (3):
qemu_capabilities: Add
Signed-off-by: Rayhan Faizel
---
src/qemu/qemu_capabilities.c | 3 +++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml | 1 +
On Wed, Apr 10, 2024 at 09:49:15AM -0400, Peter Xu wrote:
> On Wed, Apr 10, 2024 at 02:28:59AM +, Zhijian Li (Fujitsu) via wrote:
> >
> >
> > on 4/10/2024 3:46 AM, Peter Xu wrote:
> >
> > >> Is there document/link about the unittest/CI for migration tests, Why
> > >> are those tests
28 matches
Mail list logo
