Re: [PATCH 3/3] qemu_command: Generate mem-reserve for controllers

On Mon, Apr 15, 2024 at 10:53:18AM +0200, Michal Privoznik wrote: > +++ b/src/qemu/qemu_command.c > @@ -2776,6 +2776,7 @@ qemuBuildControllerPCIDevProps(virDomainControllerDef > *def, > if (virJSONValueObjectAdd(, >"s:driver", modelName, >

Re: [PATCH 2/3] qemu_validate: Restrict setting @memReserve only to some controllers

On Mon, Apr 15, 2024 at 10:53:17AM +0200, Michal Privoznik wrote: > Only two controller models allow setting mem-reserve: > pcie-root-port and pci-bridge. Reflect this fact during > validation. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_validate.c | 25 + >

Re: [PATCH 1/3] conf: Introduce @memReserve to

On Mon, Apr 15, 2024 at 10:53:16AM +0200, Michal Privoznik wrote: > +++ b/docs/formatdomain.rst > @@ -4153,6 +4153,12 @@ generated by libvirt. :since:`Since 1.2.19 (QEMU > only)`. > ``index`` > pci-root controllers for pSeries guests use this attribute to record the > order they will

VHPC'24 - 19th Virtualization in High-Performance Cloud Computing Workshop - Call for Papers

VHPC'24: August 26th-27th, Madrid, Spain, co-located with Euro-Par 2024. Papers due: May 6th. The Workshop on Virtualization in High-Performance Cloud Computing (VHPC) aims to bring together researchers and industrial practitioners facing the challenges

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

Hello Peter und Zhjian, Thank you so much for letting me know about this. I'm also a bit surprised at the plan for deprecating the RDMA migration subsystem. > IMHO it's more important to know whether there are still users and whether > they would still like to see it around. > I admit RDMA

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

> 1) Either a CI test covering at least the major RDMA paths, or at least > periodically tests for each QEMU release will be needed. We use a batch of regression test cases for the stack, which covers the test for QEMU. I did such test for most of the QEMU releases planned as candidates for

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

Hi Peter, On Tue, Apr 9, 2024 at 9:47 PM Peter Xu wrote: > > On Tue, Apr 09, 2024 at 09:32:46AM +0200, Jinpu Wang wrote: > > Hi Peter, > > > > On Mon, Apr 8, 2024 at 6:18 PM Peter Xu wrote: > > > > > > On Mon, Apr 08, 2024 at 04:07:20PM +0200, Jinpu Wang wrote: > > > > Hi Peter, > > > > > >

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

on 4/10/2024 3:46 AM, Peter Xu wrote: >> Is there document/link about the unittest/CI for migration tests, Why >> are those tests missing? >> Is it hard or very special to set up an environment for that? maybe we >> can help in this regards. > See tests/qtest/migration-test.c. We put most of

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

Hi Peter, On Mon, Apr 8, 2024 at 6:18 PM Peter Xu wrote: > > On Mon, Apr 08, 2024 at 04:07:20PM +0200, Jinpu Wang wrote: > > Hi Peter, > > Jinpu, > > Thanks for joining the discussion. > > > > > On Tue, Apr 2, 2024 at 11:24 PM Peter Xu wrote: > > > > > > On Mon, Apr 01, 2024 at 11:26:25PM

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

Hi Peter, On Tue, Apr 2, 2024 at 11:24 PM Peter Xu wrote: > > On Mon, Apr 01, 2024 at 11:26:25PM +0200, Yu Zhang wrote: > > Hello Peter und Zhjian, > > > > Thank you so much for letting me know about this. I'm also a bit surprised > > at > > the plan for deprecating the RDMA migration

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

Phil, on 3/29/2024 6:28 PM, Philippe Mathieu-Daudé wrote: >> >> >>> IMHO it's more important to know whether there are still users and >>> whether >>> they would still like to see it around. >> >> Agree. >> I didn't immediately express my opinion in V1 because I'm also >> consulting our >>

[PATCH 3/3] qemu_command: Generate mem-reserve for controllers

Pretty straightforward. Just put mem-reserve attribute whenever it's set. Previous commit ensures it's set only for valid controller models. Resolves: https://issues.redhat.com/browse/RHEL-7461 Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 3 +++

[PATCH 2/3] qemu_validate: Restrict setting @memReserve only to some controllers

Only two controller models allow setting mem-reserve: pcie-root-port and pci-bridge. Reflect this fact during validation. Signed-off-by: Michal Privoznik --- src/qemu/qemu_validate.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/qemu/qemu_validate.c

[PATCH 1/3] conf: Introduce @memReserve to

There are PCI devices with pretty large non-prefetchable memory, for instance: Memory at 9d80 (64-bit, non-prefetchable) [size=8M] Memory at a680 (64-bit, non-prefetchable) [size=16K] For cold plugged devices this is not a problem, because firmware sets PCI controllers in a way that

[PATCH 0/3] Allow reserving more memory for PCI controllers

This is a rebased version I've posted a while ago: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/DFQXPLJGZK72W3JOEDQAY52VDCYYIJRH/ Michal Prívozník (3): conf: Introduce @memReserve to qemu_validate: Restrict setting @memReserve only to some controllers

[PATCH] domain_interface: Fix build on FreeBSD

In one of my recent commits I've chopped just too much and moved a variable declaration into a function not realizing it's still used on FreeBSD. Bring it back but only for the FreeBSD case. Fixes: f8b5bd855f8312457fd9ad8a68fb044982bd3cc6 Signed-off-by: Michal Privoznik --- Pushed as build