On Wed, Apr 17, 2024 at 1:54 AM Jiri Denemark wrote:
> Ages ago origCPU in domain private data was introduced to provide
> backward compatibility when migrating to an old libvirt, which did not
> support fetching updated CPU definition from QEMU. Thus origCPU will
> contain the original CPU defin
The pc-i440fx-2.3 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
docs/about/deprecated.rst | 4 ++--
docs/about/removed-features.rst
The pc-i440fx-2.2 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Reviewed-by: Zhao Liu
---
docs/about/deprecated.rst
The pc-i440fx-2.1 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Reviewed-by: Zhao Liu
---
docs/about/deprecated.rst
The pc-i440fx-2.0 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Reviewed-by: Zhao Liu
---
docs/about/deprecated.rst
Similarly to the commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated",
deprecate the 2.4 to 2.12 machines.
Suggested-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Reviewed-by: Zhao Liu
---
docs/about/deprecated.rst | 4 +
Signed-off-by: Jiri Denemark
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index c108e66f46..852dadf532 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -21,6 +21,14 @@ v10.3.0 (unreleased)
* **Bug fixes**
+ * qemu: Fix migration with custom XML
+
+
Ages ago origCPU in domain private data was introduced to provide
backward compatibility when migrating to an old libvirt, which did not
support fetching updated CPU definition from QEMU. Thus origCPU will
contain the original CPU definition before such update. But only if the
update actually chang
Jiri Denemark (2):
qemu: Fix migration with custom XML
NEWS: Mention migration bug with custom XML
NEWS.rst| 8
src/qemu/qemu_domain.c | 38 +-
src/qemu/qemu_process.c | 14 ++
3 files changed, 31 insertions(+), 29 del
On 16/04/2024 16.49, Philippe Mathieu-Daudé wrote:
On 16/4/24 16:23, Thomas Huth wrote:
On 16/04/2024 15.52, Philippe Mathieu-Daudé wrote:
Similarly to the commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated",
deprecate the 2.4 to 2.7 machines.
Suggested
On a Tuesday in 2024, Jiri Denemark wrote:
The only thing we need to free in the cleanup code is virCPUDef and for
that we already have g_autoptr handler.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_process.c | 25 ++---
1 file changed, 10 insertions(+), 15 deletions(-)
The only thing we need to free in the cleanup code is virCPUDef and for
that we already have g_autoptr handler.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_process.c | 25 ++---
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/q
On 16/4/24 16:23, Thomas Huth wrote:
On 16/04/2024 15.52, Philippe Mathieu-Daudé wrote:
Similarly to the commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated",
deprecate the 2.4 to 2.7 machines.
Suggested-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Da
On 16/04/2024 15.52, Philippe Mathieu-Daudé wrote:
Similarly to the commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated",
deprecate the 2.4 to 2.7 machines.
Suggested-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
docs/about/deprecated.rst |
The pc-i440fx-2.3 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
docs/about/deprecated.rst | 4 ++--
docs/about/removed-features.rst
The pc-i440fx-2.2 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-13-phi...@linaro.or
The pc-i440fx-2.1 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-7-phi...@linaro.org
The pc-i440fx-2.0 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-2-phi...@linaro.org
Similarly to the commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated",
deprecate the 2.4 to 2.7 machines.
Suggested-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
docs/about/deprecated.rst | 4 ++--
hw/i386/pc_piix.c | 2 +-
2 files cha
On 28/3/24 05:10, Zhao Liu wrote:
Hi Philippe,
On Wed, Mar 27, 2024 at 10:51:23AM +0100, Philippe Mathieu-Daudé wrote:
Date: Wed, 27 Mar 2024 10:51:23 +0100
From: Philippe Mathieu-Daudé
Subject: [PATCH-for-9.1 v2 21/21] hw/i386/pc: Replace
PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE
On 27/3/24 12:32, David Hildenbrand wrote:
On 27.03.24 10:51, Philippe Mathieu-Daudé wrote:
'legacy_align' is always NULL, remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20240305134221.30924-11-phi...@linaro.org>
---
I was really confused for a second
On 28/3/24 03:54, Zhao Liu wrote:
On Wed, Mar 27, 2024 at 10:51:14AM +0100, Philippe Mathieu-Daudé wrote:
Date: Wed, 27 Mar 2024 10:51:14 +0100
From: Philippe Mathieu-Daudé
Subject: [PATCH-for-9.1 v2 12/21] hw/i386/pc: Remove
PCMachineClass::enforce_aligned_dimm
X-Mailer: git-send-email 2.41.
On Tue, Apr 16, 2024 at 12:58:53PM +0200, Ján Tomko wrote:
> On a Tuesday in 2024, Daniel P. Berrangé wrote:
> > The typed parameter array must be either 0, or a positive
> > number.
> >
>
> Does this matter?
>
> The API documentation says:
> * @nparams: pointer to received number of interface
On a Tuesday in 2024, Daniel P. Berrangé wrote:
The typed parameter array must be either 0, or a positive
number.
Does this matter?
The API documentation says:
* @nparams: pointer to received number of interface parameter
and it looks like we ignore the number as long as params is NULL.
Ja
The typed parameter array must be either 0, or a positive
number.
Signed-off-by: Daniel P. Berrangé
---
src/libvirt-network.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/libvirt-network.c b/src/libvirt-network.c
index ef17a8a04d..e467716b6a 100644
--- a/src/libvirt-network.c
+++ b/
Reviewed-by: Boris Fiuczynski
On 4/12/24 15:36, Marc Hartmayer wrote:
Inline `udevRemoveOneDevice` as it's used only once.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/src/node_de
On 4/12/24 15:36, Marc Hartmayer wrote:
Use a worker pool for processing the udev events and the initialization instead
of a separate initThread and a mdevctl-thread. This has the large advantage that
we can leverage the job API and now this thread pool is responsible to do all
the "costly-work"
Reviewed-by: Boris Fiuczynski
On 4/12/24 15:36, Marc Hartmayer wrote:
There is only one case where force is true, therefore let's inline that case.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 25 +++--
1 file changed, 11 insertions(+), 14 dele
Reviewed-by: Boris Fiuczynski
On 4/12/24 15:36, Marc Hartmayer wrote:
There is no reason to serialize the `mdevctl list` calls.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/node_device/nod
29 matches
Mail list logo
