[PATCH v2] docs: ensure HTML/images are built before running reference tests

2024-05-08 Thread Daniel P . Berrangé
The 'check-html-references' test will process the built HTML files, so they must exist before it is run, along with any images that they point to. If using the older 'configure_file' command, no changes are needed since that always gets executed at 'meson setup' time, rather than at 'meson

Re: [PATCH v2 1/3] tools: Introduce SSH proxy

2024-05-08 Thread Daniel P . Berrangé
On Tue, May 07, 2024 at 01:08:00PM +0200, Michal Privoznik wrote: > This allows users to SSH into a domain with a VSOCK device: > > ssh user@qemu/machineName > > So far, only QEMU domains are supported AND qemu:///system is > looked for the first for 'machineName' followed by >

Re: [PATCH v2] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead

2024-05-08 Thread Thomas Huth
On 08/05/2024 15.20, Claudio Fontana wrote: On 5/6/24 13:20, Thomas Huth wrote: The old "-runas" option has the disadvantage that it is not visible in the QAPI schema, so it is not available via the normal introspection mechanisms. We've recently introduced the "-run-with" option for exactly

Re: [PATCH v2] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead

2024-05-08 Thread Claudio Fontana
On 5/6/24 13:20, Thomas Huth wrote: > The old "-runas" option has the disadvantage that it is not visible > in the QAPI schema, so it is not available via the normal introspection > mechanisms. We've recently introduced the "-run-with" option for exactly > this purpose, which is meant to handle

Re: [PATCH 2/2] tests: fix two off-by-1 errors in read-big-pipe test

2024-05-08 Thread Andrea Bolognani
On Wed, May 08, 2024 at 01:11:31PM GMT, Daniel P. Berrangé wrote: > When testPipeFeeder copies the XML document into the padded buffer, it > tells virStrcpy that 'xmlsize' bytes are available. This is under > reporting size by 1 byte, and as a result it fails to copy the trailing > '\n' replacing

Re: [PATCH 1/2] tests: fix hang in virshtest 'read-big-pipe' case

2024-05-08 Thread Andrea Bolognani
On Wed, May 08, 2024 at 01:11:30PM GMT, Daniel P. Berrangé wrote: > * On ppc64, testPipeFeeder opens R+W, tries to write 140kb >and write() succeeds because the larger 64kb page size >resulted in greater buffer capacity for the pipe. It thus >quickly closes the pipe, removing the

[PATCH 1/2] tests: fix hang in virshtest 'read-big-pipe' case

2024-05-08 Thread Daniel P . Berrangé
The virshtest program testPipeFeeder method is doing this: mkfifo("test.fifo", 0600) ; int fd = open("test.fifo", O_RDWR); char buf[...]; memset(buf, 'a', sizeof(buf)); write(fd, buf, sizeof(buf)) == sizeof(buf)); close(fd); while the the 'virsh' child process then ends up doing:

[PATCH 2/2] tests: fix two off-by-1 errors in read-big-pipe test

2024-05-08 Thread Daniel P . Berrangé
When testPipeFeeder copies the XML document into the padded buffer, it tells virStrcpy that 'xmlsize' bytes are available. This is under reporting size by 1 byte, and as a result it fails to copy the trailing '\n' replacing it when '\0'. The return value of virStrcpy wasn't checked, but was

[PATCH 0/2] tests: fix very subtle bugs in 'read-big-pipe'

2024-05-08 Thread Daniel P . Berrangé
Daniel P. Berrangé (2): tests: fix hang in virshtest 'read-big-pipe' case tests: fix two off-by-1 errors in read-big-pipe test tests/virshtest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.43.0 ___ Devel mailing list --

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-08 Thread Daniel P . Berrangé
On Tue, May 07, 2024 at 06:52:50AM +0200, Jinpu Wang wrote: > Hi Peter, hi Daniel, > On Mon, May 6, 2024 at 5:29 PM Peter Xu wrote: > > > > On Mon, May 06, 2024 at 12:08:43PM +0200, Jinpu Wang wrote: > > > Hi Peter, hi Daniel, > > > > Hi, Jinpu, > > > > Thanks for sharing this test results.

[PATCH] docs: Add nanoseconds units for vcpu.delay doc

2024-05-08 Thread Assaf Admi
Submitted https://gitlab.com/libvirt/libvirt/-/merge_requests/352: Add nanoseconds units for vcpu.delay doc, as it's based on /proc//task//schedstat, according to https://gitlab.com/libvirt/libvirt/-/blob/master/src/qemu/qemu_driver.c#L1288. schedstat is in nanoseconds units, according to