Re: [PATCH] Pass shutoff reason to release hook

2024-06-18 Thread Swapnil Ingle
On 18.06.24 10:53, Michal Prívozník wrote: !---| CAUTION: External Email |---! On 6/3/24 16:10, Swapnil Ingle wrote: Sometimes in release hook it is useful to

[PATCH v2] Pass shutoff reason to release hook

2024-06-18 Thread Swapnil Ingle
Sometimes in release hook it is useful to know if the VM shutdown was graceful or not. This is especially useful to do cleanup based on the VM shutdown failure reason in release hook. This patch proposes to use the last argument 'extra' to pass VM shutoff reason in the call to release hook. Making

Re: [PATCH] qemu: add support for qemu switchover-ack

2024-06-18 Thread Jon Kohler
> On Jun 18, 2024, at 11:14 AM, Daniel P. Berrangé wrote: > > !---| > CAUTION: External Email > > |---! > > On Tue, Jun 18, 2024 at 08:06:06AM -0700, Jon Kohler

Plans for 10.5.0 release (freeze on Tuesday 25 Jun)

2024-06-18 Thread Jiri Denemark
We are getting close to 10.5.0 release of libvirt. To aim for the release on Monday 01 Jul I suggest entering the freeze on Tuesday 25 Jun and tagging RC2 on Thursday 27 Jun. I hope this works for everyone. Jirka

Re: [PATCH] qemu: add support for qemu switchover-ack

2024-06-18 Thread Daniel P . Berrangé
On Tue, Jun 18, 2024 at 08:06:06AM -0700, Jon Kohler wrote: > Add plumbing for QEMU's switchover-ack migration capability, which > helps lower the downtime during VFIO migrations. This capability is > enabled by default as long as both the source and destination support > it. > > Note:

[PATCH] qemu: add support for qemu switchover-ack

2024-06-18 Thread Jon Kohler
Add plumbing for QEMU's switchover-ack migration capability, which helps lower the downtime during VFIO migrations. This capability is enabled by default as long as both the source and destination support it. Note: switchover-ack depends on the return path capability, so this may not be used when

Re: [PATCH] qemu: Don't specify vfio-pci.ramfb when ramfb is false

2024-06-18 Thread Jonathon Jongsma
ping On 6/13/24 9:50 AM, Jonathon Jongsma wrote: Commit 7c8e606b64c73ca56d7134cb16d01257f39c53ef attempted to fix the specification of the ramfb property for vfio-pci devices, but it failed when ramfb is explicitly set to 'off'. This is because only the 'vfio-pci-nohotplug' device supports the

Re: [PATCH v2 00/20] node_dev_udev: use workerpool and improve nodedev events

2024-06-18 Thread Jonathon Jongsma
On 6/18/24 6:33 AM, Boris Fiuczynski wrote: On 6/13/24 11:14 PM, Jonathon Jongsma wrote: On 6/13/24 6:13 AM, Marc Hartmayer wrote: On Tue, Apr 23, 2024 at 08:08 PM +0200, Marc Hartmayer wrote: When an udev event occurs for a mediated device (mdev) the mdev config data requires an update via

Re: [PATCH v2 00/20] node_dev_udev: use workerpool and improve nodedev events

2024-06-18 Thread Boris Fiuczynski
On 6/13/24 11:14 PM, Jonathon Jongsma wrote: On 6/13/24 6:13 AM, Marc Hartmayer wrote: On Tue, Apr 23, 2024 at 08:08 PM +0200, Marc Hartmayer wrote: When an udev event occurs for a mediated device (mdev) the mdev config data requires an update via mdevctl as the udev event does not contain

Re: [PATCH 2/2] qemu: implement iommu coldplug/unplug

2024-06-18 Thread Michal Prívozník
On 6/18/24 11:56, Adam Julis wrote: > Resolves: https://issues.redhat.com/browse/RHEL-23833 > Signed-off-by: Adam Julis > --- > src/qemu/qemu_driver.c | 20 ++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c >

Re: [PATCH 0/2] qemu: implement iommu coldplug/unplug

2024-06-18 Thread Michal Prívozník
On 6/18/24 11:56, Adam Julis wrote: > Adam Julis (2): > syms: Properly export virDomainIOMMUDefFree() > qemu: implement iommu coldplug/unplug > > src/libvirt_private.syms | 1 + > src/qemu/qemu_driver.c | 20 ++-- > 2 files changed, 19 insertions(+), 2 deletions(-) >

Re: [PATCH v2] ci: fix CI package list and refresh with 'lcitool manifest'

2024-06-18 Thread Michal Prívozník
On 6/18/24 11:53, Daniel P. Berrangé wrote: > The ci/manifest.yml file references a package 'libclang-rt-dev' that > does not exist in libvirt-ci mappings.yml. The latest refresh in > > commit 0759cf3fa6ed8d12bd327c5752785c53e35c8483 > Author: Michal Prívozník > Date: Fri May 3 15:58:20

[PATCH 2/2] qemu: implement iommu coldplug/unplug

2024-06-18 Thread Adam Julis
Resolves: https://issues.redhat.com/browse/RHEL-23833 Signed-off-by: Adam Julis --- src/qemu/qemu_driver.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 67b9778c67..74d5e3bb86 100644 ---

[PATCH 1/2] syms: Properly export virDomainIOMMUDefFree()

2024-06-18 Thread Adam Julis
While the function is exported via header, the symbol itself was not. Signed-off-by: Adam Julis --- src/libvirt_private.syms | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 653c84a520..8d760aca04 100644 --- a/src/libvirt_private.syms

[PATCH 0/2] qemu: implement iommu coldplug/unplug

2024-06-18 Thread Adam Julis
Adam Julis (2): syms: Properly export virDomainIOMMUDefFree() qemu: implement iommu coldplug/unplug src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 20 ++-- 2 files changed, 19 insertions(+), 2 deletions(-) -- 2.45.0

[PATCH v2] ci: fix CI package list and refresh with 'lcitool manifest'

2024-06-18 Thread Daniel P . Berrangé
The ci/manifest.yml file references a package 'libclang-rt-dev' that does not exist in libvirt-ci mappings.yml. The latest refresh in commit 0759cf3fa6ed8d12bd327c5752785c53e35c8483 Author: Michal Prívozník Date: Fri May 3 15:58:20 2024 +0200 ci: Introduce Ubuntu 24.04 was

Re: [PATCH v2 20/20] node_device_udev: remove incorrect G_GNUC_UNUSED

2024-06-18 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 4/23/24 8:09 PM, Marc Hartmayer wrote: Signed-off-by: Marc Hartmayer --- src/node_device/node_device_udev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index

Re: [PATCH] Pass shutoff reason to release hook

2024-06-18 Thread Michal Prívozník
On 6/3/24 16:10, Swapnil Ingle wrote: > Sometimes in release hook it is useful to know if the VM shutdown was graceful > or not. This is especially useful to do cleanup based on the VM shutdown > failure > reason in release hook. This patch proposes to use the last argument 'extra' > to pass VM

Re: [PATCH v2 1/4] tests: Add TPM coverage to default-models tests

2024-06-18 Thread Andrea Bolognani
On Tue, Jun 18, 2024 at 11:57:49AM GMT, lixianglai wrote: > Hi Andrea: > > We have a non-trivial amount of architecture-specific logic > > dealing with TPM, so it's good to have coverage for it. > > > > Note that two architectures currently don't have support for > > TPM devices enabled by default

Re: [PATCH 2/2] qemu: implement iommu coldplug/unplug

2024-06-18 Thread Michal Prívozník
I can't find 1/2 anywhere. Is it lost? Judging from the code below I believe it contained code to export virDomainIOMMUDefFree(), didn't it. On 6/17/24 16:26, Adam Julis wrote: > Resolves: https://issues.redhat.com/browse/RHEL-23833 > Signed-off-by: Adam Julis > --- > src/qemu/qemu_driver.c |

Re: [PATCH] conf: add validation of potential dependencies

2024-06-18 Thread Michal Prívozník
On 6/17/24 15:51, Adam Julis wrote: > Although existing virDomainDefPostParse is called after modifying > the XML and it contains validating process for changed device, > the virDomainDefValidate function performs a more comprehensive > check. It should detect errors resulting from dependencies >