[PATCH] NEWS: Document features/improvements/bug fixes I've participated in

2024-07-29 Thread Michal Privoznik
There are some features/improvements/bug fixes I've either contributed or reviewed/merged. Document them for upcoming release. Signed-off-by: Michal Privoznik --- NEWS.rst | 34 ++ 1 file changed, 34 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 17335b3f6e

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Jason Wang
On Tue, Jul 30, 2024 at 11:29 AM Akihiko Odaki wrote: > > On 2024/07/30 12:17, Jason Wang wrote: > > On Tue, Jul 30, 2024 at 11:12 AM Akihiko Odaki > > wrote: > >> > >> On 2024/07/30 12:03, Jason Wang wrote: > >>> On Tue, Jul 30, 2024 at 10:57 AM Akihiko Odaki > >>> wrote: > > On 202

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Akihiko Odaki
On 2024/07/30 12:17, Jason Wang wrote: On Tue, Jul 30, 2024 at 11:12 AM Akihiko Odaki wrote: On 2024/07/30 12:03, Jason Wang wrote: On Tue, Jul 30, 2024 at 10:57 AM Akihiko Odaki wrote: On 2024/07/30 11:04, Jason Wang wrote: On Tue, Jul 30, 2024 at 12:43 AM Akihiko Odaki wrote: On 2024

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Jason Wang
On Tue, Jul 30, 2024 at 11:12 AM Akihiko Odaki wrote: > > On 2024/07/30 12:03, Jason Wang wrote: > > On Tue, Jul 30, 2024 at 10:57 AM Akihiko Odaki > > wrote: > >> > >> On 2024/07/30 11:04, Jason Wang wrote: > >>> On Tue, Jul 30, 2024 at 12:43 AM Akihiko Odaki > >>> wrote: > > On 202

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Akihiko Odaki
On 2024/07/30 12:03, Jason Wang wrote: On Tue, Jul 30, 2024 at 10:57 AM Akihiko Odaki wrote: On 2024/07/30 11:04, Jason Wang wrote: On Tue, Jul 30, 2024 at 12:43 AM Akihiko Odaki wrote: On 2024/07/29 23:29, Peter Xu wrote: On Mon, Jul 29, 2024 at 01:45:12PM +0900, Akihiko Odaki wrote: On

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Jason Wang
On Tue, Jul 30, 2024 at 10:57 AM Akihiko Odaki wrote: > > On 2024/07/30 11:04, Jason Wang wrote: > > On Tue, Jul 30, 2024 at 12:43 AM Akihiko Odaki > > wrote: > >> > >> On 2024/07/29 23:29, Peter Xu wrote: > >>> On Mon, Jul 29, 2024 at 01:45:12PM +0900, Akihiko Odaki wrote: > On 2024/07/29

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Akihiko Odaki
On 2024/07/30 11:04, Jason Wang wrote: On Tue, Jul 30, 2024 at 12:43 AM Akihiko Odaki wrote: On 2024/07/29 23:29, Peter Xu wrote: On Mon, Jul 29, 2024 at 01:45:12PM +0900, Akihiko Odaki wrote: On 2024/07/29 12:50, Jason Wang wrote: On Sun, Jul 28, 2024 at 11:19 PM Akihiko Odaki wrote: On

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Jason Wang
On Tue, Jul 30, 2024 at 12:43 AM Akihiko Odaki wrote: > > On 2024/07/29 23:29, Peter Xu wrote: > > On Mon, Jul 29, 2024 at 01:45:12PM +0900, Akihiko Odaki wrote: > >> On 2024/07/29 12:50, Jason Wang wrote: > >>> On Sun, Jul 28, 2024 at 11:19 PM Akihiko Odaki > >>> wrote: > > On 2024/07

[RFC PATCH v4 5/5] tests: Added tests for eBPF blob loading.

2024-07-29 Thread Andrew Melnychenko
Added net-virtio-rss-bpf to qemuxmlconf's test. Synthetically modified caps-9.0.0 with a reply. Added mock functions for loading eBPF. Signed-off-by: Andrew Melnychenko Fixed Tests for 9.1.0 Added tests for SPARK Fixed issue with ident Signed-off-by: Andrew Melnychenko --- tests/qemuxml2argv

[RFC PATCH v4 2/5] qemu_capabilities: Added logic for retrieving eBPF objects from QEMU.

2024-07-29 Thread Andrew Melnychenko
eBPF objects stored in the hash table during runtime. eBPF objects cached encoded in base64 in the .xml cache file. Signed-off-by: Andrew Melnychenko --- src/qemu/qemu_capabilities.c | 130 src/qemu/qemu_capabilities.h | 4 + .../caps_9.0.0_sparc.

[RFC PATCH v4 4/5] qemu_command: Added "ebpf_rss_fds" support for virtio-net.

2024-07-29 Thread Andrew Melnychenko
Added new capability ebpf_rss_fds for QEMU. Added logic for loading the "RSS" eBPF program. eBPF file descriptors passed to the QEMU. Signed-off-by: Andrew Melnychenko --- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_co

[RFC PATCH v4 3/5] qemu_interface: Added routine for loading the eBPF objects.

2024-07-29 Thread Andrew Melnychenko
Also, added dependencies for libbpf with bpf option. Signed-off-by: Andrew Melnychenko --- libvirt.spec.in | 3 ++ meson.build | 7 meson_options.txt | 1 + src/qemu/meson.build | 1 + src/qemu/qemu_interface.c | 87 ++

[RFC PATCH v4 1/5] qemu_monitor: Added QEMU's "request-ebpf" support.

2024-07-29 Thread Andrew Melnychenko
Added code for monitor and monitor_json. The "request-ebpf" return's eBPF binary object encoded in base64. QEMU provides eBPF that can be loaded and passed to it from Libvirt. QEMU requires exact eBPF program/maps, so it can be retrieved using QAPI. To load eBPF program - administrative capabiliti

[RFC PATCH v4 0/5] Added virtio-net RSS with eBPF support.

2024-07-29 Thread Andrew Melnychenko
This series of rfc patches adds support for loading the RSS eBPF program and passing it to the QEMU. Comments and suggestions would be useful. QEMU with vhost may work with RSS through eBPF. To load eBPF, the capabilities required that Libvirt may provide. eBPF program and maps may be unique for p

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Daniel P . Berrangé
On Mon, Jul 29, 2024 at 01:00:30PM -0400, Peter Xu wrote: > On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: > > > > We've got two mutually conflicting goals with the machine type > > definitions. > > > > Primarily we use them to ensure stable ABI, but an important > > secondar

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Akihiko Odaki
On 2024/07/30 2:00, Peter Xu wrote: On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: On Fri, Jul 26, 2024 at 04:47:40PM -0400, Peter Xu wrote: On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: In terms of launching QEMU I'd imagine: $QEMU -machine pc-q

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Akihiko Odaki
On 2024/07/30 0:58, Daniel P. Berrangé wrote: On Fri, Jul 26, 2024 at 04:47:40PM -0400, Peter Xu wrote: On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: In terms of launching QEMU I'd imagine: $QEMU -machine pc-q35-9.1 -platform linux-6.9 ...args... Any virtual machine

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Peter Xu
On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 26, 2024 at 04:47:40PM -0400, Peter Xu wrote: > > On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: > > > > > > In terms of launching QEMU I'd imagine: > > > > > > $QEMU -machine pc-q35-9.1 -plat

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Akihiko Odaki
On 2024/07/29 23:29, Peter Xu wrote: On Mon, Jul 29, 2024 at 01:45:12PM +0900, Akihiko Odaki wrote: On 2024/07/29 12:50, Jason Wang wrote: On Sun, Jul 28, 2024 at 11:19 PM Akihiko Odaki wrote: On 2024/07/27 5:47, Peter Xu wrote: On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé w

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Daniel P . Berrangé
On Fri, Jul 26, 2024 at 04:47:40PM -0400, Peter Xu wrote: > On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: > > > > In terms of launching QEMU I'd imagine: > > > > $QEMU -machine pc-q35-9.1 -platform linux-6.9 ...args... > > > > Any virtual machine HW features which are tie

Re: [PATCH 8/8] qemu: migration: Don't remember seclabel for images shared from current host

2024-07-29 Thread Andrea Bolognani
On Mon, Jul 29, 2024 at 03:09:55PM GMT, Peter Krempa wrote: > On Fri, Jul 26, 2024 at 07:47:57 -0700, Andrea Bolognani wrote: > > For example, if the domain uses UEFI, local -> remote migration works > > but when attempting to migrate back I get > > > > error: Requested operation is not valid: Se

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Peter Xu
On Mon, Jul 29, 2024 at 01:45:12PM +0900, Akihiko Odaki wrote: > On 2024/07/29 12:50, Jason Wang wrote: > > On Sun, Jul 28, 2024 at 11:19 PM Akihiko Odaki > > wrote: > > > > > > On 2024/07/27 5:47, Peter Xu wrote: > > > > On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: > > >

Re: [PATCH] conf: Check for bandwidth limits during parsing

2024-07-29 Thread Peter Krempa
On Thu, Jul 04, 2024 at 13:02:46 +0200, Michal Privoznik wrote: > The 'tc' program stores speeds in 64bit integers (unit is bytes > per second) and sizes in uints (unit is bytes). We use different > units: kilobytes per second and kibibytes and therefore we can > parse values larger than 'tc' can h

Re: Arm CCA instance creation fails

2024-07-29 Thread Peter Krempa
On Mon, Jul 22, 2024 at 15:43:22 +0900, Itaru Kitayama wrote: > Hi, > > With the below virt-install options, I am trying to import a Realm VM: > > […] > export LIBVIRT_QEMU=/home/realm/qemu-system-aarch64 > > virt-install --machine=virt --arch=aarch64 --name=test8 --disk > path=/var/lib/libvirt

Re: [PATCH 8/8] qemu: migration: Don't remember seclabel for images shared from current host

2024-07-29 Thread Peter Krempa
On Fri, Jul 26, 2024 at 07:47:57 -0700, Andrea Bolognani wrote: > On Wed, Jul 24, 2024 at 05:34:32PM GMT, Peter Krempa wrote: > > +static void > > +qemuMigrationDstPrepareDiskSeclabels(virDomainObj *vm, > > + size_t nmigrate_disks, > > +

[PATCH 2/2] qemu: Pre-create pstore device file

2024-07-29 Thread Michal Privoznik
So far we are relying on QEMU or sysadmin to create the file for pstore. This is suboptimal as in the case of the former we can not set proper seclabels (there's nothing to set seclabels on until QEMU is started). Therefore, make sure the file is created before launching QEMU and that it has the c

[PATCH 1/2] qemu: Autofill pstore path if missing

2024-07-29 Thread Michal Privoznik
Introduced only a couple of commits ago (in v10.5.0-84-g90e50e67c6) the pstore device acts as a nonvolatile storage, where guest kernel can store information about crashes. This device, however, expects a file in the host from which the crash data is read. So far, we expected users to provide a pat

[PATCH for v10.6.0 0/2] qemu: Two pstore improvements

2024-07-29 Thread Michal Privoznik
These address Andrea's suggestion: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/EEIMDSBO7GPHXKXPWKRAI6MCUKHXQ3D2/ I know we've just entered freeze, but pstore is a new feature and it'd be nice to have these in. The first one is technically a feature, but the second one

Entering freeze for libvirt-10.6.0

2024-07-29 Thread Jiri Denemark
I have just tagged v10.6.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue