Re: [PATCH RFC v3 05/16] qemu: monitor: Add support for ThrottleGroup operations

2024-08-06 Thread Chun Feng Wu
let me confirm my understanding, do you mean there should be group name mapping between DOM($group_name_in_DOM) and QOM(throttle-$group_name_in_DOM) for both throttle group and throttle filter? if so, there seems two ways to achieve that: - mapping group_name in callers like qemu_driver.c, qem

Re: [PATCH RFC v3 02/16] schema: Add new domain elements to support multiple throttle filters

2024-08-06 Thread Chun Feng Wu
my original conclusion is based on the following test xml:   ...         200   200   limit0 1           250   250   limit1 1           300   300   limit2 1           400   400   limit012 1       ...                

Re: [PATCH] apparmor: Allow more paths for qemu-bridge-helper

2024-08-06 Thread Jim Fehlig via Devel
On 8/5/24 08:25, Andrea Bolognani wrote: The QEMU package in Debian has recently moved the qemu-bridge-helper binary under /usr/libexec/qemu. Update the AppArmor profile accordingly. https://bugs.debian.org/1077915 Signed-off-by: Andrea Bolognani --- src/security/apparmor/usr.sbin.libvirtd.i

[PATCH RESEND v2 0/4] multiple memory backend support for CPR Live Updates

2024-08-06 Thread Michael Galaxy via Devel
From: Michael Galaxy CPR-based support for whole-hypervisor kexec-based live updates is now finally merged into QEMU. In support of this, we need NUMA to be supported in these kinds of environments. To do this we use a technology called PMEM (persistent memory) in Linux, which underpins the abili

[PATCH RESEND v2 1/4] qemu.conf changes to support multiple memory backend

2024-08-06 Thread Michael Galaxy via Devel
From: Michael Galaxy We start by introducing a backwards-compatible, comma-separated specification that will not break existing installations, such as in the following example: $ cat qemu.conf | grep memory_backing_dir memory_backing_dir = ["/path/to/pmem/0", "/path/to/pmem/1"] (The old syntax

[PATCH RESEND v2 4/4] Update documentation to reflect memory_backing_dir change in qemu.conf

2024-08-06 Thread Michael Galaxy via Devel
From: Michael Galaxy Update the documentation and changelog accordingly to reflect that the syntax of the memory_backing_dir setting has changed. Signed-off-by: Michael Galaxy --- NEWS.rst| 7 +++ docs/kbase/virtiofs.rst | 2 ++ src/qemu/qemu.conf.in | 2 ++ 3 files chang

[PATCH RESEND v2 3/4] Update unit test to support multiple memory backends

2024-08-06 Thread Michael Galaxy via Devel
From: Michael Galaxy Update the associated test case. Signed-off-by: Michael Galaxy --- tests/testutilsqemu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index d70850cb5d..dd8db4835e 100644 --- a/tests/testutilsqemu.c +

[PATCH RESEND v2 2/4] Support live migration between file-backed memory and anonymous memory.

2024-08-06 Thread Michael Galaxy via Devel
From: Michael Galaxy In our environment, we need to convert VMs into a live-update-comptabile configuration "on-the-fly" (via live migration). More specifically: We need to convert between anonymous memory-backed VMs and file-backed memory VMs. So, for this very specific case, this needs to work

Re: [PATCH v2 4/4] Update documentation to reflect memory_backing_dir change in qemu.conf

2024-08-06 Thread Michael Galaxy via Devel
Hi, Acknowledged all. Thanks again for the instructions/review. - Michael On 8/6/24 07:44, Martin Kletzander wrote: On Wed, Jun 05, 2024 at 04:37:38PM -0400, mgal...@akamai.com wrote: From: Michael Galaxy Update the documentation and changelog accordingly to reflect that the syntax of the m

Re: [PATCH v2 3/4] Update unit test to support multiple memory backends

2024-08-06 Thread Michael Galaxy via Devel
Hi, On 8/6/24 07:41, Martin Kletzander wrote: On Wed, Jun 05, 2024 at 04:37:37PM -0400, mgal...@akamai.com wrote: From: Michael Galaxy Update the associated test case. This definitely needs to be part of the patch that changes this in qemu driver code as otherwise the compilation would fai

Re: [PATCH v2 2/4] Support live migration between file-backed memory and anonymous memory.

2024-08-06 Thread Michael Galaxy via Devel
Hi, On 8/6/24 07:38, Martin Kletzander wrote: On Wed, Jun 05, 2024 at 04:37:36PM -0400, mgal...@akamai.com wrote: From: Michael Galaxy     if (src->mem.source != dst->mem.source) { -    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, -   _("Target memoryBacking source '%1$

Re: [PATCH v2 1/4] qemu.conf changes to support multiple memory backend

2024-08-06 Thread Michael Galaxy via Devel
By the way, it took me a few hours to notice that you reviewed this. Thanks again. Please disregard my RESEND. Sorry for the noise! - Michael On 8/6/24 07:35, Martin Kletzander wrote: On Wed, Jun 05, 2024 at 04:37:35PM -0400, mgal...@akamai.com wrote: From: Michael Galaxy Hi, sorry for

Re: [PATCH v2 1/4] qemu.conf changes to support multiple memory backend

2024-08-06 Thread Michael Galaxy via Devel
Thank you so much for the detailed comments. I'll work on those. I believe you had a couple questions below on this one..inlined . On 8/6/24 07:35, Martin Kletzander wrote: On Wed, Jun 05, 2024 at 04:37:35PM -0400, mgal...@akamai.com wrote: From: Michael Galaxy + 

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-06 Thread Peter Xu
On Mon, Aug 05, 2024 at 04:27:43PM +0900, Akihiko Odaki wrote: > On 2024/08/04 22:08, Peter Xu wrote: > > On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote: > > > On 2024/08/03 1:26, Peter Xu wrote: > > > > On Sat, Aug 03, 2024 at 12:54:51AM +0900, Akihiko Odaki wrote: > > > > > > > > I

Re: [PATCH RESEND v2 0/4] multiple memory backend support for CPR Live Updates

2024-08-06 Thread Michael Galaxy via Devel
I'm so sorry, Martin. You literally JUST replied (this morning! so funny!) and I totally missed those emails. I will reply in the other thread. Please disregard this resend. - Michael On 8/6/24 15:32, mgal...@akamai.com wrote: From: Michael Galaxy CPR-based support for whole-hypervisor k

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-06 Thread Michael S. Tsirkin
On Tue, Aug 06, 2024 at 04:35:44PM +0900, Akihiko Odaki wrote: > On 2024/08/05 19:08, Michael S. Tsirkin wrote: > > On Mon, Aug 05, 2024 at 06:37:58PM +0900, Akihiko Odaki wrote: > > > If cross-migrate=off, QEMU can still migrate on the same host (checkpoint > > > and restart). QEMU can also migrat

Re: [PATCH v2 1/2] qemu_domain: Strip from s390(x) definitions

2024-08-06 Thread Peter Krempa
On Fri, Aug 02, 2024 at 09:34:54 +0200, Boris Fiuczynski wrote: > On 8/1/24 3:52 PM, Peter Krempa wrote: > > The s390(x) machines never supported ACPI. That didn't stop users > > enabling ACPI in their config. As of libvirt-9.2 (98c4e3d073) with new > > enough qemu we reject configs which require A

Re: [PATCH v2 4/4] Update documentation to reflect memory_backing_dir change in qemu.conf

2024-08-06 Thread Martin Kletzander
On Wed, Jun 05, 2024 at 04:37:38PM -0400, mgal...@akamai.com wrote: From: Michael Galaxy Update the documentation and changelog accordingly to reflect that the syntax of the memory_backing_dir setting has changed. Signed-off-by: Michael Galaxy --- NEWS.rst| 7 +++ docs/kbas

Re: [PATCH v2 3/4] Update unit test to support multiple memory backends

2024-08-06 Thread Martin Kletzander
On Wed, Jun 05, 2024 at 04:37:37PM -0400, mgal...@akamai.com wrote: From: Michael Galaxy Update the associated test case. This definitely needs to be part of the patch that changes this in qemu driver code as otherwise the compilation would fail between these patches and we require that the

Re: [PATCH v2 2/4] Support live migration between file-backed memory and anonymous memory.

2024-08-06 Thread Martin Kletzander
On Wed, Jun 05, 2024 at 04:37:36PM -0400, mgal...@akamai.com wrote: From: Michael Galaxy In our environment, we need to convert VMs into a live-update-comptabile configuration "on-the-fly" (via live migration). More specifically: We need to convert between anonymous memory-backed VMs and file-b

Re: [PATCH v2 1/4] qemu.conf changes to support multiple memory backend

2024-08-06 Thread Martin Kletzander
On Wed, Jun 05, 2024 at 04:37:35PM -0400, mgal...@akamai.com wrote: From: Michael Galaxy Hi, sorry for such a late reply and thank you for the patches. There are few things that need tweaking and the series does not apply cleanly, but fortunately there is only one conflict. Once needed adj

Re: [PATCH 00/12] Introduce SEV-SNP support

2024-08-06 Thread Daniel P . Berrangé
On Tue, Aug 06, 2024 at 11:46:13AM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 21, 2024 at 12:06:01PM +0200, Michal Prívozník wrote: > > On 6/20/24 17:19, Jonathon Jongsma wrote: > > > On 6/20/24 6:22 AM, Michal Privoznik wrote: > > >> SEV-SNP support just landed in QEMU. Here is the first round

Re: [PATCH 1/3] Makefile: `make check` now computes env variable on the fly

2024-08-06 Thread Ján Tomko
For repos other than the main 'libvirt' repo, we use merge requests on GitLab. On a Monday in 2024, Ariel Otilibili wrote: * env variable used to be Python3.6 * Python3.6 is end of life since December 2021 [1]. [1] https://devguide.python.org/versions/ Signed-off-by: Ariel Otilibili --- Makef

Re: [PATCH 00/12] Introduce SEV-SNP support

2024-08-06 Thread Daniel P . Berrangé
On Fri, Jun 21, 2024 at 12:06:01PM +0200, Michal Prívozník wrote: > On 6/20/24 17:19, Jonathon Jongsma wrote: > > On 6/20/24 6:22 AM, Michal Privoznik wrote: > >> SEV-SNP support just landed in QEMU. Here is the first round of patches > >> to incorporate support into libvirt. > >> > >> TODOs (aka p

Re: [PATCH V2 0/4] Rework qemu internal active snapshots to use QMP

2024-08-06 Thread Nikolai Barybin via Devel
On 7/17/24 20:21, Nikolai Barybin wrote: Den, Peter, Daniel thank you for your comments! I'm sending v2 of this patchset. Changes since last revision: - dropped [PATCH 4/4] qemu monitor: reap qemu_monitor_text - added new patch: qemu capabilities: add QEMU_CAPS_SNAPSHOT_SAVE/_DELETE - preser

Re: [PATCH RFC v3 02/16] schema: Add new domain elements to support multiple throttle filters

2024-08-06 Thread Peter Krempa
On Tue, Aug 06, 2024 at 00:27:58 -, Chun Feng Wu wrote: Please keep the context in the reply. I had to check back what I've asked. > The order of such ``throttlefilter`` doesn't matter within > ``throttlefilters``. So IIUC, re-ordering of the filters doesn't have any guest-OS visible impact

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-06 Thread Akihiko Odaki
On 2024/08/05 19:08, Michael S. Tsirkin wrote: On Mon, Aug 05, 2024 at 06:37:58PM +0900, Akihiko Odaki wrote: If cross-migrate=off, QEMU can still migrate on the same host (checkpoint and restart). QEMU can also migrate across hosts if the user ensures they are on the same platform. What is so

[PATCH] network: fix crashing "modify" option for hostname

2024-08-06 Thread Adam Julis
The original condition caused (after adding modify option) possibly access to not allocated memory. For consistency added new check for multiple same records. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/654 Signed-off-by: Adam Julis --- src/conf/network_conf.c | 9 - 1 file cha

[PATCH] network: NULL check for "modify" DNS-txt records

2024-08-06 Thread Adam Julis
The "modify" command allowed to replace an existing record, now checks for the NULL string in the new value and throw error if found. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/655 Signed-off-by: Adam Julis --- src/conf/network_conf.c | 7 +++ 1 file changed, 7 insertions(+) diff