Re: [PATCH RFC v3 09/16] qemu: hotplug: Support hot attach and detach block disk along with throttle filters

2024-08-14 Thread Chun Feng Wu
On 2024/8/9 22:04, Peter Krempa wrote: On Wed, Jun 12, 2024 at 03:02:17 -0700,w...@linux.ibm.com wrote: From: Chun Feng Wu When attaching disk along with specified throttle groups, those groups will be chained up by parent node name, this change includes service side codes: * Each filter ref

Re: [PATCH 0/2] add NIC hotplug support to test hypervisor

2024-08-14 Thread John Levon
On Thu, Aug 01, 2024 at 12:47:39PM +0100, John Levon wrote: > These two patches add basic support for NIC hot[un]plug to the test > hypervisor, > based on the qemu driver; only ethernet and bridge type VNICS are currently > supported. > > John Levon (2): > test_driver: provide basic NIC hotplu

[libvirt PATCH 20/20] ci: drop yajl completely

2024-08-14 Thread Ján Tomko
It is no longer used by libvirt so it's pointless to install it. Signed-off-by: Ján Tomko --- ci/buildenv/almalinux-9.sh | 3 +-- ci/buildenv/alpine-319.sh | 3 +-- ci/buildenv/alpine-edge.sh | 3 +-- ci/buildenv/centos-str

[libvirt PATCH 19/20] util: drop dead code

2024-08-14 Thread Ján Tomko
Now that WITH_YAJL can never be set, we can remove some more code. Signed-off-by: Ján Tomko --- src/util/virjson.c | 416 - 1 file changed, 416 deletions(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index 7a22c54f03..98011759fb 100644 --- a

[libvirt PATCH 18/20] meson: drop yajl detection

2024-08-14 Thread Ján Tomko
After this commit, WITH_YAJL can no longer be set. Signed-off-by: Ján Tomko --- meson.build | 42 -- 1 file changed, 42 deletions(-) diff --git a/meson.build b/meson.build index e8c19d8725..503b4362f7 100644 --- a/meson.build +++ b/meson.build @@ -1377,47

[libvirt PATCH 17/20] meson: options: drop yajl

2024-08-14 Thread Ján Tomko
Drop the yajl option and all references to it. Signed-off-by: Ján Tomko --- libvirt.spec.in | 1 - meson.build | 2 +- meson_options.txt | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b9f9f5ed45..e0c616627e 100644 --- a/libvir

[libvirt PATCH 16/20] meson: do not link anything with yajl anymore

2024-08-14 Thread Ján Tomko
Signed-off-by: Ján Tomko --- src/meson.build | 1 - src/util/meson.build | 1 - tests/meson.build | 1 - tools/nss/meson.build | 2 -- 4 files changed, 5 deletions(-) diff --git a/src/meson.build b/src/meson.build index b9652785dd..b53ea2a71f 100644 --- a/src/meson.build +++ b/src/mes

[libvirt PATCH 06/20] meson: link libvirt with json_c if available

2024-08-14 Thread Ján Tomko
Signed-off-by: Ján Tomko --- src/meson.build | 1 + src/util/meson.build | 1 + tests/meson.build| 1 + 3 files changed, 3 insertions(+) diff --git a/src/meson.build b/src/meson.build index 8cce42c7ad..b9652785dd 100644 --- a/src/meson.build +++ b/src/meson.build @@ -552,6 +552,7 @@ if

[libvirt PATCH 15/20] libvirt-spec: switch to building with json-c

2024-08-14 Thread Ján Tomko
Signed-off-by: Ján Tomko --- libvirt.spec.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index ad0f4f784f..b9f9f5ed45 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -361,7 +361,7 @@ BuildRequires: libblkid-devel >= 2.17 Build

[libvirt PATCH 08/20] ci: install json-c too

2024-08-14 Thread Ján Tomko
Now that we actually have some working code using json-c, install it in our CI to demonstrate that it works. Signed-off-by: Ján Tomko --- ci/buildenv/almalinux-9.sh | 1 + ci/buildenv/alpine-319.sh | 1 + ci/buildenv/alpine-edge.sh

[libvirt PATCH 13/20] meson: switch checks to depend on json-c instead of yajl

2024-08-14 Thread Ján Tomko
Signed-off-by: Ján Tomko --- meson.build | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/meson.build b/meson.build index 39d6d700d3..837b209232 100644 --- a/meson.build +++ b/meson.build @@ -1620,10 +1620,10 @@ if not get_option('driver_ch').disabled() and host_m

[libvirt PATCH 12/20] tests: depend on WITH_JSON_C instead of WITH_YAJL

2024-08-14 Thread Ján Tomko
After the series finale, there will be no WITH_YAJL anymore. Signed-off-by: Ján Tomko --- tests/meson.build| 6 +++--- tests/virnetdaemontest.c | 2 +- tests/virstoragetest.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/meson.build b/tests/meson.build

[libvirt PATCH 11/20] nss: convert findMACs to use json-c

2024-08-14 Thread Ján Tomko
While the parsing is still done by 1K buffers, the results are no longer filtered during the parsing, but the whole JSON has to live in memory at once, which was also the case before the NSS plugin dropped its dependency on libvirt_util. Also, the new parser might be more forgiving of missing elem

[libvirt PATCH 14/20] meson-options: switch to depend on json-c instead of yajl

2024-08-14 Thread Ján Tomko
Signed-off-by: Ján Tomko --- meson_options.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index 9b1610fcfe..122cda0350 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -68,14 +68,14 @@ option('driver_libvirtd', type: 'f

[libvirt PATCH 09/20] meson: nss: link with json-c if available

2024-08-14 Thread Ján Tomko
Signed-off-by: Ján Tomko --- tools/nss/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/nss/meson.build b/tools/nss/meson.build index 85e2838fb7..1cae93ac67 100644 --- a/tools/nss/meson.build +++ b/tools/nss/meson.build @@ -28,6 +28,7 @@ nss_libvirt_impl = static_library(

[libvirt PATCH 10/20] nss: convert findLeases to use json-c

2024-08-14 Thread Ján Tomko
While the parsing is still done by 1K buffers, the results are no longer filtered during the parsing, but the whole JSON has to live in memory at once, which was also the case before the NSS plugin dropped its dependency on libvirt_util. Also, the new parser might be more forgiving of missing elem

[libvirt PATCH 05/20] meson: add option for building with json-c

2024-08-14 Thread Ján Tomko
Also disable it immediately for the mingw build because it's not available there. Signed-off-by: Ján Tomko --- libvirt.spec.in | 1 + meson.build | 7 +++ meson_options.txt | 1 + 3 files changed, 9 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 29101e74fe..ad0f4

[libvirt PATCH 07/20] util: json: write a json-c implementation

2024-08-14 Thread Ján Tomko
Write an alternative implementation of our virJSON functions, using json-c instead of yajl. Signed-off-by: Ján Tomko --- src/util/virjson.c | 177 - 1 file changed, 175 insertions(+), 2 deletions(-) diff --git a/src/util/virjson.c b/src/util/virjson.c

[libvirt PATCH 04/20] tests: switch to compact empty JSON object formatting

2024-08-14 Thread Ján Tomko
Some earlier versions of json-c format empty elements differently. Run the tests who use the pretty formatting for readability and diffability through a function that unifies the output. Signed-off-by: Ján Tomko --- tests/qemublocktest.c | 5 - tests/qemublocktes

[libvirt PATCH 00/20] Switch to json-c from yajl

2024-08-14 Thread Ján Tomko
As requested by: https://gitlab.com/libvirt/libvirt/-/issues/581 The ci update depends on the following libvirt-ci MR: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/497 targets: bump OpenSUSE Leap to 15.6 Pipeline: https://gitlab.com/janotomko/libvirt/-/pipelines/1413887401/ Ján Tomko (

[libvirt PATCH 03/20] util: json: introduce virJSONStringPrettifyBlanks

2024-08-14 Thread Ján Tomko
A horribly named function for unifying formatting when pretty-printing empty JSON arrays and objects. Useful for having stable test output even if different JSON libraries format these differently. Signed-off-by: Ján Tomko --- src/libvirt_private.syms | 1 + src/util/virjson.c | 34 ++

[libvirt PATCH 02/20] ci: update OpenSUSE Leap to 15.6

2024-08-14 Thread Ján Tomko
It was released on June 12, 2024. The update means we no longer have to care about json-c 0.13 present in Leap 15.5, which solves some whitespace issues in tests. Signed-off-by: Ján Tomko --- ci/containers/opensuse-leap-15.Dockerfile | 2 +- ci/gitlab/builds.yml | 2 +- 2 f

[libvirt PATCH 01/20] tests: json: relax some test cases

2024-08-14 Thread Ján Tomko
Some JSON parsers do not like bare types outside of objects or arrays or do validation of object key uniqueness. Signed-off-by: Ján Tomko --- tests/virjsontest.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/virjsontest.c b/tests/virjsontest.c index 6b6a64d3d

[libvirt PATCH RFC] ci: adapt to 'dtrace' package split

2024-08-14 Thread Ján Tomko
Fedora has decided to separate dtrace out of the systemtap-sdt-devel package: https://fedoraproject.org/wiki/Changes/Separate_dtrace_package Similarly, these are split in OpenSUSE Tumbleweed, however in a backward-compatbile way: https://build.opensuse.org/package/show/openSUSE:Factory/systemtap

Re: [PATCH v2 1/4] qemu.conf changes to support multiple memory backend

2024-08-14 Thread Michael Galaxy via Devel
Ok, I tested one of your concerns below, and I caught that already. Just following up.. On 8/6/24 07:35, Martin Kletzander wrote: On Wed, Jun 05, 2024 at 04:37:35PM -0400, mgal...@akamai.com wrote: From: Michael Galaxy +   _("Domain requesting configuration fo

Re: [PATCH 0/3] Implement support for QCOW2 data files

2024-08-14 Thread Denis V. Lunev via Devel
On 8/12/24 16:46, Peter Krempa wrote: On Mon, Aug 12, 2024 at 12:04:01 +0200, Denis V. Lunev wrote: On 8/12/24 10:36, Peter Krempa wrote: On Mon, Aug 12, 2024 at 09:26:08 +0200, Peter Krempa wrote: On Sun, Aug 11, 2024 at 17:34:45 +0300, Nikolai Barybin via Devel wrote: There are use cases wh

Re: [PATCH V3 3/4] qemu capabilities: add QEMU_CAPS_SNAPSHOT_SAVE/_DELETE

2024-08-14 Thread Peter Krempa
On Wed, Jul 17, 2024 at 21:21:39 +0300, Nikolai Barybin via Devel wrote: > The 'snapshot-save/delete' QMP commands were introduced in QEMU 6.0.0, > so we add a compatible capability to check if target QEMU binary supports it. > > Signed-off-by: Nikolai Barybin > --- > src/qemu/qemu_capabilities.

Re: [PATCH V2 2/4] qemu blockjob: add snapshot-save/delete job types

2024-08-14 Thread Peter Krempa
On Wed, Jul 17, 2024 at 21:21:37 +0300, Nikolai Barybin via Devel wrote: The commit message should shortly state the job types we're about to handle so that anyone looking at the commit doesn't need to go digging. > Signed-off-by: Nikolai Barybin > --- > src/qemu/qemu_block.c| 2 ++ > src/q

Re: [PATCH V2 1/4] qemu monitor: add snaphot-save/delete QMP commands

2024-08-14 Thread Peter Krempa
On Wed, Jul 17, 2024 at 21:21:35 +0300, Nikolai Barybin via Devel wrote: > Signed-off-by: Nikolai Barybin > --- > src/qemu/qemu_monitor.c | 30 > src/qemu/qemu_monitor.h | 13 +++ > src/qemu/qemu_monitor_json.c | 66 > src/qemu/q

Re: [PATCH V2 0/4] Rework qemu internal active snapshots to use QMP

2024-08-14 Thread Peter Krempa
On Wed, Jul 17, 2024 at 21:21:33 +0300, Nikolai Barybin via Devel wrote: > Den, Peter, Daniel thank you for your comments! > > I'm sending v2 of this patchset. > > Changes since last revision: > > - dropped [PATCH 4/4] qemu monitor: reap qemu_monitor_text > > - added new patch: qemu capabilitie

[PATCH 1/1] virsh: allow both --table and --uuid at the same time

2024-08-14 Thread Nikolai Barybin via Devel
This will allow to print full domains info: Id Name State UUID --- Signed-off-by: Nikolai Barybin --- docs/manpages/virsh.rst | 14 +++--- tools/virsh-domain-monitor.c | 37 2 files changed, 40 insertions(+), 11 de

[PATCH 0/1] virsh: allow both --table and --uuid at the same time

2024-08-14 Thread Nikolai Barybin via Devel
For now virsh does not provide a set of options to print all info about domain: --all does not print uuid, combination of --id --name --uuid does not have '--state' option. I think we should address this issue and allow user to get all available info with one command. The easiest way to do that is