Re: [PATCH 2/2] libxl: Reject VM config referencing nwfilters

2024-09-11 Thread Laine Stump
On 9/11/24 7:42 PM, Demi Marie Obenour wrote: On Wed, Sep 11, 2024 at 05:09:03PM -0600, Jim Fehlig wrote: On 9/11/24 16:24, Laine Stump wrote: On 9/11/24 5:02 PM, Jim Fehlig via Devel wrote: The Xen libxl driver does not support nwfilter. Add a check for nwfilters to the devicesPostParseCallba

Re: [PATCH 1/2] docs: Clarify hypervisor support for nwfilter profiles

2024-09-11 Thread Laine Stump
On 9/11/24 6:44 PM, Jim Fehlig via Devel wrote: On 9/11/24 15:54, Demi Marie Obenour wrote: On Wed, Sep 11, 2024 at 03:02:41PM -0600, Jim Fehlig wrote: Enhance the 'since' annotation of documentation to note it's only supported by the QEMU, LXC, and ch hypervisor drivers. Signed-off-by: Jim F

Re: [PATCH 2/2] libxl: Reject VM config referencing nwfilters

2024-09-11 Thread Jim Fehlig via Devel
On 9/11/24 16:24, Laine Stump wrote: On 9/11/24 5:02 PM, Jim Fehlig via Devel wrote: The Xen libxl driver does not support nwfilter. Add a check for nwfilters to the devicesPostParseCallback, returning VIR_ERR_CONFIG_UNSUPPORTED if any are found. It's generally preferred for drivers to ignore u

Re: [PATCH 1/2] docs: Clarify hypervisor support for nwfilter profiles

2024-09-11 Thread Jim Fehlig via Devel
On 9/11/24 16:08, Laine Stump wrote: On 9/11/24 5:02 PM, Jim Fehlig via Devel wrote: Enhance the 'since' annotation of documentation to note it's only supported by the QEMU, LXC, and ch hypervisor drivers. Signed-off-by: Jim Fehlig ---   docs/formatdomain.rst | 8   1 file changed, 4

Re: [PATCH 1/2] docs: Clarify hypervisor support for nwfilter profiles

2024-09-11 Thread Jim Fehlig via Devel
On 9/11/24 15:54, Demi Marie Obenour wrote: On Wed, Sep 11, 2024 at 03:02:41PM -0600, Jim Fehlig wrote: Enhance the 'since' annotation of documentation to note it's only supported by the QEMU, LXC, and ch hypervisor drivers. Signed-off-by: Jim Fehlig --- docs/formatdomain.rst | 8

Re: [PATCH 0/2] Reject Xen VM config containing nwfilter references

2024-09-11 Thread Jim Fehlig via Devel
On 9/11/24 15:49, Demi Marie Obenour wrote: On Wed, Sep 11, 2024 at 03:02:40PM -0600, Jim Fehlig wrote: This is essentially V2 of a small series inspired by a report on the security list about nwfilters not working with Xen VMs. V1 was posted to the security list, so no public reference. The lib

Re: [PATCH 2/2] libxl: Reject VM config referencing nwfilters

2024-09-11 Thread Laine Stump
On 9/11/24 5:02 PM, Jim Fehlig via Devel wrote: The Xen libxl driver does not support nwfilter. Add a check for nwfilters to the devicesPostParseCallback, returning VIR_ERR_CONFIG_UNSUPPORTED if any are found. It's generally preferred for drivers to ignore unsupported XML features, I would ins

Re: [PATCH 1/2] docs: Clarify hypervisor support for nwfilter profiles

2024-09-11 Thread Laine Stump
On 9/11/24 5:02 PM, Jim Fehlig via Devel wrote: Enhance the 'since' annotation of documentation to note it's only supported by the QEMU, LXC, and ch hypervisor drivers. Signed-off-by: Jim Fehlig --- docs/formatdomain.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --

[PATCH 2/2] libxl: Reject VM config referencing nwfilters

2024-09-11 Thread Jim Fehlig via Devel
The Xen libxl driver does not support nwfilter. Add a check for nwfilters to the devicesPostParseCallback, returning VIR_ERR_CONFIG_UNSUPPORTED if any are found. It's generally preferred for drivers to ignore unsupported XML features, but ignoring a user's request to filter VM network traffic can

[PATCH 1/2] docs: Clarify hypervisor support for nwfilter profiles

2024-09-11 Thread Jim Fehlig via Devel
Enhance the 'since' annotation of documentation to note it's only supported by the QEMU, LXC, and ch hypervisor drivers. Signed-off-by: Jim Fehlig --- docs/formatdomain.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst

[PATCH 0/2] Reject Xen VM config containing nwfilter references

2024-09-11 Thread Jim Fehlig via Devel
This is essentially V2 of a small series inspired by a report on the security list about nwfilters not working with Xen VMs. V1 was posted to the security list, so no public reference. The libxl driver simply does not support nwfilters, so the report is really a RFE vs a security issue. I'm now mo

[PATCH] vmx: Allow '*' to appear in VMX file keys

2024-09-11 Thread Richard W.M. Jones
When connecting to a VMware server (eg using vpx://) we download and try to parse the VMware metadata '*.vmx' file of a guest. In this case a VMX file was found which contained this key: pciPassthru*.present = "False" The '*' character was not previously allowed in keys so this failed to parse

[PATCH 2/2] vmx: use xmlBufferDetach() when applicable

2024-09-11 Thread Jakub Palacky
xmlBuffer->content was deprecated in libxml2 v2.13.0-33-gb34dc1e4 xmlBufferDetach(xmlBuffer) should be used instead Signed-off-by: Jakub Palacky --- src/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 227744d062..de16c1f634 100644

[PATCH 1/2] util/virxml: use xmlCtxtGetLastError when applicable

2024-09-11 Thread Jakub Palacky
xmlParserCtxt->lastError was deprecated in libxml2 v2.13.0-103-g1228b4e0 xmlCtxtGetLastError(xmlParserCtxt) should be used instead Signed-off-by: Jakub Palacky --- src/util/virxml.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/util/virxml.c b/src/util/

[PATCH 0/2] Adapt to latest libxml2

2024-09-11 Thread Jakub Palacky
I noticed a couple deprecation errors when trying to build libvirt with the latest libxml2 version from the master branch. These patches fix the deprecated fields. Both functions used are available in the oldest libxml2 version required by libvirt, so there is no need to bump it. Jakub Palacky

[PATCH v2] util/virutil: Use readpassphrase when libbsd is available

2024-09-11 Thread Jakub Palacky
When libbsd is available, use the preferred readpassphrase() function isntead of getpass() as the getpass() function has been marked as obsolete and shouldnt be used Signed-off-by: Jakub Palacky --- Changes in v2: - Fix possible memory leak of g_new0 - Use PASS_MAX for max password length

Re: [PATCH] util/virutil: Use readpassphrase when libbsd is available

2024-09-11 Thread Daniel P . Berrangé
On Wed, Sep 11, 2024 at 01:51:29PM +0200, Jakub Palacky wrote: > When libbsd is available, use the preferred readpassphrase() function isntead > of getpass() > as the getpass() function has been marked as obsolete and shouldnt be used > > Signed-off-by: Jakub Palacky > --- > meson.build

[PATCH] util/virutil: Use readpassphrase when libbsd is available

2024-09-11 Thread Jakub Palacky
When libbsd is available, use the preferred readpassphrase() function isntead of getpass() as the getpass() function has been marked as obsolete and shouldnt be used Signed-off-by: Jakub Palacky --- meson.build| 6 ++ src/meson.build| 1 + src/util/virutil.c | 6 ++ 3 files

Re: [PATCH v1] chardev: introduce 'reconnect-ms' and deprecate 'reconnect'

2024-09-11 Thread Daniil Tatianin
Ping :) I think this one should be good to go now! On 9/5/24 11:57 AM, Daniil Tatianin wrote: The 'reconnect' option only allows to specify the time in seconds, which is way too long for certain workflows. We have a lightweight disk backend server, which takes about 20ms to live update, but due

Re: [PATCH 13/26] contrib/plugins: control flow plugin

2024-09-11 Thread Pierrick Bouvier
On 9/10/24 07:07, Alex Bennée wrote: This is a simple control flow tracking plugin that uses the latest inline and conditional operations to detect and track control flow changes. It is currently an exercise at seeing how useful the changes are. Based-on: <20240312075428.244210-1-pierrick.bouv..

Re: [PATCH 20/26] tests/tcg: only read/write 64 bit words on 64 bit systems

2024-09-11 Thread Pierrick Bouvier
On 9/10/24 07:07, Alex Bennée wrote: While the compilers will generally happily synthesise a 64 bit value for you on 32 bit systems it doesn't exercise anything on QEMU. It also makes it hard to accurately compare the accesses to test_data when instrumenting. Signed-off-by: Alex Bennée --- te

Re: [PATCH 19/26] tests/tcg: clean up output of memory system test

2024-09-11 Thread Pierrick Bouvier
On 9/10/24 07:07, Alex Bennée wrote: This is useful information when debugging memory issues so lets improve by: - include the ptr address for u8 fills (like the others) - indicate the number of operations for reads and writes - explicitly note when we are flushing - move the fill pr

Re: [PATCH 12/26] deprecation: don't enable TCG plugins by default with TCI

2024-09-11 Thread Pierrick Bouvier
On 9/10/24 07:07, Alex Bennée wrote: The softmmu memory instrumentation test sees so many more accesses than a normal translated host and its really not worth fixing up. Lets deprecate this odd configuration and save on the CI cycles. Signed-off-by: Alex Bennée --- docs/about/deprecated.rst |

Re: [PATCH 11/26] deprecation: don't enable TCG plugins by default on 32 bit hosts

2024-09-11 Thread Pierrick Bouvier
On 9/10/24 07:07, Alex Bennée wrote: The existing plugins already liberally use host pointer stuffing for passing user data which will fail when doing 64 bit guests on 32 bit hosts. We should discourage this by officially deprecating support and adding another nail to the 32 bit host coffin. Sig

Re: [PATCH 04/26] scripts/ci: update the gitlab-runner playbook

2024-09-11 Thread Pierrick Bouvier
On 9/10/24 07:07, Alex Bennée wrote: The upstream install instructions: https://docs.gitlab.com/runner/install/linux-repository.html Now refer to repositories and a setup script. Modernise the playbook to use the preferred delivery method. Signed-off-by: Alex Bennée --- scripts/ci/setup/

Re: [PATCH 03/26] docs/devel: fix duplicate line

2024-09-11 Thread Pierrick Bouvier
On 9/10/24 07:07, Alex Bennée wrote: I guess the same change came in via two patch series. Remove the repetition. Fixes: 2a851fca9f (docs/devel: remind developers to run CI container pipeline when updating images) Signed-off-by: Alex Bennée --- docs/devel/testing/main.rst | 6 -- 1 file

Re: [PATCH 02/26] tests/docker: update debian i686 and mipsel images to bookworm

2024-09-11 Thread Pierrick Bouvier
On 9/10/24 07:07, Alex Bennée wrote: Whatever issues there were which stopped these being updates when the rest were have now been resolved. However mips64el continues to be broken so don't update it here. Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-i686-cross.docker | 10

Re: [PATCH 01/26] tests/docker: remove debian-armel-cross

2024-09-11 Thread Pierrick Bouvier
On 9/10/24 07:07, Alex Bennée wrote: As debian-11 transitions to LTS we are starting to have problems building the image. While we could update to a later Debian building a 32 bit QEMU without modern floating point is niche host amongst the few remaining 32 bit hosts we regularly build for. For n