Re: [RFC PATCH v2 7/8] docs: Add documentation for the TPM backend profile node

2024-09-27 Thread Daniel P . Berrangé
On Thu, Sep 26, 2024 at 04:44:28PM -0400, Stefan Berger wrote: > > > On 9/26/24 4:18 PM, Daniel P. Berrangé wrote: > > On Thu, Sep 26, 2024 at 03:32:07PM -0400, Stefan Berger wrote: > > > Add documentation for the TPM backend profile node and point the reader to > > > further documentation about

libvirt-10.8.0 release candidate 2

2024-09-27 Thread Jiri Denemark
I have just tagged v10.8.0-rc2 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

[PATCH] qemu: Look for qemu-bridge-helper in more directories

2024-09-27 Thread Andrea Bolognani
Commit 0caacf47d7b423db9126660fb0382ed56cd077c1 recently made it so the new path used for qemu-bridge-helper in Debian would be allowed, but the logic used to actually figure out the complete path for the helper was not updated accordingly. https://bugs.debian.org/1082530 Signed-off-by: Andrea Bo

Re: [RFC PATCH 2/5] qemu_capabilities: Introduce QEMU_CAPS_AMD_IOMMU_INTREMAP

2024-09-27 Thread Daniel P . Berrangé
On Fri, Sep 27, 2024 at 10:22:34AM +0200, Peter Krempa wrote: > On Fri, Sep 27, 2024 at 15:45:43 +0800, Han Han wrote: > > It will be used for the property "intremap" of the device amd-iommu. > > Looking at the detected versions and the qemu code it seems that > 'intremap' is supported for all qem

Re: [RFC PATCH 0/5] Implement amd-iommu device to libvirt

2024-09-27 Thread Daniel P . Berrangé
On Fri, Sep 27, 2024 at 03:45:41PM +0800, Han Han wrote: > Here is a draft patch series for amd-iommu device. It will implement > amd-iommu device and its attributes: intremap, device-iotlb, xtsup. > > However, its secret device AMDVI-PCI will occupy a PCIe slot and cause > VM failed to start: > D

Re: [RFC PATCH 5/5] qemu: Add suppport for amd-iommu device and xtsup attrib

2024-09-27 Thread Peter Krempa
Note that this is not a full review as I don't know how the iommu is behaving/used so I can't comment on that. On Fri, Sep 27, 2024 at 15:45:46 +0800, Han Han wrote: > Fixes: https://issues.redhat.com/browse/RHEL-50560 Please describe in the commit message what/why you are doing. e.g. at the v

Re: [RFC PATCH 3/5] qemu_capabilities: Introduce QEMU_CAPS_AMD_IOMMU_DEVICE_IOTLB

2024-09-27 Thread Peter Krempa
On Fri, Sep 27, 2024 at 15:45:44 +0800, Han Han wrote: > It will be used for the device-iotlb property of amd-iommu device. Same as previous patch.

Re: [RFC PATCH 2/5] qemu_capabilities: Introduce QEMU_CAPS_AMD_IOMMU_INTREMAP

2024-09-27 Thread Peter Krempa
On Fri, Sep 27, 2024 at 15:45:43 +0800, Han Han wrote: > It will be used for the property "intremap" of the device amd-iommu. Looking at the detected versions and the qemu code it seems that 'intremap' is supported for all qemu versions and also it doesn't seem to be able to be disabled. Thus thi

[RFC PATCH 5/5] qemu: Add suppport for amd-iommu device and xtsup attrib

2024-09-27 Thread Han Han
Fixes: https://issues.redhat.com/browse/RHEL-50560 Signed-off-by: Han Han --- docs/formatdomain.rst | 20 +- src/conf/domain_conf.c| 16 src/conf/domain_conf.h| 2 + src/conf/domain_validate.c

[RFC PATCH 4/5] qemu_capabilities: Introduce QEMU_CAPS_AMD_IOMMU_XTSUP

2024-09-27 Thread Han Han
It will be used for the xtsup property of amd-iommu device. Signed-off-by: Han Han --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_9.1.0_x8

[RFC PATCH 3/5] qemu_capabilities: Introduce QEMU_CAPS_AMD_IOMMU_DEVICE_IOTLB

2024-09-27 Thread Han Han
It will be used for the device-iotlb property of amd-iommu device. Signed-off-by: Han Han --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_5.2.0_x86_64.xml | 1 + tests/qemucapabilitie

[RFC PATCH 2/5] qemu_capabilities: Introduce QEMU_CAPS_AMD_IOMMU_INTREMAP

2024-09-27 Thread Han Han
It will be used for the property "intremap" of the device amd-iommu. Signed-off-by: Han Han --- src/qemu/qemu_capabilities.c | 8 src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_5.2.0_x86_64.xml | 1 + tests/qemucap

[RFC PATCH 1/5] qemu_capabilities: Introduce QEMU_CAPS_AMD_IOMMU

2024-09-27 Thread Han Han
This qemu capability will be used for the device amd-iommu. Signed-off-by: Han Han --- src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + .../caps_5.2.0_x86_64.replies | 90 +++-- .../caps_5.2.0_x86_64.xml

[RFC PATCH 0/5] Implement amd-iommu device to libvirt

2024-09-27 Thread Han Han
Here is a draft patch series for amd-iommu device. It will implement amd-iommu device and its attributes: intremap, device-iotlb, xtsup. However, its secret device AMDVI-PCI will occupy a PCIe slot and cause VM failed to start: Domain XML: ... ... ➜ ~ virsh create

[PATCH 1/2] qemu: blockjob: Update 'mirror' of a copy job before removing images

2024-09-27 Thread Peter Krempa
When concluding a job with a 'mirror' we first unplugged the appropriate no-longer used images from qemu and then updated the definition. Normally this wouldn't be a problem because for any other thread this is done under the VM lock thus atomic. Unfortunately though, the AppArmor security backend

[PATCH 2/2] qemu: blockjob: Clean out disk mirror data after concluding the job

2024-09-27 Thread Peter Krempa
The 'disk->mirrorJob' and 'disk->mirrorState' fields need to be cleared after a blockjob, but should be kept around while 'disk->mirror' is still in place. As 'disk->mirror' is cleared only after conclusion of the job in 'qemuBlockJobEventProcessConcluded()' we should be resetting them only afterwa

[PATCH 0/2] qemu: blockjob: Fix ordering of operations when concluding a block copy

2024-09-27 Thread Peter Krempa
Modify the ordering so that the VM definition stays in a state allowing us to format a valid XML for the virt-aa-helper. Peter Krempa (2): qemu: blockjob: Update 'mirror' of a copy job before removing images qemu: blockjob: Clean out disk mirror data after concluding the job src/qemu/qemu_bl

Re: [PATCH v2] docs: Mark "gluster" support in QEMU as deprecated

2024-09-27 Thread Markus Armbruster
Thomas Huth writes: > According to https://marc.info/?l=fedora-devel-list&m=171934833215726 > the GlusterFS development effectively ended. Thus mark it as deprecated > in QEMU, so we can remove it in a future release if the project does > not gain momentum again. > > Acked-by: Niels de Vos > Sig