Re: [PATCH v2 1/4] qemu.conf changes to support multiple memory backend

2024-10-23 Thread Michael Galaxy via Devel
Hi All, This is just a heads up: I will be changing employment soon, so my Akamai email address will cease to operate this week. My personal email: mich...@flatgalaxy.com. I'll re-subscribe later once I have come back online to work soon. Thanks! - Michael On 10/23/24 10:34, Michael Galax

Re: [PATCH v2 1/4] qemu.conf changes to support multiple memory backend

2024-10-23 Thread Michael Galaxy via Devel
On 10/2/24 02:54, Martin Kletzander wrote: On Sun, Sep 08, 2024 at 08:00:02AM +0200, Martin Kletzander wrote: On Thu, Aug 15, 2024 at 01:30:38PM -0500, Michael Galaxy wrote: On 8/7/24 10:10, Michael Galaxy wrote: On 8/7/24 08:23, Martin Kletzander wrote: Exactly, we do not want the paths to ch

[PATCH v2 4/4] NEWS: Report CPU model blockers in domain capabilities

2024-10-23 Thread Jiri Denemark
Signed-off-by: Jiri Denemark Reviewed-by: Ján Tomko --- Notes: Version 2: - no change NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 56adf8df8b..191fd74830 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -54,6 +54,12 @@ v10.9.0 (unreleased) re

[PATCH v2 0/4] Report CPU model blockers in domain capabilities

2024-10-23 Thread Jiri Denemark
Version 2: - avoid adding the same blocker more than once for each model Jiri Denemark (4): util: Introduce virStringListRemoveDuplicates domain_capabilities: Sort CPU models domain_capabilities: Report CPU blockers NEWS: Report CPU model blockers in domain capabilities NEWS.rst

[PATCH v2 1/4] util: Introduce virStringListRemoveDuplicates

2024-10-23 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- Notes: Version 2: - new patch src/libvirt_private.syms | 1 + src/util/virstring.c | 29 + src/util/virstring.h | 2 ++ 3 files changed, 32 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.s

Re: [PATCH (RFC and a half?)] network: add rule to nftables backend that zeroes checksum of DHCP responses

2024-10-23 Thread Laine Stump
FYI I've also tested this with Win10 and it works fine. It would be nice to get this into the upcoming release if possible (nudge nudge, wink wink) On 10/21/24 12:14 AM, Laine Stump wrote: Many long years ago (April 2010), soon after "vhost" in-kernel packet processing was added to the virtio-n

Re: [PATCH v3 10/18] gitlab: make check-[dco|patch] a little more verbose

2024-10-23 Thread Daniel P . Berrangé
On Wed, Oct 23, 2024 at 12:33:58PM +0100, Alex Bennée wrote: > When git fails the rather terse backtrace only indicates it failed > without some useful context. Add some to make the log a little more > useful. > > Signed-off-by: Alex Bennée > > --- > v2 > - keep check_call, just don't redirect

[PATCH v3 06/18] scripts/ci: remove architecture checks for build-environment updates

2024-10-23 Thread Alex Bennée
We were missing s390x here. There isn't much point testing for the architecture here as we will fail anyway if the appropriate package list is missing. Message-Id: <20241022105614.839199-7-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- scripts/ci/setup/ubun

[PATCH v3 12/18] config/targets: update aarch64_be-linux-user gdb XML list

2024-10-23 Thread Alex Bennée
Attempting to run the binary asserts when it can't find the XML entry. We can fix it so we don't although I suspect other stuff is broken. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2580 Message-Id: <20241022105614.839199-13-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-o

[PATCH v3 17/18] contrib/plugins: remove Makefile for contrib/plugins

2024-10-23 Thread Alex Bennée
From: Pierrick Bouvier Now replaced by meson build. Signed-off-by: Pierrick Bouvier Message-Id: <20240925204845.390689-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- configure| 18 - Makefile | 10 - contrib/plugins/Makefile | 87

[PATCH v3 13/18] tests/tcg: enable basic testing for aarch64_be-linux-user

2024-10-23 Thread Alex Bennée
We didn't notice breakage of aarch64_be because we don't have any TCG tests for it. However while the existing aarch64 compiler can target big-endian builds no one packages a BE libc. Instead we bang some rocks together to do the most basic of hello world with a nostdlib syscall test. Message-Id:

[PATCH v3 08/18] accel/tcg: add tracepoints for cpu_loop_exit_atomic

2024-10-23 Thread Alex Bennée
We try to avoid using cpu_loop_exit_atomic as it brings in an all-core sync point. However on some cpu/kernel/benchmark combinations it is starting to show up in the performance profile. To make it easier to see whats going on add tracepoints for the slow path so we can see what is triggering the w

[PATCH v3 07/18] tests/tcg/x86_64: Add cross-modifying code test

2024-10-23 Thread Alex Bennée
From: Ilya Leoshkevich commit f025692c992c ("accel/tcg: Clear PAGE_WRITE before translation") fixed cross-modifying code handling, but did not add a test. The changed code was further improved recently [1], and I was not sure whether these modifications were safe (spoiler: they were fine). Add a

[PATCH v3 15/18] testing: Enhance gdb probe script

2024-10-23 Thread Alex Bennée
From: Gustavo Romero Use list and set comprehension to simplify code. Also, gently handle invalid gdb filenames. Signed-off-by: Gustavo Romero Reviewed-by: Pierrick Bouvier Message-Id: <20241022105614.839199-16-alex.ben...@linaro.org> Message-Id: <20241015145848.387281-1-gustavo.rom...@linaro.

[PATCH v3 18/18] plugins: fix qemu_plugin_reset

2024-10-23 Thread Alex Bennée
From: Pierrick Bouvier 34e5e1 refactored the plugin context initialization. After this change, tcg_ctx->plugin_insn is not reset inconditionnally anymore, but only if one plugin at least is active. When uninstalling the last plugin active, we stopped reinitializing tcg_ctx->plugin_insn, which le

[PATCH v3 16/18] MAINTAINERS: mention my plugins/next tree

2024-10-23 Thread Alex Bennée
Make it easier to find where plugin patches are being staged. Message-Id: <20241022105614.839199-17-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7eea7b7954..5b

[PATCH v3 14/18] tests/tcg/aarch64: Use raw strings for regexes in test-mte.py

2024-10-23 Thread Alex Bennée
From: Gustavo Romero Use Python's raw string notation instead of string literals for regex so it's not necessary to double backslashes when regex special forms are used. Raw notation is preferred for regex and easier to read. Signed-off-by: Gustavo Romero Reviewed-by: Philippe Mathieu-Daudé Me

[PATCH v3 11/18] MAINTAINERS: mention my gdbstub/next tree

2024-10-23 Thread Alex Bennée
Make it easy for people to see what is already queued. Message-Id: <20241022105614.839199-12-alex.ben...@linaro.org> Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAI

[PATCH v3 05/18] docs/devel: update tsan build documentation

2024-10-23 Thread Alex Bennée
From: Pierrick Bouvier Mention it's now possible to build with gcc, instead of clang, and explain how to build a sanitized glib version. Signed-off-by: Pierrick Bouvier Reviewed-by: Thomas Huth Message-Id: <20240910174013.141-4-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée ---

[PATCH v3 10/18] gitlab: make check-[dco|patch] a little more verbose

2024-10-23 Thread Alex Bennée
When git fails the rather terse backtrace only indicates it failed without some useful context. Add some to make the log a little more useful. Signed-off-by: Alex Bennée --- v2 - keep check_call, just don't redirect stdout/err --- .gitlab-ci.d/check-dco.py | 5 ++--- .gitlab-ci.d/check-patc

[PATCH v3 09/18] dockerfiles: fix default targets for debian-loongarch-cross

2024-10-23 Thread Alex Bennée
From: Pierrick Bouvier fix system target name, and remove --disable-system (which deactivates system target). Found using: make docker-test-build@debian-loongarch-cross V=1 Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <2024102021375

[PATCH v3 04/18] meson: hide tsan related warnings

2024-10-23 Thread Alex Bennée
From: Pierrick Bouvier When building with gcc-12 -fsanitize=thread, gcc reports some constructions not supported with tsan. Found on debian stable. qemu/include/qemu/atomic.h:36:52: error: ‘atomic_thread_fence’ is not supported with ‘-fsanitize=thread’ [-Werror=tsan] 36 | #define smp_mb()

[PATCH v3 02/18] tests/docker: add NOFETCH env variable for testing

2024-10-23 Thread Alex Bennée
Testing non-auto built docker containers (i.e. custom built compilers) is a bit fiddly as you couldn't continue a build with a previously locally built container. While you can play games with REGISTRY its simpler to allow a NOFETCH that will go through the cached build process when you run the tes

[PATCH v3 03/18] MAINTAINERS: mention my testing/next tree

2024-10-23 Thread Alex Bennée
I put it under my name as there may be other maintainer testing trees as well. Message-Id: <20241022105614.839199-4-alex.ben...@linaro.org> Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c3b

[PATCH v3 01/18] tests/docker: Fix microblaze atomics

2024-10-23 Thread Alex Bennée
From: Ilya Leoshkevich GCC produces invalid code for microblaze atomics. The fix is unfortunately not upstream, so fetch it from an external location and apply it locally. Suggested-by: Peter Maydell Signed-off-by: Ilya Leoshkevich Reviewed-by: Pierrick Bouvier Message-Id: <20241022105614.83

[PATCH v3 00/18] maintainer updates (testing, gdbstub, plugins) pre-PR

2024-10-23 Thread Alex Bennée
This is an aggregation of three of my maintainer trees which you can also get from their respective branches (testing/next, gdbstub/next and plugins/next). It is now ready for a pull request. Since last post: - added r-b tags - some minor typo fixes - dropped meson plugin contrib build and

Re: [PATCH 0/9] qemu: Change CPU comparison algorithm for future models

2024-10-23 Thread Ján Tomko
On a Thursday in 2024, Jiri Denemark wrote: When starting a domain we check whether the guest CPU definition is compatible with the host (i.e., when the host supports all features required both explicitly and by the specified CPU model) as long as check == 'partial', which is the default. We are

Re: [PATCH v1] tests: add capabilities for QEMU 9.1.0 on s390x

2024-10-23 Thread Boris Fiuczynski
On 10/18/24 13:37, Shalini Chellathurai Saroja wrote: Let us introduce the xml and reply files for QEMU 9.1.0 on s390x. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by:Boris Fiuczynski The replies and xml files are removed from this patch and is available in https://gitlab.com/shaliniche

Re: [PATCH] ci: Move definition of exit codes allowed to fail for cirrus jobs

2024-10-23 Thread Ján Tomko
On a Wednesday in 2024, Peter Krempa wrote: Update with latest lcitool. Update the build templates to move the definition of exit codes which are allowed to fail for cirrus jobs for cases when we run out of CI minutes. The previous location was overridden with the per-job 'allow_failure' value a

Re: [PATCH v2 18/20] meson: build contrib/plugins with meson

2024-10-23 Thread Alex Bennée
Pierrick Bouvier writes: > On 10/22/24 03:56, Alex Bennée wrote: >> From: Pierrick Bouvier >> Tried to unify this meson.build with tests/tcg/plugins/meson.build >> but >> the resulting modules are not output in the right directory. >> Originally proposed by Anton Kochkov, thank you! >> Solves: h

Re: [PATCH v2 07/20] tests/tcg/x86_64: Add cross-modifying code test

2024-10-23 Thread Alex Bennée
Pierrick Bouvier writes: > On 10/22/24 17:16, Ilya Leoshkevich wrote: >> On Tue, 2024-10-22 at 13:36 -0700, Pierrick Bouvier wrote: >>> On 10/22/24 03:56, Alex Bennée wrote: From: Ilya Leoshkevich commit f025692c992c ("accel/tcg: Clear PAGE_WRITE before translation") fix

[PATCH] ci: Move definition of exit codes allowed to fail for cirrus jobs

2024-10-23 Thread Peter Krempa
Update with latest lcitool. Update the build templates to move the definition of exit codes which are allowed to fail for cirrus jobs for cases when we run out of CI minutes. The previous location was overridden with the per-job 'allow_failure' value and thus didn't apply. Signed-off-by: Peter Kr

[PATCH v3 5/5] NEWS: Mention event handling support in ch driver

2024-10-23 Thread Purna Pavan Chandra Aekkaladevi
Signed-off-by: Purna Pavan Chandra Signed-off-by: Purna Pavan Chandra Aekkaladevi --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 56adf8df8b..7bf8dcc085 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -28,6 +28,13 @@ v10.9.0 (unreleased) for ``virs

Re: [PATCH v2 1/6] utils: Implement virFileIsNamedPipe

2024-10-23 Thread Purna Pavan Chandra Aekkaladevi
On Tue, Oct 08, 2024 at 01:39:34PM -0500, Praveen K Paladugu wrote: > > > On 10/1/2024 7:20 AM, Purna Pavan Chandra Aekkaladevi wrote: > >virFileIsNamedPipe checks whether passed path is a FIFO file or not. > > > >Signed-off-by: Purna Pavan Chandra Aekkaladevi > > > >Co-authored-by: Vineeth Pill

[PATCH v3 3/5] ch: events: Read and parse cloud-hypervisor events

2024-10-23 Thread Purna Pavan Chandra Aekkaladevi
Implement `chReadProcessEvents` and `chProcessEvents` to read events from event monitor FIFO file and parse them accordingly. Signed-off-by: Purna Pavan Chandra Aekkaladevi Co-authored-by: Vineeth Pillai --- src/ch/ch_events.c | 136 +++- src/ch/ch_even

[PATCH v3 4/5] ch: events: facilitate lifecycle events handling

2024-10-23 Thread Purna Pavan Chandra Aekkaladevi
Implement `virCHProcessEvent` that maps event string to corresponding event type and take appropriate actions. As part of this, handle the shutdown event by correctly updating the domain state. this change also facilitates the handling of other VM lifecycle events, such as booting, rebooting, pause

[PATCH v3 2/5] ch: start a new thread for handling ch events

2024-10-23 Thread Purna Pavan Chandra Aekkaladevi
Use a FIFO(named pipe) for --event-monitor option in CH. Introduce a new thread, `virCHEventHandlerLoop`, to continuously monitor and handle events from cloud-hypervisor. Signed-off-by: Purna Pavan Chandra Aekkaladevi Co-authored-by: Vineeth Pillai --- po/POTFILES | 1 + src/ch/ch_eve

[PATCH v3 1/5] ch: pass --event-monitor option to cloud-hypervisor

2024-10-23 Thread Purna Pavan Chandra Aekkaladevi
The `--event-monitor` option in cloud-hypervisor outputs events to a specified file. This file can then be used to monitor VM lifecycle, other vmm events and trigger appropriate actions. Signed-off-by: Purna Pavan Chandra Aekkaladevi Co-authored-by: Vineeth Pillai --- src/ch/ch_monitor.c | 20

[PATCH v3 0/5] ch: handle events from cloud-hypervisor

2024-10-23 Thread Purna Pavan Chandra Aekkaladevi
changes from v2->v3: * Remove patch 'utils: Implement virFileIsNamedPipe' as it is no more needed. * Remove the eventmonitorpath only if it exists * Added domain name as a prefix to logs from ch_events.c. This will make debugging easier. * Simplified event parsing logic by reserving a byte for nu

Re: [PATCH v2 15/20] testing: Enhance gdb probe script

2024-10-23 Thread Pierrick Bouvier
On 10/22/24 03:56, Alex Bennée wrote: From: Gustavo Romero Use list and set comprehension to simplify code. Also, gently handle invalid gdb filenames. Signed-off-by: Gustavo Romero Message-Id: <20241015145848.387281-1-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée --- scripts/probe-

Re: [PATCH v2 07/20] tests/tcg/x86_64: Add cross-modifying code test

2024-10-23 Thread Pierrick Bouvier
On 10/22/24 17:16, Ilya Leoshkevich wrote: On Tue, 2024-10-22 at 13:36 -0700, Pierrick Bouvier wrote: On 10/22/24 03:56, Alex Bennée wrote: From: Ilya Leoshkevich commit f025692c992c ("accel/tcg: Clear PAGE_WRITE before translation") fixed cross-modifying code handling, but did not add a test

Re: [PATCH v2 07/20] tests/tcg/x86_64: Add cross-modifying code test

2024-10-23 Thread Ilya Leoshkevich
On Tue, 2024-10-22 at 13:36 -0700, Pierrick Bouvier wrote: > On 10/22/24 03:56, Alex Bennée wrote: > > From: Ilya Leoshkevich > > > > commit f025692c992c ("accel/tcg: Clear PAGE_WRITE before > > translation") > > fixed cross-modifying code handling, but did not add a test. The > > changed code wa

Re: [PATCH v2 17/20] plugins: add ability to register a GDB triggered callback

2024-10-23 Thread Pierrick Bouvier
On 10/22/24 03:56, Alex Bennée wrote: Now gdbstub has gained the ability to extend its command tables we can allow it to trigger plugin callbacks. This is probably most useful for QEMU developers debugging plugins themselves but might be useful for other stuff. Trigger the callback by sending:

Re: [PATCH v2 16/20] MAINTAINERS: mention my plugins/next tree

2024-10-23 Thread Pierrick Bouvier
On 10/22/24 03:56, Alex Bennée wrote: Make it easier to find where plugin patches are being staged. Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 81396c9f15..02b8b2dfd6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [PATCH v2 13/20] tests/tcg: enable basic testing for aarch64_be-linux-user

2024-10-23 Thread Pierrick Bouvier
On 10/22/24 03:56, Alex Bennée wrote: We didn't notice breakage of aarch64_be because we don't have any TCG tests for it. However while the existing aarch64 compiler can target big-endian builds no one packages a BE libc. Instead we bang some rocks together to do the most basic of hello world wit

Re: [PATCH v2 12/20] config/targets: update aarch64_be-linux-user gdb XML list

2024-10-23 Thread Pierrick Bouvier
On 10/22/24 03:56, Alex Bennée wrote: Attempting to run the binary asserts when it can't find the XML entry. We can fix it so we don't although I suspect other stuff is broken. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2580 Signed-off-by: Alex Bennée --- configs/targets/aarch64_be-

Re: [PATCH v2 07/20] tests/tcg/x86_64: Add cross-modifying code test

2024-10-23 Thread Pierrick Bouvier
On 10/22/24 03:56, Alex Bennée wrote: From: Ilya Leoshkevich commit f025692c992c ("accel/tcg: Clear PAGE_WRITE before translation") fixed cross-modifying code handling, but did not add a test. The changed code was further improved recently [1], and I was not sure whether these modifications wer

Re: [PATCH v2 06/20] scripts/ci: remove architecture checks for build-environment updates

2024-10-23 Thread Pierrick Bouvier
On 10/22/24 03:56, Alex Bennée wrote: We were missing s390x here. There isn't much point testing for the architecture here as we will fail anyway if the appropriate package list is missing. Signed-off-by: Alex Bennée --- scripts/ci/setup/ubuntu/build-environment.yml | 2 -- 1 file changed, 2

Re: [PATCH v2 02/20] tests/docker: add NOFETCH env variable for testing

2024-10-23 Thread Pierrick Bouvier
On 10/22/24 03:55, Alex Bennée wrote: Testing non-auto built docker containers (i.e. custom built compilers) is a bit fiddly as you couldn't continue a build with a previously locally built container. While you can play games with REGISTRY its simpler to allow a NOFETCH that will go through the c

Re: [PATCH v2 01/20] tests/docker: Fix microblaze atomics

2024-10-23 Thread Pierrick Bouvier
On 10/22/24 03:55, Alex Bennée wrote: From: Ilya Leoshkevich GCC produces invalid code for microblaze atomics. The fix is unfortunately not upstream, so fetch it from an external location and apply it locally. Suggested-by: Peter Maydell Signed-off-by: Ilya Leoshkevich Message-Id: <20240919