[PATCH v1 2/5] qemu: parse deprecated-props from query-cpu-model-expansion response

2024-11-12 Thread Collin Walling
query-cpu-model-expansion may report an array of deprecated properties. This array is optional, and may not be supported for a particular architecture or reported for a particular CPU model. If the output is present, then capture it and store in a qemuMonitorCPUModelInfo struct for later use. The

[PATCH v1 0/5] Allow Guest CPU Model with Deprecated Features Disabled

2024-11-12 Thread Collin Walling
Add support for libvirt to query and cache an array of deprecated CPU features (aka CPU properties) for the host-model. This data is queried via a full query-cpu-model-expansion and cached in the QEMU capabilities file. This model expansion will depend on the availability of the "deprecated-props

[PATCH v1 5/5] conf: add deprecated_features attribute

2024-11-12 Thread Collin Walling
Add a new a attribute, deprecated_features='on|off' to the element. This is used to toggle features flagged as deprecated on the CPU model on or off. When this attribute is paired with 'on', deprecated features will not be filtered. When paired with 'off', any CPU features that are flagged as d

[PATCH v1 1/5] qemuMonitorJSONGetCPUModelExpansion: refactor parsing functions

2024-11-12 Thread Collin Walling
Refactor the CPU Model parsing functions within qemuMonitorJSONGetCPUModelExpansion. The new functions, qemuMonitorJSONParseCPUModelExpansionData and qemuMonitorJSONParseCPUModelExpansion invoke the functions they replace and leave room for a subsequent patch to handle parsing the (optional) depre

[PATCH v1 3/5] qemu_capabilities: query deprecated features for host-model

2024-11-12 Thread Collin Walling
Add QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION_DEPRECATED_PROPS for detecting if query-cpu-model-expansion can report deprecated CPU model properties. QEMU introduced this capability in 9.1 release. Add flag and deprecated features to the capabilities test data for QEMU 9.1 and 9.2 replies/XML since it c

[PATCH v1 4/5] virsh: add --disable-deprecated-features flag to domcapabilities

2024-11-12 Thread Collin Walling
Add a new flag, --disable-deprecated-features, to the domcapabilities command. This will modify the output to show the 'host-model' CPU with features flagged as deprecated paired with the 'disable' policy. virsh domcapabilities --disable-deprecated-features Signed-off-by: Collin Walling --- do

Re: [PATCH] Drop unused function declarations

2024-11-12 Thread Ján Tomko
On a Tuesday in 2024, Michal Privoznik wrote: When moving function and/or renaming them sometimes corresponding change to corresponding header file is not done. This leaves us with functions that are declared in header files, but nowhere implemented. Drop such declarations. Signed-off-by: Michal

Re: [PATCH] virnetserverclient.h: Fix typo in comment of virNetServerClientPrivPreExecRestart()

2024-11-12 Thread Ján Tomko
On a Tuesday in 2024, Michal Privoznik wrote: The function the comment is referring to is virNetServerClientPrivNew() not virNetServerClintPrivNew(). The latter doesn't even exist. Signed-off-by: Michal Privoznik --- src/rpc/virnetserverclient.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] Drop unused function declarations

2024-11-12 Thread Michal Privoznik
When moving function and/or renaming them sometimes corresponding change to corresponding header file is not done. This leaves us with functions that are declared in header files, but nowhere implemented. Drop such declarations. Signed-off-by: Michal Privoznik --- These were identified by a bash

Re: [PATCH v3] qemu_hotplug: Do not report unknown error when hot-unplugging non-existing device

2024-11-12 Thread Ján Tomko
On a Tuesday in 2024, Martin Kletzander wrote: When qemuDomainDeleteDevice() gets "DeviceNotFound" error it is a special case as we're trying to remove a device which does not exists any more. Such occasion is indicated by the return value -2. Callers of the aforementioned function ought to bas

[PATCH] virnetserverclient.h: Fix typo in comment of virNetServerClientPrivPreExecRestart()

2024-11-12 Thread Michal Privoznik
The function the comment is referring to is virNetServerClientPrivNew() not virNetServerClintPrivNew(). The latter doesn't even exist. Signed-off-by: Michal Privoznik --- src/rpc/virnetserverclient.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetserverclient.h

[PATCH v3] qemu_hotplug: Do not report unknown error when hot-unplugging non-existing device

2024-11-12 Thread Martin Kletzander
When qemuDomainDeleteDevice() gets "DeviceNotFound" error it is a special case as we're trying to remove a device which does not exists any more. Such occasion is indicated by the return value -2. Callers of the aforementioned function ought to base their behaviour on the return value. However n

Re: [PATCH v2] qemu_hotplug: Do not report unknown error when hot-unplugging non-existing device

2024-11-12 Thread Martin Kletzander
On Tue, Nov 12, 2024 at 02:10:31PM +0100, Ján Tomko wrote: On a Monday in 2024, Martin Kletzander wrote: When qemuDomainDeleteDevice() gets "DeviceNotFound" error it is a special case as we're trying to remove a device which does not exists any more. Such occasion is indicated by the return val

Re: [PATCH v2] qemu_hotplug: Do not report unknown error when hot-unplugging non-existing device

2024-11-12 Thread Ján Tomko
On a Monday in 2024, Martin Kletzander wrote: When qemuDomainDeleteDevice() gets "DeviceNotFound" error it is a special case as we're trying to remove a device which does not exists any more. Such occasion is indicated by the return value -2. Callers of the aforementioned function ought to base

Re: [PATCH] security_apparmor: store dynamically generated rules

2024-11-12 Thread Georgia Garcia
Hi Peter, On Mon, 2024-11-11 at 09:48 +0100, Peter Krempa wrote: > On Fri, Nov 08, 2024 at 15:58:35 -0300, Georgia Garcia wrote: > > Some rules are generated dynamically during boot and added to the > > AppArmor policy. An example of that is macvtap devices that call the > > AppArmorSetFDLabel hoo

Re: [PATCH 0/2] disk hotplug support for test hypervisor

2024-11-12 Thread John Levon
On Tue, Nov 12, 2024 at 09:14:22AM +0100, Michal Prívozník wrote: > On 11/1/24 23:31, John Levon wrote: > > John Levon (2): > > test_driver: provide basic disk hotplug support > > test_driver: provide basic disk hotunplug support > > > > src/test/test_driver.c | 276 +

Re: [PATCH] docs: Add Sys::Async::Virt to apps.html

2024-11-12 Thread Daniel P . Berrangé
On Tue, Nov 12, 2024 at 10:59:20AM +0100, Martin Kletzander wrote: > As requested on the libvirt users list I am adding this mention to the > apps page. > > Reported-by: Erik Huelsmann > Signed-off-by: Martin Kletzander > --- > docs/apps.rst | 5 + > 1 file changed, 5 insertions(+) > > dif

[PATCH] docs: Add Sys::Async::Virt to apps.html

2024-11-12 Thread Martin Kletzander
As requested on the libvirt users list I am adding this mention to the apps page. Reported-by: Erik Huelsmann Signed-off-by: Martin Kletzander --- docs/apps.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/apps.rst b/docs/apps.rst index 443c888c4d5d..b2168f9599bb 100644 --- a/d

Re: [PATCH v2] docs: Recommend virtio instead of virtio-(non-)transitional

2024-11-12 Thread Andrea Bolognani
On Tue, Nov 12, 2024 at 09:12:06AM +, Daniel P. Berrangé wrote: > On Mon, Nov 11, 2024 at 09:27:00AM +0100, Martin Kletzander wrote: > > > +Virtio device models > > > + > > > + > > > +Virtio devices come in several variants, some of which are only > > > applicable to > > >

Re: [PATCH] ci: Update with newer lcitool

2024-11-12 Thread Jiri Denemark
On Tue, Nov 12, 2024 at 09:05:38 +0100, Martin Kletzander wrote: > This switches to newer freebsd 14.1 and implements the new RUN_PIPELINE > behaviour introduced by Daniel. > > Signed-off-by: Martin Kletzander > --- > As far as I understand this does not need any change in the CI/CD settings in >

Re: [PATCH v2] docs: Recommend virtio instead of virtio-(non-)transitional

2024-11-12 Thread Daniel P . Berrangé
On Mon, Nov 11, 2024 at 09:27:00AM +0100, Martin Kletzander wrote: > On Thu, Nov 07, 2024 at 06:34:49PM +0100, Andrea Bolognani wrote: > > When virtio-(non-)transitional models were introduced, the > > documentation was updated to include them; at the same time, > > language was introduced indicati

Re: [PATCH 2/2] test_driver: provide basic disk hotunplug support

2024-11-12 Thread Michal Prívozník
On 11/1/24 23:31, John Levon wrote: > Signed-off-by: John Levon > --- > src/test/test_driver.c | 114 - > 1 file changed, 112 insertions(+), 2 deletions(-) > > diff --git a/src/test/test_driver.c b/src/test/test_driver.c > index b7e36e8451..789b1a 1006

Re: [PATCH 1/2] test_driver: provide basic disk hotplug support

2024-11-12 Thread Michal Prívozník
On 11/1/24 23:31, John Levon wrote: > Add some basic plumbing, based on the qemu driver. > > Signed-off-by: John Levon > --- > src/test/test_driver.c | 162 - > 1 file changed, 161 insertions(+), 1 deletion(-) > > diff --git a/src/test/test_driver.c b/src

Re: [PATCH 0/2] disk hotplug support for test hypervisor

2024-11-12 Thread Michal Prívozník
On 11/1/24 23:31, John Levon wrote: > John Levon (2): > test_driver: provide basic disk hotplug support > test_driver: provide basic disk hotunplug support > > src/test/test_driver.c | 276 - > 1 file changed, 273 insertions(+), 3 deletions(-) > Sorry

[PATCH] ci: Update with newer lcitool

2024-11-12 Thread Martin Kletzander
This switches to newer freebsd 14.1 and implements the new RUN_PIPELINE behaviour introduced by Daniel. Signed-off-by: Martin Kletzander --- As far as I understand this does not need any change in the CI/CD settings in gitlab, but I do not have access to those. ci/cirrus/freebsd-14.vars |