Re: [PATCH v5 07/18] remote: New APIs for ThrottleGroup lifecycle management

2025-02-06 Thread Harikumar Rajkumar
> On Mon, Nov 18, 2024 at 19:24:15 +0530, Harikumar R wrote: > I don't think we should do the 'change a subset of' semantics any more. > It was proven that it doesn't make sense. Specifically it's not possible > to distinguish between "I don't want to change this field" and "I want > to delete/reve

Re: [PATCH v2] ch: Enable SEV SNP support

2025-02-06 Thread Daniel P . Berrangé
On Thu, Feb 06, 2025 at 11:11:11AM -0600, Praveen K Paladugu wrote: > Enable SEV-SNP support for ch guests. > > Co-Authored-by: Smit Gardhariya > Signed-off-by: Praveen K Paladugu > --- > src/ch/ch_monitor.c | 70 + > 1 file changed, 58 insertions(+),

Re: [PATCH] ch: Enable SEV SNP support

2025-02-06 Thread Praveen K Paladugu
On 2/4/2025 3:33 PM, Peter Krempa wrote: On Tue, Feb 04, 2025 at 14:36:48 -0600, Praveen K Paladugu wrote: Enable SEV-SNP support for ch guests. Co-Authored-by: Smit Gardhariya Signed-off-by: Praveen K Paladugu --- src/ch/ch_monitor.c | 74 +

[PATCH v2] ch: Enable SEV SNP support

2025-02-06 Thread Praveen K Paladugu
Enable SEV-SNP support for ch guests. Co-Authored-by: Smit Gardhariya Signed-off-by: Praveen K Paladugu --- src/ch/ch_monitor.c | 70 + 1 file changed, 58 insertions(+), 12 deletions(-) diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c index bed

[PATCH 0/3] qemu: fix setup of FD passed disks

2025-02-06 Thread Peter Krempa
See 3/3 Peter Krempa (3): qemuxmlconftest: Allow testing of the 'writable' flag for passed FDs for disks qemuxmlconftest: Add testing of FDs with 'writable' flag in 'disk-source-fd' qemu: domain: Initialize FD passthrough for a virStorageSource before using it src/qemu/qemu_dom

[PATCH] node_device_udev: add error reporting to udevProcessCCWGroup

2025-02-06 Thread Boris Fiuczynski
Add reporting an internal error when the string to type conversion of devtype fails as this indicates a serious problem since devtype was used to get into this method during the udev event handling. Signed-off-by: Boris Fiuczynski --- src/node_device/node_device_udev.c | 6 +- 1 file changed

[PATCH 3/3] qemu: domain: Initialize FD passthrough for a virStorageSource before using it

2025-02-06 Thread Peter Krempa
The call to 'qemuBlockStorageSourceNeedsFormatLayer()' bases the decision also on the state of the passed FD, so we must initialize the passthrough data via 'qemuDomainPrepareStorageSourceFDs()' before the aforementioned call. In the test change it's visible that we didn't add the necessary 'raw'

[PATCH 2/3] qemuxmlconftest: Add testing of FDs with 'writable' flag in 'disk-source-fd'

2025-02-06 Thread Peter Krempa
Add few examples of fd groups with the 'writable' flag set, when passing a single FD. Notably as a top level image of a readonly disk (even when that doesn't make much sense) and also as a base image of a chain. Note that this documents a status quo of a bug fixed in upcoming patch. Signed-off-by

[PATCH 1/3] qemuxmlconftest: Allow testing of the 'writable' flag for passed FDs for disks

2025-02-06 Thread Peter Krempa
Pass also the 'writable' state to the fake passed FDs so that we can test it. Signed-off-by: Peter Krempa --- tests/qemuxmlconftest.c | 6 +++--- tests/testutilsqemu.c | 2 ++ tests/testutilsqemu.h | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/qemuxmlconftest.c

Re: [PATCH 0/8] nodedev: add support for ccwgroup based qeth devices

2025-02-06 Thread Boris Fiuczynski
On 2/5/25 18:01, Michal Prívozník wrote: On 2/4/25 18:11, Boris Fiuczynski wrote: CCW group devices are devices that use multiple subchannels on the mainframe's channel subsystem. A qeth group device maps to subchannels and their corresponding device numbers and device bus-IDs. The qeth device

Re: [PATCH 6/8] nodedev: add ccwgroup node device support

2025-02-06 Thread Boris Fiuczynski
On 2/5/25 19:37, Peter Krempa wrote: On Tue, Feb 04, 2025 at 18:11:41 +0100, Boris Fiuczynski wrote: Add ccwgroup node device type supporting qeth generic driver. Signed-off-by: Boris Fiuczynski --- docs/manpages/virsh.rst | 6 +- include/libvirt/libvirt-nodedev.h

Re: [PATCH] docs: Reword virDomainGetEmulatorPinInfo description

2025-02-06 Thread Michal Prívozník
On 1/13/25 15:48, Martin Kletzander wrote: > This API only queries the XML settings and not the running threads > themselves. In order to avoid confusion, change the wording slightly. > > Resolves: https://issues.redhat.com/browse/RHEL-72052 > Signed-off-by: Martin Kletzander > --- > src/libvir

Re: [PATCH] tests: emuxmlconfdata: Update launch-security-sev-snp.xml

2025-02-06 Thread Martin Kletzander
On Mon, Jan 27, 2025 at 12:39:38PM +0100, Michal Privoznik wrote: Recently, I was part of a discussion where it was suspected that libvirt does not pick up correct FW for SEV-SNP guests. Update our test to demonstrate it does. Signed-off-by: Michal Privoznik With s/emu/qemu/ in $SUBJ Reviewe

Re: [PATCH] nodedev: udev: Hook up virFileWaitForExist to address uevent, race of pci device

2025-02-06 Thread Martin Kletzander
On Thu, Dec 19, 2024 at 11:07:35PM +0800, Guoyi Tu wrote: this commit addresses the same issue that as commit 1af45804 does. the following message is copying from that commit: If we find ourselves in the situation that the 'add' uevent has been fired earlier than the sysfs tree for a device