Re: Question about SEV* guests and automatic firmware selection

2025-04-24 Thread Jim Fehlig via Devel
On 4/24/25 04:59, Daniel P. Berrangé wrote: On Mon, Apr 21, 2025 at 01:38:35PM -0600, Jim Fehlig via Devel wrote: Hi All, While investigating an internal bug report, we noticed that a minimal firmware auto-selection configuration along with SEV* fails to find a match. E.g. the following config

[PATCH] conf: Fix handling of vlan with one tagged vlan id

2025-04-24 Thread Leigh Brown
Yanqiu Zhang reported [1] that when a vlan is defined with a single vlan id and native mode set to tagged, the vlan was not setup correctly using the standard Linux bridge functionality. This is due a conflict between the XML validation and the bridge functionality. The XML validation will allow a

[PATCH v2] virhostcpu: Fix potential use of unallocated memory

2025-04-24 Thread Felix Huettner via Devel
In case of a host that has a large number of cpus offline the count of host cpus and the last bit set in the virHostCPUGetOnlineBitmap might diverge significantly. This can e.g. be the case when disabling smt via /sys/devices/system/cpu/smt/control. On the host this looks like: ``` $ cat /sys/devi

Re: [PATCH] virhostcpu: Fix potential use of unallocated memory

2025-04-24 Thread Felix Huettner via Devel
On Thu, Apr 24, 2025 at 02:07:17PM +0100, Daniel P. Berrangé wrote: > > On Thu, Apr 24, 2025 at 01:22:46PM +0200, Felix Huettner via Devel wrote: > > In case of a host that has a large number of cpus offline the count of > > host cpus and the last bit set in the virHostCPUGetOnlineBitmap might > >

[PATCH] qemuxmlactivetest: Don't segfault when capability XMLs are invalid

2025-04-24 Thread Peter Krempa via Devel
From: Peter Krempa This is purely a devel-time problem in the test suite. 'qemuxmlactivetest' invokes the whole test worker twice, once for inactive output and second time for active. Now 'testQemuInfoInitArgs' returns a failure if the XML is invalid and the test is skipped. On another invocati

Re: [PATCH 2/3] qemu: Replace usb-storage with usb-bot

2025-04-24 Thread Peter Krempa via Devel
On Sat, Mar 08, 2025 at 14:57:41 +0900, Akihiko Odaki wrote: > usb-storage is a compound device that automatically creates a USB mass > storage device and a SCSI device as its backend. Unfortunately it lacks > some configuration options that are usually present with a SCSI device, > and cannot repr

Re: [PATCH] virhostcpu: Fix potential use of unallocated memory

2025-04-24 Thread Daniel P . Berrangé via Devel
On Thu, Apr 24, 2025 at 01:22:46PM +0200, Felix Huettner via Devel wrote: > In case of a host that has a large number of cpus offline the count of > host cpus and the last bit set in the virHostCPUGetOnlineBitmap might > diverge significantly. This can e.g. be the case when disabeling smt via > /sy

[PATCH] virhostcpu: Fix potential use of unallocated memory

2025-04-24 Thread Felix Huettner via Devel
In case of a host that has a large number of cpus offline the count of host cpus and the last bit set in the virHostCPUGetOnlineBitmap might diverge significantly. This can e.g. be the case when disabeling smt via /sys/devices/system/cpu/smt/control. On the host this looks like: ``` $ cat /sys/dev

Re: Question about SEV* guests and automatic firmware selection

2025-04-24 Thread Daniel P . Berrangé via Devel
On Mon, Apr 21, 2025 at 01:38:35PM -0600, Jim Fehlig via Devel wrote: > Hi All, > > While investigating an internal bug report, we noticed that a minimal > firmware auto-selection configuration along with SEV* fails to find a match. > E.g. the following config > > > > hvm > > >

Re: [PATCH 0/2] qemucapabilitiestest: Update of x86_64 test data for qemu-10.0 release

2025-04-24 Thread Ján Tomko via Devel
On a Wednesday in 2025, Peter Krempa via Devel wrote: Peter Krempa (2): qemucapabilitiestest: Final update for qemu-10.0 release on x86_64 qemucapabilitiestest: Final update for qemu-10.0 release on x86_64 of the 'amdsev' variant .../caps_10.0.0_x86_64+amdsev.replies | 199 +

Re: [PATCH] rpm: Enable KVM for riscv64 on RHEL 10+

2025-04-24 Thread Daniel P . Berrangé via Devel
On Wed, Apr 23, 2025 at 11:39:34AM -0700, Andrea Bolognani wrote: > On Fri, Mar 14, 2025 at 10:13:49AM +, Daniel P. Berrangé wrote: > > On Fri, Mar 14, 2025 at 11:01:21AM +0100, Andrea Bolognani wrote: > > > %define arches_qemu_kvm %{ix86} x86_64 %{power64} %{arm} aarch64 > > > s390x

Re: [PATCH] qemuSnapshotDeleteValidate: Fix crash when disk is not found in VM definition

2025-04-24 Thread Peter Krempa via Devel
On Tue, Apr 22, 2025 at 18:51:18 +0800, jungleman759 wrote: > Hi > Thanks for following up, and sorry for the delay in getting back to you. > You're right to suspect the issue might be related to device changes. Here’s > how the crash can be triggered: > The VM initially uses a SATA controller, wi