Re: [PATCH V1 0/6] fast qom tree get

2025-04-28 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 4/28/2025 4:04 AM, Markus Armbruster wrote: >> Steven Sistare writes: >> >>> On 4/9/2025 3:39 AM, Markus Armbruster wrote: Hi Steve, I apologize for the slow response. Steve Sistare writes: > Using qom-list and qom-get to get all the nodes an

Re: [PATCH V1 0/6] fast qom tree get

2025-04-28 Thread Steven Sistare via Devel
On 4/28/2025 4:04 AM, Markus Armbruster wrote: Steven Sistare writes: On 4/9/2025 3:39 AM, Markus Armbruster wrote: Hi Steve, I apologize for the slow response. Steve Sistare writes: Using qom-list and qom-get to get all the nodes and property values in a QOM tree can take multiple second

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-28 Thread Pierrick Bouvier
On 4/25/25 11:21 PM, Markus Armbruster wrote: Trouble is some uses of the second kind are in QAPI conditionals. I can see three options: (1) Drop these conditionals. (2) Replace them by run-time checks. (3) Have target-specific QAPI-generated code for multiple targets coexist in the sing

Re: [PATCH 2/2] scripts: Fix reading list of files in mock-noinline.py

2025-04-28 Thread Daniel P . Berrangé via Devel
On Mon, Apr 28, 2025 at 01:47:50PM +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > The mock-noinline.py script is fed list of files through its > stdin, each file on its own line. Unfortunately, the way the > script is written does nothing as the trailing newline character >

Re: [PATCH 1/2] util: Add missing G_NO_INLINE annotation

2025-04-28 Thread Daniel P . Berrangé via Devel
On Mon, Apr 28, 2025 at 01:47:49PM +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > There are two functions that are mocked, but are missing required > G_NO_INLINE attribute: virFirewallDIsRegistered() and > virHostCPUGetPhysAddrSize(). Add it. > > Signed-off-by: Michal Priv

Re: [PATCH] qemu: Add GTK display with OpenGL support

2025-04-28 Thread Kirill Shchetiniuk via Devel
On Mon, Apr 28, 2025 at 02:40:49PM +0200, Peter Krempa wrote: > On Mon, Apr 28, 2025 at 12:22:22 +0200, Kirill Shchetiniuk via Devel wrote: > > From: Kirill Shchetiniuk > > > > Introduce GTK display support with OpenGL for the QEMU driver. > > > > - Add new XML options for GTK display type. > >

Re: [PATCH 0/3] Preper noipa attribute over noinline

2025-04-28 Thread Daniel P . Berrangé via Devel
On Mon, Apr 28, 2025 at 03:20:55PM +0200, Michal Privoznik via Devel wrote: > Somewhat green-ish pipeline: > > https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1790043585 > > Jobs that failed are unrelated. > > Thing is, our upstream pipeline started failing on Rawhide + gcc because > of I

Re: [PATCH] qemu: Add GTK display with OpenGL support

2025-04-28 Thread Kirill Shchetiniuk via Devel
On Mon, Apr 28, 2025 at 12:33:19PM +0200, Peter Krempa wrote: > On Mon, Apr 28, 2025 at 12:22:22 +0200, Kirill Shchetiniuk via Devel wrote: > > From: Kirill Shchetiniuk > > > > Introduce GTK display support with OpenGL for the QEMU driver. > > > > - Add new XML options for GTK display type. > >

Re: [PATCH 1/3] internal: Introduce ATTRIBUTE_NOIPA

2025-04-28 Thread Daniel P . Berrangé via Devel
On Mon, Apr 28, 2025 at 03:20:56PM +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > Currently, if we want to mock a function the noinline attribute > is appended after the function (via G_NO_INLINE macro). This used > to work for non pure functions. But there are some trivial

Re: [PATCH] domaincapstest: Remove XMLs for already dropped qemu versions (4.2.0 - 5.1.0)

2025-04-28 Thread Ján Tomko via Devel
On a Monday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa The files were forgotten after the previous bump to use qemu-5.2 as minimum. The data for qemu-5.2, qemu-6.0, and qemu-6.1 was already removed when bumping to qemu-6.2. Signed-off-by: Peter Krempa --- .../domaincapsdata/qem

[PATCH 2/3] src: s/G_NO_INLINE/ATTRIBUTE_NOIPA/

2025-04-28 Thread Michal Privoznik via Devel
From: Michal Privoznik Per change in coding style done in previous commit, ATTRIBUTE_NOIPA should be used instead of G_NO_INLINE for functions that are mocked in our test suite. Do the change. Signed-off-by: Michal Privoznik --- src/cpu/cpu.h | 2 +- src/hypervisor/domain_

[PATCH 3/3] scripts: Adapt mock-noinline.py to ATTRIBUTE_NOIPA

2025-04-28 Thread Michal Privoznik via Devel
From: Michal Privoznik The script is renamed to mock-noipa.py and adjusted to check for the new attribute. Signed-off-by: Michal Privoznik --- build-aux/syntax-check.mk | 4 ++-- scripts/meson.build | 2 +- scripts/{mock-noinline.py => mock-noipa.py} |

[PATCH 1/3] internal: Introduce ATTRIBUTE_NOIPA

2025-04-28 Thread Michal Privoznik via Devel
From: Michal Privoznik Currently, if we want to mock a function the noinline attribute is appended after the function (via G_NO_INLINE macro). This used to work for non pure functions. But there are some trivial functions (for instance virQEMUCapsProbeHVF()) that are pure, i.e. have no side effec

[PATCH 0/3] Preper noipa attribute over noinline

2025-04-28 Thread Michal Privoznik via Devel
Somewhat green-ish pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1790043585 Jobs that failed are unrelated. Thing is, our upstream pipeline started failing on Rawhide + gcc because of IPA. The unfortunate part is, noinline does not guarantee the function is mockable. The fortu

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-28 Thread Philippe Mathieu-Daudé
On 28/4/25 13:07, Markus Armbruster wrote: Peter Krempa writes: The second thing that libvirt does after 'query-version' is 'query-target'. So what should libvirt do once multiple targets are supported? How do we query CPUs for each of the supported targets? Will the result be the same if

Re: [PATCH] qemu: Add GTK display with OpenGL support

2025-04-28 Thread Peter Krempa via Devel
On Mon, Apr 28, 2025 at 12:22:22 +0200, Kirill Shchetiniuk via Devel wrote: > From: Kirill Shchetiniuk > > Introduce GTK display support with OpenGL for the QEMU driver. > > - Add new XML options for GTK display type. > - Include capability flags for the QEMU driver. > > Note: The `QEMU_CAPS_

Re: [PATCH] qemucapabilitiesdata: Enable GTK graphics for 'caps_10.0.0_x86_64'

2025-04-28 Thread Pavel Hrdina via Devel
On Mon, Apr 28, 2025 at 02:24:20PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > The common x86_64 test output was usually built without GTK as I've had > that in my build script for a long time. Enable it now as GTK UI is > enabled by many distros and upcoming patches plan to add

Re: [PATCH 0/2] Make mock-noinline.py work again

2025-04-28 Thread Peter Krempa via Devel
On Mon, Apr 28, 2025 at 13:47:48 +0200, Michal Privoznik via Devel wrote: > *** BLURB HERE *** Reviewed-by: Peter Krempa > > Michal Prívozník (2): > util: Add missing G_NO_INLINE annotation > scripts: Fix reading list of files in mock-noinline.py

Re: [PATCH] qemu: Add GTK display with OpenGL support

2025-04-28 Thread Peter Krempa via Devel
On Mon, Apr 28, 2025 at 12:57:42 +0200, Peter Krempa via Devel wrote: > On Mon, Apr 28, 2025 at 12:33:19 +0200, Peter Krempa via Devel wrote: > > On Mon, Apr 28, 2025 at 12:22:22 +0200, Kirill Shchetiniuk via Devel wrote: [...] > Since the 'gtk' backend in support was introduced predating qemu-2.

[PATCH] qemucapabilitiesdata: Enable GTK graphics for 'caps_10.0.0_x86_64'

2025-04-28 Thread Peter Krempa via Devel
From: Peter Krempa The common x86_64 test output was usually built without GTK as I've had that in my build script for a long time. Enable it now as GTK UI is enabled by many distros and upcoming patches plan to add support to libvirt as well. Signed-off-by: Peter Krempa --- tests/qemucapabili

[PATCH 2/2] scripts: Fix reading list of files in mock-noinline.py

2025-04-28 Thread Michal Privoznik via Devel
From: Michal Privoznik The mock-noinline.py script is fed list of files through its stdin, each file on its own line. Unfortunately, the way the script is written does nothing as the trailing newline character prevents any .endswith() match. Strip each line of white spaces. Signed-off-by: Michal

[PATCH 1/2] util: Add missing G_NO_INLINE annotation

2025-04-28 Thread Michal Privoznik via Devel
From: Michal Privoznik There are two functions that are mocked, but are missing required G_NO_INLINE attribute: virFirewallDIsRegistered() and virHostCPUGetPhysAddrSize(). Add it. Signed-off-by: Michal Privoznik --- src/util/virfirewalld.h | 2 +- src/util/virhostcpu.h | 2 +- 2 files change

[PATCH 0/2] Make mock-noinline.py work again

2025-04-28 Thread Michal Privoznik via Devel
*** BLURB HERE *** Michal Prívozník (2): util: Add missing G_NO_INLINE annotation scripts: Fix reading list of files in mock-noinline.py scripts/mock-noinline.py | 3 ++- src/util/virfirewalld.h | 2 +- src/util/virhostcpu.h| 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) -- 2

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-28 Thread Markus Armbruster via Devel
Peter Krempa writes: > On Fri, Apr 25, 2025 at 17:38:44 +0200, Markus Armbruster via Devel wrote: >> Pierrick Bouvier writes: > > [...] > >> To be precise: conditionals that use macros restricted to >> target-specific code, i.e. the ones poisoned by exec/poison.h. Let's >> call them target-spec

Re: [PATCH] qemu: Add GTK display with OpenGL support

2025-04-28 Thread Peter Krempa via Devel
On Mon, Apr 28, 2025 at 12:33:19 +0200, Peter Krempa via Devel wrote: > On Mon, Apr 28, 2025 at 12:22:22 +0200, Kirill Shchetiniuk via Devel wrote: > > From: Kirill Shchetiniuk > > > > Introduce GTK display support with OpenGL for the QEMU driver. > > > > - Add new XML options for GTK display t

Re: [PATCH] qemu: Add GTK display with OpenGL support

2025-04-28 Thread Peter Krempa via Devel
On Mon, Apr 28, 2025 at 12:22:22 +0200, Kirill Shchetiniuk via Devel wrote: > From: Kirill Shchetiniuk > > Introduce GTK display support with OpenGL for the QEMU driver. > > - Add new XML options for GTK display type. > - Include capability flags for the QEMU driver. > > Note: The `QEMU_CAPS_

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-28 Thread Peter Krempa via Devel
On Fri, Apr 25, 2025 at 14:07:34 -0700, Pierrick Bouvier wrote: > On 4/25/25 08:38, Markus Armbruster wrote: > > Pierrick Bouvier writes: > > > > > Note: This RFC was posted to trigger a discussion around this topic, and > > > it's > > > not expected to merge it as it is. > > > > > > Context >

[PATCH] qemu: Add GTK display with OpenGL support

2025-04-28 Thread Kirill Shchetiniuk via Devel
From: Kirill Shchetiniuk Introduce GTK display support with OpenGL for the QEMU driver. - Add new XML options for GTK display type. - Include capability flags for the QEMU driver. Note: The `QEMU_CAPS_GTK_GL` flag cannot yet be checked, so device definition validation is incomplete. A placeho

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-28 Thread Peter Krempa via Devel
On Fri, Apr 25, 2025 at 17:38:44 +0200, Markus Armbruster via Devel wrote: > Pierrick Bouvier writes: [...] > To be precise: conditionals that use macros restricted to > target-specific code, i.e. the ones poisoned by exec/poison.h. Let's > call them target-specific QAPI conditionals. > > The

Entering freeze for libvirt-11.3.0

2025-04-28 Thread Jiri Denemark via Devel
I have just tagged v11.3.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH] po/zh_CN.po: Fix some translation issues

2025-04-28 Thread Peter Krempa via Devel
On Mon, Apr 28, 2025 at 09:57:50 +0200, Jiri Denemark via Devel wrote: > On Sun, Apr 27, 2025 at 10:44:20 +0800, liu.son...@zte.com.cn wrote: > > From: QiangWei Zhang > > > > Swap the order of the two objects to ensure that the logic of the > > two objects translated into Chinese is correct. > >

Re: [PATCHv2 5/5] NEWS: Document qemu nvme disk emulation feature

2025-04-28 Thread Peter Krempa via Devel
On Sun, Apr 27, 2025 at 19:48:07 +0800, honglei.w...@smartx.com wrote: > From: ray > > Signed-off-by: ray > --- > NEWS.rst | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 3c13a84a1b..938c9ba559 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @

Re: [PATCHv2 4/5] tests: Add test case for nvme-ns device configuration

2025-04-28 Thread Peter Krempa via Devel
On Sun, Apr 27, 2025 at 19:48:06 +0800, honglei.w...@smartx.com wrote: > From: ray > > Signed-off-by: ray > --- > .../disk-nvme-ns-device.x86_64-latest.args | 36 +++ > .../disk-nvme-ns-device.x86_64-latest.xml | 42 > ++ > tests/qemuxmlconf

Re: [PATCHv2 3/5] schema: Add nvme controller and nvme-ns bus defination

2025-04-28 Thread Peter Krempa via Devel
On Sun, Apr 27, 2025 at 19:48:05 +0800, honglei.w...@smartx.com wrote: > From: ray > > Signed-off-by: ray > --- > src/conf/schemas/domaincommon.rng | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/src/conf/schemas/domaincommon.rng > b/src/conf/schemas/domai

Re: [PATCH V1 0/6] fast qom tree get

2025-04-28 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 4/9/2025 3:39 AM, Markus Armbruster wrote: >> Hi Steve, I apologize for the slow response. >> >> Steve Sistare writes: >> >>> Using qom-list and qom-get to get all the nodes and property values in a >>> QOM tree can take multiple seconds because it requires 1000's of

Re: [PATCH] po/zh_CN.po: Fix some translation issues

2025-04-28 Thread Jiri Denemark via Devel
On Sun, Apr 27, 2025 at 10:44:20 +0800, liu.son...@zte.com.cn wrote: > From: QiangWei Zhang > > Swap the order of the two objects to ensure that the logic of the > two objects translated into Chinese is correct. Hi, we use Fedora Weblate for translations: https://translate.fedoraproject.org/pro

[PATCH] po/zh_CN.po: Fix some translation issues

2025-04-28 Thread liu.song13
From: QiangWei Zhang Swap the order of the two objects to ensure that the logic of the two objects translated into Chinese is correct. Signed-off-by: QiangWei Zhang --- po/zh_CN.po | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/po/zh_CN.po b/po

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-28 Thread Pierrick Bouvier
On 4/25/25 14:07, Pierrick Bouvier wrote: QAPI/QMP introspection has all commands and events, and all types reachable from them. query-qmp-schema returns an array, where each array element describes one command, event, or type. When a command, event, or type is conditional in the schema, the el

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-28 Thread Pierrick Bouvier
On 4/25/25 08:38, Markus Armbruster wrote: Pierrick Bouvier writes: Note: This RFC was posted to trigger a discussion around this topic, and it's not expected to merge it as it is. Context === Linaro is working towards heterogeneous emulation, mixing several architectures in a single QEM

Re: [PATCHv2 2/5] qemu_capabilities: Add support for nvme-ns bus capabilities

2025-04-28 Thread Peter Krempa via Devel
On Sun, Apr 27, 2025 at 19:48:04 +0800, honglei.w...@smartx.com wrote: > From: ray > > Signed-off-by: ray > --- Generally patches adding a capability flag should only add the capability flag. Thus you'll need to split this patch. 1) capability addition - move it ahead to the beginning of t

Re: [PATCHv2 1/5] qemu: Add support for NVMe namespace disk bus type

2025-04-28 Thread Peter Krempa via Devel
On Sun, Apr 27, 2025 at 19:48:03 +0800, honglei.w...@smartx.com wrote: > From: ray > > This patch extends the disk bus support by introducing a new nvme-ns bus type. > > The nvme-ns bus disk needs to be attached to nvme controller. A controller > can contain multiple nvme-ns disk devices. > > S