Similar to the QEMU driver, the ch driver receives support for
configuration files that allows doing certain configuration on the
virtchd daemon.
The initial use case will be setting the verbosity of the cloud
hypervisor instances started by virtchd, but the implementation allows
for adding furthe
Allow a user to set the verbosity of the cloud hypervisor instances by
specifying it in the ch.conf configuration file.
---
src/ch/ch_conf.c| 10 ++
src/ch/ch_conf.h| 15 +++
src/ch/ch_monitor.c | 6 ++
3 files changed, 31 insertions(+)
diff --git a/src/ch/ch_conf
Similar to the qemu.conf file that allows QEMU specific configurations we add
the possibility to specify a ch.conf file for Cloud Hypervisor configuration.
The initial single config option is the log level, which sets the verbosity of
the Cloud Hypervisor process. This allows for simpler debugging
On 5/22/25 1:33 AM, Collin Walling wrote:
Please refer to v3 and ignore this version. I found an issue after
posting. It is fixed in v3.
--
Regards,
Collin
To ease the user with defining a guest with a migratable CPU model,
let's disable the deprecated features from the get-go. If these
features are still desired, they may be reenabled via the
deprecated_features='on' attribute.
Some existing tests utilize this updated behavior, so update the CPU
fe
Currently, virQEMUCapsUpdateCPUDeprecatedFeatures only allows for
disabling deprecated features. This locks the deprecated_features
attribute to only do something if set to 'off'.
Let's add a virCPUFeaturePolicy to the function's parameters which will
allow the caller to decide what happens to th
Group up the deprecated features code into a single block to keep things
clean; only check if the deprecated_features attribute is present
once and then do relevent work.
Signed-off-by: Collin Walling
---
src/qemu/qemu_process.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
Changelog
v3
- added qemu caps check to avoid breaking s390 guests trying to
default deprecated_features='off' on QEMU versions that
do not support reporting these features
v2
- changed behavior from disabling features on the host model to
instead flagging
On 5/22/25 1:33 AM, Collin Walling wrote:
> Group up the deprecated features code into a single block to keep things
> clean; only check if the deprecated_features attribute is present
> once and then do relevent work.
>
> Signed-off-by: Collin Walling
> ---
> src/qemu/qemu_process.c | 13 ++
To ease the user with defining a guest with a migratable CPU model,
let's disable the deprecated features from the get-go if using mode
host-model. If these features are still desired, they may be
reenabled via the deprecated_features='on' attribute.
Some existing tests utilize this updated behav
Group up the deprecated features code into a single block to keep things
clean; only check if the deprecated_features attribute is present
once and then do relevent work.
Signed-off-by: Collin Walling
---
src/qemu/qemu_process.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
Currently, virQEMUCapsUpdateCPUDeprecatedFeatures only allows for
disabling deprecated features. This locks the deprecated_features
attribute to only do something if set to 'off'.
Let's add a virCPUFeaturePolicy to the function's parameters which will
allow the caller to decide what happens to th
Changelog
v2
- changed behavior from disabling features on the host model to
instead flagging the guest CPU to disable deprecated features
- removed disabling deprecated features on host model in
virQEMUCapsInitCPUModelS390
- added flagging deprecated_feats in qemu
From: Peter Krempa
Explain what the individual settings actually result in. The changes
are based on the paraprhase of qemu documentation which in
'qemu-options.hx' states:
``werror=action,rerror=action``
Specify which action to take on write and read errors. Valid
actions are: "ig
On Wed, May 21, 2025 at 08:37:08AM +0200, Markus Armbruster wrote:
> Commit 4d8b0f0a9536 (v6.2.0) deprecate incorrectly typed device_add
> arguments. Commit be93fd53723c (qdev-monitor: avoid QemuOpts in QMP
> device_add) fixed them for v9.2.0, but neglected to update
> documentation. Do that now.
On Wed, May 21, 2025 at 04:28:33PM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > On Wed, May 21, 2025 at 08:37:09AM +0200, Markus Armbruster wrote:
> >> Argument @detach has always been ignored. Start the clock to get rid
> >> of it.
> >>
> >> Cc: Peter Xu
> >> Cc: Fabiano Rosas
>
Peter Xu writes:
> On Wed, May 21, 2025 at 08:37:09AM +0200, Markus Armbruster wrote:
>> Argument @detach has always been ignored. Start the clock to get rid
>> of it.
>>
>> Cc: Peter Xu
>> Cc: Fabiano Rosas
>> Signed-off-by: Markus Armbruster
>> ---
>> docs/about/deprecated.rst | 5 +
On Wed, May 21, 2025 at 08:37:09AM +0200, Markus Armbruster wrote:
> Argument @detach has always been ignored. Start the clock to get rid
> of it.
>
> Cc: Peter Xu
> Cc: Fabiano Rosas
> Signed-off-by: Markus Armbruster
> ---
> docs/about/deprecated.rst | 5 +
> qapi/migration.json
Markus Armbruster writes:
> Argument @detach has always been ignored. Start the clock to get rid
> of it.
>
> Cc: Peter Xu
> Cc: Fabiano Rosas
> Signed-off-by: Markus Armbruster
Reviewed-by: Fabiano Rosas
On 5/15/25 10:42, Kirill Shchetiniuk via Devel wrote:
> Hello everyone,
>
> Sometime ago I sent a patch changing the XML schema to add GTK support for
> libvirt. As the type for one path argument, I used the type, simply
> copying the similar approach from another place in the XML schema defini
Peter Krempa writes:
> On Wed, May 21, 2025 at 09:46:10 +0200, Peter Krempa via Devel wrote:
>> On Wed, May 21, 2025 at 08:37:09 +0200, Markus Armbruster via Devel wrote:
>> > Argument @detach has always been ignored. Start the clock to get rid
>> > of it.
>> >
>> > Cc: Peter Xu
>> > Cc: Fabia
On 5/21/25 10:06, Peter Krempa via Devel wrote:
> QEMU is deprecating 'detach' argument of 'migrate' as it was never
> actually used. Drop it in libvirt as we always specify it.
>
> The monitor handler of 'dump-guest-memory' allows controlling 'detach'
> but always passes true. Libvirt doesn't wan
On Wed, May 21, 2025 at 09:46:10 +0200, Peter Krempa via Devel wrote:
> On Wed, May 21, 2025 at 08:37:09 +0200, Markus Armbruster via Devel wrote:
> > Argument @detach has always been ignored. Start the clock to get rid
> > of it.
> >
> > Cc: Peter Xu
> > Cc: Fabiano Rosas
> > Signed-off-by: Ma
From: Peter Krempa
The argument was always ignored by qemu [1], as of qemu-10.1 it will be
deprecated. As it was always unused/ignored we can drop it without any
extra logic.
[1] qemu docs state:
3. The user Monitor's "detach" argument is invalid in QMP and
should not be used.
Signed-o
From: Peter Krempa
The only caller always passes 'true'. We also don't want to ever use the
blocking variant as it blocks the whole monitor until dump finishes.
Hardcode it to 'true' in the monitor code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 2 +-
src/qemu/qemu_monito
QEMU is deprecating 'detach' argument of 'migrate' as it was never
actually used. Drop it in libvirt as we always specify it.
The monitor handler of 'dump-guest-memory' allows controlling 'detach'
but always passes true. Libvirt doesn't want to block the monitor so
hardcode 'true' in the monitor c
The POC currently detaches the network device prior to live migration because
there is some missing cloud hypervisor support.
We might want to restrict live mive migration to VMs without network devices
until the issue is resolved in cloud hypervisor.
See https://github.com/cloud-hypervisor/clo
On Wed, May 21, 2025 at 08:37:09 +0200, Markus Armbruster via Devel wrote:
> Argument @detach has always been ignored. Start the clock to get rid
> of it.
>
> Cc: Peter Xu
> Cc: Fabiano Rosas
> Signed-off-by: Markus Armbruster
> ---
> docs/about/deprecated.rst | 5 +
> qapi/migration.jso
28 matches
Mail list logo
