[libvirt PATCH v2 7/7] qemu: format pt and xstup on the command line

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c| 2 ++ tests/qemuxmlconfdata/amd-iommu.x86_64-latest.args | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6fae9b1f5a..b7

[libvirt PATCH v2 5/7] conf: add passthrough and xtsup attributes for IOMMU

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko For the newly supported AMD device. Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 8 src/conf/domain_conf.c | 30 + src/conf/domain_conf.h | 2 ++ src/conf/schemas/domaincommon.rng | 10

[libvirt PATCH v2 6/7] conf: reject some attributes not applicable to intel IOMMU

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- src/conf/domain_validate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index b9a6740437..b28af7fa56 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -

[libvirt PATCH v2 4/7] docs: formatdomain: document intel-only IOMMU attributes

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 53d4349d2b..7ebb4c3e9e 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -9077,14 +

[libvirt PATCH v2 2/7] qemu: introduce QEMU_CAPS_PCI_ID

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Introduced by QEMU commit f864a3235ea1d1d714b3cde2d9a810ea6344a7b5 the presence of this attribute allows libvirt to specify the alias of the AMDVI-PCI device explicitly. (It was implicit before the introduction of this attribute) Signed-off-by: Ján Tomko --- src/qemu/qemu_capa

[libvirt PATCH v2 3/7] qemu: add IOMMU model amd

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Introduce a new IOMMU device model 'amd', both the parser and the formatter for QEMU because of our enum warnings. https://issues.redhat.com/browse/RHEL-50560 Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 5 ++- src/conf/domain_conf.c

[libvirt PATCH v2 REBASED 0/7] qemu: introduce amd-iommu support

2025-06-18 Thread Ján Tomko via Devel
Ján Tomko (7): qemu: introduce QEMU_CAPS_AMD_IOMMU qemu: introduce QEMU_CAPS_PCI_ID qemu: add IOMMU model amd docs: formatdomain: document intel-only IOMMU attributes conf: add passthrough and xtsup attributes for IOMMU conf: reject some attributes not applicable to intel IOMMU qemu:

[libvirt PATCH v2 1/7] qemu: introduce QEMU_CAPS_AMD_IOMMU

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Check for the presence of the amd-iommu device, so we can conditionalize probing for its properties. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 3 +++ tests/qemucapab

Re: [PATCH 0/1] cpu_map: fix vmx-* features wrong bitmaps

2025-06-18 Thread Jiri Denemark via Devel
On Mon, Jun 16, 2025 at 01:46:59 +0200, Hector Cao wrote: > Hello, > > A friendly ping, > > To fix this issue, I would like to propose this solution. > Here is the draft patch, I can submit a proper one in a separate mail if we > can reach an agreement > on this solution. > > Thanks ! > > diff

Re: [PATCH] cpu_map: Add more -noTSX x86 CPU models (Sapphire and Granite rapids)

2025-06-18 Thread Jiří Denemark via Devel
On Mon, Jun 16, 2025 at 16:27:48 +0200, Hector Cao wrote: > On Mon, Jun 16, 2025 at 2:39 PM Jiří Denemark wrote: > > Yes, this should be fixed by a documentation. It should definitely go > > upstream (and any relevant downstream documentation as well) unless it's > > already there or in case it's

Re: [PATCH] security_manager: Don't leak seclabel in virSecurityManagerGenLabel()

2025-06-18 Thread Michal Prívozník via Devel
On 6/17/25 5:46 PM, Ján Tomko wrote: > On a Monday in 2025, Michal Privoznik via Devel wrote: >> From: Michal Privoznik >> >> When a domain is being started, seclabels are generated for it. >> This is handled in virSecurityManagerGenLabel() which can either >> find pre-existing seclabel in domain

Plans for 11.5.0 release (freeze on 2025-06-24)

2025-06-18 Thread Jiri Denemark via Devel
We are getting close to 11.5.0 release of libvirt. To aim for the release on Tuesday 01 Jul I suggest entering the freeze on Tuesday 24 Jun and tagging RC2 on Friday 27 Jun. I hope this works for everyone. Jirka

Re: [PATCH] virSocketAddrPrefixToNetmask: Prevent undefined behaviour on bitshifts on signed integer

2025-06-18 Thread Pavel Hrdina via Devel
On Wed, Jun 18, 2025 at 08:31:36AM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > Shifting bits into the sign bit is undefined behaviour in C although > both gcc and clang handle it as expected. > > Since the value is used as unsigned convert it to unsigned int. For code > readabi

Re: [PATCH] qemu: Be more forgiving when acquiring QUERY job when formatting domain XML

2025-06-18 Thread Pavel Hrdina via Devel
On Mon, Jun 16, 2025 at 10:45:15AM +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > In my previous commit of v11.0.0-rc1~115 I've made QEMU driver > implementation for virDomainGetXMLDesc() (qemuDomainGetXMLDesc()) > acquire QERY job. See its commit message for more info. But